kc3-lang/angle/src/tests

src/tests

Log

Author Commit Date CI Message
Robic Sun 34faa3db 2025-02-08T15:17:10 Fix issue that stride setting is incorrect when rotation is true When rotateXY is true, stride should increase or decrease on the Y axis. Bug: angleproject:395131251 Change-Id: I0f5363c9952ccdf0a036499a9f918853eff7cd10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6242496 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Robic Sun <Robic.Sun@arm.com>
Amirali Abdolrashidi c21e31a1 2025-02-20T17:32:17 Add handling null input to eglGetProcAddress * Modified eglGetProcAddress() so it can handle a null input by returning nullptr. * Added a test for this case: * EGLReadinessCheckTest.GetProcAddressNullInput * Fixed some typos. Bug: angleproject:397720948 Change-Id: If55223b12831649252e2e06e47abaf8d3546c86f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6289249 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Igor Nazarov 323c49a3 2025-02-20T15:44:08 Vulkan: Fix swap optimization after staged clear for MSAA If the MSAA image only had a clear update and the update wasn't going to be applied to the swapchain image, the clear update was accidentally dropped because `flushStagedUpdates` wouldn't see the clear update which is already extracted in `deferredClearValues`. Test: angle_end2end_tests --gtest_filter=EGLSingleBufferTest.StagedClearResolveOnSwap/* Bug: angleproject:382006939 Change-Id: I53ae26eeb8a7f38b7758f86bf97982a90b1990dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285627 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll eb22e1f8 2025-02-21T11:44:31 Roll vulkan-deps from 126c9b378eb7 to f489bd52916f (18 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/126c9b378eb7..f489bd52916f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e66176c3f685b14dfa83882329e5d02f4e027c9b..104bd85d990155f04f050972374a3502b4631830 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/09913f088a1197aba4aefd300a876b2ebbaa3391..54a521dd130ae1b2f38fef79b09515702d135bdd https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9fa14b91414994e2bf4d9509b8efc8071f154991..a80d3b5c505e6541d98003b880ae583bc706bbc9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/234c4b7370a8ea3239a214c9e871e4b17c89f4ab..952f776f6573aafbb62ea717d871cd1d6816c387 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/087c22a441e5fb8563516b6b515483898c843242..a10e2725f99c333bbc468373159442fe41158039 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ifb414ab9bbbd524973d4944854649deb0f1714c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6288472 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Aurora Zhang 3972cfa1 2025-02-18T19:52:06 YUV should support on all the shader stages * The spec requires all shader stages should support YUV. Therefore, move YUV related functions out of the switch. * Add a new end2end test that sampling YUV in the vertex shader. Bug: angleproject:391919465 Change-Id: I7811d419d5f1461c2499c522a902c3b2149289a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6263325 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Aurora Zhang ba174a76 2025-02-19T16:35:15 Vulkan: Bugfix for nullColorAttachmentWithExternalFormatResolve When nullColorAttachmentWithExternalFormatResolve is VK_TRUE, * The imageView in VkRenderingAttachmentInfo for dynamic rendering should be VK_NULL_HANDLE. * Push YUV resolveImageView as if it is the color attachment to ensure the coherency between ops, clearValues and attachmentViews for both dynamic rendering and render pass objects. Then pack the YUV resolve information first as well. * Add end2end tests that render and clear YUV with a depth attachment. Bug: angleproject:395212980 Change-Id: I8b6173b41723ed7dc12359e181791fb1ac22fc41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6262510 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Alexey Knyazev f9566385 2025-02-06T00:00:00 Fix GetBooleani_v validation That entrypoint must require OpenGL ES 3.1. Fixed: angleproject:394610814 Change-Id: I9ee80d1497afadfdc0d714e49bb97b741ad57b63 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6243878 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Chris Dalton be98f841 2024-11-30T02:11:05 Implicitly end PLS for framebuffer reads and writes In preparation for removing the PLS allow list, convert more problematic methods to the new paradigm of implicitly ending PLS instead of generating errors. Also simplify the disable logic for framebuffer modifications, and just blindly disable PLS for framebuffer updates, regardless of whether it's GL_READ_FRAMEBUFFER or GL_DRAW_FRAMEBUFFER. Bug: angleproject:40096838 Change-Id: Ie4390a219f5f05ef0a3d00f405d4914592726283 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6077335 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 22dfe435 2025-02-20T06:46:07 Revert "Add GL_BGRA_EXT as a sized renderable format" This reverts commit 80093a7d8f850c3ab551ddb4972c2f1f27511433. Reason for revert: suspect for blocking rolling ANGLE into Chroimum https://chromium-review.googlesource.com/c/chromium/src/+/6283973 https://ci.chromium.org/ui/p/chromium/builders/try/chromeos-amd64-generic-rel-gtest/372754/overview Original change's description: > Add GL_BGRA_EXT as a sized renderable format > > dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable > format. It was apparently always supposed to be, based on the > wording of the spec. > > This CL adds that support and updates expectations, along with a few > extra tests. > > Includes contributions from Robic.Sun@arm.com. > > Test: angle_end2end_tests, angle_deqp_*_tests > Bug: b/42267264 > Bug: angleproject:394384906 > Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/42267264 Bug: angleproject:394384906 Change-Id: I64572361cfed33b4ea17eabf278f580471d045c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6285628 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 80093a7d 2025-02-03T08:50:21 Add GL_BGRA_EXT as a sized renderable format dEQP tests were updated to cover GL_BGRA_EXT as a sized renderable format. It was apparently always supposed to be, based on the wording of the spec. This CL adds that support and updates expectations, along with a few extra tests. Includes contributions from Robic.Sun@arm.com. Test: angle_end2end_tests, angle_deqp_*_tests Bug: b/42267264 Bug: angleproject:394384906 Change-Id: Ia10bcd61f66c5d99a3d27a2cfd6008c991ddcaa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235444 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov cab0acdf 2025-02-19T16:22:07 Suppress dEQP ASAN failures These block upgrading Clang to a new version that detects more problems. Bug: b/395920316 Change-Id: Ie07d1fce240741f2572546c86e838f8b16c4950c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6281031 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Austin Annestrand d5a0d83a 2025-02-14T15:47:06 CL/VK: Fix addMemoryDependencies RAW barrier Additionally, remove unused barrier insertion code in processKernelResources(). Bug: angleproject:380188569 Change-Id: Id9f330410eecf45f94fe77bf072cf6601bd2a9e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6271135 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Liza Burakova bc40362b 2025-02-18T13:24:31 Add line loop emulation for draw arrays Bug: angleproject:383356846 Change-Id: I43f4835e17ecb2401418f77555fd70332612e1bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6090912 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Mark Lobodzinski bace6371 2025-02-17T15:14:37 Tests: Add Brotato ANGLE trace Test: angle_trace_tests --gtest_filter=*brotato Bug: b/397185288 Change-Id: I3d89d4b073b56efeede42abf5b0f44f8e9bd221a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6277708 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 367541f5 2025-02-05T16:45:13 Capture/Replay: Add multi-capture support to tracer Multiple captures can now be grabbed by setting the trigger value to the desired framecount and then resetting it to zero to trigger a new capture. Captures will be saved in the current capture.out_dir directory and this should be changed between captures to keep traces separate. Note that this feature will not work with apps using persistent coherent memory, and in these cases the tracer will exit, preserving the initial, valid trace. Bug: b/394107532, angleproject:42263521 Change-Id: I9d31d19ec6c3736dbda356405eb91fba2dd5a8d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258503 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Austin Annestrand c8dc7c08 2025-02-13T16:35:05 CL: Fix typo in cl::BitField's exclude() routine Ignored passed "other" param. Bug: angleproject:42266936 Change-Id: Ia616bc7e2d1bfbdd39ed22221157b6aca5529ed2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6265705 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop c8049a47 2025-02-12T13:21:56 Tests: Add Tower of Fantasy trace Test: angle_trace_tests --gtest_filter="*tower_of_fantasy" Bug: b/389808881 Change-Id: I16a4ab0c12c18d2feb9df41cb0ba5667adb1f161 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258901 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Yuly Novikov 7014e9ec 2025-02-12T16:42:40 Further suppress dEQP-GLES2.functional.fragment_ops.blend on WGPU Only blend.*constant_alpha* were previously suppressed, but many other tests are flaky on Mac Intel. Bug: angleproject:370690274 Change-Id: I8618c6251956308fa06fe2739eff5050c9578f2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258051 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 688f328f 2025-02-12T06:55:55 Revert "Suppress ImageTestES3 on Pixel 6 Vulkan" This reverts commit ef2ef107242781000ebe2f4f11839ea233aae01b. Reason for revert: should be fixed by https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9418 Original change's description: > Suppress ImageTestES3 on Pixel 6 Vulkan > > ImageTestES3.ClearYUVAHB > ImageTestES3.RenderToYUVAHB > > Report on Pixel 6 Android 14: > VUID-VkSubpassDescription2-nullColorAttachmentWithExternalFormatResolve-09336 > > Suppress temporarily while VUID is being fixed. > > Bug: angleproject:395223719 > Change-Id: I52c7fea1058b522badbbd3be5050a01b099d15a7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6243416 > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:395223719 Change-Id: I22b6ccde6444990d31b95771f067a31669ac3aa1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258049 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 7ed5575f 2025-02-11T16:21:56 Tests: Skip monopoly_go on Linux/Intel * Skipped this trace on Linux/Intel due to failure on the perf bot. Bug: angleproject:385226328 Change-Id: If1d741fb681027865409c16ebe736c5ce8516ac1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6254465 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 19c5293e 2025-02-11T10:28:41 Tests: fix Swiftshader test instantiation logic Tests should not be disabled when IsSwiftshaderDevice(), for example running ANGLE builds without Swiftshader on cuttlefish which has Swiftshader set up as the GLES driver. Bug: angleproject:42266725 Change-Id: Id7155c0dfef84a775e558cfc84eb241b727a93a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6253838 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean c0d806b4 2025-02-10T23:01:33 CL: OpenCL support for ANGLE Capture/Replay Implementation of OpenCL Capture/Replay tool in ANGLE. Brief notes about the change: - Most meaningful changes for the capture process are made in src/libANGLE/capture/ - Most meaningful changes for replay are made in util/capture/ and src/tests/perf_tests/ - Many autogenerated files are changed/added to allow the capture of OpenCL objects & calls - The following applications were captured/replayed: benchmark_model, GeekBench Compute, GeekBench ML, AI-Benchmark, various OCL CTS tests - End2end test added to capture_tests. CapturedTestCL.MultiFrameCL/ES3_Vulkan Bug: angleproject:383841335 Change-Id: I55fdaa6cd6c7ba740aaa2351e4d29050059d6d1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6102105 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Geoff Lang e746fb06 2025-01-23T13:23:30 WebGPU: Implement blending Constant alpha is not handled yet. It needs to be emualted or added to WebGPU. Bug: angleproject:370690274 Change-Id: I5f8402f74ab08345b2f02c18e2d43fa39b2479a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194554 Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Amirali Abdolrashidi 9e86d8c0 2025-02-05T16:31:22 Vulkan: Fix VVL due to memory map range VVL: VUID-VkMappedMemoryRange-size-01390 * Updated BufferBlock::map() so the device memory uses the actually allocated buffer size. * To flush and invalidate a mapped memory range (non-coherent), the memory size is now aligned with nonCoherentAtomSize from the physical device limits. * Added an assert to make sure that the mapped size is within the allocated buffer size range. * Unskipped ExternalBufferTestES31 cases for Pixel6, except one case which seems to take a long time and result in timeout. * BufferDoesNotLeakAHB Bug: angleproject:394685081 Change-Id: Iddfb45997fed53c5ee99938d9bb57b670550b9a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6238059 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxiang Qian 883f6246 2025-01-22T16:36:26 Add validation for eglSetDamageRegionKHR Although this is not mentioned in spec, n_rects in eglSetDamageRegionKHR should be a valid value. It doesn't make sense if it's less than 0. Refine the validation in ANGLE and also add end2end test. Bug: angleproject:395482390 Change-Id: Idbde839be85bac927486b7613005f25d54c3d5f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6242903 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d252425d 2025-02-06T14:51:36 Vulkan: Check source image usage flags in copy paths ... instead of the format feature flags. If the source of the copy is has external format (allowed with glCopy[Sub]TextureCHROMIUM), the format feature checks are unable to query the format features. However, the image usage flags already have the required information (whether the image can be copied from, sampled from, etc). Bug: chromium:383056998 Change-Id: I2ba8820751eb526ef497a8be724193276fd46160 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6238265 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 0026006d 2025-02-10T12:03:40 Vulkan: Fix missing barrier between dispatch calls When storage images are used, ANGLE accidentally did not mark the images as being written to, so subsequent barriers were not produced when necessary. Bug: angleproject:352610491 Bug: b/394611669 Change-Id: Idd3e6aa6b90212605594240a533ebaec66850ea9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6249459 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Yuly Novikov ef2ef107 2025-02-09T10:53:00 Suppress ImageTestES3 on Pixel 6 Vulkan ImageTestES3.ClearYUVAHB ImageTestES3.RenderToYUVAHB Report on Pixel 6 Android 14: VUID-VkSubpassDescription2-nullColorAttachmentWithExternalFormatResolve-09336 Suppress temporarily while VUID is being fixed. Bug: angleproject:395223719 Change-Id: I52c7fea1058b522badbbd3be5050a01b099d15a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6243416 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya aef40167 2025-02-07T13:42:34 Vulkan: Account for padBuffersToMaxVertexAttribStride ... when evaluating maxTextureBufferSize Bug: angleproject:391002353 Test: KHR-GLES31.core.texture_buffer.texture_buffer_max_size KHR-GLES32.core.texture_buffer.texture_buffer_max_size Change-Id: I7f59d642ed5af87fdb0c683189da88b0a70a1122 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6244611 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Robic Sun b5584cfd 2025-02-05T15:14:52 ValidTexLevelDestinationTarget should add external related cases GL_TEXTURE_EXTERNAL_OES is not documented in OES_EGL_image_external spec, but we consider that to be an omission in the spec. Bug: angleproject:394380758 Change-Id: Idb5523c173ae0a5910af97639dadff3c5adf9fdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6232504 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Austin Annestrand 2ab36882 2024-09-16T14:28:49 CL/VK: Add fillBuffer staging/transfer routine Bug: angleproject:377545840 Change-Id: I90f6896f96af25d7776a36595930b81af8c1141b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6237414 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Mohan Maiya eaf06ea7 2025-02-06T13:58:07 Vulkan: Bugfix in resolvePrecisionMismatch(...) Early-return if a varying is not active in either the front or back shader Bug: angleproject:386749841 Test: GLSLTest.MismatchedInactiveVarying* Change-Id: Ie0c6dfd6616afcb94bec043d36d4f8188df8abb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6239031 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Geoff Lang 9f8d7cc2 2025-01-23T13:27:19 WebGPU: Stream incompatible vertex and index data. Support reading back index and vertex buffers to stream incompatible source data. For now this includes: * Non-multiple-of-4 stride vertex data * Stride not a multiple of the type size * Unsigned byte indices Fix fallback formats so that all GLES formats have a fallback. Fix CopyToFloatVertexData writing the alpha channel as Float32One with a static_cast which converted Float32One (an integer) to a float instead of bit-casting. Bug: angleproject:368602384 Change-Id: I7eb1ba7ad1ec4292060c18de22f5948136cbb0a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194556 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 0790b50d 2025-02-07T11:15:11 Android: Sleep after orientation change in EGL test In each of the EGLPreRotation* tests that change dislay orientation, we have a sleep that gives the Android device time to react. A new test was added that didn't include the sleeps and is causing flaky asserts based on how it got sharded for testing. This CL adds the sleeps, mirroring other tests. Test: EGLPreRotationSurfaceTest.CheckSurfaceCapabilities Bug: angleproject:395110957 Change-Id: If2a959d69ba4f4b4ed0f6a6fbffb94762174966d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6244919 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen d4083c79 2025-01-31T15:06:36 Metal: Make ObjCPtr available to all modules Move ObjCPtr implementation to src/common/ObjCPtr.h, angle::ObjCPtr so that it's available also outside libANGLE. Bug: angleproject:393263506 Change-Id: I8ecd5632c7ae33ef4b409fc820fad229e91bc0ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6219318 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Kimmo Kinnunen 4e5f2ca3 2025-01-31T14:30:05 Metal: Rewrite AutoObjCPtr as ObjCPtr Rewrite without WrappedObject base class, the base class only convolutes things and does not help. This way the class can be moved upwards in the software layers in subsequent commits. Fix the class so that it can be used with ObjCPtr<T> and ObjCPtr<id<P>> signatures, to resemble other smart pointers. Remove the Auto prefix, ObjCPtr should be relatable to other smart pointers such as unique_ptr. Bug: angleproject:393263506 Change-Id: Ia5a5728514b7f9182c2ec8380c04716e8b9d2351 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6219317 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll e9cda7f6 2025-02-06T08:01:49 Roll VK-GL-CTS from 48e7f3020f52 to 1177f7b7d556 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/48e7f3020f52..1177f7b7d556 Includes manual merge to remove GN reference to deDefs_kc_cts.h 2025-02-04 lorenzo@khronosgroup.org Remove all references to KC-CTS and GTF 2025-02-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2025-02-04 elima@igalia.com Add VK_KHR_video_maintenance2 tests 2025-02-04 lorenzo@khronosgroup.org Update external sources and use Vulkan 1.4.307 2025-02-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I881df1f09ca98c892a485c5a8368c3f6eda390f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6237566 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 93e99da3 2025-02-05T11:23:50 Vulkan: Fix bugs with varying precision fixer This transformation creates new variables and turns the original ones Private. There were a few bugs where some transformations referred to the replaced id (larger than the original index bound) and had wrong look up (where e.g. they would cache something based on the original id, then try to look it up with the replaced id). This change makes it such that where needed, both the old and new ids are given to the various transformations, so they can look up with the old id, but output instructions with the replaced id. Bug: angleproject:386749841 Bug: b/394299327 Change-Id: Ie6b3c3445c440417cbbffdd849a036abfc504fe2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6235664 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Kimmo Kinnunen 82e25a32 2025-02-03T15:07:33 Make all " < 0" error messages consistent Use the form: Error is due to reason: <error message> Bug: angleproject:392938089 Change-Id: I9e72858cf76a46ab874ffc211afdae1eb93ca05d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6225600 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Austin Annestrand da837830 2025-01-30T15:37:56 CL: Fix device queue query validation for 3.0 Was missing 3.0 check for device queue size. Since device queue support is optional for 3.0, device queue query (CL_QUEUE_SIZE) needed device queue support. Adding validation check for that here. Bug: angleproject:42267011 Change-Id: Ibc1d7e00f78df01f131f69047b1390b02b5fa780 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6220894 Reviewed-by: Gowtham Tammana <g.tammana@samsung.com> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 9c6af5ce 2025-02-04T22:50:01 Vulkan: Fix crash in SPIR-V transform with varying precision fix Bug: angleproject:386749841 Change-Id: I5743eb049dde6c8a093b175e857251bad9b2bc9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6232948 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop aa94da02 2025-02-04T12:41:36 Revert "Vulkan: Bugfix in SPIRV entrypoint transformation" This reverts commit 9975e80b9d98a2158ae859b3f4eff7340baa540d. Reason for revert: Crashes on platforms with varyingsRequireMatchingPrecisionInSpirv Original change's description: > Vulkan: Bugfix in SPIRV entrypoint transformation > > Perform varying precision fixer transformation before > other shader-stage-specific transforms that could > potentially modify the interfaceList. > > Also enhance EXTBlendFuncExtendedDrawTest by enabling > additional config with VaryingsRequireMatchingPrecisionInSpirv > feature enabled > > Bug: angleproject:386749841 > Change-Id: Ife4a2f932415296f1565527e50a2b8646cd7697d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6207741 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: mohan maiya <m.maiya@samsung.com> Change-Id: I07064136f962a7d73ce5c80289da300d474faa22 Test: professional_baseball_spirits trace Bug: b/394299327 Bug: angleproject:386749841 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6227993 Reviewed-by: Cody Northrop <cnorthrop@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov c2cb1603 2025-02-03T18:21:10 Perf tests: change fps limiter method to timestamp based Instead of using previous frames, target start_time + N * delta. This will result in a smoother playback when there is no hiccups. In case of a big hiccup, replay will be catching up by submitting frames without sleeps until it hits the timestamp, then submit at the target rate again. Bug: b/376300037 Change-Id: I481f1325867d53e911acd2d381bfda4c94adefc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6226746 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Hans Wennborg 6808ef83 2025-02-04T10:57:18 Tests: suppress -Wunused-private-field warning The latest version of Clang warns about an unused member variable in es31fSRGBDecodeTests.cpp. Suppress it for now. Bug: chromium:393942204 Change-Id: Ic03c2f8f2710ff3ccf44c102d1fd991bc4d1d380 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6226805 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Austin Annestrand 957bafb5 2025-01-30T11:49:41 Infra: Print stdout for TIMEOUT cases Bug: angleproject:392929827 Change-Id: I47625474e4ce9253a4cf275ea027290a6a2fbc33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6207671 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 44b5f0a5 2025-01-06T16:01:28 OpenCL: Pass in options to the CTS tests In the case where options are specified, pass them down to the CTS tests. New tests with options for copy_images, fill_images and bruteforce are added. The changes in `angle.json` file are autogenerated by running `python3 scripts.run_code_generation.py` Bug: angleproject:388319897 Change-Id: I1c7e133d8df00e008857b652132b45975f61a08e Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6153935 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Austin Annestrand <a.annestrand@samsung.com>
Gowtham Tammana 433d14e0 2025-01-28T17:05:32 CL/Vulkan: Submit an empty command on command buffer reset On resetting the command buffer, the queue serial associated with it wont get signalled leading to causality issues. Instead submit an empty command to maintain queue serial timelines. Bug: angleproject:392934330 Change-Id: I53996b295d2744b58487e483dd45918e48f58c83 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6207673 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 7d37d970 2025-01-30T13:47:59 Make error messages end in a dot Some messages had dot and some not. Fix by adding dot to all error message string literals. Best effort, for free form string literals, check ANGLE_CHECK invocation sites only. Bug: angleproject:392938089 Change-Id: Idedc3fe1d1e186fb91b5e54407df87f6830995a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6218460 Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 03019646 2025-01-29T10:36:38 Vulkan: Fix invalidate of emulated format followed by more draws If invalidating a color image with emulated channels, a clear is automatically staged so the emulated channels don't contain invalid data later. This is problematic with deferred clears; the clear marks the framebuffer attachment as dirty, and the next command causes `FramebufferVk::syncState` to pick the clear up as a deferred clear. This is normally correct, except if the following command is another draw call; in that case, the render pass does not close, yet the clear is cached in `mDeferredClears`. When the render pass later closes, it undoes the invalidate and attempts to remove the clear from the image... but it does not exist there anymore (it's in `mDeferredClears`). Next usage of the image then clears it, undoing the draws after invalidate. In this case, the simplest approach is to close the render pass right away here. Note that it is not possible to make `FramebufferVk::syncState` avoid picking up the clear in `mDeferredClears`, not apply the clear, _and_ keep the render pass open; because future uses of the image (like with |glReadPixels|) will not trigger `FramebufferVk::syncState` and the clear won't be done. Bug: angleproject:353167428 Change-Id: Ie677bd12d9f11953cdcd5e4c374b59c4f63e7456 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6214331 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 6f5b32d0 2025-01-29T18:55:21 Suppress flaky end2end test on Linux NVIDIA Vulkan ClearTextureEXTTestES31Renderable.Clear3D Bug: angleproject:362486580 Change-Id: Iff0195d85c828d172ea4b9e150b62da7df0769d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6215271 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Liza Burakova 40523499 2025-01-29T12:13:45 WebGPU: Emulate line loops for drawElements Bug: angleproject:383356846 Change-Id: I82a6dfad4a1c5d434f029701611e4b61344655f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6086120 Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 9975e80b 2025-01-28T17:25:38 Vulkan: Bugfix in SPIRV entrypoint transformation Perform varying precision fixer transformation before other shader-stage-specific transforms that could potentially modify the interfaceList. Also enhance EXTBlendFuncExtendedDrawTest by enabling additional config with VaryingsRequireMatchingPrecisionInSpirv feature enabled Bug: angleproject:386749841 Change-Id: Ife4a2f932415296f1565527e50a2b8646cd7697d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6207741 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuly Novikov af4817db 2025-01-29T14:12:02 Suppress angle_oclcts_non_uniform_work_group failures on Linux NVIDIA Bug: angleproject:42267085 Change-Id: I13f85d8b7ed140f3a10262fe335de664cfd68624 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6213432 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov 00f0b887 2025-01-29T14:04:38 Skip pokemon_go flaky crash on Linux Intel Bug: angleproject:392938092 Change-Id: Ie46582b91fc498640b2651f3e04aaf7d1769da6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6213430 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Austin Annestrand e0cbdbb5 2025-01-15T14:08:45 CL/VK: Enable dispatch region chunking This change does two things: - Allow non-uniform workgroup size - Dispatches that go beyond VK workgroup count limit Bug: angleproject:42267085 Change-Id: I1f2da93252e466b811273ee34d9d38e454f11686 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180550 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov d9128ff4 2025-01-28T09:43:58 Clean up Galaxy expectations for A/S23 and S24 Exynos/QC Split A23 and S23 into separate lists GALAXYS24EXYNOS for S24 Exynos ("International") GALAXYS24QUALCOMM for S24 Qualcomm Bug: angleproject:359904354 Bug: b/338429767 Change-Id: If9c1f184df6c6f15e3b5d5af3a7e1310cb445984 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6207255 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop fa0de0dd 2025-01-27T17:32:49 restricted_trace_perf: Support --fps-limit Simply passes the flag and value through. Test: restricted_trace_perf.py --fps-limit 30 ... Bug: b/376300037 Change-Id: I344492944babed33edcbdae6b2906795d31715e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6204802 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Geoff Lang bec97bbb 2025-01-23T13:29:04 WebGPU: Flip Y for ReadPixels ReadPixels results are upside down. Flip the results in the PackPixels functions. TODO: Re-evaluate if this needs to be default-FBO only once more tests are running. Bug: angleproject:42267090 Change-Id: Ia5e5ee218de2e754f5de02a826f664d2f71efb76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194557 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 0f75fc3d 2025-01-20T14:10:41 Vulkan: Transition foreign images to the FOREIGN queue on submit Vulkan's interaction with AHB and dmabuf images is through the FOREIGN queue family. When ANGLE uses these images, it must take ownership of the images by doing a queue family ownership transfer (QFOT) away from the FOREIGN queue family and into the graphics queue family used by the Vulkan backend. Prior to this change, ANGLE would do the QFOT away from FOREIGN once such a foreign image is imported into an EGL image. Afterwards, usage in ANGLE works correctly. What ANGLE did not handle is when a foreign entity wants to use these images _after_ ANGLE has used them. For the above to work correctly, ANGLE must do a QFOT back into FOREIGN before the image can be used by the foreign entity. Unfortunately, EGL does not provide a clear point for this hand-off to happen. ANGLE has no choice then to proactively transition the images back into FOREIGN at some point "just in case". For some native drivers, this hand-off to FOREIGN can be quite frequent. For example, on Android for most vendors there is no actual layout transition between graphics and FOREIGN queue families (the actual data layout is the same), so a cache flush/invalidate at strategic points (such as the end of the command buffer) is sufficient as equivalent to transition to FOREIGN (and another at the beginning of the command buffer as equivalent to transition from FOREIGN). As a layer over Vulkan's formalism, ANGLE is less lucky; it has to enumerate exactly which image is being transitioned to and away from FOREIGN. Transitions away from FOREIGN are in principle easy. As long as the image is marked as being in the FOREIGN queue family, it will automatically transition to the graphics queue family on first use. In this change, when a foreign image is transitioned out of the FOREIGN queue, it's added to a list of images to be transitioned back to FOREIGN at submit time. Once submission is done, the image may or may not actually be used by a foreign entity, but ANGLE cannot know that. The next time the image is used in ANGLE, it is transitioned out of FOREIGN. Verifying correctness with multi-threading is tricky, and relies on GL's requirement that access in one context is followed by a synchronization and rebind in another context before it can be used there. This means that the image's transition to FOREIGN (at the end of one submission) naturally happens before the transition back from FOREIGN (at the beginning of the next submission). Because the set of images to transition is tracked in the context, submissions in other contexts don't interfere with the above logic. The situation can be more complicated with one-off submissions, but fortunately, no such usage of foreign images is present. Another wrinkle is simultaneous usage of the image as read-only in two contexts. According to GL, this is not a hazard and requires no synchronization. However this is broken in ANGLE even for non-foreign images (see http://anglebug.com/42266349), because as what _seems_ like read-only usage of the image from GL's point of view (like sampling from the image), there are associated write operations from Vulkan's point of view (image layout transitions and QFOT). This change does not attempt to address this corner case. Bug: angleproject:42263241 Bug: angleproject:42262454 Bug: angleproject:390443243 Bug: chromium:382527242 Change-Id: Idd4ef1fecfa3fccf1a4063f1bddb08d28b85386b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6184604 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 54b69688 2025-01-21T11:28:59 Vulkan: Add max memory allocation size limit check During memory allocation, we should make sure that the attempted allocation size does not exceed the maximum allowed size. Failure to do so may result in validation errors. * Added the following object to the renderer: mMaintenance3Properties * It holds the following device property: maxMemoryAllocationSize * Inline renderer function: getMaxMemoryAllocationSize() * Buffer and image allocation sizes will now be checked with the function above. * In case of exceeding the maximum allocation size, a device OOM error is returned after issuing a warning: * MemoryAllocationTracker::onExceedingMaxMemoryAllocationSize() * Removed the suppression for the test failing due to this issue. * Removed the maxMemoryAllocationSize VVL skip targeted for MockICD. * Suppressed tests on S22 that now fail due to exceeding this limit: * KHR-GLES[31/32].core.texture_buffer.texture_buffer_max_size Bug: angleproject:391002353 Change-Id: Id271066bd872c80344ef8531653afda3e6b40a93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187981 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuly Novikov 2d71b6b7 2025-01-23T16:56:02 Suppress dEQP failures on S22 dEQP-GLES31.functional.geometry_shading.instanced.geometry_output_different_32_invocations dEQP-GLES31.functional.geometry_shading.instanced.geometry_output_different_max_invocations KHR-GLES31.core.geometry_shader.primitive_counter.* KHR-GLES32.core.geometry_shader.primitive_counter.* Bug: angleproject:386749841 Change-Id: I41f399ab914d000d6b606170b6d191b61840eec8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194732 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuxin Hu 51cdae04 2025-01-21T18:41:15 Update dEQP-GLES2.functional.shaders.random* test expectations Most tests have been fixed with the latest qualcomm drivers, except 1 test is still failing: dEQP-GLES2.functional.shaders.random.all_features.fragment.39. Bug: b/328156792 Bug: b/338287961 Change-Id: Ib2ff74c6ae7e9f39958617fb8d00b9b1f89878ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188697 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 0acd0a17 2025-01-21T18:31:32 Remove fixed dEQP-EGL.functional.*pbuffer tests from skip list These tests pass with latest ANGLE version d9c0aa4aff. Bug: b/330906568 Bug: b/328156792 Bug: b/332784194 Change-Id: Ib42fe3cfb22f3f7a1bd84609f927cc47613a4920 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188696 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 9867010e 2025-01-21T18:17:37 Remove fixed dEQP renderbuffer test from skipped test list Test passes with the latest ANGLE version d9c0aa4aff. Bug: b/328156792 Bug: b/333959262 Change-Id: I231feb43af69a1dab877fd3d3bd915b73d56d4b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187619 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu fd94ce5b 2025-01-21T18:05:41 Update the deqp blend equation advanced test expectations on qualcomm Some of the dEQP-GLES31.functional.blend_equation_advanced* tests are fixed by the latest qualcomm drivers. There are 9 remaining tests still failing. Update the expectation file with these 9 tests. Bug: b/328156792 Bug: b/345581214 Change-Id: I995b0f8a14d18f8ed4d1cdd27c334bdb09387d97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187617 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuxin Hu e5a4924e 2025-01-21T17:42:50 Remove fixed dEQP copy texture tests from skipped test list Tests passed with the latest qualcomm drivers. Bug: b/347306270 Bug: b/328156792 Change-Id: I8d6c0cb04d13635a91b0d774c56d8f3f72bc0e4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187616 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxiang Qian 308cfc62 2025-01-13T14:54:18 Do not reset buffer age after query The spec doesn't mention that we need to reset the buffer age if no rendering after last call of eglQuerySurface to query EGL_BUFFER_AGE_KHR. Age was also reset after first time of query. Remove it to align with spec. New end2end test is also added. Bug: angleproject:391039188 Change-Id: I00c96e3a71ea2c9abcb86ebaf520243408dedd52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6185135 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov 680ff1f4 2025-01-22T19:17:40 Suppress flaky end2end test on Linux NVIDIA Vulkan ClearTextureEXTTestES31Renderable.Clear2DArray ClearTextureEXTTestES31Renderable.ClearCubeMap ClearTextureEXTTestES31Renderable.ClearCubeMapArray Bug: angleproject:362486580 Change-Id: I4254a4c28cb0b201d9e94511d5ddc8cce975d1c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6190629 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Yuly Novikov 4be68add 2025-01-22T18:24:24 Skip OcclusionQueriesTest.WrongSkippedQuery Fails on Win Intel UHD 770 Vulkan Bug: angleproject:388144480 Change-Id: Iee4bbae63991bb7d678bdd0777b45647322f3843 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191327 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Amirali Abdolrashidi 3734b432 2025-01-21T14:24:42 Suppress some clear tests on Linux/Intel/GL * Suppressed the following tests on Linux/Intel/OpenGL due to observed flakiness on the bots: * ClearTextureEXTTestES31Unrenderable.Clear3D * (ismatch in output values) * ClearTextureEXTTestES31Renderable.Clear2DArray * (FBO status is shown as incomplete) Bug: angleproject:384967031 Change-Id: I46e23e95619c6836b03edf6a52514b138f1542dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6182634 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Roman Lavrov e06a8369 2025-01-21T14:56:09 Tests: fix IndexConversionPerfTest using unaligned offset Breaking Win perf bots since https://crrev.com/c/6151227 Bug: angleproject:385264236 Change-Id: I807b9823b5e1dfb12ec4ee7fe48d6addd568c224 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187621 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Neil Zhang 0554e7f0 2025-01-09T10:05:12 Vulkan: Resume render pass queries when render pass reactivates Bug: angleproject:388144480 Change-Id: Ibcf3b247f347705feed4aa43d237406ccb142704 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6185098 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Steven Noonan 801993bc 2025-01-18T21:48:41 handle Qualcomm's mixed vendor IDs This is a weird situation. Up until Qualcomm had a native Vulkan driver for Windows (with the Snapdragon X series chips), the only vendor ID observable on Windows was 0x4D4F4351. This was reported through DXGI, device manager, etc. But with their native Vulkan driver, they now report 0x5143 as well: VkPhysicalDeviceProperties: --------------------------- apiVersion = 1.3.295 (4206887) driverVersion = 0.807.0 (2150789120) vendorID = 0x5143 deviceID = 0x36334330 deviceType = PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU deviceName = Qualcomm(R) Adreno(TM) X1-85 GPU pipelineCacheUUID = 0eba4509-4351-0000-0000-010c05430000 And yet, DXGI still reports 0x4D4F4351. Cool, huh? Let's teach IsQualcomm to understand both vendor IDs to ensure the device is correctly detected as a tile-based renderer in the Vulkan backend. Bug: angleproject:390866623 Change-Id: I9170c30262ace269498f066e922a279c7e981de6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6183621 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
Xin Yuan c7cfbbc9 2025-01-20T22:31:42 Check if the GLES resources are bound to EGL image Per spec, The resource that will be used to create egl image must not itself be an EGLImage sibling, so validation for the resource in this case should be include. Bug: angleproject:388310036 Change-Id: I2b47e3de4f92beca7ff7a80383a7598c79fdedb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6170833 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shashank Sharma 0c9ce8c7 2023-09-08T21:34:07 Trace-based testing app Modifying angle_trace_tests app to run traces automatically on invocation and dumps fps information. Also, compares the screenshot with the golden images if provided and dumps the histogram of image diff. Golden image naming format: <trace_name>_golden.png - Run traces - Capture screenshot - Record FPS value - Record image diff histogram Bug: b/270421213 Doc: doc/StandaloneBenchmark.md Change-Id: I42b8d229e1e358d48887f29f2424b9e771093ce9 Commit-Queue: Shashank Sharma <shawshanks@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6072349 Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shashank Sharma <shawshanks@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev a0e36ad5 2025-01-20T00:00:00 Vulkan: Fix image bindings for non-layered textures Layer index must be ignored if the texture does not have multiple layers or faces. Fixed: angleproject:344950165 Change-Id: I4b402ee28d365f0459f980e01488828c80c93527 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6185849 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 8bf7d458 2025-01-20T09:37:25 Manual roll vulkan-deps from 476cafde9e9d to e8b712767b9e (8 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/476cafde9e9d..e8b712767b9e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/321692686b64873ccf4972754e36185697993e21..b9d5ced92ac454caf526c3b80d5105a1f38878ce https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/35a851d182cdebef408493b9a82ba212d1a2629c..1586f33d6d79eb9ffa5963ce4f70423986b95d8a https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/2fe3a7791dc9c34a581dc45522ab9b4363b4f321..7b23ba7a5f86936a8d783baf64a77c38977d6890 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a80bafccd11d2b4e44dee21c530da49b41083682..1ce4b30307301d20d58040e088eb57c5ea8bb6ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I297016b55854913ceda6cc4afb80f67eafe65e26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6183654 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Aurora Zhang 0dabfe5a 2025-01-16T16:00:51 Tests: Supplement EXT_clear_texture tests * Added negative tests in ClearTextureEXTTest.Validation. * According to spec, divided format lists into color renderable and unrenderable two sets. * Bind the renderable format texture as a color attachment to test EXT_clear_texture. * Sample the unrenderable format texture then call glDraw to test EXT_clear_texture. Bug: angleproject:384967031 Change-Id: I71d77ef57772fbb5b174929e9ac2892e7dc3215f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108999 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Mohan Maiya aa6a9fae 2025-01-16T17:18:59 Vulkan: Selectively enable input attachment usage bit Add VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT iff supportsShaderFramebufferFetchDepthStencil feature is enabled. Also, add noncoherent qualifier in a few FramebufferFetchTest Bug: angleproject:352364582 Change-Id: I09c54a8d738b5cb4cbcf2716cdbff0c0ec9e31cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6181497 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shufen Ma fc33f0a0 2025-01-15T11:23:25 Add a ReadPixels test for offset alignment check An INVALID_OPERATION error is generated if a pixel pack buffer object is bound and data is not evenly divisible by the number of basic machine units needed to store in memory the corresponding GL data type from table 8.4 for the type parameter. Add a test for this. Bug: angleproject:352963094 Change-Id: I81eda446df5ff29da1326a1f75f5d5aa0825aafd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6170763 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Matthew Denton 8ee72cc7 2025-01-13T13:44:31 WGSL: support matCx2 in uniforms matCx2 in WGSL does not match std140 layout and so it needs to be translated as array<ANGLE_wrapped_vec2, C> when in a uniform. On use it needs to be converted to a WGSL-native matCx2. This also includes the optimization of an array<matCx2> in a uniform--when indexing into it, only the indexed element will be converted to a native matCx2, instead of converting the entire array and then indexing. Bug: angleproject:376553328 Change-Id: I1d84471234b3d3cf4cf361ae89cb61675d5bf9a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6157788 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 062f1fc1 2024-12-17T22:22:04 Vulkan: Use waitFenceUnlocked to finish one command Batch Using `CommandBatch::waitFence()` in finish one command Batch is no longer necessary, since `mQueueSubmitMutex` remains locked, preventing adding new commands when `kInFlightCommandsLimit` is exceeded. The `Locked` suffix is removed from `finishOneCommandBatchLocked()` since it is now accepts the `lock` (similarly to `waitFenceUnlocked()`) and may temporarily unlock it. Test: angle_end2end_tests --gtest_filter=EGLSyncTest.BlockingOnSubmitCPUThrottling/* Bug: b/362604439 Change-Id: I8f39d7b2e6f1b9ce8ed4aa8875375769211572e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6098256 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Kimmo Kinnunen 0cfea380 2025-01-15T10:46:54 Rename sh::TSpan as general purpose angle::Span Span abstraction is useful for making buffer manipulation more consistent. The commit makes the Span available to all code until std::span can be used. Bug: angleproject:389951202 Change-Id: Id0c6b54bb6e75d3cc4e85af854d9e61b66906752 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6170997 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b4cb17b8 2025-01-15T10:08:39 Roll VK-GL-CTS from 9509eb274dfe to 962460e9975c (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9509eb274dfe..962460e9975c 2025-01-10 javed@igalia.com Add tests for input assembly primitive stat with tess 2025-01-10 piotr.byszewski@mobica.com Fix promoted extension tests not running correctly 2025-01-10 ziga@lunarg.com Fix supported sample count check in draw_copy_resolve tests 2025-01-10 marcin.zajac@mobica.com Fix validation error in api tests 2025-01-10 nikolaysmirnov@google.com Add multiple_render_targets_overdraw test 2025-01-10 gleese@broadcom.com gen_framework.py: Fix some alignment 2025-01-10 gleese@broadcom.com Update amber version to the latest upstream 2025-01-10 rgarcia@igalia.com Test varying tessellation state in Indirect Execution Sets 2025-01-10 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:390138123 Change-Id: I6b653b347550d4a7d4f75e3ce1a0f7bf20e0d0cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6175280 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop 28fbe4a5 2025-01-15T10:12:05 Docs: Fix CIPD link For whatever reason, markdown wasn't resolving the link. Bug: None Change-Id: I27848b0ddbd579c7faf5832119d6521113dfea13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6172575 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mavis Deng 3675ca04 2025-01-07T17:59:30 Vulkan: Bugfix for xfb GL_SEPARATE_ATTRIBS mode in PPO case The new executable state transformFeedbackBufferMode should hold the result of the link. An end2end test is added. Bug: angleproject:385662281 Change-Id: I52398ad9a9fe76344b94dac787cae7141924d1dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6156277 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Xin Yuan 4c1354d9 2025-01-03T14:41:27 Make sure the AHB is not corrupt when bound to egl image The AHB bound to egl image could be corrupt or not a valid ANativeWindowBuffer, it should be validated when creating egl image. Bug: angleproject:387226848 Change-Id: Iefc5506746ceaad92d16b02d5c0838156eee2f9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6126739 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Neil Zhang 0501d32f 2024-12-23T18:02:54 Draw call with un-aligned index buffer should be checked Bug: angleproject:385264236 Change-Id: I1ff7e93bf4b9ea9020e82f3558e4157b74cb7078 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6151227 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Takuto Ikuta d9c0aa4a 2025-01-09T18:08:08 Reland "Roll third_party/glmark2/src/ ca8de51fe..2054465f6 (77 commits)" This is a reland of commit 68b594e859f036b01974f78f8ddca8c419bc8ce3 Includes fixes to glmark2Benchmark.cpp to parse updated output. Original change's description: > Roll third_party/glmark2/src/ ca8de51fe..2054465f6 (77 commits) > > https://chromium.googlesource.com/external/github.com/glmark2/glmark2/+log/ca8de51fedb7..2054465f6f7c > > $ git log ca8de51fe..2054465f6 --date=short --no-merges --format='%ad %ae %s' > 2024-04-25 alexandros.frantzis Use std::filesystem throughout the codebase > 2024-04-25 alexandros.frantzis android: Build native code with C++17 > 2024-04-25 alexandros.frantzis Doc: Recommend meson for building win32 flavors > 2024-04-25 alexandros.frantzis github: Build win32 flavors with msvc in CI > 2024-04-25 alexandros.frantzis github: Build win32 flavors with mingw in CI > 2024-04-25 alexandros.frantzis include/getopt: Always use non-const char array to avoid MSVC errors > 2024-04-25 alexandros.frantzis libmatrix: Add utility function to get idle time > 2024-04-25 alexandros.frantzis libmatrix: Add utility function to get process times > 2024-04-24 alexandros.frantzis libmatrix: Add utility function to get the number of processors > 2024-04-25 alexandros.frantzis libmatrix: Use C++ std::chrono instead of clock_gettime > 2024-04-25 alexandros.frantzis libmatrix: Use C++17 std::filesystem instead of dirent > 2024-04-25 alexandros.frantzis Build: Add support for win32 flavors in meson > 2024-04-24 alexandros.frantzis libmatrix: Provide a copy of the va_list to __android_log_vprint > 2024-04-13 kode54 NativeStateX11: Fix WM_DELETE_WINDOW handling > 2024-02-15 alexandros.frantzis NativeStateWayland: Explicitly destroy all Wayland resources at shutdown > 2024-02-15 alexandros.frantzis Explicitly release GL related resources at shutdown > 2023-06-03 prlw1 src/meson.build: add x11 dependency to glx > 2024-02-07 timchen021 Fix memory leaks using smart pointers > 2024-01-12 daniel.levin Add missing includes in scene-collection.h > 2023-11-01 alexandros.frantzis GLVisualConfig: By default don't care about the stencil config component > 2023-11-01 alexandros.frantzis Options,GLStateEGL,GLStateGLX: Add option to require a good visual config > 2023-07-26 abs GLStateEGL,GLStateGLX: Change failure to get a "good" visual config to warning > 2023-11-01 alexandros.frantzis libmatrix: Add Log::warning() function > 2023-05-20 prlw1 meson.build: fix build and avoid sigsegv > 2023-05-03 ofourdan NativeStateX11: Add winsys option for position > 2023-01-19 alexandros.frantzis Build,Doc: Update files for 2023.01 release > 2023-01-19 alexandros.frantzis NativeStateMir: Remove Mir/mirclient support > 2023-01-03 alexandros.frantzis ResultsFile: Support storing results in an XML file > 2023-01-03 alexandros.frantzis ResultsFile: Support storing results in a CSV file > 2023-01-03 alexandros.frantzis Options,ResultsFile: Add option to set the results file > 2023-01-03 alexandros.frantzis Introduce infrastructure to support saving results to a file > 2023-01-03 alexandros.frantzis CanvasGeneric: Store individual info elements in separate strings > 2023-01-03 alexandros.frantzis MainLoop: Store indivitual result values in separate strings > 2023-01-03 alexandros.frantzis Scene: Remove trailing ':' from scene info string > 2023-01-04 alexandros.frantzis SceneTerrain: Silence unused variable warning > 2022-12-21 pierre-yves.mordret NativeStateGBM: Lock and release the front buffer on flip > 2022-12-21 alexandros.frantzis MainLoop,Scene: Support reporting shader compilation time > 2022-12-20 alexandros.frantzis MainLoop,Scene: Add busy percentage in CPU time results > 2022-12-20 alexandros.frantzis MainLoop,Scene: Support reporting CPU time results > 2022-12-20 alexandros.frantzis Options: Introduce option to specify benchmark results to show > 2022-12-20 alexandros.frantzis Scene: Update elapsed times when a benchmark finishes > 2022-12-19 alexandros.frantzis Scene: Introduce struct to keep track of elapsed time > 2022-12-15 alexandros.frantzis Scene: Introduce infrastructure for more complex scene stats > 2022-12-15 alexandros.frantzis Scene: Move common preparation logic to Scene::prepare > 2022-12-13 alexandros.frantzis Scene: Introduce non-virtual methods to prepare and finish a scene for benchmark > 2022-12-08 alexandros.frantzis GLVisualConfig: Support specifying the config id in --visual-config > 2022-12-08 alexandros.frantzis libmatrix: Support prefix dependent input conversions from string > 2022-12-08 alexandros.frantzis GLStateEGL,GLStateGLX: Fail if no suitable config is found > 2022-12-08 alexandros.frantzis GLStateEGL,GLStateGLX: Don't limit the configs passed to our selection mechanism > 2022-12-08 alexandros.frantzis GLVisualConfig: Penalize configs with components smaller than requested > 2022-11-16 alexandros.frantzis github: Build x11-gl-egl flavor in CI > 2022-11-14 rilian-la-te build: Add x11-gl-egl flavor > 2022-11-10 alexandros.frantzis GLStateGLX: Support multisampled configs > 2022-11-10 l.stach GLStateEGL: Support multisampled configs > 2022-11-10 l.stach GLVisualConfig: Add multisampling support > 2022-09-02 120989324 Add missing newline at end of log messages > 2022-11-10 alexandros.frantzis NativeStateDRM,NativeStateGBM: Support configuring the DRM device > 2022-11-10 alexandros.frantzis Options: Support passing window system specific options > 2022-04-23 nunes.erico NativeStateGBM: Add GBM offscreen backend > 2022-07-07 wuqianhai SceneJellyfish: Fix memory leak > 2022-07-07 wuqianhai SceneRefract: Fix texture leak > 2022-07-07 wuqianhai SceneIdeas: Fix texture leak > 2022-06-14 Martin.Jansa waflib: fix compatibility with python-3.11 > 2022-05-12 jeffy.chen NativeStateDRM: Honor visual configuration > 2022-05-13 alexandros.frantzis GLStateEGL,GLStateGLX: Use SwapInterval 1 for FIFO swap mode > 2022-04-15 alexandros.frantzis NativeStateDrm: Implement swap interval 0 > 2022-02-14 alexandros.frantzis github: Run apt-get update to get latest packages > 2022-02-14 alexandros.frantzis CanvasGeneric,CanvasAndroid: Display surface config info > 2022-02-14 alexandros.frantzis Options: Support --version command line argument > 2022-02-14 alexandros.frantzis libmatrix: Add missing <utility> include > 2022-02-10 hillma libmatrix: avoid -Wimplicit-fallthrough > 2021-12-23 alexandros.frantzis Build,Doc: Update files for 2021.12 release > 2021-12-23 alexandros.frantzis NativeStateDrm: Fix crash when we can't become DRM master > 2021-09-30 jf android: Fix benchmark parameter edition > 2021-08-30 alexandros.frantzis Use highp precision modifier only on GLES > 2021-08-30 alexandros.frantzis GLStateEGL: Support EGL versions < 1.4 > 2021-04-11 maahiuzeon Fix model loading on big endian. > > Created with: > roll-dep third_party/glmark2/src > > Bug: chromium:40263312 > No-Presubmit: true > Change-Id: Ifee506badac67ff5af57605994daff01278c6d56 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6162277 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Test: angle_perftests --gtest_filter="*GLMark2Benchmark*" Bug: chromium:40263312 Change-Id: I54d8982cb37e488f80b7511ad0111d1ff111f004 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6174747 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi bbc0d702 2024-12-27T07:44:01 Vulkan: Add entry points to lock the Vulkan queue ... which can be retrieved via EGL_ANGLE_device_vulkan. Otherwise the application is unable to use the VkQueue that is retrieved out of ANGLE from other threads (such as Chromium's DrDC feature). Bug: chromium:380295059 Change-Id: Ife80f54440777486f72fc61697a68fb0c2b2d0f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6116046 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 65513240 2025-01-03T17:26:55 Fix initializing output variables ... by compiling a list of TVariables instead of names that are later looked up. The latter results in wrong symbols being initialized when the output variables are shadowed. Bug: chromium:376738756 Bug: chromium:377553431 Change-Id: I76b9688c035476c547ac73cff380629161210406 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6143374 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Amirali Abdolrashidi fe76d70b 2025-01-10T14:41:06 Vulkan: Enable 16-bit norm support for tex buffers According to the spec for EXT_texture_norm16, it enables texture buffers to support the following additional formats: * GL_R16_EXT * GL_RG16_EXT * GL_RGBA16_EXT All of the above are unsigned short normalized values. * Updated validation to support the aforementioned formats in texture buffers in case of support for the norm16 extension. * Updated AdjustViewFormatForSampler() to also support norm16 values. * Added the condition for advertising textureNorm16EXT that the 16-bit UNORM formats above should have the buffer feature bit for texture buffer support: VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT * Added support check for renderSnormEXT after textureNorm16EXT, since the check for former currently uses the support for latter as a parameter. * Added unit tests to draw using a texture buffer with norm16 formats. * Added TextureBufferTestBase in order to test the API calls in the extensions and the core ES 3.2 version, which the following suites are derived from: * TextureBufferTestES31 (existing) * TextureBufferTestES32 (new) * Extended the tests to similar 8-bit formats. Bug: angleproject:381313704 Change-Id: I49157e8c2c9b5438eaf8d56c1932d12e56489318 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6169006 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop f094a81e 2025-01-07T14:08:11 restricted_trace_perf: Add screenshot support This update allows users to capture screenshots when using restricted_trace_perf.py. * Two new optional arguments are added. If either is set, a screenshot will be captured. --screenshot-dir (host directory to write screenshots, default CWD) --screenshot-frame (specify desired frame, default is 1 or KeyFrame) * If screenshots are requested, we create a temp dir on the device, pull the screenshot, then delete the dir * The screenshot is renamed during pull to reflect the renderer that created it. Otherwise they are all named "native" since we convince the platform to use its default driver, allowing calls to go through the EGL loader. Test: restricted_trace_perf.py --screenshot-dir ~/Screenshots --screenshot-frame 2 Bug: b/377325803 Change-Id: I5be7a1e2f9f557668bff51349654c8c4e093b47a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6154857 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Mohan Maiya b3af2e86 2024-12-31T08:51:37 Enhance MemoryBuffer API Add support for - 1. reserve - users can reserve sufficient capacity upfront to minimize subsequent reallocations due to resize 2. append - to append data from a source so user doesn't need to track offsets explicitly Bug: angleproject:386749841 Tests: MemoryBufferTest* Change-Id: Ibf2a3228d5a00ed34a7e0c5e3eb185e42677d676 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6135238 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Neil Zhang cfe87e34 2024-12-16T16:29:39 Add multisample support for glCopyImageSubDataEXT As GL_TEXTURE_2D_MULTISAMPLE/GL_TEXTURE_2D_MULTISAMPLE_ARRAY been introduced by GLES3.1, glCopyImageSubDataEXT should support those types. Bug: angleproject:381727390 Change-Id: Ib3571ea38dc8d8ceb1bc9ad0c8a6e04d28b0ec33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6146194 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxiang Qian 4c60a308 2024-12-30T15:35:07 Change default return value for eglDupNativeFenceFDANDROID According to EGL spec, eglDupNativeFenceFDANDROID should return EGL_NO_NATIVE_FENCE_FD_ANDROID when there is error. However, ANGLE just returns 0 as default value. Now overload the default return value to EGL_NO_NATIVE_FENCE_FD_ANDROID. Also, a end2end test is added. Bug: angleproject:385190296 Change-Id: I214efdeb3ad583989fab5e2244c82cb7295f8b67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6146195 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Matthew Denton c289b30f 2025-01-09T12:49:27 WGSL: Add test for failure case of uniform struct rewrites. Using a uniform struct outside of the uniform address space fails if we've rewritten any of the member types and want to assign to that member. E.g. this line of GLSL, assigning to a member of a struct used in the uniform address space: privUnis.x = float[3](1.0, 1.0, 1.0); Produces this WGSL warning: ERR: DisplayWgpu.cpp:295 (operator()): Error: 2 - message: Error while parsing WGSL: :50:63 error: expected ')' (ANGLE_Convert_ANGLE_wrapped_float_ElementsTo_float_Elements((_uprivUnis)._ux)) = (array<f32, 3>(1.0f, 1.0f, 1.0f)); This adds a test and suppresses it on WGSL. Future design options: https://docs.google.com/document/d/17Qku1QEbLDhvJS-JJ9lPQAbnuZtLxWhG-ha5eCUhtEY/edit?tab=t.0#bookmark=id.r89s1r69tl77 Bug: angleproject:376553328 Change-Id: I57304e9d2a889d00ac4fa02f265198ce3d78e7e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6165290 Reviewed-by: Matt Denton <mpdenton@google.com> Commit-Queue: Matt Denton <mpdenton@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org>
Matthew Denton b1a0d60f 2025-01-08T15:10:41 WGSL: Fix accidentally overloaded functions Small-stride arrays in uniforms with the same element type, but different array sizes, would cause the WGSL generator to produce conversion functions with the same name but different array sizes. This CL puts the array size in the name of the function to avoid overloading, which is unsupported in WGSL. Bug: angleproject:376553328 Change-Id: I446e91ccb9da2872c88f1a4e05283aacc9d6f8b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6160334 Commit-Queue: Matt Denton <mpdenton@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Matt Denton <mpdenton@google.com> Reviewed-by: Liza Burakova <liza@chromium.org>
Yuxiang Qian 2de256cb 2024-12-30T17:26:38 Change some error type in eglCreateImageKHR Following the spec, for eglCreateImageKHR, if target is EGL_LINUX_DMA_BUF_EXT and attribute value is not expected, then EGL_BAD_ATTRIBUTE should be returned. However, ANGLE would return EGL_BAD_PARAMETER. Now change these error handlings to return EGL_BAD_ATTRIBUTE. Also, a end2end test is added. Bug: angleproject:387892107 Change-Id: I73ecfc3da273c0fb5ac362e451fd186209f1a52b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6146196 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Steven Noonan 3226a3df 2024-12-13T14:06:55 Reland: vulkan: add EGL_ANGLE_platform_angle_vulkan_device_uuid Implement the ability to select a specific device and driver combination through a few new selection criteria: VkPhysicalDeviceIDProperties::deviceUUID VkPhysicalDeviceIDProperties::driverUUID VkPhysicalDeviceDriverProperties::driverID Earlier version had problems due to a test build issue. Per syoussefi@, going to rework the test into a separate CL so that we get the core change merged. Bug: angleproject:351866412 Change-Id: I0a3f4f1a2154a06bf6286a037c9ad4834ef4dda2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6165286 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
kmx.io     mail     discord kmxgit v0.4.0