kc3-lang/angle
Branch :
Log
| Author | Commit | Date | CI | Message |
|---|---|---|---|---|
 |
f64ddcfd | 2020-01-06 13:27:30 | Add missing steps in DevSetup Bug: angleproject:4268 Change-Id: Ib7f58ba241c24acb35d8705d994c57422d9b73e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987908 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
56fd2bce | 2019-12-17 10:00:55 | Fix GGP build Bug: angleproject:4246 Change-Id: I80906196ebc3c904e75516e8c53b05dd81c5fa5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982633 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
 |
ab42afa6 | 2019-11-21 10:13:44 | Metal: fix vertex attribute's conversion lost after changing buffer binding. After vertex buffer's attribute is converted and stored in conversion buffer. Binding the same attribute to another buffer, then binding it back to previous buffer will result in previous conversion information lost. The conversion method would skip the conversion due to buffer's content hadn't been changed, however it didn't reuse the old conversion result. This CL also changed the way binding offset is used in Metal backend. - Previous, the offset would be assigned to the offset field of MTLVertexAttributeDescriptor, then the buffer would simply be bound to the command encoder with offset=0 i.e. setVertexBuffer(buffer, index, 0) - However this approach has several disadvantages. Since Metal doesn't allow MTLVertexAttributeDescriptor's offset to be larger than the vertex attribute's stride, the old approach would force the back-end to convert the attribute and store in conversion buffer. New approach: - MTLVertexAttributeDescriptor's offset will be zero. The offset will be used to bind the buffer itself to the render command encoder. i.e. setVertexBuffer(buffer, index, offset) This way the "offset <= stride" restriction no longer exists. The only restriction is the offset must be multiple of attribute's size. Added 3 new tests: - SimpleStateChangeTest.RebindTranslatedAttribute - VertexAttributeTest.DrawWithLargeBufferOffset - VertexAttributeTest.DrawWithLargeBufferOffsetAndLessComponents Bug: angleproject:2634 Change-Id: I6c2fa8091436e4a24405d791f86d17d97df02d64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940009 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
 |
3311ef65 | 2020-01-03 11:52:15 | update date comments to 2020 run_code_generation.py updated comments with 2019 to 2020. Put all date updates into this one CL. This also updated hashes. Bug: angleproject:4262 Change-Id: Ia213dd5e47f155986cbb4161d777724355878af0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986994 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
1031d2c6 | 2020-01-03 14:28:26 | Upstream Mac logging changes from WebKit. Use os_log_with_type in ANGLE's logging facility rather than fprintf. Bug: angleproject:4263 Change-Id: I0c418fc5544001bf4f47ff511d05de2f0ebaa1de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987145 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> | |
 |
81ee4d29 | 2019-12-04 17:05:11 | Workaround EXT_texture_norm16 for OpenGL ES drivers Implement a workaround for widespread bugs calling glReadPixels with RGBA/UNSIGNED_SHORT against R16/RG16 color attachments. Read back the data using the GL_IMPLEMENTATION_COLOR_READ_FORMAT, and then rearrange the read back pixels to fit the RGBA layout. Also skip RGB16/RGB16_SNORM texture sample test on Nexus 5X/Nexus 6P due to a another driver bug. Bug: chromium:1000354, angleproject:4214, angleproject:4215, angleproject:4245 Change-Id: Iedea6f4136878cac5ad0dec3757c77b73502e1cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1952166 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> | |
 |
de97fb4a | 2020-01-03 07:01:41 | Roll third_party/vulkan-validation-layers/src e4a2b7f22782..2be3fe0f8471 (7 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e4a2b7f22782..2be3fe0f8471 git log e4a2b7f22782..2be3fe0f8471 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 jzulauf@lunarg.com layers: Record initial layout on release barriers 2020-01-02 mark@lunarg.com corechecks: Plumb VtxIndex VUIDs through to helper func 2020-01-02 mark@lunarg.com corechecks: Remove obsolete perf warning 2020-01-02 mark@lunarg.com tests: Removed PerfWarning test from VkLayerTest harness 2020-01-02 mark@lunarg.com bestpractices: Use BP VUID in place of corechecks one 2020-01-02 mark@lunarg.com tests: Added test for missing vtx buffers to BP harness 2020-01-02 mark@lunarg.com bestpractices: Added perf warning for missing vtx buffers Created with: gclient setdep -r third_party/vulkan-validation-layers/src@2be3fe0f8471 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I80a335bf862d776bc1533f366316f5b899fbfb09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986605 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
 |
93061d4e | 2019-12-30 23:45:08 | Vulkan: Support vertex-only line emulation draw with xfb The code that patches the line raster emulation directive assumed both vertex and fragment shaders would be present. This is invalid if only a vertex shader is present. This change adds the directive to any stage that's available. This includes the possibility of a missing vertex shader also, which can be useful for separable shaders and program pipeline objects. Bug: angleproject:3394 Change-Id: I84555db81b59c318300003f7108a01f330e4259f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982782 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> | |
|
35e6050f | 2019-12-30 23:47:51 | Vulkan: Correct error message for VK_ERROR_INVALID_SHADER_NV If an invalid shader is generated, generate the appropriate message instead of "Unknown error". Bug: angleproject:3394 Change-Id: I586c99e95cd72daeaf74b4d1eff352942e01d8b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982783 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
1fdf6ca5 | 2019-12-31 14:25:35 | D3D11: Restrict to translate uniform block to StructuredBuffer Only translate uniform block to StructuredBuffer when system is Windows 10 and later. Bug: angleproject:3682 Change-Id: I27e3f4503392791883a44e1d486ffe9512e04bd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984863 Commit-Queue: Xinghua Cao <xinghua.cao@intel.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
cbbfa2f2 | 2019-12-31 07:01:43 | Roll third_party/SwiftShader 59465799210b..10a900e5ffaf (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/59465799210b..10a900e5ffaf git log 59465799210b..10a900e5ffaf --date=short --first-parent --format='%ad %ae %s' 2019-12-30 chrisforbes@google.com Add assert in GenericValue constant access Created with: gclient setdep -r third_party/SwiftShader@10a900e5ffaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Id7ec364a7df7c8389d3bab78761f4b1061d93e10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984961 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
 |
942d9152 | 2019-12-23 15:31:52 | EGL: Add support for EGL_KHR_gl_colorspace extension If the Vulkan backend supports VK_EXT_swapchain_colorspace extension, enable the option for applications to create surfaces with non-linear formats. Not all formats have non-linear versions and is platform specific. Tests: dEQP-EGL.functional.wide_color.* angle_deqp_egl_tests --use-angle=vulkan --deqp-gl-context-type=egl --deqp-case=dEQP-EGL.functional.wide_color.* Bug: angleproject:2514 Change-Id: I441ee797cceef92c84473bfa18605c4fd8180de1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951963 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> | |
|
c1fc6de8 | 2019-12-30 07:02:09 | Roll third_party/vulkan-headers/src 0e57fc1cfa56..f63dd5c9d874 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/0e57fc1cfa56..f63dd5c9d874 git log 0e57fc1cfa56..f63dd5c9d874 --date=short --first-parent --format='%ad %ae %s' 2019-12-28 flibitijibibo@gmail.com GN: Make PLATFORM_XCB optional, based on a user-defined variable. Created with: gclient setdep -r third_party/vulkan-headers/src@f63dd5c9d874 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=ynovikov@chromium.org Bug: None Change-Id: I57e5f53b741fce8a14d27af4445fcc31ea860c70 Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984191 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
f02490d1 | 2019-12-23 14:06:12 | Vulkan: clean up arguments to glslang wrapper Some flags were sent as parameters while an Options parameter was added. This change moves those flags to the GlslangSourceOptions struct. Bug: angleproject:3394 Change-Id: Iff5c1c83dd564d7bcfcbd84e6df244b7356d669d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984108 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
7fad424e | 2019-12-30 00:07:09 | Avoid vector copy in BinaryOutputStream::writeIntVector Also adds a unit test to make sure readIntVector and writeIntVector match. It was not immediately clear that writing the vector size in writeIntVector is writing an int instead of a size_t. Bug: angleproject:3394 Change-Id: I09a003c169dbc47e40c0cd3e4da6f1d7a905c6da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1983162 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
9fac1817 | 2019-12-30 07:01:40 | Roll third_party/glslang/src 5de15a256eb0..6334d594f68c (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5de15a256eb0..6334d594f68c Created with: gclient setdep -r third_party/glslang/src@6334d594f68c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ynovikov@chromium.org Change-Id: I13837b1d19eccf54aae171349dfadd0d37d7ef77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1984164 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
fca5a005 | 2019-12-27 07:01:40 | Roll third_party/glslang/src bd97b6f9f213..5de15a256eb0 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bd97b6f9f213..5de15a256eb0 Created with: gclient setdep -r third_party/glslang/src@5de15a256eb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ynovikov@chromium.org Change-Id: I2324cfed3dd1026a11ead024c805b216481d47ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982965 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
ebed8559 | 2019-12-27 07:01:43 | Roll third_party/SwiftShader 6e3a387c0159..59465799210b (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/6e3a387c0159..59465799210b git log 6e3a387c0159..59465799210b --date=short --first-parent --format='%ad %ae %s' 2019-12-27 capn@google.com Remove Reactor/MutexLock.hpp Created with: gclient setdep -r third_party/SwiftShader@59465799210b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ynovikov@chromium.org Change-Id: I10048c2c0d1fd7843762ea3636b1ef29b7200359 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982966 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
01dd6f6c | 2019-12-25 07:01:28 | Roll third_party/vulkan-tools/src 37af49fa7b55..55333361f9a1 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/37af49fa7b55..55333361f9a1 git log 37af49fa7b55..55333361f9a1 --date=short --first-parent --format='%ad %ae %s' 2019-12-24 charles@lunarg.com vulkaninfo: exit on invalid gpu selected Created with: gclient setdep -r third_party/vulkan-tools/src@55333361f9a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I3a08dd0ecc6c3745d29a149fa75d825ddd3b7860 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1981930 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
a35aa03a | 2019-12-20 16:15:53 | Vulkan: EXT_gpu_shader5: textureGatherOffsets The validation of the offsets parameter is added in this change. Bug: angleproject:3569 Change-Id: Ide2ea4b9e88b28ca5ef34d5f3f5203f6e48d5f74 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1979133 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
beb33691 | 2019-12-20 16:15:20 | Vulkan: EXT_gpu_shader5: Fix textureGatherOffsets builtin This function is the only builtin with arrays as parameter. A new constexpr constructor is added to TType to support this, and gen_builtin_symbols is changed to emit the correct type for offsets parameter of this function. Bug: angleproject:3569 Change-Id: I55af58b43f24cd605c622ee685b359535e11ef85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975431 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
52dae168 | 2019-12-19 12:03:30 | Vulkan : Fix maxVertexOutputComponents GL_MAX_VERTEX_OUTPUT_COMPONENTS should mirror Vulkan's reported maxVertexOutputComponents; this shouldn't include any gl_Position adjustments. It was previously set as maxVaryingVectors * 4. The workaround for AMD that reserved an extra varying due to driver instability is no longer required (see: https://chromium-review.googlesource.com/c/angle/angle/+/1980272) Bug: angleproject:4233 Change-Id: I8d7b8eafa7edd4c56005dad039fe69e072692fca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975851 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
86d9c93a | 2019-12-16 16:07:04 | Use TSpan for TType's array sizes Until C++20, std::vector doesn't have a constexpr constructor, which means TType cannot use a `TVector` for `mArraySizes` if an arrayed type needs to be created constexpr. This is needed for the upcoming textureGatherOffsets implementation. A new TSpan class is introduced, based on std::span (from C++20) that holds the pointer/size allocated from a TVector without owning it. Since TVector's allocation are made from a pool, the allocated memory will live beyond the vector's destruction. `TType::mArraySizes` is changed to this type. This change will allow a new constexpr constructor to be added to TType that takes a TSpan as array directly, a value which is constexpr initialized from a static array (instead of TVector). Bug: angleproject:3569 Change-Id: I78793b0f4c64519e0ebe30cf6e0de995ba70035d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1968260 Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
c713abfd | 2019-12-23 12:03:02 | Vulkan:Transform/feedback instanced draw support These fixes allow dEQP 3.1 KHR-GLES31.core.vertex_attrib_binding.basic-input* test cases to pass. This fixes a bug in instanced drawing with transform feedback buffers where we were overwriting the initial transform feedback output as new instances were drawn. To fix this, the vertices in each draw are passed into a uniform value and the output is offset based on the current instance and the number of vertices in the draw. It also fixes a validation error where transform feedback descriptor was sometimes setting a buffer range of 0. This is not allowed, so in the 0 case we pull the actual buffer size from the bufferHelper object. Bug: angleproject:4236 Change-Id: Ib72898a0e6caab96c446c1e996a6124d2c001193 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1979600 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com> | |
|
67d8b63a | 2019-12-23 11:35:52 | Vulkan:Update Vulkan Vertex Attribute Offsets This fixes most of the test for dEQP 3.1 KHR-GLES31.core.vertex_attrib_binding.basic-input* The bug fixes is that we were not correctly setting the vertex attribute offset for vertex attribs that were converted into their own buffer. We kept the attrib offset from the frontend as if the converted attribs were in the original buffer, but converted vtx attrib buffers in the VK backend are tightly packed from the start of the buffer so when converting the actual offset should be 0. Also, in order to avoid a VK validation error, this change includes a tmp workaround to make sure transform feedback output buffer range is never 0, but sets VK_WHOLE_SIZE in that case. A follow-on fix that focuses on transform feedback fixes will address this validation error more fully. Bug: angleproject:4145 Bug: angleproject:4236 Change-Id: I8c218954725945414a8f18beb4f964b90da7062a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1980906 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
87607526 | 2019-12-23 22:48:06 | Disable flaky test on Metal Bug: chromium:1037665 Bug: angleproject:4177 Change-Id: I38f05f1567803e7ac0c631d94056f26dc122a4f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1980278 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
c41f2e56 | 2019-12-23 13:33:58 | Disable UniformBufferTests on Windows 7 / D3D11 / NVIDIA. Bug: chromium:1037644 Change-Id: Ic8bf76bb0c1b8bdcf36f6af5a8d91ac815334917 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1981070 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> | |
|
e2fc92ca | 2019-12-23 14:21:28 | Vulkan: Fix swiftshader device selection A recent SwS roll changed the deviceName of swiftshader to include the backend (LLVM for example). That made ANGLE no longer recognize SwiftShader. This change looks for the known SwS device name as a prefix of the deviceName retrieved from the device, rather than a complete match. Bug: angleproject:3876 Change-Id: If6dacb1e5685493d5334cad2015439f0f6b71124 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1980275 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
07f0f019 | 2019-12-19 14:47:46 | Translator: Memory qualifiers on SSBO fields These were not output prior to this CL. Of these qualifiers, readonly and writeonly are unnecessary as ANGLE already does the appropriate validation, but the rest (coherent, volatile, restrict) are necessary, even though the tests pass on the bots by coincidence of driver behavior/test simplicity. Bug: angleproject:3602 Change-Id: Ie75fee0f004944b50ef21124ba25c4315e082b85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1976499 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
80943776 | 2019-12-17 16:58:06 | Refactor TType's constructors Instead of duplicating the initialization of every field, use one of the constructors to initialize the other ones. Bug: angleproject:3569 Change-Id: Ie342111218235ecb4124deb2f0147f97cdbed51a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972889 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
f5c3afec | 2019-12-23 07:01:40 | Roll third_party/glslang/src ebf634bcaa3e..bd97b6f9f213 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ebf634bcaa3e..bd97b6f9f213 Created with: gclient setdep -r third_party/glslang/src@bd97b6f9f213 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Icc6edef982018a13e978f307491e333e41a64c82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1980455 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
392c9809 | 2019-12-23 07:01:41 | Roll third_party/vulkan-validation-layers/src 6b71f08cc83e..e4a2b7f22782 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6b71f08cc83e..e4a2b7f22782 git log 6b71f08cc83e..e4a2b7f22782 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 mark@lunarg.com statetracker: Fetch shader float control properties 2019-12-20 mark@lunarg.com test: Fix ByteCount test failure on Pixel3 2019-12-20 mark@lunarg.com tests: Add CmdDrawIndirectByteCountEXT stride test 2019-12-20 mark@lunarg.com stateless: Added check for XformFeedback vertexStride Created with: gclient setdep -r third_party/vulkan-validation-layers/src@e4a2b7f22782 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I9fc5f15dcfd281021d5c89e9b0739aba45e68174 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1980456 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
c92b5991 | 2019-12-23 07:01:43 | Roll third_party/SwiftShader 6d29348ddb7e..6e3a387c0159 (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/6d29348ddb7e..6e3a387c0159 git log 6d29348ddb7e..6e3a387c0159 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 capn@google.com Exclude padding bytes from image size limit 2019-12-20 amaiorano@google.com Vulkan: include backend name in deviceName 2019-12-20 amaiorano@google.com Debug: add trace to debug out 2019-12-20 swiftshader.regress@gmail.com Regres: Update test lists @ 6d29348d Created with: gclient setdep -r third_party/SwiftShader@6e3a387c0159 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ic67a12b7547b8563f195ff800ed02cd19e86481b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1980457 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
07d3bcf1 | 2019-12-20 11:23:26 | Correct calculation of GL_MAX_VARYING_COMPONENTS GL_MAX_VARYING_COMPONENTS does not equal maxVertexOutputComponents. The minimum supported limit for GL_MAX_VARYING_COMPONENTS is 60, whereas the minimum for maxVertexOutputComponents is 64. On devices that have the minimum limits the existing code will report a limit for GL_MAX_VARYING_COMPONENTS that is too large (64 vs 60). Report instead as (GL_MAX_VARYING_VECTORS * 4). Bug: angleproject:4233 Change-Id: I920a32cf21040ff5b64746fcf3489db740028d48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978638 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
0af8b596 | 2019-09-03 16:24:45 | D3D11: Translate uniform blocks to StructuredBuffer when necessary fxc exhibits slow compile performance with dynamic cbuffer indexing. So when a uniform block contains only one large array member, which is an array of structures, translate this uniform block to a StructuredBuffer instead. Bug: angleproject:3682 TEST=angle_end2end_tests.UniformBufferTest.* Change-Id: Ife80dba8aae65b761737e095895e00a570230f88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1782046 Commit-Queue: Xinghua Cao <xinghua.cao@intel.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
291be9ac | 2019-12-18 14:36:17 | Add DEP to pull internal capture files To enable, add the following to your .gclient file: "custom_vars": { "checkout_angle_internal":"True", }, Bug: angleproject:3630 Change-Id: I639ba5236fc6d90060a7b50bd0942fe2d0285a25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949604 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> | |
|
84f45f10 | 2019-12-18 14:34:29 | Use checkout_angle_internal for non-public files The previous flag was too broad, pulling all Chromium internal files. We only need one repository. Bug: angleproject:3630 Bug: chromium:1032708 Change-Id: I8aac322e2f748570432be27f2981f927bd264fce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969735 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> | |
 |
abc8f277 | 2019-12-19 10:47:31 | Vulkan: Disallow multisampling with a sample count of 1 GLES uses a sample count of 0 to indicate non-multisampling, and a sample count of 1 or greater to indicate multisampling. While the Vulkan specification seems to support multisampling with a sample count of 1, the following spec language effectively disallows it (even when the underlying Vulkan driver supports it): If the image was created with VkImageCreateInfo::samples equal to VK_SAMPLE_COUNT_1_BIT, the instruction must have MS = 0. The following GLES 3.1 dEQP tests use shaders that look for the sample position, with a sample count of 1: dEQP-GLES31.functional.texture.multisample.samples_1.* For Vulkan drivers that fully support multisampling with a sample count of 1, these tests pass, but get Vulkan validation errors because of the above spec language. This was discussed in the Khronos-private issue tracker (see: https://gitlab.khronos.org/vulkan/vulkan/issues/1925). The Vulkan working group wondered if ANGLE could live with not supporting a sample count of 1 (but upgrading such requests to the next-largest supported sample count, per the GLES specification). This change implements that approach. Bug: angleproject:4197 Bug: angleproject:4212 Change-Id: I009ba47b48efe5af464011c7c15022fc01f45e76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974842 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com> | |
 |
9d03c297 | 2019-12-20 11:53:32 | Skip all Metal dEQP tests First step in running dEQP tests on the Metal backend on the bots Bug: angleproject:4235 Change-Id: Ib191205179d98bc907cc7d48340744ea719a0bc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978577 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> | |
 |
816132a3 | 2019-12-17 15:47:09 | Do not send attribute data for built-ins Built-ins (e.g. gl_VertexID or gl_InstanceID) were settings dirty bits in the driver's ActiveAttribLocationsMask which would later cause the Vulkan back-end to issue bind commands on these built-in attributes that don't have / need anything bound. Test: angle_deqp_khr_gles31_tests --use-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_shader_storage_buffer_object_advancedswitchBuffersvs Bug: angleproject:4107 Change-Id: Id1f1c6699d512d0726b22d9bb0c16abad179950d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972200 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> | |
|
7f2930fc | 2019-12-20 07:01:43 | Roll third_party/SwiftShader 4fd7fccd6db5..6d29348ddb7e (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/4fd7fccd6db5..6d29348ddb7e git log 4fd7fccd6db5..6d29348ddb7e --date=short --first-parent --format='%ad %ae %s' 2019-12-19 sugoi@google.com Enable filtering depth only formats 2019-12-19 bclayton@google.com Kokoro: Add style presubmit checks 2019-12-19 swiftshader.regress@gmail.com Regres: Update test lists @ 4fd7fccd Created with: gclient setdep -r third_party/SwiftShader@6d29348ddb7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I301672b05e9440fe89ebd115a95a5739b203dac8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978599 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
2303ff5b | 2019-12-20 07:01:28 | Roll third_party/vulkan-tools/src 246503e9c085..37af49fa7b55 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/246503e9c085..37af49fa7b55 git log 246503e9c085..37af49fa7b55 --date=short --first-parent --format='%ad %ae %s' 2019-12-19 tony@lunarg.com cube: Leave uniform memory mapped Created with: gclient setdep -r third_party/vulkan-tools/src@37af49fa7b55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I3f954505f6186b894d5515b1395f0e22960f183e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978597 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
21e894d7 | 2019-12-20 07:01:41 | Roll third_party/vulkan-validation-layers/src e8e8f32d1b7a..6b71f08cc83e (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e8e8f32d1b7a..6b71f08cc83e git log e8e8f32d1b7a..6b71f08cc83e --date=short --first-parent --format='%ad %ae %s' 2019-12-19 locke@lunarg.com tests: Remove UnexpectedError 2019-12-19 locke@lunarg.com layers: Skip PARTIALLY_BOUND 2019-12-19 tony@lunarg.com gpu: Initialize report_data for instance 2019-12-19 petr_kraus@email.cz layers: Fix wrong version reported by tooling Created with: gclient setdep -r third_party/vulkan-validation-layers/src@6b71f08cc83e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I23c37bcf3db43fb582be4711c319e7ac353db5d6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978598 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
fe2ed33a | 2019-12-19 14:43:25 | Translator: Output memory qualifiers in OutputTree Bug: angleproject:3602 Change-Id: I673d8080be874bea0a73a89f7499b652549c2f3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1976498 Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
fbe6c1d2 | 2019-12-14 21:54:34 | Metal: correctly clamp stencil reference values According to GL spec: - If stencil ref value is larger than max value the stencil buffer can represent, clamp it to max value (2^bits - 1) - The stencil clear value & mask will be truncated to stencil buffer's bits instead of clamping. Metal API is very vague on how it handles the stencil ref value larger than the stencil bits can represent, so we need to handle it manually. In fact, the Metal API seems to have bugs when dealing with large stencil ref value, i.e. > 0xff for example. Bug: angleproject:2634 Change-Id: I86f61f0bfd19dfc0fa459c84d98785a1af857a6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966185 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
7b55aac3 | 2019-12-12 10:14:10 | Add Broadcom as a known vendor Broadcom's vendor ID wasn't listed anywhere. Fixed the sort order of vendor names in a number of places also. Bug: angleproject:4218 Change-Id: Iddc504fa35833ac14375cb77e7a2b1cc405f0e80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972714 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
9dec123f | 2019-12-19 11:05:04 | Ignore nameless vim swap files Starting vim with no file name creates a swap file in the form of .swp, .swo etc. Add these files to .gitignore. Bug: None Change-Id: Id9639f626daebc993ccc9ab0a9049a18e0f80862 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975612 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
f321db9a | 2019-12-19 07:01:48 | Roll third_party/spirv-tools/src 38d7fbaad0a3..e70b009b0f1e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/38d7fbaad0a3..e70b009b0f1e Created with: gclient setdep -r third_party/spirv-tools/src@e70b009b0f1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I8c577825cd88e3b8a502a36399a8988b0bba6020 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974923 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
f23d5401 | 2019-12-19 07:01:43 | Roll third_party/SwiftShader 21be09d8e699..4fd7fccd6db5 (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/21be09d8e699..4fd7fccd6db5 git log 21be09d8e699..4fd7fccd6db5 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 chrisforbes@google.com Regres: Roll deqp forward to latest 1.1.6 2019-12-18 sugoi@google.com Allow 32F texture to use linear filtering 2019-12-18 capn@google.com Remove sw::Vector, Point, and Matrix 2019-12-18 swiftshader.regress@gmail.com Regres: Update test lists @ 21be09d8 Created with: gclient setdep -r third_party/SwiftShader@4fd7fccd6db5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I496b3ce51d50ec10f72ccc523027dff7c77a135e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974922 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
b0172d37 | 2019-12-19 07:01:41 | Roll third_party/vulkan-validation-layers/src 2b19f3916726..e8e8f32d1b7a (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2b19f3916726..e8e8f32d1b7a git log 2b19f3916726..e8e8f32d1b7a --date=short --first-parent --format='%ad %ae %s' 2019-12-19 mark@lunarg.com tests: Add ClearColorImage SHARED_PRESENT layout check 2019-12-19 mark@lunarg.com corechecks: Fix CmdClear layout validation 2019-12-18 tony@lunarg.com layers: Guard against ATTACHMENT_UNUSED 2019-12-17 mark@lunarg.com objlifetimes: Fix undestroyed object reporting Created with: gclient setdep -r third_party/vulkan-validation-layers/src@e8e8f32d1b7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ice1e926ff24301c807b0acdf13d087e8b1242634 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974921 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
ecc96617 | 2019-12-19 07:01:28 | Roll third_party/vulkan-tools/src 9c5719ab7149..246503e9c085 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/9c5719ab7149..246503e9c085 git log 9c5719ab7149..246503e9c085 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 shannon@lunarg.com winrt: Update `VulkanRT-License.txt` text Created with: gclient setdep -r third_party/vulkan-tools/src@246503e9c085 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I68bb42383831cbf9aebc75e3daeae17cba45219b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974920 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
4b80fbc8 | 2019-12-18 23:40:15 | Fix textureGatherOffsets classification sampler2DRect was placed under ESSL while sampler2DArrayShadow was placed under desktop GLSL. They are swapped. Bug: angleproject:3569 Change-Id: Ibf39868d4cd702d9d1da7fc286171bb70b80d6df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975430 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
6423b7fc | 2019-12-04 18:45:24 | Return the correct location count for Matrices GetLocationCount() is currently returning the number of rows in the matrix, rather than the columns, which leads to shader validation errors (and test failures). This fix returns the number of columns in a matrix. Bug: angleproject:4200 Test: dEQP-GLES31.functional.separate_shader.random.63 Change-Id: I8d25eb3733c2ddbe53ff54794f480c1d43e22a88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1952173 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Tim Van Patten <timvp@google.com> | |
|
20432bf3 | 2019-12-18 08:51:34 | Vulkan: Update GLES 3.1 expectations for now-passing tests. Bug: angleproject:4099 Bug: angleproject:4100 Bug: angleproject:4102 Change-Id: I975485baea3ff6ec8247cbb5c92efdb907974ebc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974271 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com> | |
|
cd129d17 | 2019-12-16 15:08:11 | Reset binding offset & size when unbinding Bug: angleproject:4147 Change-Id: I4ace1221d32631cdb14a95c71ee9a1617837a5ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1970495 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> | |
 |
17b3c2f3 | 2019-10-14 14:13:59 | Implement SamplerVideoWEBGL for WEBGL_video_texture extension on desktop WEBGL_video_texture is an extension that will improve uploading video frame to WebGL performance. (https://www.khronos.org/registry/webgl/extensions/proposals/WEBGL_video_texture/) This extension introduced a new texture type TEXTURE_VIDEO_IMAGE_WEBGL and a new sampler type samplerVideoWEBGL to sample it. In chromium implementation, TEXTURE_VIDEO_IMAGE_WEBGL maps to different native texture type based on platform. On desktop, it maps to GL_TEXTURE2D(Currently supported). On Android, it should map to GL_TEXTURE_EXTERNAL(TODO). SamplerVideoWEBGL needs to be mapped to sampler2D or samplerExternalOES according to TEXTURE_VIDEO_IMAGE_WEBGL implementation. This patch implements samplerVideoWEBGL in Angle to support WEBGL_video_texture on desktop. In this case, samplerVideoWEBGL should map to sampler2D. Bug: chromium:776222, angleproject:3889 Change-Id: Idb0a5fcde37ca75ccc1181226b91f257212e7500 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1866274 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> | |
|
65e2f03b | 2019-12-18 07:01:42 | Roll third_party/SwiftShader fbbfeb700295..21be09d8e699 (17 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/fbbfeb700295..21be09d8e699 git log fbbfeb700295..21be09d8e699 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 sugoi@google.com Enable samplerAnisotropy 2019-12-18 chrisforbes@google.com Advertise variableMultisampleRate feature 2019-12-17 bclayton@google.com clang-format the src/WSI directory 2019-12-17 bclayton@google.com clang-format the src/Vulkan directory 2019-12-17 bclayton@google.com clang-format the src/System directory 2019-12-17 bclayton@google.com clang-format the src/Reactor directory 2019-12-17 bclayton@google.com clang-format the src/Pipeline directory 2019-12-17 bclayton@google.com clang-format the src/Device directory 2019-12-17 bclayton@google.com Start a custom .clang-format rule 2019-12-17 capn@google.com Remove spaces after control statements keywords 2019-12-17 sugoi@google.com Enable blending for 32FP formats 2019-12-17 capn@google.com Make use of vec<T, N> vector broadcasts 2019-12-17 capn@google.com Replace vector() and replicate() with float4 constructors 2019-12-17 capn@google.com Create a generic vec<T, N> class 2019-12-17 capn@google.com Typedef int4/float4 from a vec4<T> template 2019-12-17 capn@google.com Prefer alignas() over ALIGN() 2019-12-17 sugoi@google.com R11G11B10F support Created with: gclient setdep -r third_party/SwiftShader@21be09d8e699 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Iff5532b2838a657d66fc51751fd95036d35f3f30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1973467 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
e5c2e047 | 2019-12-18 07:01:02 | Roll third_party/vulkan-tools/src 0c2618b2c31e..9c5719ab7149 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/0c2618b2c31e..9c5719ab7149 git log 0c2618b2c31e..9c5719ab7149 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 charles@lunarg.com vulkaninfo: safely handle device groups not supported Created with: gclient setdep -r third_party/vulkan-tools/src@9c5719ab7149 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Idca41eac95939e072b5e9317ffbfbcce57646ff6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1973466 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
 |
751e7888 | 2019-12-16 17:21:02 | Update with official gl.xml and re-sort added formats Use latest Khronos gl.xml file and re-sort format enums that angle had already added to this file Bug: angleproject:4093 Change-Id: Ic5c1abc2a79fec14f3c53856a429c9b2489e3275 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972199 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
c3f833f3 | 2019-12-17 16:06:59 | Vulkan: Update expectations for newly-passing tests Bug: angleproject:4101 Bug: angleproject:4105 Change-Id: Ida462f69660a55e13b48ebea22ffc2a6b6bfe867 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972202 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com> | |
 |
17217c6e | 2019-12-17 17:31:17 | Vulkan: Fix layers being disabled in tests. The ANGLE_ENABLE_VULKAN_VALIDATION_LAYERS_BY_DEFAULT define shouldn't be being checked in tests. Enable the debug layers by default. Bug: angleproject:4227 Bug: angleproject:4229 Change-Id: I9717cb1c611ebd585a5c03ba2057036e1b086001 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972497 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> | |
|
d205ee3a | 2019-12-16 10:59:43 | Pass GLImplFactory to Query constructor. This makes the code more consistent and allows for the Query constructor to generate a Serial. Bug: angleproject:4223 Change-Id: I6cc683b11ed364f13d303f97aa0984e63260953e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969061 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
545c6142 | 2019-12-17 13:53:28 | Vulkan:Lazily link libvulkan Move libvulkan to a data_dep as we no longer statically link it. Bug: angleproject:4225 Change-Id: I96458d4727d2d47d8c259ec51d91fd852067c059 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972192 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
d50151d3 | 2019-12-17 13:57:12 | Move Serial utils to their own file. This will let the front-end access them without pulling in the rest of renderer_utils. The Serial class in particular will be useful for capture/replay. Also adds a very minimal unit test. Bug: angleproject:4223 Change-Id: I9e63b8a8227a245b20a8f024b960fcf60c7840db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954611 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> | |
|
e60d05b2 | 2019-12-17 13:59:24 | Make Sync constructors take GLImplFactory. Makes them consistent with the rest of the code. Will allow the Sync class to call methods in GLImplFactory to generate a resource Serial. Also updates the unit test to the new design. Bug: angleproject:4223 Change-Id: Ic5ba69c3a6a51d4b51d876c3b5e7eb7bc44a9ae8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969060 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> | |
|
44722daa | 2019-12-06 22:31:08 | Vulkan: Enable inactive SSBO with unsized array tests The change introduced in https://chromium-review.googlesource.com/c/angle/angle/+/1951523 removes inactive shader interface declarations. That automatically resolves an issue where glslang wrapper doesn't handle inactive SSBO declarations with unsized arrays, by removing those declarations at translation time altogether. Bug: angleproject:3714 Change-Id: I710d59546d716bfb5bc0112b5152fed20a810a52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954615 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
7e19e25e | 2019-12-16 10:59:42 | Vulkan: Fix SwiftShader disabled build. Disabling SwiftShader in the GN build led to a compile error when trying to use ANGLE_VK_SWIFTSHADER_ICD_JSON. Bug: angleproject:4223 Change-Id: I076a88e6bc58adf1e34bbb7286b1f46028cd021a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969059 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> | |
|
d674e1e5 | 2019-12-12 14:47:24 | Vulkan: EXT_gpu_shader5: non-const offset in textureGatherOffset This change includes preparatory work for textureGatherOffsets as well, though that requires special handling which is addressed in a follow-up change. This special handling is due to the fact that this family of functions is the only built-in with an array parameter, and our built-in table generation doesn't handle it correctly. Bug: angleproject:3569 Change-Id: Ic1c8dd03878a184be00f578ab9fc42af8f6e47ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965435 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
634ee434 | 2019-12-16 11:39:10 | Improve presubmit's Bug: tag check Specifying the project name is now mandatory. This helps avoid accidentally referring to chromium bugs by forgetting the project name. At the same time, it ensures the project name is not misspelled. Bug: angleproject:4184 Change-Id: I6bbfe1751e2fd0baf424be38018374cce360df5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969067 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
a5dd3888 | 2019-12-04 14:31:57 | Vulkan: fix handling of inactive atomic counters The translator emulates atomic counters with a storage buffer array during translation to Vulkan GLSL. Glslang wrapper then should assign set/binding to this buffer. However, if the atomic counters are actually unused in the shader, this assignment is never done. This change adds a small tree transformation for Vulkan that removes any uniform or interface block declaration that's not active. In particular, this makes atomic counter emulation a no-op if no atomic counters are used. It also has the benefit of not requiring glslang wrapper to remove such inactive resources. Bug: angleproject:4190 Change-Id: I286c199854ec2379558ad1ec48b4d2c4bf5544d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951523 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> | |
|
0c14e233 | 2019-12-17 07:01:41 | Roll third_party/spirv-tools/src 96354f5047bf..38d7fbaad0a3 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/96354f5047bf..38d7fbaad0a3 Created with: gclient setdep -r third_party/spirv-tools/src@38d7fbaad0a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I81d302d7aaf865489f50fa722791efdb5fbb6a05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1971254 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
5407aaa0 | 2019-12-16 15:50:12 | Re-land "Add new test runner harness." (#2) Re-land #2 changes: * export labels are fixed for the CFI build * crash test disabled because of flakiness and issues with asan Re-land changes: * Unit test is suppressed in ASAN * --deqp-case is fixed * Debug layer errors should correctly work with failure expectations Original message: The ANGLE test harness is a harness around GoogleTest that provides functionality similar to the Chromium test harness. It supports: * splitting a test set into shards * catching and reporting crashes and timeouts * outputting to the Chromium JSON test results format * multi-process execution Unit tests are added in test_utils_unittest.cpp. Bug: angleproject:3162 Bug: chromium:1030192 Change-Id: I71d66a407ea0e53d73cbe75b5b4bfb9e73791534 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965091 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> | |
|
5cfab195 | 2019-10-28 09:12:53 | Vulkan: Add test that logs supported texture formats Add a whitebox test to log all supported GLES formats for the active Vulkan ICD. The test object is dependent on libANGLE's gl_enum_util.* files as we need it to print out human readable values in the PrintAllFormatSupport test. Test: angle_white_box_tests --gtest_filter=*PrintAllSupportedFormats* Bug: angleproject:4093 Change-Id: I99d74935b705b2984f6320ed80a0e977c8fcd4be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1930607 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
9190f49c | 2019-12-16 16:03:57 | GN: Make new angle_test_utils target. This source set target lets other targets import the test utils without needing to export them. They get built into angle_util. They also get compiled into the various tests and samples. The change also fixes export issues. Moves some of the GN logic into the util/ subfolder. Bug: angleproject:3162 Bug: chromium:1030192 Change-Id: If99d201092ad8541c0de60b3bd893ac9b5875270 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1968259 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
390c4952 | 2019-12-10 19:30:15 | Adds missing extensions to registry_xml.py Bug: angleproject:4093 Change-Id: I979b54e12c1e897ccfa116f332bf9146dcd00cae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965644 Commit-Queue: Brandon Schade <b.schade@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
ce41a43c | 2019-12-16 09:49:05 | Vulkan: Fix failed assert when unbinding texture We were hitting onImageStateChange with no texture active and hitting the assert in that function for needing a texture. There are times when we call onImageStateChange where there is no texture bound, early exit in those cases. Test: angle_deqp_khr_gles31_tests --user-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_image2D_layout_binding_imageLoad_* also: --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_atomic_uint_layout_binding_atomic_ComputeShader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_buffer_layout_binding_atomicAdd_ComputeShader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_block_layout_binding_block_ComputeShader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_sampler2D_layout_binding_texture_ComputeShader Bug: angleproject:4124 Change-Id: I027cf4ecb6a5d6aea874c306bf3e67b95a75af62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965027 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
5fd73782 | 2019-08-09 11:46:46 | Vulkan: Use volk to load vk* func ptrs Thanks to Jamie Madill for some fixes to get all CI test passing w/ volk. This change updates all ANGLE targets that use Vulkan to dyanmically link all of the VK entrypoints using the volk OSS library from https://github.com/zeux/volk. It's only two source files so baking them directly into ANGLE repo. Also it's used in both the tests and libANGLE trees so added to src/common/third_party/volk dir. Updated volk and the renderer to track latest instance and device that were loaded and renderer will refresh vk* function pointers if the current and previous device and/or instance don't match. This prevents errors in the test framework as we transition between backends, especially between VK HW & SwiftShader ICDs. This change rolls the Vulkan Loader forward to use the latest loader version which no longer allows static linking but requires dynamic linking. Bug: angleproject:3740 Bug: angleproject:4092 Bug: angleproject:4162 Bug: angleproject:4210 Bug: angleproject:4225 Change-Id: I8a0b7d24c9545bbfdfaa4b9357a9bfe6793e0140 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965640 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
2eeb980e | 2019-12-10 12:58:13 | Added enums to InternalFormat and PixelType groups in gl.xml Bug: angleproject:4093 Change-Id: Ib69f0553f79d0e5dfbcc9165ad71a42be3e6d55d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965643 Commit-Queue: Brandon Schade <b.schade@samsung.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
06cbb283 | 2019-12-11 14:46:59 | Validate uniform location size, fix unlink cleanup Also cleanup shader storage blocks. Test: angle_deqp_khr_gles31_tests --use-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_explicit_uniform_location_uniform* Bug: angleproject:4132 Bug: angleproject:4217 Change-Id: Ie0375ab9226f3f49cb0c0d208ac08f99d98dad8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963139 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> | |
|
8f619682 | 2019-12-16 07:01:41 | Roll third_party/SwiftShader ebb0bec91552..fbbfeb700295 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/ebb0bec91552..fbbfeb700295 git log ebb0bec91552..fbbfeb700295 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 chrisforbes@google.com Add missing source file to android build 2019-12-13 swiftshader.regress@gmail.com Regres: Update test lists @ ebb0bec9 Created with: gclient setdep -r third_party/SwiftShader@fbbfeb700295 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I93e47bb372477b074173951ded4f0af35269e206 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969219 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
d5914d97 | 2019-12-16 07:01:02 | Roll third_party/vulkan-tools/src c1a7421f0f93..0c2618b2c31e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c1a7421f0f93..0c2618b2c31e git log c1a7421f0f93..0c2618b2c31e --date=short --first-parent --format='%ad %ae %s' 2019-12-13 jeremyk@lunarg.com build: Update glslang version in known_good.json Created with: gclient setdep -r third_party/vulkan-tools/src@0c2618b2c31e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Iaddfe799d5fb0e3e444eea4cc3cf4a3852be7f1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969218 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
14820b1e | 2019-12-16 07:01:58 | Roll third_party/vulkan-validation-layers/src d2c3daeb56e9..2b19f3916726 (10 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d2c3daeb56e9..2b19f3916726 git log d2c3daeb56e9..2b19f3916726 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 mark@lunarg.com tests: Add tests for DescTemplates fixes and new VUIDs 2019-12-13 mark@lunarg.com objlifetimes: Fix CreateDescUpdateTemplates object val 2019-12-13 mark@lunarg.com build: Update glslang & VulkanTools known-good IDs 2019-12-13 geecandrey@gmail.com corechecks: Invalid error message in vkCmdPipelineBarrier 2019-12-13 mark@lunarg.com tests: Add positive test for tooling ext query 2019-12-13 mark@lunarg.com chassis: Support tooling queries in khronos layer 2019-12-13 mark@lunarg.com chassis: Add physicaldevice support for tools info API 2019-12-13 mark@lunarg.com stateless: Update for new struct_type_array case 2019-12-13 mark@lunarg.com chassis: Implement GetPhysicalDeviceProcAddr layer func 2019-12-13 jeremyk@lunarg.com layers: Fix issue 1416 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@2b19f3916726 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Idadb73efcc3bdf73f0dfd41d4f1793eb93e3b0b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969220 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
d1860ea1 | 2019-11-19 23:04:00 | Metal: support OES_depth_texture Also added Depth32 & Depth16 texture data upload tests. Bug: angleproject:2634 Change-Id: I103f1cda1dc915f0dc8b04f7aaa2d8c0f9220cda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919281 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
75875885 | 2019-11-20 01:04:00 | Metal: Fix glDisable(GL_DEPTH_TEST) didn't disable depth write Per standard glDisable(GL_DEPTH_TEST) will disable depth write also regardless of the value of glDepthMask() Tests done: - dEQP.GLES2/functional_fragment_ops_depth_stencil_stencil_*_no_depth Bug: angleproject:2634 Change-Id: I3b101b8c0b3060f5ddbb18d3f97d7d6889cdec01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966184 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
5245de82 | 2019-11-20 01:04:00 | Metal: Update spirv-cross from upstream to fix mat2 issues Previously spirv-cross had problems translate mat2 to equivalent Metal type. See the reported issue: https://github.com/KhronosGroup/SPIRV-Cross/issues/1200 It has been fixed on upstream repo. DEQP tests using mat2 should pass now. Bug: angleproject:2634 Change-Id: I68e871965c7004ae34dc0fa92c926905cb0c14cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966183 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
 |
92ba377f | 2019-12-10 23:48:35 | Vulkan: remove unnecessary transition of external images Since semaphore has been supported, the code for changing external texture layout and queue family is not necessary anymore. So remove them. Bug: angleproject:3289 Change-Id: I5470fa4bf7db7ee4c68f157674cf907a8e455d75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1964655 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> | |
 |
7718c952 | 2019-12-13 16:39:15 | [Fuchsia] Update FIDL library target names in ANGLE The SDK has renamed some targets, so update to the new names. Bug: chromium:1033597 Change-Id: Id346f5fb0094e4b71f8ec3b8c302eaa362529c06 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1967958 Commit-Queue: Michael Spang <spang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
8b74bdc2 | 2019-12-10 23:15:57 | Vulkan: Refactor glslang wrapper's varying location assignment Instead of multiple ifs that test for various combination of shader stages and calling AssignVaryingLocations for the appropriate pairs, that function loops over all stages and assigns a location to the varying in any stage it is active. This change will help keep this code simpler with the introduction of tessellation shaders. Bug: angleproject:3571 Change-Id: Iaf3ee67990bd219080314237b314bd2770a43085 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961096 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
19868b7e | 2019-12-13 14:29:57 | Restructure textureGatherOffset* builtin declarations This is in preparation of textureGatherOffsets support. Bug: angleproject:3569 Change-Id: I4ce5a1e102790181c8f843735961b9c249a69221 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965720 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
|
b8e056dd | 2019-12-11 15:02:43 | Vulkan: Have the translator output in/out qualifiers Currently, when assigning varying locations, we assign in/out qualifiers based on whether the varying name is present between different shader stages. This is broken for separate shader objects as there is possibly no pair of shaders to be able to tell which is input and which is output (by trying to find the same varying in a stage before or after the shader). Bug: angleproject:3571 Change-Id: Id928a3eaa16e917c81bae0b3414c41842eb2b664 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961993 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> | |
|
e181f2f7 | 2019-12-10 22:57:42 | Validate that image array indices are constant Also adds compiler tests for dynamic indexing of SSBOs and images. Bug: angleproject:3569 Change-Id: I84b90813840ffad5a9a3cd8e7f12bd637a57b327 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961095 Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> | |
 |
bf47a17e | 2019-12-13 01:40:33 | Fix GGP build Bug: angleproject:4221 Change-Id: I625b78795dbc826d176660e47af9b51d3f8d417b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966410 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
e1822727 | 2019-12-13 07:01:58 | Roll third_party/vulkan-validation-layers/src 6a35bc9967d9..d2c3daeb56e9 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6a35bc9967d9..d2c3daeb56e9 git log 6a35bc9967d9..d2c3daeb56e9 --date=short --first-parent --format='%ad %ae %s' 2019-12-12 jzulauf@lunarg.com layers: Improve const shared pointer handling 2019-12-12 mark@lunarg.com corechecks: Correct swapchain validation error text 2019-12-12 tony@lunarg.com gpu: Add validation for VK_KHR_buffer_device_address Created with: gclient setdep -r third_party/vulkan-validation-layers/src@d2c3daeb56e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Iafb69556fd7a48e7df8e1f08d8f38fd23a659f9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966026 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
f139f976 | 2019-12-13 07:01:41 | Roll third_party/SwiftShader 07958d452f93..ebb0bec91552 (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/07958d452f93..ebb0bec91552 git log 07958d452f93..ebb0bec91552 --date=short --first-parent --format='%ad %ae %s' 2019-12-12 sergeyu@chromium.org Use allocateExecutable() in LLVMReactor 2019-12-12 sugoi@google.com Fix BCn related SwANGLE test failure 2019-12-12 capn@google.com Prevent clang-format from splitting shift operator 2019-12-12 sugoi@google.com Support for BC1, BC2, BC3, BC4 and BC5 Created with: gclient setdep -r third_party/SwiftShader@ebb0bec91552 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: If0eb478a35cabd6c09007f70a75dad0757749605 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966024 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
06db147e | 2019-12-13 07:01:40 | Roll third_party/spirv-tools/src 5c019b5923c1..96354f5047bf (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5c019b5923c1..96354f5047bf Created with: gclient setdep -r third_party/spirv-tools/src@96354f5047bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: Ia02eda3a904131e1efa5f401e6259e09bf9848a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966023 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
ef11f849 | 2019-12-13 07:01:56 | Roll third_party/glslang/src 6c479796f6e4..ebf634bcaa3e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6c479796f6e4..ebf634bcaa3e Created with: gclient setdep -r third_party/glslang/src@ebf634bcaa3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I5d36e291b54c1d57688e413a9b8e6a794b15277f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966025 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> | |
|
1d77542f | 2019-12-03 15:54:41 | Add flag to label captures Add an optional parameter (ANGLE_CAPTURE_LABEL) to ANGLE frame capture that tags files and functions uniquely, allowing multiple frame captures to be replayed by a test harness. Example: ANGLE_CAPTURE_LABEL=foo Results in filenames like this: foo_capture_context1.cpp foo_capture_context1.h foo_capture_context1_files.txt foo_capture_context1_frame000.angledata foo_capture_context1_frame000.cpp foo_capture_context1_frame001.angledata foo_capture_context1_frame001.cpp ... Functions wrapped in namespaces like this: namespace foo { void ReplayContext1Frame0(); void ReplayContext1Frame1(); } For use like this: foo::SetupContext1Replay(); for (...) { foo::ReplayContext1Frame(i); } Bug: angleproject:3630 Change-Id: Ibe27dc4d40a36606ee40678a9e4d43b5a4baf976 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949603 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> | |
|
554b453c | 2019-12-12 13:09:30 | gn: Add 'test_only' label to util targets. Clarifies that angle_util is only used in tests and samples. Bug: angleproject:3162 Change-Id: I9a578cf7a9a09b2c3fd4683155824ed2e72f68cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1964934 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
270e2e88 | 2019-12-12 13:08:08 | util: Always export default visibility. This should fix the CFI build compatibility with class exports. Bug: chromium:1030192 Bug: angleproject:3162 Change-Id: I228d6d387f8b29c0a500038de962f9f216454d7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1964933 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> | |
|
e0f8b5d0 | 2019-12-12 14:58:12 | Roll chromium_revision d209d45ba4..e1633af636 (719599:724302) Change log: https://chromium.googlesource.com/chromium/src/+log/d209d45ba4..e1633af636 Full diff: https://chromium.googlesource.com/chromium/src/+/d209d45ba4..e1633af636 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ebec9c5ad4..dfe5662014 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/72e16daaa5..c1b508625d * third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/60616473f7..f8eeeb06c0 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e77e1c06c8..f262c1b3c4 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/05979d8cad..a9190d6699 DEPS diff: https://chromium.googlesource.com/chromium/src/+/d209d45ba4..e1633af636/DEPS Clang version changed e84b7a5fe230e42b8e6fe451369874a773bf1867:c2443155a0fb245c8f17f2c1c72b6ea391e86e81 Details: https://chromium.googlesource.com/chromium/src/+/d209d45ba4..e1633af636/tools/clang/scripts/update.py TBR=jmadill@chromium.org, BUG=None Change-Id: I3e2d6b59263870a6713b8e3d2161c2411b932cf1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965436 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> |