kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi f72428bb 2025-01-10T22:24:07 Vulkan: Fix MSAA swapchain resolve out of render pass .. vs the optimization that transitions the swapchain image to PRESENT_SRC as part of the render pass. When the swapchain image is the resolve attachment, its layout is decided when the render pass is closed (or through manual calls to finalizeImageLayout()). If the render area forbids the swapchain image from becoming the resolve attachment, it must be resolved after the render pass. Prior to this change, the swapchain image was still marked for transition to PRESENT_SRC by the render pass. This is inefficient, as the following out-of-render-pass resolve would have to transition the image back out of PRESENT_SRC. Nevertheless, this also had a bug exposed by an ASSERT in the dynamic rendering path: * Before the out-of-render-pass resolve, the image layouts are forcefully finalized. * The code in finalizeImageLayout() checks which image is being finalized; if the image is not any of the ones in the render pass, it was silently ignored. * The image marked for transition to PRESENT_SRC (mImageOptimizeForPresent) is not separately checked, as it is expected to be an attachment as well. The code that optimized the final render pass always marked the swapchain image for optimization, even if it was not going to become the resolve attachment. This change makes sure this optimization is done only if the image is definitely an attachment of the render pass. Bug: angleproject:389048224 Change-Id: I9f451d2698944111ac96bd97fefd6efa23859b7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6168388 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Mohan Maiya b3af2e86 2024-12-31T08:51:37 Enhance MemoryBuffer API Add support for - 1. reserve - users can reserve sufficient capacity upfront to minimize subsequent reallocations due to resize 2. append - to append data from a source so user doesn't need to track offsets explicitly Bug: angleproject:386749841 Tests: MemoryBufferTest* Change-Id: Ibf2a3228d5a00ed34a7e0c5e3eb185e42677d676 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6135238 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov b5b2612e 2025-01-13T12:36:39 Tune branching in getProgramResolveLink() Hinting the likely/unlikely branches in related calls. Notably, mShaderProgramManager->getProgram() has a flat resource array and a fallback to a absl::flat_hash_map. As observed in driver_overhead_2 trace based PGO builds, the fallback gets un-inlined by PGO (presumably due to being hit rarely) and becomes a function call. Regular builds without the tuning in this CL inline flat_hash_map implementation, increasing the code size / worsening locality for a fallback case. This change makes the Context::useProgram() aarch64 assembly in regular builds very close to the driver_overhead_2 based PGO, and the code size goes down from 576 to 256 bytes. The total reduction of the .so size is 36KB (0.6%), likely due to all the cases where the inlining is avoided by hinting. There appears to be a ~1% perf improvement in driver_overhead_2 trace wall_time in my tests on a couple of Android devices. Hard to tell if this is due to the improved code locality or some other aspect of the change in assembly. Bug: b/383305597 Change-Id: I85c02cc74a56e7074086965e8d31018bd9ee0040 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6169263 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Neil Zhang cfe87e34 2024-12-16T16:29:39 Add multisample support for glCopyImageSubDataEXT As GL_TEXTURE_2D_MULTISAMPLE/GL_TEXTURE_2D_MULTISAMPLE_ARRAY been introduced by GLES3.1, glCopyImageSubDataEXT should support those types. Bug: angleproject:381727390 Change-Id: Ib3571ea38dc8d8ceb1bc9ad0c8a6e04d28b0ec33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6146194 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxiang Qian 4c60a308 2024-12-30T15:35:07 Change default return value for eglDupNativeFenceFDANDROID According to EGL spec, eglDupNativeFenceFDANDROID should return EGL_NO_NATIVE_FENCE_FD_ANDROID when there is error. However, ANGLE just returns 0 as default value. Now overload the default return value to EGL_NO_NATIVE_FENCE_FD_ANDROID. Also, a end2end test is added. Bug: angleproject:385190296 Change-Id: I214efdeb3ad583989fab5e2244c82cb7295f8b67 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6146195 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Aurora Zhang 28270609 2025-01-09T18:08:40 Vulkan: Fix clear texture for unrenderable internalformat Checking whether the texture is renderable or not depends on the output texture's format. If the output format is unrenderable, while format and type indicate the input format as renderable, the clear texture should still go into the unrenderable path. Bug: angleproject:385190304 Change-Id: I2963caad4996547a0aa27fcc37033ca95e2fa21e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6134267 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 4b0f6f06 2025-01-13T10:01:37 Roll vulkan-deps from 58a9b6e76b58 to 8d2a13cc4374 (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/58a9b6e76b58..8d2a13cc4374 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f754c852a87988eb097a39480c65f704ceb46274..e43514866f7e0f8265c677039d2fe773c892d44b https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/73995ddc2b38b5653c8eb3b4a0d1cd6cc2cea4c0..4446967600048557909231722d2c92212b6ca258 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/8b39a8b54d55c8737196cdce705f32f94d3b2463..9064fe8637daf9f694c8a2e035a34da94022f2be https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b18ee987c900b7d84908b32add45610032e25d28..ea05bf71f2948d64f7d36651ffcad59216401095 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Iac67f2a480447cb9f19e80ef79e1cde59bfc047c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6172309 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 961939b3 2025-01-13T08:41:35 Roll Chromium from 6678a1628926 to 6920d2f1f699 (726 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6678a1628926..6920d2f1f699 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b2b443d269..bbdae0b409 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c7596937d4..5b3283646f * third_party/android_build_tools/error_prone/cipd: a-wq097LhH9krgIuF0T5waFnHU4KilRItqhJPGFZxtwC..7c91BXn6VPvSmr-dFRYaNVkfHjRN1jdMIN4EcrPem9cC * third_party/android_build_tools/manifest_merger/cipd: T3B_dWqgDISstbC0L7CrQOOf9xe-27KUYK8UCTq6trgC..osgd04hyZB3eu5L7oiL6irk9AqRBX9lOxNLsaCmUCowC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/423f1e1914..a912cd245b * third_party/fuchsia-sdk/sdk: version:26.20250103.4.1..version:26.20250110.4.1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/44258fc58f..597b2e8c42 * third_party/r8/cipd: pTuwP6kf9nJ3wT_GS6XQy5z5xjF3Cb5JDfVapSCBRvcC..xbInvmbYpySCc5-qVBjQg8Ns8FvdvEyvQFadpxKY1-sC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/145029da02..668908cb48 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fc64227b60..145ae97377 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c3b61a49db..efca7ea4f9 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/474e007a4e..05dbbfdcec Clang version changed llvmorg-20-init-16062-g091448e3:llvmorg-20-init-17108-g29ed6000 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/fc64227b60f7887c09283f873eb18b087eb6f0c2..145ae97377dc97a0c5a9ce7ab5709f3492757475/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I57dc0354c66dadc659693137de02dc90ca43a24c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6171595 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 0a207b65 2025-01-10T12:01:01 Vulkan: Assert size of GraphicsDriverUniformsExtended is within limits ANGLE updates driver uniforms using push constants, ensure size of ANGLE's driver uniform struct is within Vulkan spec's guaranteed limit of 128 bytes. Bug: angleproject:386749841 Change-Id: Iaa5ca8a46865a804b4c854ba27448bf4b6546646 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6164689 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Alex Dean 5f6be593 2024-12-30T09:35:16 CL: Add check for 2d image creation from buffer CL_INVALID_OPERATION must be returned when creating a 2d image from the buffer if cl_khr_image2d_from_buffer is not supported. Tests-Passing: OCLCTS.test_api consistency_2d_image_from_buffer Bug: angleproject:384765581 Change-Id: I431188b9c1d1881cf755058a8b8ca5741d17652d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6102106 Commit-Queue: Gowtham Tammana <g.tammana@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Matthew Denton c289b30f 2025-01-09T12:49:27 WGSL: Add test for failure case of uniform struct rewrites. Using a uniform struct outside of the uniform address space fails if we've rewritten any of the member types and want to assign to that member. E.g. this line of GLSL, assigning to a member of a struct used in the uniform address space: privUnis.x = float[3](1.0, 1.0, 1.0); Produces this WGSL warning: ERR: DisplayWgpu.cpp:295 (operator()): Error: 2 - message: Error while parsing WGSL: :50:63 error: expected ')' (ANGLE_Convert_ANGLE_wrapped_float_ElementsTo_float_Elements((_uprivUnis)._ux)) = (array<f32, 3>(1.0f, 1.0f, 1.0f)); This adds a test and suppresses it on WGSL. Future design options: https://docs.google.com/document/d/17Qku1QEbLDhvJS-JJ9lPQAbnuZtLxWhG-ha5eCUhtEY/edit?tab=t.0#bookmark=id.r89s1r69tl77 Bug: angleproject:376553328 Change-Id: I57304e9d2a889d00ac4fa02f265198ce3d78e7e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6165290 Reviewed-by: Matt Denton <mpdenton@google.com> Commit-Queue: Matt Denton <mpdenton@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org>
Matthew Denton b1a0d60f 2025-01-08T15:10:41 WGSL: Fix accidentally overloaded functions Small-stride arrays in uniforms with the same element type, but different array sizes, would cause the WGSL generator to produce conversion functions with the same name but different array sizes. This CL puts the array size in the name of the function to avoid overloading, which is unsupported in WGSL. Bug: angleproject:376553328 Change-Id: I446e91ccb9da2872c88f1a4e05283aacc9d6f8b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6160334 Commit-Queue: Matt Denton <mpdenton@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Matt Denton <mpdenton@google.com> Reviewed-by: Liza Burakova <liza@chromium.org>
Yuxiang Qian 2de256cb 2024-12-30T17:26:38 Change some error type in eglCreateImageKHR Following the spec, for eglCreateImageKHR, if target is EGL_LINUX_DMA_BUF_EXT and attribute value is not expected, then EGL_BAD_ATTRIBUTE should be returned. However, ANGLE would return EGL_BAD_PARAMETER. Now change these error handlings to return EGL_BAD_ATTRIBUTE. Also, a end2end test is added. Bug: angleproject:387892107 Change-Id: I73ecfc3da273c0fb5ac362e451fd186209f1a52b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6146196 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll c01fb331 2025-01-10T15:14:26 Manual roll vulkan-deps from 1fa2eb257bf0 to 58a9b6e76b58 (9 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/1fa2eb257bf0..58a9b6e76b58 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/196627ca4ebb72cb1367755b9d97a9ed716e4728..b18ee987c900b7d84908b32add45610032e25d28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com,ynovikov@google.com Change-Id: I5d53877be3ecc058ee8b3a3571962e1a3e2ae581 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6167404 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop c10f5e3f 2025-01-08T10:04:39 Debug: Allow forcing GL_VERSION string Similar to forcing renderer and vendor, useful for debug. Bug: b/388459021 Change-Id: If00128369cf26069708e8db06c5e17b7ad0bdb58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6157784 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Gowtham Tammana 3772d47e 2024-12-11T00:25:37 CL/Vulkan: Allocate descriptor sets under lock The descriptor pool must be externally synchronized as per the vulkan spec, as such acquire a lock when allocating descriptor sets from it. Bug: angleproject:383999367 Change-Id: I98448770681ad39dae0dc7e413e28ec7dfa89f87 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6099129 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 4079d29f 2025-01-10T09:46:12 Roll Chromium from f564482196af to 6678a1628926 (620 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f564482196af..6678a1628926 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fdd1d9a6db..b2b443d269 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/dc74188326..59f9fbaa49 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a3636addb9..c7596937d4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8491e07230..c4c972c5f0 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/8e1e2869d6..44258fc58f * third_party/r8/cipd: TQJgBofMEzGILWhAM0LXeob_ZpAiDc8w8SBzU0d8o8YC..pTuwP6kf9nJ3wT_GS6XQy5z5xjF3Cb5JDfVapSCBRvcC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/08704ba669..145029da02 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a1ea7f2d05..fc64227b60 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/27f9a300ee..c3b61a49db * tools/skia_goldctl/linux: l5aKsGPbt8dooumWZmU3fwjo40Xiiw3v-G-1HnEa-isC..y4kowbHdyv_7-p0-MB1QlTWy5YWYDclmStirH1GbuCkC * tools/skia_goldctl/mac_amd64: iAGPE6NpjDOoBn4Qan139Qgz6nxEvTMnestoh1t6iX8C..tGIX6p4MvgbXFQWrWBCJ-xjSTLxHwW3ShJXRnLQCUdYC * tools/skia_goldctl/mac_arm64: ClryFyU_y524TiVfuuSclcUclZakblMk6Ntdp1kT_T4C..7m6yrdw10Gle5GlaI-jY2YVIqXxO_8MgLIVhKt9tPzYC * tools/skia_goldctl/win: lUGH7_HceKY7ywhy0vKwG_HMa8T01IwbU3qADAtu7bwC..skMt2xgfOuITCmlSoLbBGHtrtM3geW4ejGVKFtFxTvsC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I33fdf435fe23cc173239588746288c2a54445d37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6167147 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 06380dbc 2025-01-10T09:04:52 Add const missed in crrev.com/c/6153395 Mutability makes Chroimum's "android-binary-size" unhappy Bug: b/383305597 Change-Id: I523bc92056962cef9a6f1e76d732ad1953bd46c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6166761 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Steven Noonan 3226a3df 2024-12-13T14:06:55 Reland: vulkan: add EGL_ANGLE_platform_angle_vulkan_device_uuid Implement the ability to select a specific device and driver combination through a few new selection criteria: VkPhysicalDeviceIDProperties::deviceUUID VkPhysicalDeviceIDProperties::driverUUID VkPhysicalDeviceDriverProperties::driverID Earlier version had problems due to a test build issue. Per syoussefi@, going to rework the test into a separate CL so that we get the core change merged. Bug: angleproject:351866412 Change-Id: I0a3f4f1a2154a06bf6286a037c9ad4834ef4dda2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6165286 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
angle-autoroll 7f46db8a 2025-01-10T02:01:47 Roll SwiftShader from 5221bf031f44 to f6ad529e86e4 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5221bf031f44..f6ad529e86e4 2025-01-10 tikuta@google.com add missing includes for the build with use_libcxx_modules If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5ee57fa773e62dc6e493098b4d035ca4bacb2975 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6165613 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya db833869 2025-01-08T06:14:22 Vulkan: Return cached width and height for eglQuerySurface eglQuerySurface will return extents as of the most recent eglSwapBuffers call Bug: angleproject:153329980 Test: EGLPreRotationSurfaceTest.CheckSurfaceCapabilities* Change-Id: Ifc9e84ed92bdc645afd12814a3a5539cc8b55da3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6158264 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Kimmo Kinnunen 19ef77a2 2025-01-09T15:37:34 Validate glEGLImageTargetRenderbufferStorageOES renderbuffer glEGLImageTargetRenderbufferStorageOES changes the renderbuffer. Avoid crashing if there is no renderbuffer bound. Bug: angleproject:388616184 Change-Id: I05eacb7a5907d2ca9cde8e91aa7814daa3008c71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6163503 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana f64fef25 2024-06-07T12:18:18 CL/Vulkan: Protect clspv compiler calls The clspv compiler uses llvm backend to perform source code transliteration, and the llvm parser used is non-rentrant. So protect the clspv compiler call with a mutex. Bug: angleproject:361717757 Change-Id: Ib10d6d165307594bed607d5e794b0ef92c3c894b Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6092035 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 69ab60cb 2025-01-09T11:23:03 Revert "Roll third_party/glmark2/src/ ca8de51fe..2054465f6 (77 commits)" This reverts commit 68b594e859f036b01974f78f8ddca8c419bc8ce3. Reason for revert: breaks Perf bots: https://ci.chromium.org/ui/p/angle/builders/ci/linux-nvidia-gtx1660-perf/4958/overview https://ci.chromium.org/ui/p/angle/builders/ci/win10-intel-uhd630-perf/4885/overview https://ci.chromium.org/ui/p/angle/builders/ci/win10-nvidia-gtx1660-perf/4881/overview https://ci.chromium.org/ui/p/angle/builders/ci/linux-intel-uhd630-perf/4903/overview Original change's description: > Roll third_party/glmark2/src/ ca8de51fe..2054465f6 (77 commits) > > https://chromium.googlesource.com/external/github.com/glmark2/glmark2/+log/ca8de51fedb7..2054465f6f7c > > $ git log ca8de51fe..2054465f6 --date=short --no-merges --format='%ad %ae %s' > 2024-04-25 alexandros.frantzis Use std::filesystem throughout the codebase > 2024-04-25 alexandros.frantzis android: Build native code with C++17 > 2024-04-25 alexandros.frantzis Doc: Recommend meson for building win32 flavors > 2024-04-25 alexandros.frantzis github: Build win32 flavors with msvc in CI > 2024-04-25 alexandros.frantzis github: Build win32 flavors with mingw in CI > 2024-04-25 alexandros.frantzis include/getopt: Always use non-const char array to avoid MSVC errors > 2024-04-25 alexandros.frantzis libmatrix: Add utility function to get idle time > 2024-04-25 alexandros.frantzis libmatrix: Add utility function to get process times > 2024-04-24 alexandros.frantzis libmatrix: Add utility function to get the number of processors > 2024-04-25 alexandros.frantzis libmatrix: Use C++ std::chrono instead of clock_gettime > 2024-04-25 alexandros.frantzis libmatrix: Use C++17 std::filesystem instead of dirent > 2024-04-25 alexandros.frantzis Build: Add support for win32 flavors in meson > 2024-04-24 alexandros.frantzis libmatrix: Provide a copy of the va_list to __android_log_vprint > 2024-04-13 kode54 NativeStateX11: Fix WM_DELETE_WINDOW handling > 2024-02-15 alexandros.frantzis NativeStateWayland: Explicitly destroy all Wayland resources at shutdown > 2024-02-15 alexandros.frantzis Explicitly release GL related resources at shutdown > 2023-06-03 prlw1 src/meson.build: add x11 dependency to glx > 2024-02-07 timchen021 Fix memory leaks using smart pointers > 2024-01-12 daniel.levin Add missing includes in scene-collection.h > 2023-11-01 alexandros.frantzis GLVisualConfig: By default don't care about the stencil config component > 2023-11-01 alexandros.frantzis Options,GLStateEGL,GLStateGLX: Add option to require a good visual config > 2023-07-26 abs GLStateEGL,GLStateGLX: Change failure to get a "good" visual config to warning > 2023-11-01 alexandros.frantzis libmatrix: Add Log::warning() function > 2023-05-20 prlw1 meson.build: fix build and avoid sigsegv > 2023-05-03 ofourdan NativeStateX11: Add winsys option for position > 2023-01-19 alexandros.frantzis Build,Doc: Update files for 2023.01 release > 2023-01-19 alexandros.frantzis NativeStateMir: Remove Mir/mirclient support > 2023-01-03 alexandros.frantzis ResultsFile: Support storing results in an XML file > 2023-01-03 alexandros.frantzis ResultsFile: Support storing results in a CSV file > 2023-01-03 alexandros.frantzis Options,ResultsFile: Add option to set the results file > 2023-01-03 alexandros.frantzis Introduce infrastructure to support saving results to a file > 2023-01-03 alexandros.frantzis CanvasGeneric: Store individual info elements in separate strings > 2023-01-03 alexandros.frantzis MainLoop: Store indivitual result values in separate strings > 2023-01-03 alexandros.frantzis Scene: Remove trailing ':' from scene info string > 2023-01-04 alexandros.frantzis SceneTerrain: Silence unused variable warning > 2022-12-21 pierre-yves.mordret NativeStateGBM: Lock and release the front buffer on flip > 2022-12-21 alexandros.frantzis MainLoop,Scene: Support reporting shader compilation time > 2022-12-20 alexandros.frantzis MainLoop,Scene: Add busy percentage in CPU time results > 2022-12-20 alexandros.frantzis MainLoop,Scene: Support reporting CPU time results > 2022-12-20 alexandros.frantzis Options: Introduce option to specify benchmark results to show > 2022-12-20 alexandros.frantzis Scene: Update elapsed times when a benchmark finishes > 2022-12-19 alexandros.frantzis Scene: Introduce struct to keep track of elapsed time > 2022-12-15 alexandros.frantzis Scene: Introduce infrastructure for more complex scene stats > 2022-12-15 alexandros.frantzis Scene: Move common preparation logic to Scene::prepare > 2022-12-13 alexandros.frantzis Scene: Introduce non-virtual methods to prepare and finish a scene for benchmark > 2022-12-08 alexandros.frantzis GLVisualConfig: Support specifying the config id in --visual-config > 2022-12-08 alexandros.frantzis libmatrix: Support prefix dependent input conversions from string > 2022-12-08 alexandros.frantzis GLStateEGL,GLStateGLX: Fail if no suitable config is found > 2022-12-08 alexandros.frantzis GLStateEGL,GLStateGLX: Don't limit the configs passed to our selection mechanism > 2022-12-08 alexandros.frantzis GLVisualConfig: Penalize configs with components smaller than requested > 2022-11-16 alexandros.frantzis github: Build x11-gl-egl flavor in CI > 2022-11-14 rilian-la-te build: Add x11-gl-egl flavor > 2022-11-10 alexandros.frantzis GLStateGLX: Support multisampled configs > 2022-11-10 l.stach GLStateEGL: Support multisampled configs > 2022-11-10 l.stach GLVisualConfig: Add multisampling support > 2022-09-02 120989324 Add missing newline at end of log messages > 2022-11-10 alexandros.frantzis NativeStateDRM,NativeStateGBM: Support configuring the DRM device > 2022-11-10 alexandros.frantzis Options: Support passing window system specific options > 2022-04-23 nunes.erico NativeStateGBM: Add GBM offscreen backend > 2022-07-07 wuqianhai SceneJellyfish: Fix memory leak > 2022-07-07 wuqianhai SceneRefract: Fix texture leak > 2022-07-07 wuqianhai SceneIdeas: Fix texture leak > 2022-06-14 Martin.Jansa waflib: fix compatibility with python-3.11 > 2022-05-12 jeffy.chen NativeStateDRM: Honor visual configuration > 2022-05-13 alexandros.frantzis GLStateEGL,GLStateGLX: Use SwapInterval 1 for FIFO swap mode > 2022-04-15 alexandros.frantzis NativeStateDrm: Implement swap interval 0 > 2022-02-14 alexandros.frantzis github: Run apt-get update to get latest packages > 2022-02-14 alexandros.frantzis CanvasGeneric,CanvasAndroid: Display surface config info > 2022-02-14 alexandros.frantzis Options: Support --version command line argument > 2022-02-14 alexandros.frantzis libmatrix: Add missing <utility> include > 2022-02-10 hillma libmatrix: avoid -Wimplicit-fallthrough > 2021-12-23 alexandros.frantzis Build,Doc: Update files for 2021.12 release > 2021-12-23 alexandros.frantzis NativeStateDrm: Fix crash when we can't become DRM master > 2021-09-30 jf android: Fix benchmark parameter edition > 2021-08-30 alexandros.frantzis Use highp precision modifier only on GLES > 2021-08-30 alexandros.frantzis GLStateEGL: Support EGL versions < 1.4 > 2021-04-11 maahiuzeon Fix model loading on big endian. > > Created with: > roll-dep third_party/glmark2/src > > Bug: chromium:40263312 > No-Presubmit: true > Change-Id: Ifee506badac67ff5af57605994daff01278c6d56 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6162277 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:40263312 Change-Id: Ie43fbff5d784c2a50aae6208bc7fa692593fcdda No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6164165 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov 3b092269 2025-01-09T08:54:00 Revert "vulkan: add EGL_ANGLE_platform_angle_vulkan_device_uuid" This reverts commit 96abb2c3d9e296ae12e50e0026bf5d3a7b925e7e. Reason for revert: breaks rolling into Chromium https://chromium-review.googlesource.com/c/chromium/src/+/6158098 Original change's description: > vulkan: add EGL_ANGLE_platform_angle_vulkan_device_uuid > > Implement the ability to select a specific device and driver combination > through a few new selection criteria: > > VkPhysicalDeviceIDProperties::deviceUUID > VkPhysicalDeviceIDProperties::driverUUID > VkPhysicalDeviceDriverProperties::driverID > > Bug: angleproject:351866412 > Change-Id: Ia6716aaed658d2563612d8b5d81287df97b57462 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5686557 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Auto-Submit: Steven Noonan <steven@uplinklabs.net> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:351866412 Change-Id: Ic7cf9dcf6a950556cc44f5920498db429c866340 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6164164 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 1b068f66 2025-01-09T08:56:33 Roll Chromium from b916218d8fec to f564482196af (551 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b916218d8fec..f564482196af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f3e95cc9a0..fdd1d9a6db * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d2a70ad29f..a3636addb9 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/72093794ac..9c3ff1b50b * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/ee2354ca1c..3539c64cce * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f3776f1de7..4c97c49c40 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/2019a9e40b..8e1e2869d6 * third_party/r8/cipd: zzsW6sllgOhMp73iLSaG0dTW_A8IvWreBT1vBH6JKAIC..TQJgBofMEzGILWhAM0LXeob_ZpAiDc8w8SBzU0d8o8YC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/ae2c3a11a8..b9cb8f8d3e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6724fcc901..a1ea7f2d05 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7a73c88363..27f9a300ee * tools/skia_goldctl/mac_arm64: YxUcONVh4dduKRWDzdoArT7R9nVG3Cl72jR4lGFzkWoC..ClryFyU_y524TiVfuuSclcUclZakblMk6Ntdp1kT_T4C * tools/skia_goldctl/win: t82CKYUKKcDYN0FPMEZFScWov212eEtPJR_u9rhm_pIC..lUGH7_HceKY7ywhy0vKwG_HMa8T01IwbU3qADAtu7bwC No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I969b6f41d4b902796817c759b35f536900c45e9d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6162096 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Takuto Ikuta 68b594e8 2025-01-09T18:08:08 Roll third_party/glmark2/src/ ca8de51fe..2054465f6 (77 commits) https://chromium.googlesource.com/external/github.com/glmark2/glmark2/+log/ca8de51fedb7..2054465f6f7c $ git log ca8de51fe..2054465f6 --date=short --no-merges --format='%ad %ae %s' 2024-04-25 alexandros.frantzis Use std::filesystem throughout the codebase 2024-04-25 alexandros.frantzis android: Build native code with C++17 2024-04-25 alexandros.frantzis Doc: Recommend meson for building win32 flavors 2024-04-25 alexandros.frantzis github: Build win32 flavors with msvc in CI 2024-04-25 alexandros.frantzis github: Build win32 flavors with mingw in CI 2024-04-25 alexandros.frantzis include/getopt: Always use non-const char array to avoid MSVC errors 2024-04-25 alexandros.frantzis libmatrix: Add utility function to get idle time 2024-04-25 alexandros.frantzis libmatrix: Add utility function to get process times 2024-04-24 alexandros.frantzis libmatrix: Add utility function to get the number of processors 2024-04-25 alexandros.frantzis libmatrix: Use C++ std::chrono instead of clock_gettime 2024-04-25 alexandros.frantzis libmatrix: Use C++17 std::filesystem instead of dirent 2024-04-25 alexandros.frantzis Build: Add support for win32 flavors in meson 2024-04-24 alexandros.frantzis libmatrix: Provide a copy of the va_list to __android_log_vprint 2024-04-13 kode54 NativeStateX11: Fix WM_DELETE_WINDOW handling 2024-02-15 alexandros.frantzis NativeStateWayland: Explicitly destroy all Wayland resources at shutdown 2024-02-15 alexandros.frantzis Explicitly release GL related resources at shutdown 2023-06-03 prlw1 src/meson.build: add x11 dependency to glx 2024-02-07 timchen021 Fix memory leaks using smart pointers 2024-01-12 daniel.levin Add missing includes in scene-collection.h 2023-11-01 alexandros.frantzis GLVisualConfig: By default don't care about the stencil config component 2023-11-01 alexandros.frantzis Options,GLStateEGL,GLStateGLX: Add option to require a good visual config 2023-07-26 abs GLStateEGL,GLStateGLX: Change failure to get a "good" visual config to warning 2023-11-01 alexandros.frantzis libmatrix: Add Log::warning() function 2023-05-20 prlw1 meson.build: fix build and avoid sigsegv 2023-05-03 ofourdan NativeStateX11: Add winsys option for position 2023-01-19 alexandros.frantzis Build,Doc: Update files for 2023.01 release 2023-01-19 alexandros.frantzis NativeStateMir: Remove Mir/mirclient support 2023-01-03 alexandros.frantzis ResultsFile: Support storing results in an XML file 2023-01-03 alexandros.frantzis ResultsFile: Support storing results in a CSV file 2023-01-03 alexandros.frantzis Options,ResultsFile: Add option to set the results file 2023-01-03 alexandros.frantzis Introduce infrastructure to support saving results to a file 2023-01-03 alexandros.frantzis CanvasGeneric: Store individual info elements in separate strings 2023-01-03 alexandros.frantzis MainLoop: Store indivitual result values in separate strings 2023-01-03 alexandros.frantzis Scene: Remove trailing ':' from scene info string 2023-01-04 alexandros.frantzis SceneTerrain: Silence unused variable warning 2022-12-21 pierre-yves.mordret NativeStateGBM: Lock and release the front buffer on flip 2022-12-21 alexandros.frantzis MainLoop,Scene: Support reporting shader compilation time 2022-12-20 alexandros.frantzis MainLoop,Scene: Add busy percentage in CPU time results 2022-12-20 alexandros.frantzis MainLoop,Scene: Support reporting CPU time results 2022-12-20 alexandros.frantzis Options: Introduce option to specify benchmark results to show 2022-12-20 alexandros.frantzis Scene: Update elapsed times when a benchmark finishes 2022-12-19 alexandros.frantzis Scene: Introduce struct to keep track of elapsed time 2022-12-15 alexandros.frantzis Scene: Introduce infrastructure for more complex scene stats 2022-12-15 alexandros.frantzis Scene: Move common preparation logic to Scene::prepare 2022-12-13 alexandros.frantzis Scene: Introduce non-virtual methods to prepare and finish a scene for benchmark 2022-12-08 alexandros.frantzis GLVisualConfig: Support specifying the config id in --visual-config 2022-12-08 alexandros.frantzis libmatrix: Support prefix dependent input conversions from string 2022-12-08 alexandros.frantzis GLStateEGL,GLStateGLX: Fail if no suitable config is found 2022-12-08 alexandros.frantzis GLStateEGL,GLStateGLX: Don't limit the configs passed to our selection mechanism 2022-12-08 alexandros.frantzis GLVisualConfig: Penalize configs with components smaller than requested 2022-11-16 alexandros.frantzis github: Build x11-gl-egl flavor in CI 2022-11-14 rilian-la-te build: Add x11-gl-egl flavor 2022-11-10 alexandros.frantzis GLStateGLX: Support multisampled configs 2022-11-10 l.stach GLStateEGL: Support multisampled configs 2022-11-10 l.stach GLVisualConfig: Add multisampling support 2022-09-02 120989324 Add missing newline at end of log messages 2022-11-10 alexandros.frantzis NativeStateDRM,NativeStateGBM: Support configuring the DRM device 2022-11-10 alexandros.frantzis Options: Support passing window system specific options 2022-04-23 nunes.erico NativeStateGBM: Add GBM offscreen backend 2022-07-07 wuqianhai SceneJellyfish: Fix memory leak 2022-07-07 wuqianhai SceneRefract: Fix texture leak 2022-07-07 wuqianhai SceneIdeas: Fix texture leak 2022-06-14 Martin.Jansa waflib: fix compatibility with python-3.11 2022-05-12 jeffy.chen NativeStateDRM: Honor visual configuration 2022-05-13 alexandros.frantzis GLStateEGL,GLStateGLX: Use SwapInterval 1 for FIFO swap mode 2022-04-15 alexandros.frantzis NativeStateDrm: Implement swap interval 0 2022-02-14 alexandros.frantzis github: Run apt-get update to get latest packages 2022-02-14 alexandros.frantzis CanvasGeneric,CanvasAndroid: Display surface config info 2022-02-14 alexandros.frantzis Options: Support --version command line argument 2022-02-14 alexandros.frantzis libmatrix: Add missing <utility> include 2022-02-10 hillma libmatrix: avoid -Wimplicit-fallthrough 2021-12-23 alexandros.frantzis Build,Doc: Update files for 2021.12 release 2021-12-23 alexandros.frantzis NativeStateDrm: Fix crash when we can't become DRM master 2021-09-30 jf android: Fix benchmark parameter edition 2021-08-30 alexandros.frantzis Use highp precision modifier only on GLES 2021-08-30 alexandros.frantzis GLStateEGL: Support EGL versions < 1.4 2021-04-11 maahiuzeon Fix model loading on big endian. Created with: roll-dep third_party/glmark2/src Bug: chromium:40263312 No-Presubmit: true Change-Id: Ifee506badac67ff5af57605994daff01278c6d56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6162277 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Fumitoshi Ukai cf9949b3 2025-01-06T22:15:51 Reland "build: Generate gn_logs.txt" This reverts commit d75f4b83c50e1840305fc23f4e300b2f18e33f7c. Reason for revert: original CL broke ANGLE to Skipa auto roller: https://chromium-swarm.appspot.com/task?id=6e1b4e2c7d2a2a10 ERROR at //third_party/externals/angle2/BUILD.gn:1852:3: Unable to load "/mnt/pd0/s/w/ir/skia/build/gn_logs.gni". import("//build/gn_logs.gni") ^--------------------------- See //third_party/angle2/BUILD.gn:12:5: which caused the file to be included. "//third_party/externals/angle2:libEGL", ^-------------------------------------- Fixed by adding guard '!build_with_chromium && angle_has_build' Original change's description: > Revert "build: Generate gn_logs.txt" > > This reverts commit 4abc704df420b7f3fb6dbe35c39c7f60cfdaac3a. > > Reason for revert: breaks ANGLE to Skia auto roller: https://skia-review.googlesource.com/c/skia/+/930206 > > Original change's description: > > build: Generate gn_logs.txt > > > > This is necessary to make Siso builds work for angle. > > See https://crrev.com/c/6083212 > > > > Bug: b/385244283 > > Fixed: b/385244283 > > Change-Id: I6bc6d82744106cce1c358f415e53ad842241b567 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108522 > > Commit-Queue: Roman Lavrov <romanl@google.com> > > Auto-Submit: Junji Watanabe <jwata@google.com> > > Reviewed-by: Roman Lavrov <romanl@google.com> > > Bug: b/385244283 > Change-Id: I4106d696c8f7b5db9fba1814b04c2c5c404e9413 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6125598 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Auto-Submit: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: b/385244283 Change-Id: I28d47d176f48418a971e0460c0508dd28ae9fccf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6151225 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Junji Watanabe <jwata@google.com>
Roman Lavrov 31ccf78b 2025-01-07T15:46:15 Inline GetVertexFormatID using lookup tables Before this change the switch produced >1KB of assembly due to all the branching. This reduces the .so size by ~3KB and avoids the function call into a seemingly cold page. No obvious perf improvement in my tests from just this change. Changing underlying enum type to minimize table sizes. Bug: b/383305597 Change-Id: I724aa093ab5edf7af016b5b04764437a345517d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6153395 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov e6d9854b 2025-01-09T09:12:53 Capture/replay tests: fix logging on capture error Introduced by https://crrev.com/c/6042183. Also remove unneeded trailing \n in a few spots. Bug: angleproject:380296979 Change-Id: Ie6438409533855b22bc85a02ec0017279be4880a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6163683 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll c9fec1f7 2025-01-09T10:01:45 Roll vulkan-deps from 5f05f0592633 to 1fa2eb257bf0 (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5f05f0592633..1fa2eb257bf0 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/3f17b2af6784bfa2c5aa5dbb8e0e74a607dd8b3b..a380cd25433092dbce9a455a3feb1242138febee https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8a7619fc7dc30177cbb1d32c457c4fb05e9f82db..196627ca4ebb72cb1367755b9d97a9ed716e4728 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Idff66b4047049e3ce84f069f6cd407db098d4694 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6162097 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 71980a30 2025-01-08T12:12:46 Manual roll Chromium from 281d0392ed2f to b916218d8fec (1171 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/281d0392ed2f..b916218d8fec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/android_build_tools/aapt2/cipd: JPmxYHMZl4VH2Umf2-flGSdTVHtNDdFBmXd7v1Gs7EoC.._lNsOL_GGlXLOIMGtrbMOqNd7TQHabaP1q8SlvUpFbMC * third_party/android_build_tools/error_prone/cipd: 3uVZCorp5AfUqWJh9_b88WPAXGcMXzb2-_RELEMkIAAC..a-wq097LhH9krgIuF0T5waFnHU4KilRItqhJPGFZxtwC * third_party/android_build_tools/lint/cipd: yRtv3ENAOirUsdXx8YvmGiB0eKZ5gBioAfsRlt9K0-UC..Q2AdRKMr8eMrKgLZ9CwGTRx4BwGOL2wc6Ad942McdDUC * third_party/android_build_tools/manifest_merger/cipd: X4iLz22sYpi8ovi3X8Iv6PXgOcy2934mOa16hL5-w2gC..T3B_dWqgDISstbC0L7CrQOOf9xe-27KUYK8UCTq6trgC * third_party/android_build_tools/nullaway/cipd: KGEP4hGbArGQwI_HL3iJWEYMP1PVa2J_QRLPo-9wwiwC..65WJkoinJEXvtu9xwdDNDb3QCbqBAl8FKDpgnXr3iiEC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/86d6f8ee61..8491e07230 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/58625e82c6..423f1e1914 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1f7db7501c..74dd760826 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/83dfa1f5bf..7681005c62 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/d7c6dddc04..2019a9e40b * third_party/r8/cipd: q_wvk54XItTBlBNQMHkS4NRMp-tapPW97M292KTXHrsC..zzsW6sllgOhMp73iLSaG0dTW_A8IvWreBT1vBH6JKAIC * third_party/r8/d8/cipd: q_wvk54XItTBlBNQMHkS4NRMp-tapPW97M292KTXHrsC..U3Jf_ewWOZyxa6vyO3wjNIgm8XIz1yFk-4k3-wqDL44C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bf9a341137..6724fcc901 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/37d3b536ae..7a73c88363 * tools/skia_goldctl/linux: PNE7Fclbe9QG9LF9goXEGcZdLRF9BTfPrN_kguKqNR0C..l5aKsGPbt8dooumWZmU3fwjo40Xiiw3v-G-1HnEa-isC * tools/skia_goldctl/mac_amd64: urNQsuWSpqZHCVVDj3airG0ps7V55Zz8JNfj5p1N0h4C..iAGPE6NpjDOoBn4Qan139Qgz6nxEvTMnestoh1t6iX8C * tools/skia_goldctl/mac_arm64: N0tUKPzw6eyaiqY-Ea9g6TujzrSjazJW1GwHD6GiJvkC..YxUcONVh4dduKRWDzdoArT7R9nVG3Cl72jR4lGFzkWoC * tools/skia_goldctl/win: higEnuoHCI_e6VMHGBAiodkRZW6nOOTVKClWpyaRYJoC..t82CKYUKKcDYN0FPMEZFScWov212eEtPJR_u9rhm_pIC No update to Clang. Bug: None Tbr: solti@google.com,ynovikov@google.com Change-Id: I445205a0cdbc326d957be8ed521935b3cc5e4beb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6158262 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Steven Noonan 96abb2c3 2024-12-13T14:06:55 vulkan: add EGL_ANGLE_platform_angle_vulkan_device_uuid Implement the ability to select a specific device and driver combination through a few new selection criteria: VkPhysicalDeviceIDProperties::deviceUUID VkPhysicalDeviceIDProperties::driverUUID VkPhysicalDeviceDriverProperties::driverID Bug: angleproject:351866412 Change-Id: Ia6716aaed658d2563612d8b5d81287df97b57462 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5686557 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d4a3dbee 2025-01-08T02:01:19 Roll SwiftShader from 52586b554f93 to 5221bf031f44 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/52586b554f93..5221bf031f44 2025-01-07 syoussefi@google.com Implement VK_EXT_index_type_uint8 2025-01-07 swiftshader.regress@gmail.com Regres: Update test lists @ 52586b55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I1591b8fd242dd5b8313137f6fb008edd8d059bf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6156514 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e3b68d24 2025-01-08T10:01:37 Roll vulkan-deps from 37201c17e85f to 5f05f0592633 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/37201c17e85f..5f05f0592633 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/1a0658f55aab97e1803ca46896596a04c395d50d..8b39a8b54d55c8737196cdce705f32f94d3b2463 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b8427832bef9443081c3a8bcc30f4e999ab48b6c..8a7619fc7dc30177cbb1d32c457c4fb05e9f82db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I7633d0f13a8452d77e8a802afaba40b89e9c007f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6155578 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 47cde891 2025-01-08T05:46:56 Manual roll Chromium from 5b055b7097a9 to 281d0392ed2f (32 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/5b055b7097a9..281d0392ed2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependency * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4aba7b76ec..f3e95cc9a0 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ifa7121d1681cb8637fcc3876693788298d5a5595 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6155638 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll eb3acb1d 2025-01-08T03:37:09 Manual roll Chromium from 6dcb68c47fcc to 5b055b7097a9 (169 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/6dcb68c47fcc..5b055b7097a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/469b4146c5..dc74188326 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b2f9b39a04..d2a70ad29f * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a3f93e5082..1f7db7501c * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/eb30e7e9d4..d7c6dddc04 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/82a5fecf8a..b763971bca No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Id484beda8389f5bbfd55a72f311abaa432fd6ce2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6155576 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a51899d8 2025-01-07T23:15:23 Manual roll Chromium from a1ed57f54522 to 6dcb68c47fcc (803 revisions) Manual roll requested by solti@google.com https://chromium.googlesource.com/chromium/src.git/+log/a1ed57f54522..6dcb68c47fcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6b60728ea9..4aba7b76ec * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2823e220cb..469b4146c5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f0d4499c36..b2f9b39a04 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/02c28ce7fe..ee2354ca1c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a9315aaaa1..f3776f1de7 * third_party/fuchsia-sdk/sdk: version:26.20241227.3.1..version:26.20250103.4.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9ba1d4922a..a3f93e5082 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/b0de9011b9..eb30e7e9d4 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/2559e1ff2f..08704ba669 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f2066b43ae..ae2c3a11a8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/306a47aa4c..bf9a341137 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3da60bb598..37d3b536ae * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/02403d4e52..474e007a4e Clang version changed llvmorg-20-init-13894-g8cb44859:llvmorg-20-init-16062-g091448e3 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/306a47aa4c73ded365fb503f4a00d12e47cce204..bf9a3411372f2d5eed8b3d27ee8bd8cf6c17135f/scripts/update.py Bug: None Tbr: solti@google.com Change-Id: I2762cd0bac94ad9d1cb7bc995f6fec702211d95c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6154308 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Matthew Denton 363f6264 2025-01-07T10:35:09 WGSL: unwrap single array element from uniform ...instead of unwrapping the entire array when only one element is being accessed. The is step #4 from the implementation plan in https://docs.google.com/document/d/17Qku1QEbLDhvJS-JJ9lPQAbnuZtLxWhG-ha5eCUhtEY/edit?tab=t.0#bookmark=id.dt9vmixnpdvo Bug: angleproject:376553328 Change-Id: I6c559f44b75cd1d3c4a478141c11f65a33d76bdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6102117 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Matt Denton <mpdenton@google.com> Reviewed-by: Matt Denton <mpdenton@google.com> Reviewed-by: Liza Burakova <liza@chromium.org>
Shahbaz Youssefi 6f32ed6c 2025-01-03T23:54:22 Fix struct sampler rewrite vs comma Bug: chromium:377614665 Change-Id: I2c0e8230e31405c9e7fd165a9fca68b7e9f31a76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6142516 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sushma Venkatesh Reddy 7e9b1115 2025-01-06T15:24:56 Vulkan: Disable protected memory on Intel GPUs Due to Intel PXP termination, any active contexts held by userspace for PXP will be marked as banned. Re-establishing the session without affecting the use case is complex. Thereforce, it is preferable to disable protected memory by default unless explicitly needed. Test: Ensure powerd_dbus_suspend doesn't cause GPU process exit Bug: b/381285096 Change-Id: I057825a36d39b193f84cbdf90323fd95ed96fded Signed-off-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149057 Reviewed-by: Juston Li <justonli@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Solti Ho 833e6893 2025-01-07T18:50:25 skip some dEQP basic_shader.* tests on Linux Bug: angleproject:388052193 Change-Id: Iabc271223b24b411fc467aa42d2ff731d318411d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149875 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Solti Ho <solti@google.com>
Mohan Maiya bc795943 2025-01-06T12:41:05 Proper clean up for EGLLockSurface3Test Make sure to destroy context and window in each test Bug: angleproject:42264593 Change-Id: Ia5768ad109340a0be2bd2912877b7236e201ce0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6150289 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 59162e2e 2024-12-30T12:22:10 Vulkan: Update a few features and extensions for Samsung Enable disableProgramCaching Disable rgbxInternalFormatANGLE clipDistanceAPPLE cacheCompiledShader preferMonolithicPipelinesOverLibraries Bug: angleproject:386749841 Change-Id: Iea8033e2999c65b8715c6069d2096a709f78f438 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6133540 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi d1496a22 2025-01-03T22:54:27 Produce same compile errors for op= as op Bug: chromium:376787367 Change-Id: Ic2c1415c184c603b86876e5eb70eee602639abbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6142515 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Hans Wennborg 49e7801b 2025-01-07T12:55:05 Suppress false-positive UBSan falures in rsgExpression.cpp A recent Clang roll introduced false-positives like runtime error: load of address 0x7f9c4f3ae6c0 with insufficient space for an object of type 'const IsConversionOkFunc' (aka 'bool (*const)(ConstValueRangeAccess)') Suppress them until a fixed version of Clang has been rolled in. Bug: chromium:388039125 Change-Id: I0823e52bb892feac519b123ae66716c3dc96f6b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149452 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 29619d42 2025-01-07T12:36:24 Roll vulkan-deps from 0cf38d98a8ba to 37201c17e85f (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0cf38d98a8ba..37201c17e85f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/4c1027dc7e12adc8da50f00f5b219e81ddd2d85d..369f59ad598b60d6ed9f553af651c5cccd20234c https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/a71347ae4d76eb8454459373d4e1bfb929ea6a89..315964ad5aabd5b148a484e5fbea8a365c8d1eb3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/503060ebab2768b07c2df8987de608c657794311..b8427832bef9443081c3a8bcc30f4e999ab48b6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ife3a3829930eaeeadc625c357289a78b54d581ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149767 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 853087b7 2025-01-07T02:01:46 Roll SwiftShader from e76961fac58c to 52586b554f93 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/e76961fac58c..52586b554f93 2025-01-06 dneto@google.com Update to cmake 3.22.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I6f319860592b877d33f067ced8f6bc00af8a5fbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6152081 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 15b1fb37 2024-12-29T00:38:43 Fix mixing multisampled renderbuffers and textures When querying a renderbuffer's render-to-texture sample count, the number of samples was returned. This made it look like the renderbuffer attachment is MSRTT even if it was really multisampled. When mixed with a multisampled texture (where this mistake wasn't made), the framebuffer completeness code marked the framebuffer incomplete because it looked like one attachment is MSRTT and the other is not. Test credit zephyrxiao@tencent.com Bug: angleproject:382393146 Change-Id: I9fe516d6a92033512646414f88a9848aa1e1edc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6138979 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 465299fb 2025-01-06T16:49:15 context_private_call.cpp -> context_private_call.inl.h Most functions are trivial wrappers resulting in unnecessary forwarding calls. Most are called exactly once from entry points autogen. This _reduces_ the .so size by ~14KB and I'm seeing 1-2% better frame time in my driver_overhead_2 tests on a mobile device. Bug: b/383305597 Change-Id: I1f2a048e067c76993bacfbbce655fc1c898fdba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149814 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Tingwei Guo 83047378 2024-12-20T15:07:02 Add supplement GL_ARM_shader_framebuffer_fetch_depth_stencil tests * Add two tests about detaching the depth attachment and stencil attachment separately works correctly. * Add six tests to test whether multisample, GL_FETCH_PER_SAMPLE_ARM and fragment discard work properly in different situations. Bug: angleproject:385170273 Change-Id: I8a4299e2336a8bf800ffe286775a53f59b407c8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108524 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana b01e9b58 2024-10-07T17:48:34 CL/Vulkan: Add timestamps for skipped transitions In certain scenarios, the event state transitions might be skipped - i.e. move from QUEUED -> COMPLETE. In those cases, set time stamps for intermediate states. Bug: angleproject:377942756 Change-Id: I41ae7d555b04e4ba6a8432718c0493f9f2e88fdd Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Updated-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6120465 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Matthew Denton 53ec86ab 2024-12-17T14:40:31 WGSL: support small stride arrays in uniforms WGSL requires arrays in the uniform address space to have a stride a multiple of 16. This CL makes WGSL translator emit wrapper structs for array element types used in the uniform address space, when the array stride is not a multiple of 16. The exception is for structs that aren't an aligned size of 16n, and for any types matCx2, since they are (or will be) handled in different ways that ensure alignment to 16. This should leave only f32, i32, u32, and vec2. See https://www.w3.org/TR/WGSL/#example-67da5de6 for an example of using a wrapper struct. This requires converting arrays with a wrapper struct element type to arrays with an unwrapped element type when they are first used; this can be "optimized" later for the common case of accessing a single array element, which can then be unwrapped immediately. This CL generates WGSL conversion functions when necessary. After this, the only types that can't yet be used in a uniform are matCx2 and bools. This is #2 in https://docs.google.com/document/d/17Qku1QEbLDhvJS-JJ9lPQAbnuZtLxWhG-ha5eCUhtEY/edit?tab=t.0#bookmark=id.rt3slgehd4te Bug: angleproject:376553328 Change-Id: I1edfa7f481a6cbf5b595643aae8728e67bc4b770 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6092038 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Matt Denton <mpdenton@google.com> Commit-Queue: Matt Denton <mpdenton@google.com>
Mark Lobodzinski 491335c4 2024-12-26T10:25:32 Tests: Add Bullet Echo ANGLE trace Test: angle_trace_tests --gtest_filter=*bullet_echo Bug: b/387973432 Change-Id: Ib5694f53dd2f5a2b0d8a417582e4ff8054565461 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149436 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Solti 4d2f4d97 2025-01-06T19:49:29 skip some dEQP basic_shader.* tests on Linux Bug: angleproject:388052193 Change-Id: I2e78dbacc2367af87fa102306b2458a1ef13e313 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6150288 Commit-Queue: Solti Ho <solti@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi f80d15ad 2025-01-03T16:19:13 Vulkan: Fix crash with array of array of samplers vs comma Bug: chromium:385256122 Change-Id: I9b356401e7c007060e95bb95ca8269411178ce66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6143373 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 1a8d7712 2025-01-06T12:44:00 Inline common cases of PackParam<BufferBinding> This appears to improve frame time by ~0.8% in some of my driver_overhead_2 tests on a mobile device. Default implementation is FromGLenum<BufferBinding> https://crsrc.org/c/third_party/angle/src/common/PackedGLEnums_autogen.cpp;drc=0bb109aa3311f35bf0b51bcda3d7e095048168c8;l=106 and has 15 cases. This CL avoids the call for 3 of those cases, most common ones according to frequency of glBindBuffer arg in our trace cpp files. This mapping adds compare/branch instructions for each case, hence inlining increases the caller a little. In this case the increase is about 60 bytes. With the total of 23 callers (GL_*Buffer* exports), this increase the .so size by ~1.3KB. Just inlining the function would yield higher bloat and wouldn't prioritize the common cases. Bug: b/383305597 Change-Id: Icc205fd46fb8ef195c8ffaf67f9cd5194d1d1a5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6148838 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 2c025cb9 2025-01-06T08:36:23 Revert "Proper clean up for EGLLockSurface3Test" This reverts commit 9d9e3efce077dbfe261b13fdfb3b20fc1e4a5e4c. Reason for revert: Suspected cause of flakiness anglebug.com/387828389 Original change's description: > Proper clean up for EGLLockSurface3Test > > Perform unmakecurrent during test teardown > > Bug: angleproject:42264593 > Change-Id: I1148b5c6631e81090f7ae931495bba1b43c24502 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6133539 > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: mohan maiya <m.maiya@samsung.com> Bug: angleproject:42264593 Bug: angleproject:387828389 Change-Id: Ia8b484e391931e9401bd644c919c34ef65718b37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6147815 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexander Bobrovnik 87d4656a 2024-06-24T16:16:47 Fix EGL_NO_SURFACE on eglCreatePbufferFromClientBuffer Bug: angleproject:348452183 Change-Id: I2fe1d3a76aa896e2034ed01ec88bcae563e6071f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5646493 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 6e813222 2025-01-06T10:48:58 Inline other trivial forwarding validation calls Following Shabi's comment on https://crrev.com/c/6108030 Otherwise these end up as actual "trampoline" function calls Bug: b/383305597 Change-Id: Ie1e7f57d6b630736aa8de914ba4abe3c2d5ee09d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6148833 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll fbaaeb7b 2025-01-06T10:01:02 Roll vulkan-deps from a09312dc04d3 to 0cf38d98a8ba (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a09312dc04d3..0cf38d98a8ba Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/1757b68e6e4d490a4ed96ca9fdc9853b3ed8ee4f..503060ebab2768b07c2df8987de608c657794311 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I1d7a44313852bc638de514ea0defeb3b32e997c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6147164 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll ed3deea8 2025-01-06T08:01:00 Roll VK-GL-CTS from 77d5e6888a99 to 9509eb274dfe (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/77d5e6888a99..9509eb274dfe 2025-01-03 piotr.byszewski@mobica.com Test concurrent access across device and host 2025-01-03 ziga@lunarg.com Add missing shader object test case 2025-01-03 russellc@nvidia.com Lower dimensions for image concurrent copy tests 2025-01-03 marcin.zajac@cognizant.com Fix validation error in ycbcr tests 2025-01-03 marcin.zajac@cognizant.com Fix validation error in transform feedback tests 2025-01-03 marcin.hajder@mobica.com Made border_clamp tests independent on out of spec precision 2025-01-03 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-31 andrew.shadura@collabora.co.uk Fix instances of -Wmissing-template-arg-list-after-template-kw If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I2deed801ab285a74a6ece7121904460d4d6fc7d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6147148 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu d65751b4 2025-01-03T15:44:59 Skip monopoly_go trace on devices where the trace crashes Bug: angleproject:385226328 Change-Id: I8448e9bd355205dbf36599b6d82e5e05873b936e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6143534 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Solti Ho <solti@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 970fcf27 2025-01-03T11:01:05 Roll vulkan-deps from 96fab523bf7d to a09312dc04d3 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/96fab523bf7d..a09312dc04d3 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a90793e52ee4d30738154e5647605561c4696dad..1757b68e6e4d490a4ed96ca9fdc9853b3ed8ee4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I715443192966ef7bde9f0bb2612a84711623e71b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6140268 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b225419f 2025-01-02T11:46:21 Roll vulkan-deps from 04a50a3dd7b9 to 96fab523bf7d (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/04a50a3dd7b9..96fab523bf7d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/d6141280aadb706f49cd46128b1dee2b3a361c2e..a90793e52ee4d30738154e5647605561c4696dad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I46fce7a296cefd4dde507664f05df9214070c210 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6137315 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6b6f51ca 2025-01-02T08:45:09 Roll Chromium from 5929f2432039 to a1ed57f54522 (117 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5929f2432039..a1ed57f54522 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/44bcc9d7b8..6b60728ea9 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/8ea7f7e9d8..b0de9011b9 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ieb83a2c92129aaf9fbfabed565b8eb6b8931155e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6137928 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 9d9e3efc 2024-12-30T12:10:57 Proper clean up for EGLLockSurface3Test Perform unmakecurrent during test teardown Bug: angleproject:42264593 Change-Id: I1148b5c6631e81090f7ae931495bba1b43c24502 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6133539 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
angle-autoroll 3a2dbe02 2025-01-01T10:01:06 Roll vulkan-deps from bfa23916c97e to 04a50a3dd7b9 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bfa23916c97e..04a50a3dd7b9 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/34b85f655e7b07865ce554eb365ab8241cb8be6e..d6141280aadb706f49cd46128b1dee2b3a361c2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I2ff3b5e38eb686afd68a5444bb9397c51f6f33fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6135731 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 06a2e5e5 2025-01-01T07:00:59 Roll Chromium from 3d34cc12858a to 5929f2432039 (134 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3d34cc12858a..5929f2432039 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependency * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/30f439e02e..8ea7f7e9d8 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I3dbba954c1cd02c8a4aa999d93e9818e27f9fcf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6136362 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6015e730 2024-12-31T10:01:01 Roll vulkan-deps from 4cc576cd0e3d to bfa23916c97e (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4cc576cd0e3d..bfa23916c97e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3a2834e7702651043ca9f35d022739e740563516..f754c852a87988eb097a39480c65f704ceb46274 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I2a768ef76f36be3382a1d94fe50f0802b9c2b888 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6134642 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5e515f77 2024-12-31T07:00:58 Roll Chromium from 544ef0629b65 to 3d34cc12858a (215 revisions) https://chromium.googlesource.com/chromium/src.git/+log/544ef0629b65..3d34cc12858a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/425a626135..f0d4499c36 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/fa202ff628..30f439e02e No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: If3090006a6a15378e97fb10735dc8edabe32f31f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6134548 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 39882b2b 2024-12-28T12:00:19 Vulkan: Fix flakiness in MultipleProgramsShareDescriptors Precision differences causes the test to be flaky on some vendors. The test is not validating color accuracy, there is no need to use random numbers. Bug: angleproject:42265270 Change-Id: Ied8794d14b394e049e5735d4c42a7baf6e3aca0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6129616 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 017a9382 2024-12-30T10:01:22 Roll vulkan-deps from 2ceb995d091f to 4cc576cd0e3d (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2ceb995d091f..4cc576cd0e3d Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/becf97fdc95572165e941feadc1a3064e2b95c87..1a0658f55aab97e1803ca46896596a04c395d50d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2897317be9f49fbca8d1e14d87fb08b56023b5ed..34b85f655e7b07865ce554eb365ab8241cb8be6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I2edd9a56128a1829b8e1fbb4fa463960e4f8f078 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6130912 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b8027afe 2024-12-30T10:44:38 Roll VK-GL-CTS from 7655439d7333 to 77d5e6888a99 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7655439d7333..77d5e6888a99 2024-12-30 rgarcia@igalia.com Test depth/stencil layout changes in the transfer queue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Iea8a930ed9ff6f433b2856bca937a2eba61f386c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6131698 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c9a1a52a 2024-12-30T02:01:58 Roll SwiftShader from 118f577b4188 to e76961fac58c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/118f577b4188..e76961fac58c 2024-12-27 rprichard@google.com regcomp: avoid a namespace collision with C23 <float.h> If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I58d62ff36f28682f4b125b5adce56ae16ad3eb29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6132385 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0559bc5a 2024-12-30T07:01:17 Roll Chromium from 8bb7bbeac941 to 544ef0629b65 (853 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8bb7bbeac941..544ef0629b65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8f6742f233..44bcc9d7b8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2344736aa3..425a626135 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9b52643950..86d6f8ee61 * third_party/fuchsia-sdk/sdk: version:26.20241220.3.1..version:26.20241227.3.1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/2222607a3e..fa202ff628 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d0c22105ed..3da60bb598 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I9322fbe779b48177469051b332c6a80ec0361a92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6130907 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya 7c766c0e 2024-12-23T15:12:44 Vulkan: Bugfix in OverrideFeaturesDependent test On some vendors there is a second order effect of disabling some features, account for such vendors. Bug: angleproject:42266725 Change-Id: I53e93d595ee09210ef7781d667470e2b46c10e55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6118433 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 35ea113c 2024-12-27T06:03:23 Manual roll VK-GL-CTS from 1797eec1a51d to 7655439d7333 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/1797eec1a51d..7655439d7333 2024-12-20 michal.jakubek@mobica.com Vulkan SC doesn't report waived test case count 2024-12-20 piotr.byszewski@mobica.com Test NoContraction keyword 2024-12-20 marcin.hajder@mobica.com Added tests for non-layered bindings of 2D shader images 2024-12-20 kamil.goras@mobica.com Enable ES31_compatbility tests. Those tests are implemented but were not added to any test package. Move SampleVariablesTests, ShaderImageLoadStoreTests, ShaderStorageBufferObjectTests to common 2024-12-20 piotr.byszewski@mobica.com Fix copy tests using NaN for sfloat formats 2024-12-20 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-18 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-12-12 rgarcia@igalia.com Test depth/stencil copies on the transfer queue 2024-12-12 mateusz.bahyrycz@mobica.com Fix validation error in ray tracing tests 2024-12-12 antonio.ospite@collabora.com Build testlog-* and other tools also on Android 2024-12-12 marcin.hajder@mobica.com Added missing texture parameter for shadow samplers 2024-12-12 tomeu@tomeuvizoso.net Fix Android standalone executables to work with EGL tests 2024-12-12 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2024-12-12 gleese@broadcom.com Make autogen for VK, VK SC consistent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I73077c44cfae8ba31d7334e2b149e368c6c1f579 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6116045 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c486ce8c 2024-12-27T06:24:19 Manual roll Chromium from faba6412dc5c to 8bb7bbeac941 (279 revisions) https://chromium.googlesource.com/chromium/src.git/+log/faba6412dc5c..8bb7bbeac941 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/63ad9737d7..8f6742f233 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/56013b77b6..2823e220cb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/41bfee6b2b..2344736aa3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/11c38d901d..9ba1d4922a * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/f6418697ac..2559e1ff2f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e6eba9706f..d0c22105ed No update to Clang. Bug: None Change-Id: I6c019235e8a99d74c91496d1cdfa37b56891d65f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6121262 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shufen Ma a614c8ab 2024-12-10T11:14:29 Check alpha in ColorMask for YUV target ColorMask is used to mask the writing of R, G, B and A values to all active draw buffers. r, g, b, and a indicate whether R, G, B, or A values, respectively, are written or not (a value of TRUE means that the corresponding value is written) except when the color buffer is in YUV color space, in that case setting any one of the r, g, b, and a values as false would generate draw time INVALID_OPERATION error. Bug: angleproject:383174962 Change-Id: I38c2510c307dd8158e71c920986cb497ca923ff9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6083471 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Tingwei Guo aa263d13 2024-12-19T17:48:13 Increase GL_MAX_ARRAY_TEXTURE_LAYERS to 4096 and end2end test Increase GL_MAX_ARRAY_TEXTURE_LAYERS from 2048 to 4096, and add an end2end test to test whether the increased GL_MAX_ARRAY_TEXTURE_LAYERS meets the memory limit. Bug: angleproject:385040554 Change-Id: Ibb1ebcb2414c530dd838b3414dc82b14ce017bc4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108301 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu d75f4b83 2024-12-26T11:21:04 Revert "build: Generate gn_logs.txt" This reverts commit 4abc704df420b7f3fb6dbe35c39c7f60cfdaac3a. Reason for revert: breaks ANGLE to Skia auto roller: https://skia-review.googlesource.com/c/skia/+/930206 Original change's description: > build: Generate gn_logs.txt > > This is necessary to make Siso builds work for angle. > See https://crrev.com/c/6083212 > > Bug: b/385244283 > Fixed: b/385244283 > Change-Id: I6bc6d82744106cce1c358f415e53ad842241b567 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108522 > Commit-Queue: Roman Lavrov <romanl@google.com> > Auto-Submit: Junji Watanabe <jwata@google.com> > Reviewed-by: Roman Lavrov <romanl@google.com> Bug: b/385244283 Change-Id: I4106d696c8f7b5db9fba1814b04c2c5c404e9413 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6125598 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 00756ced 2024-12-26T01:23:08 Vulkan: Fix build on some compilers Bug: angleproject:352690896 Change-Id: Ia31fef4a3179db08d7fa9f402067c0a9aaf23ffc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6114509 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 9f82ea63 2024-12-26T00:53:39 Unsupress fixed tests Bug: angleproject:370792795 Change-Id: I7f81a58a2f502b0de321b2b2eb5d08e6dcd80d97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6121250 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll ae30ab0a 2024-12-24T10:01:32 Roll vulkan-deps from d9e522973bf6 to 2ceb995d091f (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d9e522973bf6..2ceb995d091f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/9295a8b94ed0751565fa9cda6d949f5e388b32d9..becf97fdc95572165e941feadc1a3064e2b95c87 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/6a6878c614c8c6dbe81ee7a9f1176bdb52dc7dd7..4c1027dc7e12adc8da50f00f5b219e81ddd2d85d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ib689795b70cb734100d6d633ba5d9226d0ad120f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6121647 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 711b2c32 2024-12-23T10:23:13 Vulkan: Let XFB's BufferHelper keep SharedDescriptorSetCacheKey instead of BufferBlock. Unlike uniform buffers which uses VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC, the descriptorSet for transform feedback buffers also have the buffer offset baked in, so it is not helpful to use BufferBlock's serial in the cache key. This CL changes to use BufferHelper's serial for cache key. With this we can also let BufferHelper keep the SharedDescriptorSetCacheKey instead of store it in the BufferBlock. In the case that BufferHelper gets destroyed and recreated, the SharedDescriptorSetCacheKey will also get destroyed. Right now because we cache BufferBlock serial, the SharedDescriptorSetCacheKey will not be destroyed even though BufferHelper is destroyed and there is very rare case that it can be reused, thus causing BufferBlock's SharedDescriptorSetCacheKey queue keep increasing, which causes perf issue. Bug: b/384839847 Change-Id: I76b8f0d56486079740cca302e8b14a04a6e24074 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6115111 Reviewed-by: mohan maiya <m.maiya@samsung.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 501f07a6 2024-12-23T10:01:37 Roll vulkan-deps from 45d90843193e to d9e522973bf6 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/45d90843193e..d9e522973bf6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/70c6ba3d70dc038cc1fcf319fa2ea46b8edc5d3b..73995ddc2b38b5653c8eb3b4a0d1cd6cc2cea4c0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/b8315514467ace9e22070dd8e0491aaffb9690d1..6a6878c614c8c6dbe81ee7a9f1176bdb52dc7dd7 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/90851ef5b77757556217122061672dc52e21629c..2897317be9f49fbca8d1e14d87fb08b56023b5ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I9c30781c2a571a884d0235d16d5d18216d7decf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6118432 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6bca07bd 2024-12-23T08:10:45 Roll Chromium from ebb01bde9709 to faba6412dc5c (564 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ebb01bde9709..faba6412dc5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b8a4536db2..63ad9737d7 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c1b2946e54..56013b77b6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0dd064ac2c..41bfee6b2b * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/af88579bcb..a9315aaaa1 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/22ebef9201..9b52643950 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/19548ed7a2..58625e82c6 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/175bf00303..11c38d901d * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/ca233e8056..2222607a3e * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/63612d4a53..f2066b43ae * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6f856e0b36..306a47aa4c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2fa3bb999c..e6eba9706f * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/917b7d7bef..02403d4e52 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ia99acec7b78f9f9c736af1d41a2d769921127768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6119500 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 81a41e4f 2024-12-21T01:14:31 Manual roll vulkan-deps from 2d70513951de to 45d90843193e (20 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/2d70513951de..45d90843193e Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/6a74a7d65cafa19e38ec116651436cce6efd5b2e..d4a196d8c84e032d27f999adcea3075517c1c97f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/7ccaa5e0206fcaa03135312fccb4624ae110a19b..b8315514467ace9e22070dd8e0491aaffb9690d1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/2744de9936755fea6912d47e7a0a8857d8a4fdee..a71347ae4d76eb8454459373d4e1bfb929ea6a89 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/7f8738669b15a7a158b2a77aff2033973dcd8751..5a88b6042edb8f03eefc8de73bd73a899989373f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2cbfec7bb95b3de7bab8db92716197ec9a855fb2..90851ef5b77757556217122061672dc52e21629c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7f4b0e5ffbae1a159fe1085aaf48c5eb4f219cda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6115340 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2849e8f1 2024-12-20T16:04:55 Manual roll Chromium from 7c4073fa4450 to ebb01bde9709 (737 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/7c4073fa4450..ebb01bde9709 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/1923aa3e32..b8a4536db2 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b8ff6f5a95..c1b2946e54 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0305a85a20..0dd064ac2c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/79b08c29b3..72093794ac * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e7c18388ac..22ebef9201 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fcb6178914..19548ed7a2 * third_party/fuchsia-sdk/sdk: version:26.20241213.3.1..version:26.20241220.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d0ddad5b79..175bf00303 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/02cb512292..83dfa1f5bf * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/05bd4c24a2..ca233e8056 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/3ef711c420..f6418697ac * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dffea2e717..6f856e0b36 * tools/luci-go: git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790..git_revision:320a8df0f7934159fda7721f3b507e707531d284 * tools/luci-go: git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790..git_revision:320a8df0f7934159fda7721f3b507e707531d284 * tools/luci-go: git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790..git_revision:320a8df0f7934159fda7721f3b507e707531d284 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5df8dc0a32..2fa3bb999c * tools/skia_goldctl/linux: qB-N09rgIx7yC6Zqn7Y2JvrIlrTweZuYNwSsc6xbILQC..PNE7Fclbe9QG9LF9goXEGcZdLRF9BTfPrN_kguKqNR0C * tools/skia_goldctl/mac_amd64: CFFGYiI44XKMhON-DbnaT7dFxhCTcMt3y5Cnrbwkt4IC..urNQsuWSpqZHCVVDj3airG0ps7V55Zz8JNfj5p1N0h4C * tools/skia_goldctl/mac_arm64: Bge_01Gtd7niAlYa0ekw745cni6y4ZGAAHAvBp_G5lUC..N0tUKPzw6eyaiqY-Ea9g6TujzrSjazJW1GwHD6GiJvkC * tools/skia_goldctl/win: CrceP9s_KaQvTDquHpILvfcu7lSVZOcDCsnClOyhmYQC..higEnuoHCI_e6VMHGBAiodkRZW6nOOTVKClWpyaRYJoC No update to Clang. Bug: None Tbr: abdolrashidi@google.com,ynovikov@google.com Change-Id: I536e8b573b1f74d58134bf9c4b99494e3cd893a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6114699 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Junji Watanabe 4abc704d 2024-12-20T13:23:33 build: Generate gn_logs.txt This is necessary to make Siso builds work for angle. See https://crrev.com/c/6083212 Bug: b/385244283 Fixed: b/385244283 Change-Id: I6bc6d82744106cce1c358f415e53ad842241b567 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108522 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov 195c3a20 2024-12-19T19:09:38 Inline non-PPO getActiveLinkedProgram and ValidateUniform1-4* The non-PPO part of getActiveLinkedProgram is small, and ValidateUniform1-4* are just a single call to ValidateUniform, and end up an actual function call due to being located in a different translation unit (validationES.cpp vs validationES2.cpp) Estimated 0.5-1% improvement to driver_overhead_2 wall_time on pixel 8 Bug: b/383305597 Change-Id: I256bf11952f36bbd5033f191df19aa293dbeefdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108030 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuxin Hu febba52a 2024-12-12T17:26:59 Optimize for swap after clear Bug: angleproject:382006939 Change-Id: Ia6b9a53042a1d188dbd5a5f6436f17ca1e389a4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6072416 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov db3a88fd 2024-12-19T09:15:50 Add missing include Bug: angleproject:42262955 Change-Id: If0e075d1f291321e3a265d1d68b9d813f8559d68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6110804 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Johnson <hibrian@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Solti Ho <solti@google.com>
angle-autoroll 8016c2c0 2024-12-19T02:01:26 Roll SwiftShader from 23b93c7cfe27 to 118f577b4188 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/23b93c7cfe27..118f577b4188 2024-12-18 dneto@google.com kokoro: Use Python 3.12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5131168c09664926a5b1c347b4b810778f87ef1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6110616 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6bf0acbe 2024-12-19T10:01:56 Roll vulkan-deps from ae8417f428a1 to 2d70513951de (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ae8417f428a1..2d70513951de Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b3a6aa7b03c51ba976e4f4e96b1e31f77f43f312..3a2834e7702651043ca9f35d022739e740563516 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/1a84052a5c332faaed12ea2431420b72febda807..9295a8b94ed0751565fa9cda6d949f5e388b32d9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/0ab12c1668642874f77bad0e4f4006cbd2f7eaee..7f8738669b15a7a158b2a77aff2033973dcd8751 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/fed45fcbb6cace64d6a28439d55b87327fafb34a..2cbfec7bb95b3de7bab8db92716197ec9a855fb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I573b47f32e6ec2a2ae966e33044dbb13abe5ac6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6110617 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c656c5fc 2024-12-19T07:00:53 Roll Chromium from 56d2640e97e6 to 7c4073fa4450 (673 revisions) https://chromium.googlesource.com/chromium/src.git/+log/56d2640e97e6..7c4073fa4450 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5f2852b973..1923aa3e32 * buildtools/linux64: git_revision:7296b601ea80252ccf8cce300c4bebcabf235f20..git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd * buildtools/mac: git_revision:7296b601ea80252ccf8cce300c4bebcabf235f20..git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd * buildtools/win: git_revision:7296b601ea80252ccf8cce300c4bebcabf235f20..git_revision:c97a86a72105f3328a540f5a5ab17d11989ab7dd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7153a13a08..0305a85a20 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/07cede3272..79b08c29b3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d74466096c..e7c18388ac * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/138f15432a..fcb6178914 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/77e59bec0f..02cb512292 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3605d6cf39..05bd4c24a2 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/22d3b30294..3ef711c420 * tools/luci-go: git_revision:94ce62005f7d368ce9e36897e15bb570cf0d0027..git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790 * tools/luci-go: git_revision:94ce62005f7d368ce9e36897e15bb570cf0d0027..git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790 * tools/luci-go: git_revision:94ce62005f7d368ce9e36897e15bb570cf0d0027..git_revision:cde70f87137f7a20bfc3c8d0c03a25c29932a790 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d004cd1259..5df8dc0a32 * tools/skia_goldctl/linux: aXHJ25ncUXPVNosfIlyKwiMy1_7taQbInefMc4nqOX0C..qB-N09rgIx7yC6Zqn7Y2JvrIlrTweZuYNwSsc6xbILQC * tools/skia_goldctl/mac_amd64: n7u7fnD8_JipALcOofxpNMbvph2fsWaAgmaeLeCkSs0C..CFFGYiI44XKMhON-DbnaT7dFxhCTcMt3y5Cnrbwkt4IC * tools/skia_goldctl/mac_arm64: X-JBelmtsD7X26HqTaYu0LMCepx-_ANJcSvFWh1tM24C..Bge_01Gtd7niAlYa0ekw745cni6y4ZGAAHAvBp_G5lUC * tools/skia_goldctl/win: 7nms2AMNrHCf-FHq9enXo2f6vRLs_lA_98qZ2cRiE78C..CrceP9s_KaQvTDquHpILvfcu7lSVZOcDCsnClOyhmYQC No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Id7a3b148bf9898160c21e17e80fc594b6faae0a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6109849 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi bb640019 2024-12-18T12:36:13 Vulkan: Fix partial clear texture for RGB8 snorm When clearing an RGB8 snorm texture, due to this format not being renderable, a temporary buffer is filled with the clear value and applied to the image as a buffer update. However, this buffer's unpack state has nothing to do with the context's unpacking state. This should be reflected on the pixel unpack state that is used to calculate the required buffer size for the update. Otherwise, it can result in wrong colors for parts of the image. * Updated the pixel unpack state in the unrenderable part of the clear function for textures (TextureVk::clearSubImageImpl()). * It will now use "1" as the alignment since it is tightly packed. * Added unit test to clear one corner of an RGB8 snorm texture and use it for drawing. * Clear2DRGB8SnormCorner Bug: angleproject:384765600 Change-Id: Id302a9f4049626aae1a68798e86d7183d5c264e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108140 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi da687935 2024-12-18T14:17:21 Skip stencil clear test for QCOM Bug: b/328156792 Change-Id: I0f76d5c76cb1b25f2d0aafbb5bd7f4e6ef8cbc2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108177 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Mark Lobodzinski 0dabe316 2024-12-18T09:35:35 Tests: Add Monopoly Go trace Test: angle_trace_tests --gtest_filter=*monopoly_go Bug: b/384879555 Change-Id: I64ab6efb23745ab9e099c1243d4f09cee0f311d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6106530 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0