kc3-lang/angle

Log

Author Commit Date CI Message
Austin Annestrand f85b6970 2024-01-18T11:59:24 OpenCL/Vulkan: Implement program get[Build]Info Adding backend routines for: - clGetProgramInfo - clGetProgramBuildInfo Bug: angleproject:8549 Change-Id: I890bb957e687a429eb0ed3b4756427ac98e302f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5303565 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Austin Annestrand 0ed0de4f 2024-01-18T10:47:50 OpenCL/Vulkan: Add initial program build support Introducing both clspv compiler lib integration, and clBuildProgram support. Internally we also add buildInternal() routine to abstract compile, link, and build phases. Output SPIR-V is also parsed internally via parseReflection() so that we can extract needed reflection information for CL runtime. Bug: angleproject:8549 Change-Id: If0563f4bea7ed0e04a13ea7a46c125c811d9c2a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5303564 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 1c2d2417 2024-03-01T14:50:43 Bugfix in CreateWithEGLConfig1010102Support test Create a context with config that supports RGBA1010102 format Bug: angleproject:8330 Tests: EGLSurfaceTest.CreateWithEGLConfig1010102Support* Change-Id: Ic8dfca01b253e6ae5ea1f0b99b6ac781288805c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5337608 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll f26c8d08 2024-03-01T15:43:12 Roll VK-GL-CTS from d023c17ac299 to 1918ab4d4806 (13 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d023c17ac299..1918ab4d4806 2024-03-01 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.4 into vk-gl-cts/main 2024-03-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-03-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-02-29 erik.faye-lund@collabora.com add support for bgra in texture-util 2024-02-29 erik.faye-lund@collabora.com add BGRA support for reference context 2024-02-29 pkohaut@nvidia.com Fix accidentally freed cmd buffer in sparse image rebinding tests 2024-02-29 javed@igalia.com Add test coverage for pipeline library with mesh shader. 2024-02-29 rgarcia@igalia.com Test multiview without a fragment shader 2024-02-29 piotr.byszewski@mobica.com Use descriptor buffers & legacy descriptors in same command buffer 2024-02-29 jbolz@nvidia.com Add tests for VK_NV_shader_atomic_float16_vector 2024-02-29 chip@holochip.com Use VK_EXT_metal_surface instead of VK_MVK_macos_surface 2024-02-29 aidan.fabius@coreavi.com Fix "full viewport" extended dynamic state tests 2024-02-29 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I22526f5bdda1fc33aaed991fe6cca779f59decd4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5337603 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 21381f5e 2024-03-01T07:01:36 Roll Chromium from 6b34297e693d to 40412b90c691 (533 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6b34297e693d..40412b90c691 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/100a65f1dd..0f6697fc2b * buildtools/linux64: git_revision:e05c0aa00938adc0797bda1e8f2c15675aa13c30..git_revision:88e8054aff7bd0cb2295c7d9361d2be0b7355f27 * buildtools/mac: git_revision:e05c0aa00938adc0797bda1e8f2c15675aa13c30..git_revision:88e8054aff7bd0cb2295c7d9361d2be0b7355f27 * buildtools/win: git_revision:e05c0aa00938adc0797bda1e8f2c15675aa13c30..git_revision:88e8054aff7bd0cb2295c7d9361d2be0b7355f27 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/484f898366..c3946edcd3 * third_party/android_build_tools/lint: H3namO3zonlUj075eXGd_my1zHGpGDoXubhIWd9CG0EC..KICH09fjzlFXmYj2dj16tG91b6Ueo_BM3DDwKcjK0b0C * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1ac3eb7b98..fbb0301f1f * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3787595bbb..c74625d62c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/5a776b1344..f0aa615f87 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6eeb10b9e5..b2f436cdad * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a130f45ec4..053067cf26 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ic406d248a8e467eb6531c4afb227abb894cd8710 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5337030 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 2ee295b4 2024-02-15T11:27:39 Vulkan: Add per-level image update tracker * Add a per-level image write tracker to ImageHelper. * It tracks the updates scheduled for different parts of the image. Within each level, it also tracks different layers, currently up to 64. * kMaxParallelSubresourceUpload renamed to kMaxParallelLayerWrites; moved to vk_helper header. * It is reset when a barrier is issued for the image. * Modified ImageHelper::recordWriteBarrier(). * Added isWriteBarrierNecessary(). * Now it checks the added writes for the image. It will no longer issue a barrier if the image is in the same layout and there is no write to a part of the image to which was previously written. * Added ReadImageSubresources to CommandBufferAccess. * It is used for layouts that allow both reading and writing to the image (including self-copy): * TransferSrcDst (used in CopyImageSubData) * ComputeShaderWrite (used in compute-based mipmap generation) * CommandBufferImageWrite -> CommandBufferImageSubresourceAccess * Updated onImageSelfCopy() args to include read subresource data. * Improves gpu_time for TextureUploadETC2TranscodingBenchmark perf test * Windows/NVIDIA: ~180609 ns -> ~62669 ns (~2.88x) * Linux/NVIDIA: ~157283 ns -> ~93360 ns (~1.68x) * Windows/Intel: ~72297 ns -> ~57153 ns (~1.27x) * Added a test to show that self-copy for a write-after-read works. * ArraySelfCopyImageSubDataWithWriteAfterRead * (ArraySelfCopyImageSubData covers RAW hazards; renamed) Bug: b/308455694 Change-Id: I5cef296d991ce6ec02792edc3ffc5cc4994831e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5301855 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Austin Annestrand 1ceddbf6 2024-01-11T16:15:08 OpenCL/Vulkan: Add createProgram routines Introduce createProgramWithSource and createProgramWithBinary. Additionally introduce KernelArgument types, SPIR-V Reflection info types, and DeviceProgram types. Bug: angleproject:8549 Change-Id: I611627d747a5ba6718778fd27fd28477b77fbbe1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5303563 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mike Schuchardt f7cd1c56 2024-02-28T12:04:22 Tests: Add Toca Life World trace Test: angle_trace_tests --gtest_filter=TraceTest.toca_life_world Bug: b/327354357 Change-Id: I5dc900532dc8b5db516c8c2fbab63462fa7c20ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5333438 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mike Schuchardt 56a291e8 2024-02-01T02:30:02 Rework external image capture Move external image creation into the trace fixture. Record image size at capture time and then recreate it using a GL staging texture and placeholder data during replay if the original client buffer is missing (MEC) or the image was created from another API (AHB). Track when EGLImages are created and destroyed during capture so they can be restored to their original MEC state at reset time. Clean up the backing GLTexture resources when the corresponding EGLImage is destroyed. In cases where EGL calls are made without an associated GL context, look up and active context to use from the passed in EGLDisplay parameter. Bug: b/300966403 Change-Id: I7033fa25d2cb3a59957887439506f6f6a416c8f1 Test: Trace com.square_enix.android_googleplay.FFVII Test: Trace com.MOBGames.PoppyMobileChap1 Test: Trace com.tocaboca.tocalifeworld Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4903441 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 8142dde7 2024-02-27T15:08:57 Tests: Add Pokemon Masters Ex trace Test: angle_trace_tests --gtest_filter=TraceTest.pokemon_masters_ex Bug: b/326199738 Change-Id: Ie0c4c4072865783b8f43332f9e4463a79acf3c35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5328735 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Mark Lobodzinski b45b350a 2024-02-29T10:11:42 Add skip for Pokemon Masters Ex validation warning This warning was generated in the Pokemon Masters Ex trace due to application issues and does not cause the test to fail but does create confusing output: Undefined-Value-ShaderFragmentOutputMismatch. Added it to kSkippedMessages. Test: angle_trace_tests --gtest_fitler=*pokemon_masters_ex Bug: b/319228278 Change-Id: I57bd9cca4b9bb5b681fb26884c9ba6ce8e66c667 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5334761 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 69f5e9ca 2024-02-29T10:01:36 Roll vulkan-deps from f43c5512f6d7 to 12f9cddb3ff7 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f43c5512f6d7..12f9cddb3ff7 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/05cc486580..b73e168ca5 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fbc7a14b3e..9bd44d028e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f0dacd0e25..5626df30d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I0250fcf186aae68722066ce07b4ef0b874818b0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5335015 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 19e725e4 2024-02-29T07:01:11 Roll Chromium from 579e74402476 to 6b34297e693d (578 revisions) https://chromium.googlesource.com/chromium/src.git/+log/579e74402476..6b34297e693d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dd4da8c1d8..100a65f1dd * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/135784cc4b..1db15eb420 * buildtools/linux64: git_revision:f19d5817e7ba85c2fda92e2697be11a4465d3267..git_revision:e05c0aa00938adc0797bda1e8f2c15675aa13c30 * buildtools/mac: git_revision:f19d5817e7ba85c2fda92e2697be11a4465d3267..git_revision:e05c0aa00938adc0797bda1e8f2c15675aa13c30 * buildtools/win: git_revision:f19d5817e7ba85c2fda92e2697be11a4465d3267..git_revision:e05c0aa00938adc0797bda1e8f2c15675aa13c30 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6d4ac13817..484f898366 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/db06f03d99..c1a0ba7fc3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/56ba67e870..2ee42b4fee * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/00915b6874..1ac3eb7b98 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/aff3a0b23c..b5fe27de93 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2d59d4ec48..a130f45ec4 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I0695ea23ec54fbd850eb862d1576303fb66c4864 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5334927 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 4d362242 2024-02-28T22:00:05 Vulkan: Remove call to angle::GetSystemInfo() This function is expensive, especially when it creates a temp VkInstance to query device info. It was only used to check if running on a Pixel device, but the information retrieved was to make a workaround slightly more precise. This change does away with that information and applies the workaround more generally. If the workaround precision is necessary, the necessary information should be retrieved directly without making the expensive angle::GetSystemInfo() call. Bug: b/327509734 Change-Id: Id097b427c59efde16a5811d484823b207c1a8917 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5331602 Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mohan Maiya cdf6220c 2024-02-25T05:12:21 Reland "Vulkan: Feature addition for QCOM foveated rendering extensions" This is a reland of commit 72cf9915f561ca6ca72fa4b6c84c36bba815bf29 In the reland, cache the sample counts as VkSampleCountFlags type and clamp framebufferColorSampleCounts with kSupportedSampleCounts Also evaluate supportsImagelessFramebuffer feature before evaluating supportsFoveatedRendering Original change's description: > Vulkan: Feature addition for QCOM foveated rendering extensions > > Add a new vulkan feature gating support for QCOM foveated rendering > extensions and cache shading rates and sample counts of Vulkan ICD. > > Bug: angleproject:8484 > Change-Id: Id2925541098a605749f93ad5a54c885f4a4a2c66 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5322317 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:8484 Change-Id: Ie831d27ecc0e1429a3fe365d7728f264496e234c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5328188 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya a971e5b4 2024-02-28T17:13:38 Account for zero vector axes in Mat4::Rotate(...) When the axis passed in to the Rotate function is (0, 0, 0), normalizing that vector will result in NaN values. Prevent this by returning an identity matrix and early out instead. Bug: angleproject:2306 Tests: MatrixBuiltinsTest.RotateAxisZero Change-Id: I65fd0b9944885daf56a4a35201d424e7f0aa9ba6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5333834 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 434a5b01 2024-02-28T19:00:26 Fix #2 upload_results_to_perf_dashboard usage Pass output_json_file name as an argument, instead of the open file. Bug: chromium:40807291 Change-Id: Ia0f52ff3b3a3551bcdcda235ebaa90ae217cea54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5332432 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 057db6ef 2024-02-26T10:59:20 Add ANGLE experimental S22 build and test Builders: android-arm64-exp-s22-test Testers: android-arm64-exp-s22 Bug: b/267953710 Change-Id: I28b1fe022589a2b75c90e26fc5e2aa7536b8138f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5324785 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov f8dac42e 2024-02-28T15:06:19 Fix upload_results_to_perf_dashboard usage Bug: chromium:40807291 Change-Id: I0a3ca2bfac1a29a9d56b6af15c5f123b0a41f817 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5332430 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
angle-autoroll dbbcf33e 2024-02-28T10:01:35 Roll vulkan-deps from 28960bf4a098 to f43c5512f6d7 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/28960bf4a098..f43c5512f6d7 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2c4348f064..b0df68c490 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/99a3ad32ff..fbc7a14b3e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d518edfc3c..5475f3d182 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f3f4b574d0..f0dacd0e25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ibcbd6efc59cc14870b9c025cdb34a9aeaf8e9b9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5328897 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d334a6f2 2024-02-28T07:00:56 Roll Chromium from cc3c5664ec19 to 579e74402476 (619 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cc3c5664ec19..579e74402476 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0d5608905c..dd4da8c1d8 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9eedca5b06..135784cc4b * buildtools/linux64: git_revision:5787e994aa4cb6cdb09c2c72ae6f1c6a7f1cf91a..git_revision:f19d5817e7ba85c2fda92e2697be11a4465d3267 * buildtools/mac: git_revision:5787e994aa4cb6cdb09c2c72ae6f1c6a7f1cf91a..git_revision:f19d5817e7ba85c2fda92e2697be11a4465d3267 * buildtools/win: git_revision:5787e994aa4cb6cdb09c2c72ae6f1c6a7f1cf91a..git_revision:f19d5817e7ba85c2fda92e2697be11a4465d3267 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c250128f4c..6d4ac13817 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6f4a0d6c87..56ba67e870 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4df61147ba..00915b6874 * third_party/fuchsia-sdk/sdk: 18.20240215.1.1..version:18.20240227.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/08b8dfd3a9..aff3a0b23c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/5b35c9f06c..204deaa9c5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ee25a45e79..5a776b1344 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/085f35d262..2d59d4ec48 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I51ab5b851eab837d9860f3f66e1ed5ea5c055b6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5328896 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brian Sheedy a627dd89 2024-02-27T19:00:07 Revert "Vulkan: Feature addition for QCOM foveated rendering extensions" This reverts commit 72cf9915f561ca6ca72fa4b6c84c36bba815bf29. Reason for revert: Causing crashes on Win/NVIDIA crbug.com/327027614 Original change's description: > Vulkan: Feature addition for QCOM foveated rendering extensions > > Add a new vulkan feature gating support for QCOM foveated rendering > extensions and cache shading rates and sample counts of Vulkan ICD. > > Bug: angleproject:8484 > Change-Id: Id2925541098a605749f93ad5a54c885f4a4a2c66 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5322317 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:8484 Change-Id: I45764d8119388fa2edb3e08825957fbc811b31a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5328729 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Liza Burakova 6eaaad7c 2024-02-27T21:24:59 Create ImageHelper. This CL adds a helper class ImageHelper, which acts as a wrapper on webgpu textures that will be used by TextureWgpu. Bug: angleproject:8547 Change-Id: Ia796534c9d3ff0dd24797cc483677cfcbedb1f8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5317864 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Alexey Knyazev 75c8ef1c 2024-02-22T00:00:00 Update cached component type masks on attachment redefinitions Added a new test: WebGL2ValidationStateChangeTest.AttachmentTypeRedefinition Fixed: angleproject:8556 Change-Id: I1535fba5467228076bb79ac2cc5530610d4ec747 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5318735 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mark Lobodzinski 6f2daf05 2024-02-26T16:31:58 Context: Limit max vtx uniform vectors to 256 during capture To ensure compatibility with Pixel 4/5, GL_MAX_VECTOR_UNIFORM_VECTORS should be set to 256 during capture. Bug: b/326199738 Change-Id: Ic7228322b4ed19949a9669cf0719fffa1a86f577 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5329326 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
angle-autoroll 2fb425d2 2024-02-27T10:26:28 Roll vulkan-deps from dd6c2371c85d to 28960bf4a098 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dd6c2371c85d..28960bf4a098 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2518af09c8..2c4348f064 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c3a9ffd74f..99a3ad32ff * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/71a1694c80..d518edfc3c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d7b134da10..f3f4b574d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I4b5862559272f4b65cedb2d678f5c25b6b472834 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5326619 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b0215166 2024-02-27T10:01:38 Roll SwiftShader from 0f69b790c7a4 to bbe6452b420c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/0f69b790c7a4..bbe6452b420c 2024-02-26 natsu@google.com Support ycbcr conversion linear filtering If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I37915b7905fbcc8c53024caa0b7249aa81bf2894 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5325907 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9100f2ec 2024-02-27T07:02:10 Roll Chromium from 16b5225bad88 to cc3c5664ec19 (580 revisions) https://chromium.googlesource.com/chromium/src.git/+log/16b5225bad88..cc3c5664ec19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4f4f9722eb..0d5608905c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/90b471f681..9eedca5b06 * buildtools/linux64: git_revision:03d10f1657b4ddace618c34ab61b6357d1ae9c9a..git_revision:5787e994aa4cb6cdb09c2c72ae6f1c6a7f1cf91a * buildtools/mac: git_revision:03d10f1657b4ddace618c34ab61b6357d1ae9c9a..git_revision:5787e994aa4cb6cdb09c2c72ae6f1c6a7f1cf91a * buildtools/win: git_revision:03d10f1657b4ddace618c34ab61b6357d1ae9c9a..git_revision:5787e994aa4cb6cdb09c2c72ae6f1c6a7f1cf91a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6678f5eec3..c250128f4c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4dc7721a14..6f4a0d6c87 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb43b5d82d..4df61147ba * third_party/fuchsia-sdk/sdk: version:18.20240215.1.1..18.20240215.1.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/5a3d13ed42..08b8dfd3a9 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a7b3d968a3..5b35c9f06c * third_party/turbine: s-hdujub30RR2mH9Qf7pHv6h9uNGEiYVs6W1VXWeEe8C..ZsrSMKpQt5d43K50XC1both1bFWzoloH6xOKYKZK_64C * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b3f541b36..6eeb10b9e5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/07c0c65a61..085f35d262 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I6ee8fd8498a5033f57089318c18bea002d12b839 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5325053 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi f0af4730 2024-02-26T21:16:02 Vulkan: Catch misuse of AddToPNextChain Bug: angleproject:8484 Change-Id: I02a9071509f68ad050a8abab25f11b9a8da53816 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5321049 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Mohan Maiya 72cf9915 2024-02-25T05:12:21 Vulkan: Feature addition for QCOM foveated rendering extensions Add a new vulkan feature gating support for QCOM foveated rendering extensions and cache shading rates and sample counts of Vulkan ICD. Bug: angleproject:8484 Change-Id: Id2925541098a605749f93ad5a54c885f4a4a2c66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5322317 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gregg Tavares 0afcac60 2024-02-22T11:21:15 Handle count = 0 in DrawElementsIndirect Bug: angleproject:8554 Change-Id: I9618061edf71c3d9a03ea14dfe65b54c58ee98de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5319131 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
Amirali Abdolrashidi 3c517e45 2024-02-14T14:26:42 Vulkan: Process ClearEmulatedChannels update first * When going through the level updates in flushStagedUpdates(), the ClearEmulatedChannels updates are expected to be before the rest. In addition, there can be only one such update in the level update list. Therefore, now they are processed and applied before the rest of the updates. By doing so, if this is the only update for the image, an unnecessary layout transition can be avoided. * Added flushStagedClearEmulatedChannelsUpdates(). * Added flushStagedUpdatesImpl() for the rest of the update types. * Used clipLevelToUpdateListUpperLimit() to limit the flush loops to the number of levels in subresource update list. * Added unit test to ensure updates after ClearEmulatedChannels are not ignored. * ImageTestES3.IncompleteRGBXAHBImportThenUploadThenEnd * The test contains a ClearEmulatedChannels followed by an image update. If the latter is ignored in this test, there is a failure during teardown due to orphanNonEmptyBufferBlock when destroying the buffer that contains the update. Bug: b/308455694 Change-Id: I53c73acb60a9c5440548886cde913112a664402d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5297317 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 38cc4cf0 2024-02-14T16:36:08 Vulkan: Update flushStagedUpdate to use switchcase * The if-else statements to check update type have been replaced with switch-case statements for more clarity. Bug: b/308455694 Change-Id: I3d5b77e697d342e77596fd177b2527ece4d228ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5297547 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Victor Shutemov 58c20052 2024-02-22T23:58:25 Fix build error when git history not fully available Can happen when using repo tool shallow copy or mirror features Return default commit_id instead of empty when history is not avaiable though git. Bug: angleproject:8553 Change-Id: Iddc1f0c3507a14c15292545f07223dd0e666a3f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5319504 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll d354c4dc 2024-02-26T17:13:44 Roll VK-GL-CTS from d15e5faec700 to d023c17ac299 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/d15e5faec700..d023c17ac299 2024-02-26 lorenzo@khronosgroup.org Notice of withdrawal of Vulkan CTS 1.3.5.x If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I94323f0519e71a955ab81a1b963deb28c5c36a3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5323728 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 425be99d 2024-02-26T10:01:02 Roll vulkan-deps from 602ab4120d74 to dd6c2371c85d (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/602ab4120d74..dd6c2371c85d Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1b643eac5d..c3a9ffd74f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e2642017ef..d7b134da10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I217329a5141c5650dbb3914c6b333760c9d88603 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5322533 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1fe63fec 2024-02-26T10:01:42 Roll SwiftShader from eb75201a4e03 to 0f69b790c7a4 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/eb75201a4e03..0f69b790c7a4 2024-02-23 swiftshader.regress@gmail.com Regres: Update test lists @ 7f4d495c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Id57efb4d96e3e8d2accfd86e7d56c4adec6f7c02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5323297 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 834ca37f 2024-02-26T07:54:21 Roll Chromium from b54ff9b1d5ed to 16b5225bad88 (644 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b54ff9b1d5ed..16b5225bad88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e36f984f6f..4f4f9722eb * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/88acf0de99..90b471f681 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/87bad53b08..6678f5eec3 * third_party/android_build_tools/manifest_merger: tQIUabJkFuwAI7BH20b0nn5fKWSPAa_M8cbkzpIW0VkC..ebz_Y3LqXzAa7YSsVInCAghbwoZuC4tySvJ1XPJLCzIC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/189b13f92e..4dc7721a14 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9d64acedea..cb43b5d82d * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1506720cb3..5a3d13ed42 * third_party/r8: ArRcmPYQPKnDIwdwwIr6T8QKNoFb-sQoKac2acxErbsC..XyJJ5GEKJUXldBnoKKraiUIjSbnXGqjNBcLoNuJvKccC * third_party/siso: git_revision:b52a6552a2e17e34b747fd5d29875fc4aba99da8..git_revision:8632c71c8cadd9cb9ea4d43e6b30eeae4dffcd12 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/74a1c50303..3787595bbb * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/acd6cf57ac..ee25a45e79 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1552db09d2..07c0c65a61 Clang version changed llvmorg-19-init-2319-g7c4c2746:llvmorg-19-init-2941-ga0b3dbaf Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/acd6cf57ac077a27e3eba00cf724a630bf613b99..ee25a45e79a534e8cf4546c10b317abc2a902d67/scripts/update.py Bug: None Tbr: syoussefi@google.com Change-Id: Ia3c6a12704a541c1f35b12933fab346f46d23795 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5322532 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi acba61cb 2024-02-23T17:13:17 Fix Vulkan driver version for Win/Intel * Updated the Vulkan renderer version for Windows/Intel to follow this format: <DriverMajor>.<DriverMinor> Bug: b/326669051 Change-Id: I41e868820ec351f454589cc33ed66a85669d3790 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5321166 Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev c758dc03 2024-02-22T00:00:00 GL: Adjust disableRenderSnorm condition The extension support for OpenGL ES contexts has been fixed in Mesa 23.3.0. Bug: angleproject:8315 Change-Id: I86f767fe24a2fa0c5f999969a29f52225ff1c4d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5321520 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6a88437d 2024-02-23T17:25:11 Roll VK-GL-CTS from cf5313984f57 to d15e5faec700 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/cf5313984f57..d15e5faec700 2024-02-23 aidan.fabius@coreavi.com Fix extended dynamic state tests for Vulkan SC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I3034ef70705b4193847779baf6f8e940581c8d6a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5320105 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll db886308 2024-02-23T10:15:11 Roll VK-GL-CTS from c402aa4fc1f1 to cf5313984f57 (7 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c402aa4fc1f1..cf5313984f57 2024-02-23 marcin.zajac@mobica.com Encode tests for video VK_KHR_video_maintenance1 2024-02-23 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-02-22 marcin.hajder@mobica.com Added KHR-GLESEXT.* to be part of mustpass 2024-02-22 robdclark@chromium.org Add missing subgroup support checks for linear derivate tests 2024-02-22 robdclark@chromium.org Use subgroups helper in derivate tests 2024-02-22 cturner@igalia.com Fix synchronization2 tests for video extensions 2024-02-22 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ifa35a9841dc4bf6532c1545423f0be6ed24d3b45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5320101 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bd1b918a 2024-02-23T10:01:09 Roll vulkan-deps from 004d9803b30c to 602ab4120d74 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/004d9803b30c..602ab4120d74 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/78e5d7976e..2518af09c8 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/675cc64f27..e2642017ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I7ed692fe313c34f3b3a045a70e507d48a6b47522 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5320100 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 33a33955 2024-02-23T07:00:45 Roll Chromium from cc824ffe820c to b54ff9b1d5ed (616 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cc824ffe820c..b54ff9b1d5ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/429da13a62..e36f984f6f * buildtools/reclient: re_client_version:0.131.1.784ddbb-gomaip..re_client_version:0.132.0.1a8ff94-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/37ce1e68ac..87bad53b08 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/60df7b9cbd..db06f03d99 * third_party/android_build_tools/lint: h9svnJ7PVwpadvxWMqfDD9NPFiJ4mbLravLcmBYueXgC..H3namO3zonlUj075eXGd_my1zHGpGDoXubhIWd9CG0EC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/49366de7c2..189b13f92e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03821aea69..9d64acedea * third_party/r8: azPjCe4AE6NDDqbEeSVqaz9YXQeKrH1tA3GyZ4TTRMYC..ArRcmPYQPKnDIwdwwIr6T8QKNoFb-sQoKac2acxErbsC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/03c356e4c1..74a1c50303 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4ec280bb4d..acd6cf57ac * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/610cbbc2e1..1552db09d2 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I208cb874405d63748b0032f1a577e9e94cb6feb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5319145 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Dan Glastonbury 5a4bfd61 2024-01-12T17:15:39 Metal: Separate struct definition from function return The EmitMetal pass in shader translator does not handle writing the defintion of a structure that is declared in the return type of a function, such as: struct Foo { float val; } foo() { ... } This change adds a new pass, SeparateStructFromFunctionDeclarations, to separate the definition and declaration of struct variables in function prototypes into two statements, such as: struct Foo { float val; } foo(); struct Bar { int val; } bar() { ... } void main() { ... } Foo foo() { ... } into: struct Foo { float val; }; Foo foo(); struct Bar { int val; }; Bar bar() { ... } void main() { ... } Foo foo() { ... } Fixed: angleproject:8302 Change-Id: Id8b6ba256d3c8375dd889facd70e4715261c1ca3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5191644 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7f29c703 2024-02-22T10:01:32 Roll vulkan-deps from b040470c0fde to 004d9803b30c (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b040470c0fde..004d9803b30c Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dc6676445b..1b643eac5d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/36c166d6b9..675cc64f27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Id7adfb6d0e00d2a2e3cb1f9521efc6b49cd4a5ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5315062 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b06dbffd 2024-02-22T07:00:15 Roll Chromium from 5f0b8ba66cd4 to cc824ffe820c (635 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5f0b8ba66cd4..cc824ffe820c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/33cc0d5080..429da13a62 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ae5d810433..88acf0de99 * buildtools/linux64: git_revision:0cdb7dd27f5cbafb31704a5d849efe17ef2a0acc..git_revision:03d10f1657b4ddace618c34ab61b6357d1ae9c9a * buildtools/mac: git_revision:0cdb7dd27f5cbafb31704a5d849efe17ef2a0acc..git_revision:03d10f1657b4ddace618c34ab61b6357d1ae9c9a * buildtools/win: git_revision:0cdb7dd27f5cbafb31704a5d849efe17ef2a0acc..git_revision:03d10f1657b4ddace618c34ab61b6357d1ae9c9a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/28ae5b226c..37ce1e68ac * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/14d1e3676b..c55fe19074 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/ad0b8e7a0e..3cadb17300 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d64859bbfb..49366de7c2 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7dc148fe3c..03821aea69 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0285388fda..1506720cb3 * third_party/r8: juyH-99YkP1rnGZuGXrBKk4A3PjColdhrthOaV5_dC0C..azPjCe4AE6NDDqbEeSVqaz9YXQeKrH1tA3GyZ4TTRMYC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4b5807f344..03c356e4c1 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/84dacdbf12..77a2b7ff01 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ebfc67baf1..4ec280bb4d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e286b9d919..3b3f541b36 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/78c79e3eb9..610cbbc2e1 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: If9c66e0ad8f5c60068cb0a4279d51f0f1e690347 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5313633 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Dave Tapuska cd63c5d4 2024-02-21T14:36:57 Fix build failures targetting iOS 17.4 Add ifdefs to not use deprecated APIs. Bug: chromium:40254930 Change-Id: Id2155e5014558d0c62654cec01ee32119123037c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5315376 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Mark Lobodzinski 8c503c1b 2024-02-21T09:37:06 Add skip for 07753 validation error in trace Running Pokemon Masters Ex game on Android generates the validation error VUID-vkCmdDraw-format-07753. Update the SkippedMessages list to avoid trace failures. Test: angle_trace_tests --gtest_filter=*pokemon_masters_ex Bug: b/319228278 Change-Id: I8ffbb8c6f35ef3fead583be1b8f0b96d85c7ea12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5313836 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Gowtham Tammana bcf814fd 2024-02-02T10:30:34 Vulkan: Constrain the dependency on ContextVk in BufferHelper Make the BufferHelper interface be not dependent on ContextVk state. This makes the interface to be suitable for implementation of other APIs with Vulkan backend. Any dependency on ContextVk is made explicit and handled in ContextVk. Bug: angleproject:8544 Change-Id: I8b285f54c8758a26dd7edf27b1371f9afcf7e241 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5303573 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll f43b9f87 2024-02-21T10:01:40 Roll vulkan-deps from 5fa0abb9413b to b040470c0fde (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5fa0abb9413b..b040470c0fde Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/8ca24e7cf1..78e5d7976e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/93e182977b..36c166d6b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I10077baa0f8f01730ca752a24aff06495215b4d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5311251 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0f6386a8 2024-02-21T07:02:20 Roll Chromium from 98827507560a to 5f0b8ba66cd4 (624 revisions) https://chromium.googlesource.com/chromium/src.git/+log/98827507560a..5f0b8ba66cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/af425e050d..33cc0d5080 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/36dc95f27a..ae5d810433 * buildtools/linux64: git_revision:d4f94f9a6c25497b2ce0356bb99a8d202c8c1d32..git_revision:0cdb7dd27f5cbafb31704a5d849efe17ef2a0acc * buildtools/mac: git_revision:d4f94f9a6c25497b2ce0356bb99a8d202c8c1d32..git_revision:0cdb7dd27f5cbafb31704a5d849efe17ef2a0acc * buildtools/win: git_revision:d4f94f9a6c25497b2ce0356bb99a8d202c8c1d32..git_revision:0cdb7dd27f5cbafb31704a5d849efe17ef2a0acc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c9981e7bae..28ae5b226c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d02875c9cb..60df7b9cbd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9cb2dc6f1b..d64859bbfb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/280bb93210..7dc148fe3c * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/834e97d73f..0285388fda * third_party/r8: h_Nyj61z-U6meQbvpjcxE8NoosFmfjJ_VobRAFrNCjYC..juyH-99YkP1rnGZuGXrBKk4A3PjColdhrthOaV5_dC0C * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ba160132eb..78c79e3eb9 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Icd275ec4db43e331fd45a6c1473c40b58f6bd6f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5309437 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski f546983c 2024-01-30T13:39:27 Add test and skip for 07753 validation error Running Pokemon Masters Ex game on Android generates the validation error VUID-vkCmdDrawIndexed-format-07753. This CL adds the TexImageFormatMismatch test to reproduce the error and updates the SkippedMessages list to avoid test failures. Test: angle_end2end_tests --gtest_filter=*TexImageFormatMismatch* Bug: b/319228278 Change-Id: I6ee2cac0bc899e945ef0d4aff33d5e73299c6954 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5309857 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Shahbaz Youssefi 8346addb 2024-02-06T15:40:31 Contain X11 includes and free usage of common terms This change undoes workarounds where some terms were avoided so there is no clash with X11 (such as Success, Bool and None). In particular, this helps us make sure we never include the X11 headers in such an unconstrained manner as to clash with our code. Bug: angleproject:8520 Change-Id: I53d9657c5a33164064d2c80a206b96fd52f607f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5273491 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org>
Geoff Lang 1ee04579 2024-02-20T14:53:46 Metal: Re-enable asm inejction into loops on MacOS 12+ It was confirmed that this asm injection caused issues on MacOS 11. Bug: chromium:1513738 Change-Id: I37e3af83b83de0cd447e1ff71b1f41ab755f8d4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5309225 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 21c0d31c 2024-01-25T15:33:48 OpenCL: Only build clspv for Vk backend Helps reduce build overhead for only building LLVM/clspv when needed. Mainly for users just wanting CL passthrough mode only. Bug: angleproject:8548 Change-Id: I470f56a6282ccb5f5a54df5f61719301205c7e18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5237742 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Geoff Lang b7bacdb7 2024-02-15T11:14:21 GL: Generate mipmaps through draw calls on Pixel7/Pixel8. Some patterns that use a texture as a framebuffer attachment and then generate mipmaps on that texture multiple times cause context loss or driver hangs. Extend the sRGB mipmap generation to also generate mipmaps on non-SRGB textures using draw calls and linear samplers to do the downsampling. Bug: chromium:40279678 Change-Id: I19c6bf9c702ddf2c400ef03ff076fbd4cf15d285 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5297413 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 2b1ef00a 2024-02-20T15:45:34 Metal: Fix validation for anonymous struct arrays Fix validation failure for accessing an element of array of anonymous struct. SeparateCompoundStructDeclarations would create new Structures to name unnamed structures. The Structure instance of the array index accessor node was incorrect, it was the old Structure. Use same pattern as in SeparateStructFromUniformDeclarations. Bug: angleproject:8551 Change-Id: I04684e5ad99cc2b9038a0cc21c7eefcc6cf247df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5310074 Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Austin Annestrand 19e21b1e 2024-01-11T14:38:49 OpenCL/Vulkan: Add initial support for cmdQueue Introduce OpenCL command queue object creation for Vulkan backend in ANGLE. Bug: angleproject:8500 Change-Id: I08a63e91aa0ee75dd2be00c770f521c43a3f83b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5233367 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Liza Burakova f4d5644c 2024-02-16T18:13:18 Instantiate dawn backend in angle_end2end_tests Bug: angleproject:8485 Change-Id: I07a5c5c221c6b50b839929a824753a662aa163f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5286835 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
angle-autoroll b7d0a18b 2024-02-20T10:01:19 Roll vulkan-deps from 13783d616289 to 5fa0abb9413b (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/13783d616289..5fa0abb9413b Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/d84255296c..8ca24e7cf1 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/aecbb2079c..71a1694c80 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/36b61e748d..93e182977b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ic2a782258f35ce977ffcfd0f0d3fc6446bff33cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5307026 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9f16b585 2024-02-20T07:00:12 Roll Chromium from 2905059a5737 to 98827507560a (299 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2905059a5737..98827507560a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e5cf1b3ceb..af425e050d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/af7ef4774c..36dc95f27a * buildtools/linux64: git_revision:0a2b8eac80f164f10b2cbc126890db0d295790cd..git_revision:d4f94f9a6c25497b2ce0356bb99a8d202c8c1d32 * buildtools/mac: git_revision:0a2b8eac80f164f10b2cbc126890db0d295790cd..git_revision:d4f94f9a6c25497b2ce0356bb99a8d202c8c1d32 * buildtools/win: git_revision:0a2b8eac80f164f10b2cbc126890db0d295790cd..git_revision:d4f94f9a6c25497b2ce0356bb99a8d202c8c1d32 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f61639acca..c9981e7bae * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f1c5751a2c..d02875c9cb * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9d7c8e76f8..280bb93210 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a4df104173..ebfc67baf1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2d97f0da52..ba160132eb Clang version changed llvmorg-18-init-17730-gf670112a:llvmorg-19-init-2319-g7c4c2746 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/a4df104173dae7d49205ed8abefc920b7c5162d2..ebfc67baf110c1cf28e77ad520dc9d371ad27913/scripts/update.py Bug: None Tbr: syoussefi@google.com Change-Id: If0a43355f79f73704ad0521bce3acce3bd1b91ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5308455 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e17dd5a4 2024-02-19T10:01:18 Roll vulkan-deps from 063ea20a64fc to 13783d616289 (25 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/063ea20a64fc..13783d616289 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9fd0fcd737..d84255296c * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/d3c2a6fa95..05cc486580 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f9184c6501..dc6676445b * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/5ac36269f5..31aa7f634b * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/e0d594e05b..aecbb2079c * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d7db171ca5..069bd14c05 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/86de0a0a9d..1b8b60bf7f * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1518a84bb7..36b61e748d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I248add08bc3ab2ad185e494c4bc28010da08efaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5307014 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e3badd04 2024-02-19T07:01:06 Roll Chromium from 9d4a35b46e1e to 2905059a5737 (725 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9d4a35b46e1e..2905059a5737 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a11ae4664a..e5cf1b3ceb * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f35a7d885a..af7ef4774c * buildtools/linux64: git_revision:8b973aa51d02aa1ab327100007d4070c24b862b0..git_revision:0a2b8eac80f164f10b2cbc126890db0d295790cd * buildtools/mac: git_revision:8b973aa51d02aa1ab327100007d4070c24b862b0..git_revision:0a2b8eac80f164f10b2cbc126890db0d295790cd * buildtools/win: git_revision:8b973aa51d02aa1ab327100007d4070c24b862b0..git_revision:0a2b8eac80f164f10b2cbc126890db0d295790cd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5e8f58ef80..f61639acca * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/984707e65c..f1c5751a2c * third_party/android_build_tools/lint: Hgob1AcE3OjuqT1wUs6DioB-Vfs96VKmh1vKON4ujigC..h9svnJ7PVwpadvxWMqfDD9NPFiJ4mbLravLcmBYueXgC * third_party/android_build_tools/manifest_merger: DEhOvoBwWVbV8XAI9NG-tn5g27KeMh2pXa44mY4dY10C..tQIUabJkFuwAI7BH20b0nn5fKWSPAa_M8cbkzpIW0VkC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3d6c15240b..9cb2dc6f1b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1b1a43f07..9d7c8e76f8 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9d119c1f4a..834e97d73f * third_party/r8: f7pPpoVTaC3WoBY5dURVrI-N1_4YZpSYipdiDUeWDAEC..h_Nyj61z-U6meQbvpjcxE8NoosFmfjJ_VobRAFrNCjYC * third_party/siso: git_revision:4bede4f49669d3a8bdaa8dbd01620c3a07ae0c4e..git_revision:b52a6552a2e17e34b747fd5d29875fc4aba99da8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/47756615f5..a4df104173 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/68fa723131..e286b9d919 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1972d63ee9..2d97f0da52 No update to Clang. Bug: angleproject:7109 Tbr: geofflang@google.com Change-Id: I61ef5dc7c18bfc35ef14547a14d2294e7f031849 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5305557 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya e04b7c73 2024-02-17T10:42:56 Vulkan: Expand feature to enable sample usage for all AHBs Rename forceSampleUsageForImageWithExternalFormat to forceSampleUsageForAhbBackedImages and expand scope to force enable VK_IMAGE_USAGE_SAMPLED_BIT usage flag for all AHB images irrespective of the AHB usage requested by the app. Bug: b/155487768 Change-Id: I81cc4b705339b6ff00d187faf37f66d1be1a2c8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5304997 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana e08e82b6 2024-01-31T20:48:14 CL: On kernel arg validation use right sizes The OpenCL C type `sampler_t` and `queue_t` map to API types `cl_sampler` and `cl_command_queue`[1]. Confirm the size checks accordingly. [1]: https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_C.html#other-built-in-data-types Bug: angleproject:8543 Change-Id: Ia833561e2373ab32dd62271dfc515d7ea779c81a Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5299720 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 9d453e57 2024-02-16T22:28:18 Fix ASSERT in non-global precise var decls Precise was treated as invariant. Precise can be declared for non-global variables. Bug: angleproject:8550 Change-Id: Ia0d00d67d0d1504b78294ee2256785fe3da3e399 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5300976 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll bde26cc4 2024-02-16T17:21:16 Roll VK-GL-CTS from b9ec0d4bdf99 to c402aa4fc1f1 (13 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b9ec0d4bdf99..c402aa4fc1f1 2024-02-16 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-02-15 lorenzo@khronosgroup.org Update external dependencies 2024-02-15 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-02-15 pkohaut@nvidia.com Add sparse memory rebinding tests 2024-02-15 ziga@lunarg.com Test optimalTilingLayoutUUID in host image copy is not 0 2024-02-15 syoussefi@google.com Add a VUID skip list 2024-02-15 ziga@lunarg.com Add shader object tests unbinding different shaders 2024-02-15 mateusz.bahyrycz@mobica.com Tests for lines with adjacency 2024-02-15 gleese@broadcom.com Add testing for R16_UNORM for min/max filtering 2024-02-15 xin.yuan@arm.com Fix the precision loss issue in native d16 2024-02-15 pdaniell@nvidia.com Fix logging bugs with line rasterization tests 2024-02-14 lorenzo@khronosgroup.org Generate vkKnownConformanceVersions.inl for Vulkan and Vulkan SC as two different files 2024-02-14 gleese@broadcom.com Improve buffer view testing for A8 formats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I86cfd89fc6e03e4e0789a54f7fac3d642ea662f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5303561 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 37287687 2024-02-16T10:50:14 Android: support running angle_unittests via android_helper Allows to run: 1) locally via run_angle_android_test.py, ex: % (cd out/AndroidPerformance; ../../src/tests/run_angle_android_test.py --suite=angle_unittests --list-tests --log=debug) 2) on bots via swarming trigger, ex: % tools/luci-go/swarming trigger {usual_args_and_dimensions} -- vpython3 ../../testing/test_env.py ../../src/tests/angle_android_test_runner.py gtest --output-directory=. --suite=angle_unittests --list-tests --log=debug Bug: chromium:325124206 Change-Id: I61c4e10df349a60b1ff79694bdcdac40a40d12e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5301624 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Hans Wennborg a6616081 2024-02-16T17:22:33 Add missing include The _byteswap* functions are declared in stdlib.h on Windows. Until recently, libc++ would provide that as part of some other header, but that changed in recent versions. Bug: chromium:325103513 Change-Id: Ie4240a3e0eab4421d9ad60f7e4f6f2f8754d47ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5300975 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org>
Austin Annestrand af56ca61 2024-01-11T13:14:32 OpenCL/Vulkan: Initial support for context Introduce OpenCL context object creation for Vulkan backend in ANGLE. Bug: angleproject:8499 Change-Id: I56794649c87d5cf1490e496525e6534c8f90ce32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5233366 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
angle-autoroll 298abbc1 2024-02-16T08:50:43 Roll Chromium from 29bec8631d2f to 9d4a35b46e1e (1220 revisions) Amend the roll with http://crrev.com/c/5301614 courtesy agrieve@. https://chromium.googlesource.com/chromium/src.git/+log/29bec8631d2f..9d4a35b46e1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2cece96e17..a11ae4664a * buildtools/linux64: git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa..git_revision:8b973aa51d02aa1ab327100007d4070c24b862b0 * buildtools/mac: git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa..git_revision:8b973aa51d02aa1ab327100007d4070c24b862b0 * buildtools/win: git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa..git_revision:8b973aa51d02aa1ab327100007d4070c24b862b0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c37870b5fd..5e8f58ef80 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d353dfb095..984707e65c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f39e9d8c1a..ad0b8e7a0e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/51589f432d..3d6c15240b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a5a09d23fa..b1b1a43f07 * third_party/fuchsia-sdk/sdk: version:18.20240207.3.1..version:18.20240215.1.1 * third_party/r8: tp4vVuXzmyHJxDFlwxDb7RYZLLEufc3EnGTyOTCTNkgC..f7pPpoVTaC3WoBY5dURVrI-N1_4YZpSYipdiDUeWDAEC * third_party/siso: git_revision:3cd0e6e55246b8eca6646e33b124e54e67fc5660..git_revision:4bede4f49669d3a8bdaa8dbd01620c3a07ae0c4e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/894ad691c6..47756615f5 No update to Clang. Bug: angleproject:6081, chromium:324916799 Change-Id: Ib097e6dca9374111632838beab4f0224ff6196fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5302166 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 3ca8befb 2024-02-14T12:35:08 Vulkan: Handle multi-context apps in pipeline cache graphs Append a monotonically increasing counter to filename so apps and benchmarks with multiple contexts don't clobber each others files. Bug: angleproject:6565 Change-Id: I5c781895e1ec8cc65728aa752e28fb2acb02abe9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5297288 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya 6607a2b9 2024-01-17T15:58:20 Vulkan: Add support for VK_EXT_vertex_input_dynamic_state Hook into VK_EXT_vertex_input_dynamic_state so pipeline states that differ only in vertex input state can reuse existing pipelines. Bug: angleproject:7162 Tests: StateChangeTestES3.Vertex* Change-Id: Icd3134dee93fc5fc2e9d284fcfa8c674b62faec8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5207462 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Liza Burakova bff0b1e4 2024-02-15T18:22:12 Change enum value for webgpu to unused value. Bug: angleproject:8476 Change-Id: I62c2d6d6dc0bf2125e0be9ae9a7205f46e9fc871 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5301496 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 6d4706bf 2024-02-15T14:03:45 WGPU: Add a angle_dawn_dir build override. This will allow Chromium to point out the dawn directory to ANGLE and disable the WebGPU backend if dawn does not exist. Bug: angleproject:8477 Change-Id: I5191b33dcf64ec1694f7be4ccc855b27d6fd0f76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5301615 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi aa244358 2024-02-06T14:44:39 Reland "Vulkan: Get rid of X11 include in DisplayVkXcb.cpp" This is a reland of commit 8abbe2836bb49faba8a97e2df59058290e1c385a In the reland, the xcb-util dependency is removed. Original change's description: > Vulkan: Get rid of X11 include in DisplayVkXcb.cpp > > Bug: angleproject:8520 > Change-Id: Iaa251b0ba2858873b8d22e8f9e5dae7a2567c95e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5273489 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: angleproject:8520 Change-Id: I238e0a6c3b94398c10fa1bc39c5a0b4261797311 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5292774 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 6d589ff6 2024-02-12T15:26:54 Trace perf: support custom thermal throttling for tests Vendor throttling kicks in rather quickly and starts affecting e.g. cpu/gpu freqs, which can be hard to predict and increases variance in our tests. This change implements support for disabling vendor throttling (re-enabled at the end, including ctrl-C) and using a custom temperature threshold for VIRTUAL-SKIN sensors, which are checked after each test runs. This allows to set the threshold to higher values and run the device hotter without touching cpu/gpu freqs while running tests, and then dissipate heat (if necessary) by sleeps between tests. This also allows to reduce fixed-time sleeps between tests as we're monitoring the temperatures. Only some of our trace tests heat up the device sufficiently to actually require throttling, and with active cooling I was able to avoid sleeps almost through the entire run. However, sleeps might also be needed to prevent battery from discharging, so also add a flag to sleep until a given battery level is reached after each test. Example usage, sleeping between tests until all sensors are below 39C but also battery level is at least 30%: --custom-throttling-temp=39 --min-battery-level=30 Bug: b/315042901 Change-Id: I7660fc36b1103e20e4cc97312d396f3667739481 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288455 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi ec2603d6 2024-02-14T13:02:35 Fix build in absence of SSE support Bug: angleproject:8536 Change-Id: Ic74c775b9291fb6bb75adcaeeab0a5f01c2cfa3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5296385 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi b380ed1f 2024-02-14T09:31:26 Vulkan: Add EGL_ANGLE_global_fence_sync Chrome has an implicit assumption that due to context virtualization, signaling a fence in one context results in synchronization with _all_ contexts that have previously made submissions. This is not per EGL spec, but the functionality is easily implementable in the Vulkan backend. In the Vulkan backend, each context is given its own "timeline" of submissions (tracked by serials associated with "indices"). The required functionality is implemented through a new EGL fence sync object whose sole difference is that it synchronizes with all the existing timelines rather than the one of the current context. Bug: b/318721705 Change-Id: I6c45d065e592d0d4ed627ce9695196b1086d5021 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5297396 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 40dfb3a8 2024-02-12T00:00:00 Fix length() translation for clip/cull distance arrays * Fixed a failing assertion when the arrays are resized. * Added a compile error for length() when the arrays are unsized. Fixed: angleproject:8527 Change-Id: I6379336c546b008095f0875e5b5b4e8e0e5ba3e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5293914 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen d6ceac91 2024-02-12T20:37:58 Metal: Add support for binding slices to images Add support for binding Metal MTLTextureType2DArray texture slices to EGL images. Bug: angleproject:8531 Change-Id: I938e75c81bf36d3885f3bdcb0d1007e1f87e20c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5290374 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 195c142d 2024-02-14T15:09:54 GLSL test for side effects in prune-able loop Bug: angleproject:8532 Change-Id: Ie872e957b78454d725575b05721f9b3f213889f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5297407 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Liza Burakova e8a3493f 2024-02-14T21:51:00 Initialize DisplayWgpu This change adds basic initialize to DisplayWgpu as well as adding APIs for DisplayGLX and DisplayWgpu. These APIs are necessary to ensure DisplayWgpu doesn't pull in necessary X11 headers that break builds. Bug: angleproject:8477 Change-Id: Icc6d9e7246a741def7a0337a296f9c1f9cec1415 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5259979 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Shahbaz Youssefi 2cae27c2 2024-02-14T10:38:18 Vulkan: Enable the doubleDepthBiasConstantFactor feature on NV Experimentally found to make behavior more consistent with other platforms. Discovered through a Dawn issue [1]. [1]: https://bugs.chromium.org/p/dawn/issues/detail?id=2076 Bug: b/249380591 Change-Id: I27777397d717da0d400b9e15508b17b5329e1e8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5296380 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 197beb4d 2024-02-13T15:47:32 Metal: Crash if for loop body is optimized away Loops might have their bodies optimized away. For case like `for(;;) if(false);` the constant pruning happens at parse phase. The else branch (e.e. no else branch, nullptr) would be selected as the body. Some code treated the body as optional, some code treated it as required. Define it as required, and remove all conditional code related to the loop body. Bug: angleproject:8532 Change-Id: Ic35f1bf78e63ceb2cee7b96ba99e788efc282e6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5291554 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi dbc6bd9d 2024-02-12T14:07:49 Reland "Vulkan: Fix alignment issues with SecondaryCommandBuffer" This is a reland of commit e53270c9ca1afe393d6d7d0359e81cf6755b6ca5 Original change's description: > Vulkan: Fix alignment issues with SecondaryCommandBuffer > > This solves undefined behaviour on 64-bit systems. This inflates the > size of a few commands, but most commands either already did align to 8 > bytes or could be aligned to 8 bytes with a few tweaks. > > Bug: angleproject:7852 > Change-Id: Ie61976d5bf8df7790acd95c0e15d4c79402622a1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288636 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7852 Change-Id: Ie206e66fc21c5db7c9e67eb478d9cddada5db8e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5296376 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Austin Annestrand c673c837 2024-01-08T19:05:38 OpenCL/Vulkan: Initial support for platform/device Introduce OpenCL platform and device object creation for Vulkan backend in ANGLE. Bug: angleproject:8498 Change-Id: I5af9a23ed343648115bd9f0e81cd7a53080e2982 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5233365 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen b8e56d5d 2023-11-20T15:41:44 Fix an assert when overwriting TexImage binding Fix an assert when overwriting a image binding with multiple eglBindTexImage calls on the same texture. Bug: angleproject:8521 Change-Id: Ie7247017fd73c523b889278ec19a09ecf0683692 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5272912 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 243f8ad9 2024-02-14T11:44:58 Revert "Vulkan: Fix alignment issues with SecondaryCommandBuffer" This reverts commit e53270c9ca1afe393d6d7d0359e81cf6755b6ca5. Reason for revert: breaks x86 Android build: https://chromium-review.googlesource.com/c/chromium/src/+/5293321 https://ci.chromium.org/ui/p/chromium/builders/try/android-x86-rel/144329/overview Original change's description: > Vulkan: Fix alignment issues with SecondaryCommandBuffer > > This solves undefined behaviour on 64-bit systems. This inflates the > size of a few commands, but most commands either already did align to 8 > bytes or could be aligned to 8 bytes with a few tweaks. > > Bug: angleproject:7852 > Change-Id: Ie61976d5bf8df7790acd95c0e15d4c79402622a1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288636 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7852 Change-Id: Id9c7a94ccc12816bc9e8c3803bd940550d9f7953 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5295854 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 7490ad4d 2024-02-14T10:01:43 Roll vulkan-deps from 2cedf06e4cdf to 063ea20a64fc (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2cedf06e4cdf..063ea20a64fc Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/47a02a987c..9fd0fcd737 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b7413609cf..f9184c6501 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I3c97ae6df114b8ea747fd8052e15e2a3cd2a9e8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5295018 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d8340c15 2024-02-14T07:00:53 Roll Chromium from b650d7fcd665 to 29bec8631d2f (631 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b650d7fcd665..29bec8631d2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a301b4f2a6..2cece96e17 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e6b0b51699..c37870b5fd * third_party/android_build_tools/lint: KBVVjzxe9TcHEv-JSKko21bFKEolQZXJDvUREjbrrlkC..Hgob1AcE3OjuqT1wUs6DioB-Vfs96VKmh1vKON4ujigC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/99cae5876c..51589f432d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f76550541c..a5a09d23fa * third_party/kotlin_stdlib: 7f5xFu_YQrbg_vacQ5mMcUFIkMPpvM_mQ8QERRKYBvUC..-uFeIws_FQzyqmgZlGL37ooRLAD8mwClD33O8rZwnTsC * third_party/r8: szZgxadOOC_Yfq3DhP5R0WR2LMRiVMVrt71WNfL5taIC..tp4vVuXzmyHJxDFlwxDb7RYZLLEufc3EnGTyOTCTNkgC * tools/luci-go: git_revision:c7b026b3a6a1f877ce46a90c5f761b10e5149891..git_revision:3df60a11d33a59614c0e8d2bccc58d8c30984901 * tools/luci-go: git_revision:c7b026b3a6a1f877ce46a90c5f761b10e5149891..git_revision:3df60a11d33a59614c0e8d2bccc58d8c30984901 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/50b5d62710..1972d63ee9 * tools/skia_goldctl/linux: 8xvDLWxU0ipGlMbwh07HD9us6YUasvqj9enFMIhuA5YC..zK5gXUdYtOJO_5L0VqpL13_iPtatoApMRsbAJ-AObycC * tools/skia_goldctl/mac_amd64: 4QY9kfg-XVCCc4fSkPGACm8r2hA_QhxFcrmJG4qyzEgC..I77LRdzh6aOopDPydG6LuPfDh6BbH4IFqWH8WWesWlMC * tools/skia_goldctl/mac_arm64: 4dKQux2uWzdVCj0jAeSf4toiJ2pvSwH0ElDobPMlryEC..JRekXzEdC8R2yKoqGJvHhZ516qC1pJwyHAxOuqTyDREC * tools/skia_goldctl/win: H7jFTr_bQujHnqv-ThbCTD9kI56AeRAoAWaewJIdqcwC..fWJiw3sBoMGqR2SS2otkCsOmnqK4iXZUWzTVfqw0cssC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I4c44be29a159375dde8f3a08c2b136941f041c68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5295017 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e53270c9 2024-02-12T14:07:49 Vulkan: Fix alignment issues with SecondaryCommandBuffer This solves undefined behaviour on 64-bit systems. This inflates the size of a few commands, but most commands either already did align to 8 bytes or could be aligned to 8 bytes with a few tweaks. Bug: angleproject:7852 Change-Id: Ie61976d5bf8df7790acd95c0e15d4c79402622a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288636 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e45b2fd8 2024-02-08T12:34:06 Vulkan: Implement ANGLE_translated_shader_source Support for this extension was dropped when ANGLE generated SPIR-V directly. Generating disassembled SPIR-V is not ideal as it incurs a large binary size. The online SPIR-V tool found at https://www.khronos.org/spir/visualizer/ is capable of disassembling SPIR-V from hex values. ANGLE now implements this extension by outputting the SPIR-V in hex values and relying on this tool. Bug: angleproject:8523 Change-Id: I1a0529785147acee7b49a7a75b24f7d107ef690c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5278566 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Andrew Grieve d9665098 2024-02-12T13:53:32 Do not use hardcoded ".cr.so" extension for android component builds This will enable me to remove the extension for component builds Bug: chromium:324916799 Change-Id: I20bd8f93706d182fe6ebb3022240f81fec9de449 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5287577 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Kimmo Kinnunen 9d344b5c 2024-02-13T17:54:12 Uniform block reference in constuctors crash Passing uniform block instance name to a built-in constructor would cause type confusion. Block this by failing to parse. Bug: angleproject:8533 Change-Id: I5a676b41e2f3d766ece4ed472debc1c874753293 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5290897 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll ebc151d5 2024-02-13T10:01:46 Roll vulkan-deps from 4985acbd814d to 2cedf06e4cdf (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4985acbd814d..2cedf06e4cdf Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/30661abd9c..47a02a987c * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/e77d03080b..d3c2a6fa95 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a8959dc653..b7413609cf * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/f24bab1ea1..d7db171ca5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9d00ae6c66..1518a84bb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ifeaf7a94711a34e7bba8bdfe84e22594197235f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5287952 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2cbf6613 2024-02-13T07:05:09 Roll Chromium from 3009d13b1e1a to b650d7fcd665 (3044 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3009d13b1e1a..b650d7fcd665 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f4542781a5..a301b4f2a6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d1fe4728f6..f35a7d885a * buildtools/reclient: re_client_version:0.130.0.546556b-gomaip..re_client_version:0.131.1.784ddbb-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c64b78ce9e..e6b0b51699 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d391aa34a6..d353dfb095 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/f349efeefb..14d1e3676b * third_party/android_build_tools/manifest_merger: xxtHLi-sldjnrAZqfTewA7Ai7T_i46GDTkbeOQm4Da4C..DEhOvoBwWVbV8XAI9NG-tn5g27KeMh2pXa44mY4dY10C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b03f3ff6f4..f39e9d8c1a * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/4d99ea187e..8c00b6678c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f092a8625f..99cae5876c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0696c428b0..f76550541c * third_party/fuchsia-sdk/sdk: version:18.20240127.1.1..version:18.20240207.3.1 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/e2247b3708..ebabc6deb7 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/e2d024354e..c9c77525ea * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/3c2f3884e6..9d119c1f4a * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/fb278689d9..a7b3d968a3 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/fc505746f0..8bad7bd6ec * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/0bad08bb20..e582d7f0ed * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/e1ae7a6663..af720261b5 * third_party/r8: yr6NtXUFlwC0IMXpA-KKdgva5QQ8ME9lm0LD3wz3lSQC..szZgxadOOC_Yfq3DhP5R0WR2LMRiVMVrt71WNfL5taIC * third_party/turbine: 7NPeRX_XAc2XOUX7V9moyIEyM8RjjPdAhRK-8DLzk_oC..s-hdujub30RR2mH9Qf7pHv6h9uNGEiYVs6W1VXWeEe8C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/646b7f5697..4b5807f344 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b9d6e4a6ed..84dacdbf12 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d5858b5684..894ad691c6 * tools/luci-go: git_revision:0d11be367258bfe14a13ff1afcf43a0bc6aedb45..git_revision:c7b026b3a6a1f877ce46a90c5f761b10e5149891 * tools/luci-go: git_revision:0d11be367258bfe14a13ff1afcf43a0bc6aedb45..git_revision:c7b026b3a6a1f877ce46a90c5f761b10e5149891 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0f0ac05e41..68fa723131 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6dfec558a0..50b5d62710 * tools/skia_goldctl/linux: 407H-TbIdlUjRbGWaMLTbSuhauPqvPICdysGuqJvZwUC..8xvDLWxU0ipGlMbwh07HD9us6YUasvqj9enFMIhuA5YC * tools/skia_goldctl/mac_amd64: lkI4UMXstA7DR9LqFykhbBB0sT-pbajdPVIN8nO1xCwC..4QY9kfg-XVCCc4fSkPGACm8r2hA_QhxFcrmJG4qyzEgC * tools/skia_goldctl/mac_arm64: lhItSTy1WLT7ZDUaklin1sNQ2vdQFPwVcEKC5gRty-4C..4dKQux2uWzdVCj0jAeSf4toiJ2pvSwH0ElDobPMlryEC * tools/skia_goldctl/win: 14DPIsHsHs60_8PzIoLPiLesYnsN_0qV7RUmyNCr3zMC..H7jFTr_bQujHnqv-ThbCTD9kI56AeRAoAWaewJIdqcwC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I617a02dfad21dc0bf06b1bf6fe720983b92a49c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288948 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev cb7d3cc2 2024-02-09T00:00:00 Treat clip/cull distance built-ins as having side effects The sizes of these built-in arrays may be affected by indexing them with constant integral expressions so such operations should not be optimized out. Fixed related failures during MSL and HLSL translation. Fixed: angleproject:8525 Change-Id: I8460aa03b997ebc4142ee2d9f81eeefe13661336 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5285436 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Liza Burakova e784b1ec 2024-02-09T16:23:17 Manual roll dawn This change rolls dawn to add an upstream change that sets a clang flag in non-chromium builds of dawn. ANGLE needs this flag in order to build dawn native. Bug: angleproject:8474 Change-Id: Ibb476368cc35b66bcb7c2edca7d9f2515058595f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5277473 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0