|
aea88562
|
2023-05-19T16:52:43
|
|
Reland "Metal: Optimized BufferSubData per device"
This reverts commit ee64836f702332adaca58d9f452063a04b2da955 ,
relanding the patch stack described there.
Between patchsets 1 and 5:
- The shadow buffer allocation has been replaced with a multimap of
precisely-sized buffers, rather than rounding up buffer sizes.
- Garbage collection of shadow buffers is triggered in three situations:
- A certain number of context switches have occurred; this number
was hand-tuned to avoid GC every frame.
- A certain number of command buffer submissions has occurred; this
number was hand-tuned to GC no more often than every few seconds
on representative workloads.
- The total size of the allocated shadow buffers is more than 1 MB,
and either more than twice the size at the last garbage
collection, or 64 MB more than at the last garbage collection. In
this case, aggressive GC is performed in order to reclaim shadow
buffers more quickly.
Performance before and after these changes appears identical on
microbenchmarks. On one Figma test case, comparing GPU memory
allocated inside the BufferManager, peak consumption is decreased by
over 75%, and steady-state consumption decreases by over 88%.
Patchset 6 adds a needed workaround for a bug in the
AMDMTLBronzeDriver affecting uploads of client-side data, and
therefore some dEQP tests. It also streamlines the aggressive GC.
Bug: angleproject:7544
Change-Id: I81b061f0b33c27fa403527fa12d626f4e9c88ebe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4497413
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ee64836f
|
2023-02-11T17:56:06
|
|
Revert "Metal: Optimized BufferSubData per device"
This reverts commit 968041b54770af8917001d8fe9b52a881cfed0b2.
Includes the following patches:
git revert -n 995db1f66bcf87fc9e47d908fb2a885e810d2567 \
9a6c90c8f802b4d107a081bfccaf4be007e7af54 \
dbd47e378582ef86db52c7379cd220cf0b2c8193 \
369b320f92f54774879e8b8faff834fc8db0793e \
4abae6f97586448712e2dc1cced4a678b0901d7b \
968041b54770af8917001d8fe9b52a881cfed0b2
Several conflicts with top-of-tree were resolved during this revert.
The aim is to reland this with additional code which will reduce the
amount of excess buffer memory allocated, and release the resources
associated with temporary buffer allocations.
Bug: angleproject:7544
Change-Id: Ib7a6bc2ab1c2f23cb43112cd980106e2898c3826
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4240556
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Gregg Tavares <gman@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
9a6c90c8
|
2023-01-26T14:26:49
|
|
Reland "Metal: Avoid leaking buffers for GPU access for non-discrete"
The code would pass BufferManager::getBuffer(..,useShared=false,..)
and use that as key to try to obtain a buffer from the cache.
The BufferManager would store the returned buffers based on
the actual storage mode of the buffer. The storage mode for the
buffers for integrated / iOS devices is always shared.
The above logic would lead the buffer manager always storing returned
buffers to the cache, but never being able to consume any from the
cache. The cache is designed to grow unbounded, and so it did.
Remove the inconsistent logic of passing variation of "use shared bool"
as the arguments. Various places consulted various different Feature
options in inconsistent manner.
Instead, add Buffer::Usage for the callers to express what
kind of access pattern to expect a buffer to be used. Add explicit
MTLStorageMode parameters to Buffer constructing functions.
Remove redundant functions from Buffer.
Remove dead code from BufferPool related to allocation policy.
Reland: continue to allocate buffers with shared rather than managed
mode in BufferPool, as otherwise bug angleproject:7997 is encountered.
Bug: angleproject:7975
Change-Id: Iae4e75a85e6d49b20e724ed037a7c14cc0f7693f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4217712
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Reviewed-by: Gregg Tavares <gman@chromium.org>
Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
dbd47e37
|
2023-01-30T20:54:24
|
|
Revert "Metal: Avoid leaking buffers for GPU access for non-discrete"
This reverts commit 369b320f92f54774879e8b8faff834fc8db0793e.
Reason for revert: WebGL 2.0 conformance tests failing on Mac/AMD per https://bugs.chromium.org/p/angleproject/issues/detail?id=7975#c4
Original change's description:
> Metal: Avoid leaking buffers for GPU access for non-discrete
>
> The code would pass BufferManager::getBuffer(..,useShared=false,..)
> and use that as key to try to obtain a buffer from the cache.
> The BufferManager would store the returned buffers based on
> the actual storage mode of the buffer. The storage mode for the
> buffers for integrated / iOS devices is always shared.
>
> The above logic would lead the buffer manager always storing returned
> buffers to the cache, but never being able to consume any from the
> cache. The cache is designed to grow unbounded, and so it did.
>
> Remove the inconsistent logic of passing variation of "use shared bool"
> as the arguments. Various places consulted various different Feature
> options in inconsistent manner.
>
> Instead, add Buffer::AccessPattern for the callers to express what
> kind of access pattern to expect a buffer to be used. Add explicit
> MTLStorageMode parameters to Buffer constructing functions.
> Remove redundant functions from Buffer.
> Remove dead code from BufferPool related to allocation policy.
>
> Bug: angleproject:7975
> Change-Id: I0c4661c55e8c907b702160ae42690269c049f6db
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4194172
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Gregg Tavares <gman@chromium.org>
> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Bug: angleproject:7975
Change-Id: I094de8e5b06392fe36a9887d6a817023baa48735
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4206187
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
369b320f
|
2023-01-26T14:26:49
|
|
Metal: Avoid leaking buffers for GPU access for non-discrete
The code would pass BufferManager::getBuffer(..,useShared=false,..)
and use that as key to try to obtain a buffer from the cache.
The BufferManager would store the returned buffers based on
the actual storage mode of the buffer. The storage mode for the
buffers for integrated / iOS devices is always shared.
The above logic would lead the buffer manager always storing returned
buffers to the cache, but never being able to consume any from the
cache. The cache is designed to grow unbounded, and so it did.
Remove the inconsistent logic of passing variation of "use shared bool"
as the arguments. Various places consulted various different Feature
options in inconsistent manner.
Instead, add Buffer::AccessPattern for the callers to express what
kind of access pattern to expect a buffer to be used. Add explicit
MTLStorageMode parameters to Buffer constructing functions.
Remove redundant functions from Buffer.
Remove dead code from BufferPool related to allocation policy.
Bug: angleproject:7975
Change-Id: I0c4661c55e8c907b702160ae42690269c049f6db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4194172
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Gregg Tavares <gman@chromium.org>
Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
|
|
968041b5
|
2022-08-19T12:11:23
|
|
Metal: Optimized BufferSubData per device
Adds a staging buffer path which means there are 4 paths
for bufferSubData.
1. direct copy
* get a pointer to the buffer
* copy the new data to the buffer
* if the buffer is managed, tell metal which part was updated
2. use a shadow copy
* copy the data to a shadow copy
* copy the entire shadow to a new buffer
* start using the new buffer
3. use a new buffer
* get a new buffer (or unused)
* put the new data in the new buffer
* blit any unchanged data from the old buffer to the new buffer
* start using the new buffer
4. use a staging buffer
* get a staging buffer
* put the new data in the staging buffer
* blit from the staging buffer to the existing buffer.
Further, there are 3 types of memory storage modes.
Managed, Staged, Private.
Based on the GPU type different storage modes and different
paths in different sitatutions are more performant.
So, add feature flags to select paths by GPU.
Bug: angleproject:7544
Change-Id: I741dd1874201043416374194bd2001ded8dbd9b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3842641
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
Commit-Queue: Gregg Tavares <gman@chromium.org>
|