-
Show log
Commit
-
Hash : d2de7451
Author :
Date : 2023-10-19T14:10:44
Vulkan: Fix VK_android_external_format_resolve VVL error part 5 Fix assertion in RendererVk::getFormatFeatureBits(). When formatID is external format, we can not use vkGetPhysicalDeviceFormatProperties to get the formatFeature (since VkFormat is undefined). To fix this, we keep the formatFetaure that returned from AHB in the ExternalYuvFormatInfo and use that in getFormatFeatureBits() if it is external format. This also fixes the VVL error VUID-VkImageCreateInfo-pNext-02396: The Vulkan spec states: If the pNext chain includes a VkExternalFormatANDROID structure whose externalFormat member is not 0, flags must not include VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT Bug: b/223456677 Change-Id: I625c2bf4fe534fa206918b16772ac3ac7c6fa79a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4956117 Reviewed-by: Chris Forbes <chrisforbes@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
-
Files
- BufferImpl.cpp
- BufferImpl.h
- BufferImpl_mock.h
- CLCommandQueueImpl.cpp
- CLCommandQueueImpl.h
- CLContextImpl.cpp
- CLContextImpl.h
- CLDeviceImpl.cpp
- CLDeviceImpl.h
- CLEventImpl.cpp
- CLEventImpl.h
- CLExtensions.cpp
- CLExtensions.h
- CLKernelImpl.cpp
- CLKernelImpl.h
- CLMemoryImpl.cpp
- CLMemoryImpl.h
- CLPlatformImpl.cpp
- CLPlatformImpl.h
- CLProgramImpl.cpp
- CLProgramImpl.h
- CLSamplerImpl.cpp
- CLSamplerImpl.h
- CLtypes.h
- CompilerImpl.h
- ContextImpl.cpp
- ContextImpl.h
- DeviceImpl.cpp
- DeviceImpl.h
- DisplayImpl.cpp
- DisplayImpl.h
- EGLImplFactory.h
- EGLReusableSync.cpp
- EGLReusableSync.h
- EGLSyncImpl.cpp
- EGLSyncImpl.h
- FenceNVImpl.h
- Format.h
- FormatID_autogen.h
- Format_table_autogen.cpp
- FramebufferAttachmentObjectImpl.h
- FramebufferImpl.cpp
- FramebufferImpl.h
- FramebufferImpl_mock.h
- GLImplFactory.h
- ImageImpl.cpp
- ImageImpl.h
- ImageImpl_mock.h
- MemoryObjectImpl.h
- OverlayImpl.h
- ProgramExecutableImpl.h
- ProgramImpl.cpp
- ProgramImpl.h
- ProgramImpl_mock.h
- ProgramPipelineImpl.cpp
- ProgramPipelineImpl.h
- QueryImpl.cpp
- QueryImpl.h
- README.md
- RenderTargetCache.h
- RenderbufferImpl.cpp
- RenderbufferImpl.h
- RenderbufferImpl_mock.h
- SamplerImpl.h
- SemaphoreImpl.h
- ShaderImpl.cpp
- ShaderImpl.h
- ShareGroupImpl.h
- StreamProducerImpl.h
- SurfaceImpl.cpp
- SurfaceImpl.h
- SyncImpl.h
- TextureImpl.cpp
- TextureImpl.h
- TextureImpl_mock.h
- TransformFeedbackImpl.cpp
- TransformFeedbackImpl.h
- TransformFeedbackImpl_mock.h
- VertexArrayImpl.cpp
- VertexArrayImpl.h
- angle_format.py
- angle_format_data.json
- angle_format_map.json
- cl/
- copyvertex.h
- copyvertex.inc.h
- d3d/
- d3d_format.cpp
- d3d_format.h
- driver_utils.cpp
- driver_utils.h
- driver_utils_ios.mm
- driver_utils_mac.mm
- dxgi_format_data.json
- dxgi_format_map.h
- dxgi_format_map_autogen.cpp
- dxgi_support_data.json
- dxgi_support_table.h
- dxgi_support_table_autogen.cpp
- gen_angle_format_table.py
- gen_dxgi_format_table.py
- gen_dxgi_support_tables.py
- gen_load_functions_table.py
- gl/
- load_functions_data.json
- load_functions_table.h
- load_functions_table_autogen.cpp
- metal/
- null/
- renderer_utils.cpp
- renderer_utils.h
- serial_utils.h
- serial_utils_unittest.cpp
- vulkan/
-
README.md
-
ANGLE back-ends
This folder contains shared back-end-specific implementation files. The classes and types in
rendererare not specified by GLES. They instead are common to all the various ANGLE implementations.See
renderer_utils.hfor various cross back-end utilties.ANGLE Formats
The ANGLE format class,
angle::Format, works as a union between GLES and all the various back-end formats. It can represent any type of format in ANGLE. e.g. Formats in Vulkan that don’t exist in GLES, or DXGI formats that don’t exist in GLES, or Windows/Android surface configs that don’t exist anywhere else.The
glInternalFormatmember ofangle::Formatrepresents the “closest” GL format for an ANGLE format. For formats that don’t exist in GLES this will not be exactly what the format represents.The back-ends also define their own format tables. See the Vulkan Format table docs and the [D3D11 format table docs][D23D11FormatDocs].
DXGI Format Info
DXGI formats are used in both the GL and D3D11 back-end. Therefore the generated info table lives in this common shared location.
The DXGI info table is generated by
gen_dxgi_format_table.pyand sources data fromdxgi_format_data.json. The main purpose of the table is to convert from a DXGI format to an ANGLE format, where the ANGLE format should have all the necessary information.