kc3-lang/angle/src/compiler/translator/ValidateOutputs.cpp

• Show log

  Commit

• Hash : 8518e7f6
  Author :
  Date : 2015-07-16T14:54:08
  

  Make all fragment shader out variables require location layout qualifier
  
  Make all fragment shader out variables require location layout
  qualifier. Previously, the last variable did not need a location layout
  qualifier if the previous variables had those.
  
  TEST=angle_unittests
  BUG=angleproject:1070
  
  Change-Id: Ifb66ee52b811409f5278eaad330d6cd9b8ea059f
  Reviewed-on: https://chromium-review.googlesource.com/287100
  Tested-by: Kimmo Kinnunen <kkinnunen@nvidia.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Tested-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/compiler/translator/ValidateOutputs.cpp

• //
  // Copyright (c) 2013 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "compiler/translator/ValidateOutputs.h"
  #include "compiler/translator/InfoSink.h"
  #include "compiler/translator/InitializeParseContext.h"
  #include "compiler/translator/ParseContext.h"
  
  ValidateOutputs::ValidateOutputs(TInfoSinkBase& sink, int maxDrawBuffers)
      : TIntermTraverser(true, false, false),
        mSink(sink),
        mMaxDrawBuffers(maxDrawBuffers),
        mNumErrors(0),
        mHasUnspecifiedOutputLocation(false)
  {
  }
  
  void ValidateOutputs::visitSymbol(TIntermSymbol *symbol)
  {
      TString name = symbol->getSymbol();
      TQualifier qualifier = symbol->getQualifier();
  
      if (mVisitedSymbols.count(name) == 1)
          return;
  
      mVisitedSymbols.insert(name);
  
      if (qualifier == EvqFragmentOut)
      {
          const TType &type = symbol->getType();
          const int location = type.getLayoutQualifier().location;
          const bool isUnspecifiedOutputLocation = location == -1;
  
          if (mHasUnspecifiedOutputLocation || (isUnspecifiedOutputLocation && !mOutputMap.empty()))
          {
              error(symbol->getLine(), "must explicitly specify all locations when using multiple fragment outputs", name.c_str());
          }
          else if (isUnspecifiedOutputLocation)
          {
              mHasUnspecifiedOutputLocation = true;
          }
          else
          {
              OutputMap::iterator mapEntry = mOutputMap.find(location);
              if (mapEntry == mOutputMap.end())
              {
                  const int elementCount = type.isArray() ? type.getArraySize() : 1;
                  if (location + elementCount > mMaxDrawBuffers)
                  {
                      error(symbol->getLine(), "output location must be < MAX_DRAW_BUFFERS", name.c_str());
                  }
  
                  for (int elementIndex = 0; elementIndex < elementCount; elementIndex++)
                  {
                      const int offsetLocation = location + elementIndex;
                      mOutputMap[offsetLocation] = symbol;
                  }
              }
              else
              {
                  std::stringstream strstr;
                  strstr << "conflicting output locations with previously defined output '"
                         << mapEntry->second->getSymbol() << "'";
  
                  error(symbol->getLine(), strstr.str().c_str(), name.c_str());
              }
          }
      }
  }
  
  void ValidateOutputs::error(TSourceLoc loc, const char *reason, const char* token)
  {
      mSink.prefix(EPrefixError);
      mSink.location(loc);
      mSink << "'" << token << "' : " << reason << "\n";
      mNumErrors++;
  }
  

Download