-
Show log
Commit
-
Hash : f827123d
Author :
Date : 2018-04-25T13:08:24
Handle negative float to uint conversion robustly Converting a negative float to uint is undefined in the GLSL ES 3.00.6 spec. However, it improves portability if we don't trigger undefined results in C++ in this case. To do this, we cast negative floats first to signed integer before casting them to unsigned integer. We also issue a warning about an undefined conversion in case a negative float was converted to uint. BUG=chromium:835868 TEST=angle_unittests Change-Id: I9835a739ec80699d420a4f91a3bfa112c9a13604 Reviewed-on: https://chromium-review.googlesource.com/1026681 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
-
Files
- API_test.cpp
- ARB_texture_rectangle_test.cpp
- AppendixALimitations_test.cpp
- AtomicCounter_test.cpp
- BufferVariables_test.cpp
- CollectVariables_test.cpp
- ConstantFoldingNaN_test.cpp
- ConstantFoldingOverflow_test.cpp
- ConstantFolding_test.cpp
- ConstructCompiler_test.cpp
- DebugShaderPrecision_test.cpp
- EXT_YUV_target_test.cpp
- EXT_blend_func_extended_test.cpp
- EXT_frag_depth_test.cpp
- EXT_shader_texture_lod_test.cpp
- EmulateGLFragColorBroadcast_test.cpp
- ExpressionLimit_test.cpp
- ExtensionDirective_test.cpp
- FloatLex_test.cpp
- FragDepth_test.cpp
- GLSLCompatibilityOutput_test.cpp
- GeometryShader_test.cpp
- GlFragDataNotModified_test.cpp
- HLSLOutput_test.cpp
- ImmutableString_test.cpp
- ImmutableString_test_autogen.cpp
- InitOutputVariables_test.cpp
- IntermNode_test.cpp
- NV_draw_buffers_test.cpp
- OES_standard_derivatives_test.cpp
- Pack_Unpack_test.cpp
- PruneEmptyCases_test.cpp
- PruneEmptyDeclarations_test.cpp
- PrunePureLiteralStatements_test.cpp
- PruneUnusedFunctions_test.cpp
- QualificationOrderESSL31_test.cpp
- QualificationOrder_test.cpp
- RecordConstantPrecision_test.cpp
- RegenerateStructNames_test.cpp
- RemovePow_test.cpp
- RemoveUnreferencedVariables_test.cpp
- RewriteDoWhile_test.cpp
- SamplerMultisample_test.cpp
- ScalarizeVecAndMatConstructorArgs_test.cpp
- ShCompile_test.cpp
- ShaderImage_test.cpp
- ShaderValidation_test.cpp
- ShaderVariable_test.cpp
- TextureFunction_test.cpp
- TypeTracking_test.cpp
- Type_test.cpp
- UnfoldShortCircuitAST_test.cpp
- UnrollFlatten_test.cpp
- VariablePacker_test.cpp
- VectorizeVectorScalarArithmetic_test.cpp
- WEBGL_multiview_test.cpp
- WorkGroupSize_test.cpp
