Hash :
56aee5d6
Author :
Date :
2021-12-10T12:32:58
Reland "system_utils: Add memory protection functionality." This is a reland of b1c703e5f5e44514e8db958a5fb39ff16e514fd8 that was reverted in 663831aa676c59829cc3d822340812f016bf77f6. Skip PageFaultHandlerProtect and PageFaultHandlerDefaultHandler on macOS and Fuchsia. Original change's description: > Reland "system_utils: Add memory protection functionality." > > This is a reland of ab75a90ff4ecb9d99b5c72bde92222b07c285401 > that was reverted in b007e667a8f94b47788a5ba0b2e61c9ac2d1285f. > > Implement PageFaultHandler and memory protection functions. > Uses mprotect and sigaction on POSIX and equivalent Win API functions on > win32. > > Add tests to system_utils_unittests. > > Add stubs for winuwp. > > Replace ASSERT with ASSERT_TRUE in the PageFaultHandlerDefaultHandler > test to make it succeed on release builds, as the code was optimized > out. Furthermore the test did not correctly remove protection from the > whole area it protected, which caused a hang after deinitialization on > some build configurations, since the custom page fault handler was also > still in place. The test now correclty removes protection from the whole > area and sets back the original page fault handler. > > Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*" > Bug: angleproject:5857 > Change-Id: Ibb0acfefd9a09c3360c04c812a2a8346b951e1da > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322992 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Test: angle_unittests --gtest_filter="SystemUtils.PageFaultHandler*" Bug: angleproject:5857 Change-Id: Ifaa966a7c569aa9ff0112897a02fa8f873cd52dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3329610 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367
//
// Copyright 2019 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// system_utils_unittest.cpp: Unit tests for ANGLE's system utility functions
#include "gmock/gmock.h"
#include "gtest/gtest.h"
#include "common/mathutil.h"
#include "common/system_utils.h"
#include "util/test_utils.h"
#include <vector>
#if defined(ANGLE_PLATFORM_POSIX)
# include <signal.h>
#endif
using namespace angle;
namespace
{
// Test getting the executable path
TEST(SystemUtils, ExecutablePath)
{
// TODO: fuchsia support. http://anglebug.com/3161
#if !defined(ANGLE_PLATFORM_FUCHSIA)
std::string executablePath = GetExecutablePath();
EXPECT_NE("", executablePath);
#endif
}
// Test getting the executable directory
TEST(SystemUtils, ExecutableDir)
{
// TODO: fuchsia support. http://anglebug.com/3161
#if !defined(ANGLE_PLATFORM_FUCHSIA)
std::string executableDir = GetExecutableDirectory();
EXPECT_NE("", executableDir);
std::string executablePath = GetExecutablePath();
EXPECT_LT(executableDir.size(), executablePath.size());
EXPECT_EQ(0, strncmp(executableDir.c_str(), executablePath.c_str(), executableDir.size()));
#endif
}
// Test setting environment variables
TEST(SystemUtils, Environment)
{
constexpr char kEnvVarName[] = "UNITTEST_ENV_VARIABLE";
constexpr char kEnvVarValue[] = "The quick brown fox jumps over the lazy dog";
bool setEnvDone = SetEnvironmentVar(kEnvVarName, kEnvVarValue);
EXPECT_TRUE(setEnvDone);
std::string readback = GetEnvironmentVar(kEnvVarName);
EXPECT_EQ(kEnvVarValue, readback);
bool unsetEnvDone = UnsetEnvironmentVar(kEnvVarName);
EXPECT_TRUE(unsetEnvDone);
readback = GetEnvironmentVar(kEnvVarName);
EXPECT_EQ("", readback);
}
// Test CPU time measurement with a small operation
// (pretty much the measurement itself)
TEST(SystemUtils, CpuTimeSmallOp)
{
double cpuTimeStart = GetCurrentProcessCpuTime();
double cpuTimeEnd = GetCurrentProcessCpuTime();
EXPECT_GE(cpuTimeEnd, cpuTimeStart);
}
// Test CPU time measurement with a sleepy operation
TEST(SystemUtils, CpuTimeSleepy)
{
double cpuTimeStart = GetCurrentProcessCpuTime();
angle::Sleep(1);
double cpuTimeEnd = GetCurrentProcessCpuTime();
EXPECT_GE(cpuTimeEnd, cpuTimeStart);
}
// Test CPU time measurement with a heavy operation
TEST(SystemUtils, CpuTimeHeavyOp)
{
constexpr size_t bufferSize = 1048576;
std::vector<uint8_t> buffer(bufferSize, 1);
double cpuTimeStart = GetCurrentProcessCpuTime();
memset(buffer.data(), 0, bufferSize);
double cpuTimeEnd = GetCurrentProcessCpuTime();
EXPECT_GE(cpuTimeEnd, cpuTimeStart);
}
#if defined(ANGLE_PLATFORM_POSIX)
TEST(SystemUtils, ConcatenatePathSimple)
{
std::string path1 = "/this/is/path1";
std::string path2 = "this/is/path2";
std::string expected = "/this/is/path1/this/is/path2";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, ConcatenatePath1Empty)
{
std::string path1 = "";
std::string path2 = "this/is/path2";
std::string expected = "this/is/path2";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, ConcatenatePath2Empty)
{
std::string path1 = "/this/is/path1";
std::string path2 = "";
std::string expected = "/this/is/path1";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, ConcatenatePath2FullPath)
{
std::string path1 = "/this/is/path1";
std::string path2 = "/this/is/path2";
std::string expected = "/this/is/path2";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, ConcatenatePathRedundantSeparators)
{
std::string path1 = "/this/is/path1/";
std::string path2 = "this/is/path2";
std::string expected = "/this/is/path1/this/is/path2";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, IsFullPath)
{
std::string path1 = "/this/is/path1/";
std::string path2 = "this/is/path2";
EXPECT_TRUE(IsFullPath(path1));
EXPECT_FALSE(IsFullPath(path2));
}
#elif defined(ANGLE_PLATFORM_WINDOWS)
TEST(SystemUtils, ConcatenatePathSimple)
{
std::string path1 = "C:\\this\\is\\path1";
std::string path2 = "this\\is\\path2";
std::string expected = "C:\\this\\is\\path1\\this\\is\\path2";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, ConcatenatePath1Empty)
{
std::string path1 = "";
std::string path2 = "this\\is\\path2";
std::string expected = "this\\is\\path2";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, ConcatenatePath2Empty)
{
std::string path1 = "C:\\this\\is\\path1";
std::string path2 = "";
std::string expected = "C:\\this\\is\\path1";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, ConcatenatePath2FullPath)
{
std::string path1 = "C:\\this\\is\\path1";
std::string path2 = "C:\\this\\is\\path2";
std::string expected = "C:\\this\\is\\path2";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, ConcatenatePathRedundantSeparators)
{
std::string path1 = "C:\\this\\is\\path1\\";
std::string path2 = "this\\is\\path2";
std::string expected = "C:\\this\\is\\path1\\this\\is\\path2";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, ConcatenatePathRedundantSeparators2)
{
std::string path1 = "C:\\this\\is\\path1\\";
std::string path2 = "\\this\\is\\path2";
std::string expected = "C:\\this\\is\\path1\\this\\is\\path2";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, ConcatenatePathRedundantSeparators3)
{
std::string path1 = "C:\\this\\is\\path1";
std::string path2 = "\\this\\is\\path2";
std::string expected = "C:\\this\\is\\path1\\this\\is\\path2";
EXPECT_EQ(ConcatenatePath(path1, path2), expected);
}
TEST(SystemUtils, IsFullPath)
{
std::string path1 = "C:\\this\\is\\path1\\";
std::string path2 = "this\\is\\path2";
EXPECT_TRUE(IsFullPath(path1));
EXPECT_FALSE(IsFullPath(path2));
}
#endif
// Test retrieving page size
TEST(SystemUtils, PageSize)
{
size_t pageSize = GetPageSize();
EXPECT_TRUE(pageSize > 0);
}
// mprotect is not supported on Fuchsia right now.
#if defined(ANGLE_PLATFORM_FUCHSIA)
# define MAYBE_PageFaultHandlerInit DISABLED_PageFaultHandlerInit
# define MAYBE_PageFaultHandlerProtect DISABLED_PageFaultHandlerProtect
# define MAYBE_PageFaultHandlerDefaultHandler DISABLED_PageFaultHandlerDefaultHandler
// mprotect tests hang on macOS M1.
#elif defined(ANGLE_PLATFORM_MACOS)
# define MAYBE_PageFaultHandlerInit PageFaultHandlerInit
# define MAYBE_PageFaultHandlerProtect DISABLED_PageFaultHandlerProtect
# define MAYBE_PageFaultHandlerDefaultHandler DISABLED_PageFaultHandlerDefaultHandler
#else
# define MAYBE_PageFaultHandlerInit PageFaultHandlerInit
# define MAYBE_PageFaultHandlerProtect PageFaultHandlerProtect
# define MAYBE_PageFaultHandlerDefaultHandler PageFaultHandlerDefaultHandler
#endif // defined(ANGLE_PLATFORM_FUCHSIA)
// Test initializing and cleaning up page fault handler.
TEST(SystemUtils, MAYBE_PageFaultHandlerInit)
{
PageFaultCallback callback = [](uintptr_t address) {
return PageFaultHandlerRangeType::InRange;
};
std::unique_ptr<PageFaultHandler> handler(CreatePageFaultHandler(callback));
EXPECT_TRUE(handler->enable());
EXPECT_TRUE(handler->disable());
}
// Test write protecting and unprotecting memory
TEST(SystemUtils, MAYBE_PageFaultHandlerProtect)
{
size_t pageSize = GetPageSize();
EXPECT_TRUE(pageSize > 0);
std::vector<float> data = std::vector<float>(100);
size_t dataSize = sizeof(float) * data.size();
uintptr_t dataStart = reinterpret_cast<uintptr_t>(data.data());
uintptr_t protectionStart = rx::roundDownPow2(dataStart, pageSize);
uintptr_t protectionEnd = rx::roundUpPow2(dataStart + dataSize, pageSize);
std::mutex mutex;
bool handlerCalled = false;
PageFaultCallback callback = [&mutex, pageSize, dataStart, dataSize,
&handlerCalled](uintptr_t address) {
if (address >= dataStart && address < dataStart + dataSize)
{
std::lock_guard<std::mutex> lock(mutex);
uintptr_t pageStart = rx::roundDownPow2(address, pageSize);
EXPECT_TRUE(UnprotectMemory(pageStart, pageSize));
handlerCalled = true;
return PageFaultHandlerRangeType::InRange;
}
else
{
return PageFaultHandlerRangeType::OutOfRange;
}
};
std::unique_ptr<PageFaultHandler> handler(CreatePageFaultHandler(callback));
handler->enable();
size_t protectionSize = protectionEnd - protectionStart;
// Test Protect
EXPECT_TRUE(ProtectMemory(protectionStart, protectionSize));
data[0] = 0.0;
{
std::lock_guard<std::mutex> lock(mutex);
EXPECT_TRUE(handlerCalled);
}
// Test Protect and unprotect
EXPECT_TRUE(ProtectMemory(protectionStart, protectionSize));
EXPECT_TRUE(UnprotectMemory(protectionStart, protectionSize));
handlerCalled = false;
data[0] = 0.0;
EXPECT_FALSE(handlerCalled);
// Clean up
EXPECT_TRUE(handler->disable());
}
#if defined(ANGLE_PLATFORM_POSIX)
std::mutex gCustomHandlerMutex;
bool gCustomHandlerCalled = false;
void CustomSegfaultHandlerFunction(int sig, siginfo_t *info, void *unused)
{
std::lock_guard<std::mutex> lock(gCustomHandlerMutex);
gCustomHandlerCalled = true;
}
// Test if the default page fault handler is called on OutOfRange.
TEST(SystemUtils, MAYBE_PageFaultHandlerDefaultHandler)
{
size_t pageSize = GetPageSize();
EXPECT_TRUE(pageSize > 0);
std::vector<float> data = std::vector<float>(100);
size_t dataSize = sizeof(float) * data.size();
uintptr_t dataStart = reinterpret_cast<uintptr_t>(data.data());
uintptr_t protectionStart = rx::roundDownPow2(dataStart, pageSize);
uintptr_t protectionEnd = rx::roundUpPow2(dataStart + dataSize, pageSize);
size_t protectionSize = protectionEnd - protectionStart;
// Create custom handler
struct sigaction sigAction = {};
sigAction.sa_flags = SA_SIGINFO;
sigAction.sa_sigaction = &CustomSegfaultHandlerFunction;
sigemptyset(&sigAction.sa_mask);
struct sigaction oldSigSegv = {};
ASSERT_TRUE(sigaction(SIGSEGV, &sigAction, &oldSigSegv) == 0);
struct sigaction oldSigBus = {};
ASSERT_TRUE(sigaction(SIGBUS, &sigAction, &oldSigBus) == 0);
PageFaultCallback callback = [protectionStart, protectionSize](uintptr_t address) {
EXPECT_TRUE(UnprotectMemory(protectionStart, protectionSize));
return PageFaultHandlerRangeType::OutOfRange;
};
std::unique_ptr<PageFaultHandler> handler(CreatePageFaultHandler(callback));
handler->enable();
// Test Protect
EXPECT_TRUE(ProtectMemory(protectionStart, protectionSize));
data[0] = 0.0;
{
std::lock_guard<std::mutex> lock(gCustomHandlerMutex);
EXPECT_TRUE(gCustomHandlerCalled);
}
// Clean up
EXPECT_TRUE(handler->disable());
ASSERT_TRUE(sigaction(SIGSEGV, &oldSigSegv, nullptr) == 0);
ASSERT_TRUE(sigaction(SIGBUS, &oldSigBus, nullptr) == 0);
}
#else
TEST(SystemUtils, MAYBE_PageFaultHandlerDefaultHandler) {}
#endif
} // anonymous namespace