• Show log

    Commit

  • Hash : 02f6226b
    Author : Alexis Hetu
    Date : 2022-01-06T09:07:29

    Avoid using GetCWD() on MacOS when possible
    
    GetCWD is unreliable on MacOS and often fails or returns an
    undesirable directory. This CL makes the number of GetCWD()
    calls go from 2 to 0 when running content_shell locally on
    MacOS, which makes it start successfully with SwANGLE
    enabled. The 2 changes are:
    
    1) Don't attempt to change the current working directory on
       MacOS for Validation Layers. This doesn't work as intended
       anyway and, on a GetCWD failure, ends up changing the ICD
       from SwiftShader to Default when using SwANGLE, which can
       make test runs fail.
    
    2) Don't always call GetCWD() when calling
       GetModuleDirectory(). It is only required when the module
       path is not a full path, at which point some error info
       was added to help understand what's happening if we get
       into this case.
    
    Bug: chromium:1246171
    Change-Id: Ib96142661dee3e06980eac4ffc3743aae8b97950
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3370036
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    Commit-Queue: Alexis Hétu <sugoi@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags