Hash :
5cbaa3f8
Author :
Date :
2019-05-07T15:49:22
Don't inherit ANGLETest SetUp and TearDown. Instead of inheriting from testing::Test's SetUp and TearDown we add new methods 'testSetUp' and 'testTearDown'. This helps prevent a common error of forgetting to call the base class method. Also add a check in the ANGLETest destructor that SetUp and TearDown have been called. Bug: angleproject:3393 Change-Id: Iab211305cc06ffea9ca649e864ddc9b180f2cba0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1593960 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
//
// Copyright 2016 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// SyncQueriesTest.cpp: Tests of the GL_CHROMIUM_sync_query extension
#include "test_utils/ANGLETest.h"
namespace angle
{
class SyncQueriesTest : public ANGLETest
{
protected:
SyncQueriesTest()
{
setWindowWidth(128);
setWindowHeight(128);
setConfigRedBits(8);
setConfigGreenBits(8);
setConfigBlueBits(8);
setConfigAlphaBits(8);
setConfigDepthBits(24);
}
void testTearDown() override
{
if (mQuery != 0)
{
glDeleteQueriesEXT(1, &mQuery);
mQuery = 0;
}
}
GLuint mQuery = 0;
};
// Test basic usage of sync queries
TEST_P(SyncQueriesTest, Basic)
{
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_CHROMIUM_sync_query"));
glGenQueriesEXT(1, &mQuery);
glBeginQueryEXT(GL_COMMANDS_COMPLETED_CHROMIUM, mQuery);
EXPECT_GL_NO_ERROR();
glClearColor(0.0, 0.0, 1.0, 1.0);
glClear(GL_COLOR_BUFFER_BIT);
glEndQueryEXT(GL_COMMANDS_COMPLETED_CHROMIUM);
glFlush();
GLuint result = 0;
glGetQueryObjectuivEXT(mQuery, GL_QUERY_RESULT_EXT, &result);
EXPECT_GL_TRUE(result);
EXPECT_GL_NO_ERROR();
}
// Test that the sync query enums are not accepted unless the extension is available
TEST_P(SyncQueriesTest, Validation)
{
// Need the GL_EXT_occlusion_query_boolean extension for the entry points
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_EXT_occlusion_query_boolean"));
bool extensionAvailable = IsGLExtensionEnabled("GL_CHROMIUM_sync_query");
glGenQueriesEXT(1, &mQuery);
glBeginQueryEXT(GL_COMMANDS_COMPLETED_CHROMIUM, mQuery);
if (extensionAvailable)
{
EXPECT_GL_NO_ERROR();
}
else
{
EXPECT_GL_ERROR(GL_INVALID_ENUM);
}
glDeleteQueriesEXT(1, &mQuery);
EXPECT_GL_NO_ERROR();
}
// Use this to select which configurations (e.g. which renderer, which GLES major version) these
// tests should be run against.
ANGLE_INSTANTIATE_TEST(SyncQueriesTest,
ES2_D3D9(),
ES2_D3D11(),
ES3_D3D11(),
ES2_OPENGL(),
ES3_OPENGL(),
ES2_OPENGLES(),
ES3_OPENGLES(),
ES2_VULKAN());
} // namespace angle