Hash :
79216620
Author :
Date :
2018-05-29T19:19:54
Use stringstream with locale override. Add test for compiling float literals in locales with comma decimal separators. Handle inexplicable test setlocale failure on Android,Linux. (Require success on other platforms) Skip setting the locale on Android, which is always C locale in C++, but for some reason std::locale::classic isn't implemented as a no-op. Bug: angleproject:2607 Test: angle_unittests Change-Id: I7c97cb56c01335db46f532fb8af3f9a4f2a30564 Reviewed-on: https://chromium-review.googlesource.com/1077789 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71
//
// Copyright (c) 2012 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// numeric_lex.h: Functions to extract numeric values from string.
#ifndef COMPILER_PREPROCESSOR_NUMERICLEX_H_
#define COMPILER_PREPROCESSOR_NUMERICLEX_H_
#include <cmath>
#include <sstream>
namespace angle
{
namespace pp
{
inline std::ios::fmtflags numeric_base_int(const std::string &str)
{
if ((str.size() >= 2) && (str[0] == '0') && (str[1] == 'x' || str[1] == 'X'))
{
return std::ios::hex;
}
if ((str.size() >= 1) && (str[0] == '0'))
{
return std::ios::oct;
}
return std::ios::dec;
}
// The following functions parse the given string to extract a numerical
// value of the given type. These functions assume that the string is
// of the correct form. They can only fail if the parsed value is too big,
// in which case false is returned.
template <typename IntType>
bool numeric_lex_int(const std::string &str, IntType *value)
{
std::istringstream stream(str);
// This should not be necessary, but MSVS has a buggy implementation.
// It returns incorrect results if the base is not specified.
stream.setf(numeric_base_int(str), std::ios::basefield);
stream >> (*value);
return !stream.fail();
}
template <typename FloatType>
bool numeric_lex_float(const std::string &str, FloatType *value)
{
std::istringstream stream(str);
// Android NDK forbids access to locales by always throwing instead of only accepting the C locale.
#if !defined(ANGLE_PLATFORM_ANDROID)
// Force "C" locale so that decimal character is always '.', and not dependent on the current
// locale.
stream.imbue(std::locale::classic());
#endif
stream >> (*value);
return !stream.fail() && std::isfinite(*value);
}
} // namespace pp
} // namespace angle
#endif // COMPILER_PREPROCESSOR_NUMERICLEX_H_