kc3-lang/angle/src/libANGLE/renderer/metal/RenderTargetMtl.mm

• Show log

  Commit

• Hash : 9ff063e9
  Author :
  Date : 2020-10-25T03:08:25
  

  Metal: fix max varyings, copyImage between mips, depth fmt
  
  - GLSLTest_ES3.MaxVaryingWithFeedbackAndGLline failed before because
    gl_Position takes up one slot from max varyings on Metal back-end.
    FIXED
  
  - Previously, copyImage() between mips of the same texture would fail.
    Due to the read RenderTargetMtl is released before the copy happens.
    FIXED
  
  - GL_DEPTH_COMPONENT24 texture data upload didn't work due to the source
    32 bit depth data wasn't handled properly.  FIXED
  
  - D24S8 format will be disabled on AMD for now, it will be converted to
    D32S8 instead.
  
  Bug: angleproject:2634
  Bug: angleproject:5235
  Bug: angleproject:5242
  Change-Id: Ie7082f0545c0885ce5ec72df8a7ec4ee5d5de4b1
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494525
  Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/renderer/metal/RenderTargetMtl.mm

• //
  // Copyright 2019 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // RenderTargetMtl.mm:
  //    Implements the class methods for RenderTargetMtl.
  //
  
  #include "libANGLE/renderer/metal/RenderTargetMtl.h"
  
  namespace rx
  {
  RenderTargetMtl::RenderTargetMtl() {}
  
  RenderTargetMtl::~RenderTargetMtl()
  {
      reset();
  }
  
  RenderTargetMtl::RenderTargetMtl(RenderTargetMtl &&other)
      : mTexture(std::move(other.mTexture)),
        mImplicitMSTexture(std::move(other.mImplicitMSTexture)),
        mLevelIndex(other.mLevelIndex),
        mLayerIndex(other.mLayerIndex)
  {}
  
  void RenderTargetMtl::set(const mtl::TextureRef &texture,
                            const mtl::MipmapNativeLevel &level,
                            uint32_t layer,
                            const mtl::Format &format)
  {
      setWithImplicitMSTexture(texture, nullptr, level, layer, format);
  }
  
  void RenderTargetMtl::setWithImplicitMSTexture(const mtl::TextureRef &texture,
                                                 const mtl::TextureRef &implicitMSTexture,
                                                 const mtl::MipmapNativeLevel &level,
                                                 uint32_t layer,
                                                 const mtl::Format &format)
  {
      mTexture           = texture;
      mImplicitMSTexture = implicitMSTexture;
      mLevelIndex        = level;
      mLayerIndex        = layer;
      mFormat            = &format;
  }
  
  void RenderTargetMtl::setTexture(const mtl::TextureRef &texture)
  {
      mTexture = texture;
  }
  
  void RenderTargetMtl::setImplicitMSTexture(const mtl::TextureRef &implicitMSTexture)
  {
      mImplicitMSTexture = implicitMSTexture;
  }
  
  void RenderTargetMtl::duplicateFrom(const RenderTargetMtl &src)
  {
      setWithImplicitMSTexture(src.getTexture(), src.getImplicitMSTexture(), src.getLevelIndex(),
                               src.getLayerIndex(), *src.getFormat());
  }
  
  void RenderTargetMtl::reset()
  {
      mTexture.reset();
      mImplicitMSTexture.reset();
      mLevelIndex = mtl::kZeroNativeMipLevel;
      mLayerIndex = 0;
      mFormat     = nullptr;
  }
  
  uint32_t RenderTargetMtl::getRenderSamples() const
  {
      mtl::TextureRef implicitMSTex = getImplicitMSTexture();
      mtl::TextureRef tex           = getTexture();
      return implicitMSTex ? implicitMSTex->samples() : (tex ? tex->samples() : 1);
  }
  void RenderTargetMtl::toRenderPassAttachmentDesc(mtl::RenderPassAttachmentDesc *rpaDescOut) const
  {
      rpaDescOut->texture           = mTexture.lock();
      rpaDescOut->implicitMSTexture = mImplicitMSTexture.lock();
      rpaDescOut->level             = mLevelIndex;
      rpaDescOut->sliceOrDepth      = mLayerIndex;
      rpaDescOut->blendable         = mFormat ? mFormat->getCaps().blendable : false;
  }
  }
  

Download