-
Show log
Commit
-
Hash : a88635c4
Author :
Date : 2023-04-28T18:54:25
Android logs also go to stdout/err, line-buffered if possible Currently logs like WARN() or INFO() only go to logcat, which doesn't make them visible in console. This change makes them go to both logcat and stdout/err. Fix android_helper choking on missing json data output when test crashes and test runner doesn't have a chance to produce that file. We still have the stdout/err in this case, so print it. However, a crash (such as SIGSEGV or __builtin_trap()) doesn't flush output so the non-flushed part of the buffer doesn't get in there. AngleNativeTest redirects stdout/err to a file which enables fully-buffered (stdlib) mode. Change this to line-buffered when stdout path is set to /data/ (/sdcard/ is slow) and use /data/data/com.android.angle.test/tmp/ as the temp path in android_helper. This makes e.g. FATAL() << "message"; show up in the logs in CI or local runs. This currently only applies to trace and perf tests, other tests will continue using fully-buffered /stdout/ as chromium's test_runner uses /sdcard/Download/ for temp files. Bug: b/276742336 Change-Id: Ia622c610f776f501223b0cca11d5ec1976eb9887 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4493463 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
-
Files
- ANGLETest.cpp
- ANGLETest.h
- ConstantFoldingTest.cpp
- ConstantFoldingTest.h
- MultiThreadSteps.cpp
- MultiThreadSteps.h
- MultiviewTest.cpp
- MultiviewTest.h
- RenderDoc.cpp
- RenderDoc.h
- ShaderCompileTreeTest.cpp
- ShaderCompileTreeTest.h
- ShaderExtensionTest.h
- VulkanHelper.cpp
- VulkanHelper.h
- angle_test_configs.cpp
- angle_test_configs.h
- angle_test_instantiate.cpp
- angle_test_instantiate.h
- angle_test_instantiate_apple.h
- angle_test_instantiate_apple.mm
- angle_test_platform.cpp
- angle_test_platform.h
- compiler_test.cpp
- compiler_test.h
- draw_call_perf_utils.cpp
- draw_call_perf_utils.h
- gl_raii.h
- runner/
- system_info_util.cpp
- system_info_util.h
- third_party/
