• Show log

    Commit

  • Hash : 0be285c6
    Author : Jason Macnak
    Date : 2021-07-20T11:36:22

    Vulkan: Flush read RT if color attachment is the read buffer
    
    Prior to this change, the following sequence:
    
     * eglMakeCurrent(..., draw=surface1, read=surface1, ...);
     * glClear(...);
     * eglMakeCurrent(..., draw=surface2, read=surface1, ...);
     * glBlitFramebuffer(...);
     * eglMakeCurrent(..., draw=surface1, read=surface1, ...);
     * glReadPixels(...);
    
    would end up with the `vkCmdClearColorImage()` on surface1
    occuring after the `vkCmdBlitImage()`.
    
    This CL updates flushColorAttachmentUpdates() to flush any staged
    updates to both the read and draw attachments, since they can be
    different if different read and draw surfaces are bound.
    
    Adds a test which is a small repro of
    android.opengl.cts.FramebufferTest#testBlitFramebuffer failure.
    
    Bug: b/192327017
    Test: EGLSurfaceTest.BlitBetweenSurfaces/*
    Change-Id: Iabad26dfcd8633e9dcfcee2fb16ba352bc3931d5
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078980
    Commit-Queue: Tim Van Patten <timvp@google.com>
    Reviewed-by: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    kc3_lang_org www_kmx_io thodg_w thodg_l thodg thodg_m
    Tags