kc3-lang/angle/src/tests/capture_replay_tests

Diff

• Show log

  Commit

• Hash : 391bfa35
  Author :
  Date : 2023-07-27T16:43:09
  

  Fix a missing symbol issue with CaptureReplayTests
  
  The constructor for PlatformMethods is declared with
  __declspec(dllimport) when included in CaptureReplayTests.cpp,
  Ordinarily, this would fail to link on Windows because this test doesn't
  link against a library that has an exported definition. This test
  currently builds on Windows because Clang generates an
  available_externally definition in the object file for
  CaptureReplayTests.cpp for inlining. However, this doesn't build if
  inlining is disabled, and will no longer build once an upcoming Clang
  change is rolled in. To fix this, we add the config libANGLE_config to
  the test to change the symbol declaration to __declspec(dllexport),
  which appears to be what other ANGLE tests do.
  
  Bug: chromium:1468150
  Change-Id: Ia92dde31ab624bbfe64d2e81fad18956abebc41b
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4728461
  Reviewed-by: Cody Northrop <cnorthrop@google.com>
  Commit-Queue: Cody Northrop <cnorthrop@google.com>
  

• Files

• .gitignore
• BUILD.gn
• CaptureReplayTests.cpp
• capture_replay_expectations.txt

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags