• Show log

    Commit

  • Hash : 17931e23
    Author : Alexey Knyazev
    Date : 2023-01-27T00:00:00

    Fix stencil and depth/stencil data uploads
    
    Multiple changes were made to depth and stencil load
    functions, removing redundant code and fixing issues.
    
    Failures were caused by incorrect assumptions about
    component locations in combined formats.
    
    * D32_FLOAT_S8X24_UINT has the same layout as
    GL_FLOAT_32_UNSIGNED_INT_24_8_REV
    * D24_UNORM_S8_UINT has stencil data in its MSBs,
    while GL_UNSIGNED_INT_24_8 puts it in LSBs.
    
    Bugfixes
    * Added LoadD24S8ToS8D24 that swaps D24 and S8 components
    * Added LoadS8ToS8X24 for stencil-only uploads on D3D
    * Replaced LoadD24S8ToD32F with LoadD32ToD32F
    * Fixed D and S extraction in LoadD24S8ToD32FS8X24
    * Fixed stencil load and store in LoadD32FS8X24ToS8D24 and
      LoadD32FS8X24ToD32FS8X24
    * Fixed S8_UINT subresource updates in Vulkan
    * Fixed D24_UNORM_S8_UINT subresource updates from
      GL_FLOAT_32_UNSIGNED_INT_24_8_REV data in Vulkan
    
    Cleanup
    * Renamed LoadUNorm16To32F to LoadD16ToD32F
    * Removed LoadUNorm32To32F, replaced it with LoadD32ToD32F
    * Renamed LoadR32ToR24G8 to LoadD32ToX8D24
    * Renamed LoadD32FS8X24ToD24S8 to LoadD32FS8X24ToS8D24
    * Removed unused LoadG8R24ToR24G8
    * Removed Metal-specific LoadS8D24S8ToD32FX24S8,
      made use of the fixed LoadD24S8ToD32FS8X24 instead
    * Simplifed LoadD24S8ToD32F
    
    Added Texture2DTestES3.TexImageWithStencilData.
    
    Fixed: chromium:1408004
    Fixed: angleproject:5317
    Change-Id: I231345353aa4a7cebe46ded8458ac80de2c59e01
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4203427
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags