Hash :
d375547c
Author :
Date :
2022-08-12T15:54:39
Do not link program pipeline in glUseProgramStages
1. The commit 3a9f18f135fe82 caused a link to occur everytime
glUseProgramStages is called. This is redundant since the program
pipeline can be linked just before usage, thus allowing for multiple
stages to be bound before linking the executable.
2. Mark PPO as a dirty object and link the PPO in dirty object handler
3. Early return if the same program is being bound to the same stage
of the pipeline.
4. Added ProgramPipelineObjectBenchmark perf test that switches programs
before a draw and observed following data -
1. vulkan profile -
1. wall_time before patch - 102000 ns
2. wall_time after patch - 38000 ns
2. vulkan_null profile -
1. wall_time before patch - 125000 ns
2. wall_time after patch - 52000 ns
Bug: angleproject:5102
Bug: angleproject:6566
Test: ContextNoErrorPPOTest31.*Vulkan
Test: ProgramPipelineTest31.*Vulkan
Test: ProgramPipelineObjectBenchmark*
Change-Id: Idbc2fcb4875bbd040e9ec847eb2a8f96f287173c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3830170
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186
//
// Copyright 2022 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// ProgramPipelineObjectPerfTest:
// Performance tests switching program stages of a pipeline.
//
#include "ANGLEPerfTest.h"
#include <array>
#include "common/vector_utils.h"
#include "util/shader_utils.h"
using namespace angle;
namespace
{
constexpr unsigned int kIterationsPerStep = 1024;
struct ProgramPipelineObjectParams final : public RenderTestParams
{
ProgramPipelineObjectParams()
{
iterationsPerStep = kIterationsPerStep;
majorVersion = 3;
minorVersion = 1;
windowWidth = 256;
windowHeight = 256;
}
std::string story() const override
{
std::stringstream strstr;
strstr << RenderTestParams::story();
if (eglParameters.deviceType == EGL_PLATFORM_ANGLE_DEVICE_TYPE_NULL_ANGLE)
{
strstr << "_null";
}
return strstr.str();
}
};
std::ostream &operator<<(std::ostream &os, const ProgramPipelineObjectParams ¶ms)
{
os << params.backendAndStory().substr(1);
return os;
}
class ProgramPipelineObjectBenchmark
: public ANGLERenderTest,
public ::testing::WithParamInterface<ProgramPipelineObjectParams>
{
public:
ProgramPipelineObjectBenchmark();
void initializeBenchmark() override;
void destroyBenchmark() override;
void drawBenchmark() override;
protected:
GLuint mVertProg1 = 0;
GLuint mVertProg2 = 0;
GLuint mFragProg1 = 0;
GLuint mFragProg2 = 0;
GLuint mPpo = 0;
};
ProgramPipelineObjectBenchmark::ProgramPipelineObjectBenchmark()
: ANGLERenderTest("ProgramPipelineObject", GetParam())
{}
void ProgramPipelineObjectBenchmark::initializeBenchmark()
{
glGenProgramPipelines(1, &mPpo);
glBindProgramPipeline(mPpo);
// Create 2 separable vertex and fragment program objects from the same source.
const GLchar *vertString = essl31_shaders::vs::Simple();
const GLchar *fragString = R"(#version 310 es
precision highp float;
uniform float redColorIn;
uniform float greenColorIn;
out vec4 my_FragColor;
void main()
{
my_FragColor = vec4(redColorIn, greenColorIn, 0.0, 1.0);
})";
mVertProg1 = glCreateShaderProgramv(GL_VERTEX_SHADER, 1, &vertString);
ASSERT_NE(mVertProg1, 0u);
mVertProg2 = glCreateShaderProgramv(GL_VERTEX_SHADER, 1, &vertString);
ASSERT_NE(mVertProg2, 0u);
mFragProg1 = glCreateShaderProgramv(GL_FRAGMENT_SHADER, 1, &fragString);
ASSERT_NE(mFragProg1, 0u);
mFragProg2 = glCreateShaderProgramv(GL_FRAGMENT_SHADER, 1, &fragString);
ASSERT_NE(mFragProg2, 0u);
}
void ProgramPipelineObjectBenchmark::destroyBenchmark()
{
glDeleteProgramPipelines(1, &mPpo);
glDeleteProgram(mVertProg1);
glDeleteProgram(mVertProg2);
glDeleteProgram(mFragProg1);
glDeleteProgram(mFragProg2);
}
void ProgramPipelineObjectBenchmark::drawBenchmark()
{
glUseProgramStages(mPpo, GL_VERTEX_SHADER_BIT, mVertProg1);
glUseProgramStages(mPpo, GL_FRAGMENT_SHADER_BIT, mFragProg1);
// Set the output color to red
GLint location = glGetUniformLocation(mFragProg1, "redColorIn");
glActiveShaderProgram(mPpo, mFragProg1);
glUniform1f(location, 1.0);
location = glGetUniformLocation(mFragProg1, "greenColorIn");
glActiveShaderProgram(mPpo, mFragProg1);
glUniform1f(location, 0.0);
// Change vertex and fragment programs of the pipeline before the draw.
glUseProgramStages(mPpo, GL_VERTEX_SHADER_BIT, mVertProg2);
glUseProgramStages(mPpo, GL_FRAGMENT_SHADER_BIT, mFragProg2);
// Set the output color to blue
location = glGetUniformLocation(mFragProg2, "greenColorIn");
glActiveShaderProgram(mPpo, mFragProg2);
glUniform1f(location, 0.0);
location = glGetUniformLocation(mFragProg2, "blueColorIn");
glActiveShaderProgram(mPpo, mFragProg2);
glUniform1f(location, 1.0);
// Draw
const std::array<Vector3, 6> kQuadVertices = {{
Vector3(-1.0f, 1.0f, 0.5f),
Vector3(-1.0f, -1.0f, 0.5f),
Vector3(1.0f, -1.0f, 0.5f),
Vector3(-1.0f, 1.0f, 0.5f),
}};
GLint positionLocation = glGetAttribLocation(mVertProg2, "a_position");
glBindBuffer(GL_ARRAY_BUFFER, 0);
glVertexAttribPointer(positionLocation, 3, GL_FLOAT, GL_FALSE, 0, kQuadVertices.data());
glEnableVertexAttribArray(positionLocation);
glDrawArrays(GL_TRIANGLES, 0, 6);
glDisableVertexAttribArray(positionLocation);
glVertexAttribPointer(positionLocation, 4, GL_FLOAT, GL_FALSE, 0, nullptr);
}
using namespace egl_platform;
ProgramPipelineObjectParams ProgramPipelineObjectVulkanParams()
{
ProgramPipelineObjectParams params;
params.eglParameters = VULKAN();
return params;
}
ProgramPipelineObjectParams ProgramPipelineObjectVulkanNullParams()
{
ProgramPipelineObjectParams params;
params.eglParameters = VULKAN_NULL();
return params;
}
// Test performance of switching programs before a draw.
TEST_P(ProgramPipelineObjectBenchmark, Run)
{
run();
}
ANGLE_INSTANTIATE_TEST(ProgramPipelineObjectBenchmark,
ProgramPipelineObjectVulkanParams(),
ProgramPipelineObjectVulkanNullParams());
} // anonymous namespace