-
Show log
Commit
-
Hash : f1e19872
Author :
Date : 2023-06-12T14:38:23
Vulkan: Fix read pixels with RGBX Typically, the format used for data uploads and downloads as well as the storage format are consistent. That is unfortunately not the case for GL_RGBX8_ANGLE where data uploads are through 3-byte RGB pixels while downloads are through 4-byte RGBX pixels. This change swaps out RGBX for RGBA on the read pixels path. Test credit of Jason Macnak <natsu@google.com> Bug: b/246008627 Test: atest CtsSkQPTestCases Change-Id: I531ebd8318bf4fe5ac09c623068b790a7e301428 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4608488 Reviewed-by: Jason Macnak <natsu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Files
- BufferImpl.cpp
- BufferImpl.h
- BufferImpl_mock.h
- CLCommandQueueImpl.cpp
- CLCommandQueueImpl.h
- CLContextImpl.cpp
- CLContextImpl.h
- CLDeviceImpl.cpp
- CLDeviceImpl.h
- CLEventImpl.cpp
- CLEventImpl.h
- CLExtensions.cpp
- CLExtensions.h
- CLKernelImpl.cpp
- CLKernelImpl.h
- CLMemoryImpl.cpp
- CLMemoryImpl.h
- CLPlatformImpl.cpp
- CLPlatformImpl.h
- CLProgramImpl.cpp
- CLProgramImpl.h
- CLSamplerImpl.cpp
- CLSamplerImpl.h
- CLtypes.h
- CompilerImpl.h
- ContextImpl.cpp
- ContextImpl.h
- DeviceImpl.cpp
- DeviceImpl.h
- DisplayImpl.cpp
- DisplayImpl.h
- EGLImplFactory.h
- EGLReusableSync.cpp
- EGLReusableSync.h
- EGLSyncImpl.cpp
- EGLSyncImpl.h
- FenceNVImpl.h
- Format.h
- FormatID_autogen.h
- Format_table_autogen.cpp
- FramebufferAttachmentObjectImpl.h
- FramebufferImpl.cpp
- FramebufferImpl.h
- FramebufferImpl_mock.h
- GLImplFactory.h
- ImageImpl.cpp
- ImageImpl.h
- ImageImpl_mock.h
- MemoryObjectImpl.h
- OverlayImpl.h
- ProgramImpl.cpp
- ProgramImpl.h
- ProgramImpl_mock.h
- ProgramPipelineImpl.cpp
- ProgramPipelineImpl.h
- QueryImpl.cpp
- QueryImpl.h
- README.md
- RenderTargetCache.h
- RenderbufferImpl.cpp
- RenderbufferImpl.h
- RenderbufferImpl_mock.h
- SamplerImpl.h
- SemaphoreImpl.h
- ShaderImpl.cpp
- ShaderImpl.h
- StreamProducerImpl.h
- SurfaceImpl.cpp
- SurfaceImpl.h
- SyncImpl.h
- TextureImpl.cpp
- TextureImpl.h
- TextureImpl_mock.h
- TransformFeedbackImpl.cpp
- TransformFeedbackImpl.h
- TransformFeedbackImpl_mock.h
- VertexArrayImpl.cpp
- VertexArrayImpl.h
- angle_format.py
- angle_format_data.json
- angle_format_map.json
- cl/
- copyvertex.h
- copyvertex.inc.h
- d3d/
- d3d_format.cpp
- d3d_format.h
- driver_utils.cpp
- driver_utils.h
- driver_utils_ios.mm
- driver_utils_mac.mm
- dxgi_format_data.json
- dxgi_format_map.h
- dxgi_format_map_autogen.cpp
- dxgi_support_data.json
- dxgi_support_table.h
- dxgi_support_table_autogen.cpp
- gen_angle_format_table.py
- gen_dxgi_format_table.py
- gen_dxgi_support_tables.py
- gen_load_functions_table.py
- gl/
- load_functions_data.json
- load_functions_table.h
- load_functions_table_autogen.cpp
- metal/
- null/
- renderer_utils.cpp
- renderer_utils.h
- serial_utils.h
- serial_utils_unittest.cpp
- vulkan/
-
README.md
-
ANGLE back-ends
This folder contains shared back-end-specific implementation files. The classes and types in
rendererare not specified by GLES. They instead are common to all the various ANGLE implementations.See
renderer_utils.hfor various cross back-end utilties.ANGLE Formats
The ANGLE format class,
angle::Format, works as a union between GLES and all the various back-end formats. It can represent any type of format in ANGLE. e.g. Formats in Vulkan that don’t exist in GLES, or DXGI formats that don’t exist in GLES, or Windows/Android surface configs that don’t exist anywhere else.The
glInternalFormatmember ofangle::Formatrepresents the “closest” GL format for an ANGLE format. For formats that don’t exist in GLES this will not be exactly what the format represents.The back-ends also define their own format tables. See the Vulkan Format table docs and the [D3D11 format table docs][D23D11FormatDocs].
DXGI Format Info
DXGI formats are used in both the GL and D3D11 back-end. Therefore the generated info table lives in this common shared location.
The DXGI info table is generated by
gen_dxgi_format_table.pyand sources data fromdxgi_format_data.json. The main purpose of the table is to convert from a DXGI format to an ANGLE format, where the ANGLE format should have all the necessary information.