kc3-lang/angle/src/libANGLE/RefCountObject.h

Branch : - branch - main - tag -

• Show log

  Commit

• Author : James Darpinian
  Date : 2018-01-04 18:02:24
  Hash : e8a93c6e
  Message : New transform feedback buffer binding rules Detects undefined behavior when a buffer is bound to a transform feedback binding point and a non transform feedback binding point at the same time. Also moves the transform feedback buffer generic binding point out of the transform feedback object and into the context's global state, to match driver behavior. This way binding a new transform feedback object does not affect GL_TRANSFORM_FEEDBACK_BUFFER_BINDING which is similar to how VAOs work with GL_ARRAY_BUFFER_BINDING. Bug: 696345 Change-Id: If3b9306cde7cd2197a8ce35e10c3af9ee58da0b8 Reviewed-on: https://chromium-review.googlesource.com/853130 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>

• src/libANGLE/RefCountObject.h

• //
  // Copyright (c) 2002-2010 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // RefCountObject.h: Defines the gl::RefCountObject base class that provides
  // lifecycle support for GL objects using the traditional BindObject scheme, but
  // that need to be reference counted for correct cross-context deletion.
  // (Concretely, textures, buffers and renderbuffers.)
  
  #ifndef LIBANGLE_REFCOUNTOBJECT_H_
  #define LIBANGLE_REFCOUNTOBJECT_H_
  
  #include "angle_gl.h"
  #include "common/debug.h"
  #include "libANGLE/Error.h"
  
  #include <cstddef>
  
  namespace gl
  {
  class Context;
  
  class RefCountObjectNoID : angle::NonCopyable
  {
    public:
      RefCountObjectNoID() : mRefCount(0) {}
      virtual Error onDestroy(const Context *context);
  
      void addRef() const { ++mRefCount; }
  
      void release() const
      {
          ASSERT(mRefCount > 0);
  
          if (--mRefCount == 0)
          {
              delete this;
          }
      }
  
      size_t getRefCount() const { return mRefCount; }
  
    protected:
      virtual ~RefCountObjectNoID();
  
      // A specialized release method for objects which need a destroy context.
      void release(const gl::Context *context)
      {
          ASSERT(mRefCount > 0);
          if (--mRefCount == 0)
          {
              ANGLE_SWALLOW_ERR(onDestroy(context));
              delete this;
          }
      }
  
      template <class ObjectType>
      friend class BindingPointer;
      mutable std::size_t mRefCount;
  };
  
  inline RefCountObjectNoID::~RefCountObjectNoID()
  {
      ASSERT(mRefCount == 0);
  }
  
  inline Error RefCountObjectNoID::onDestroy(const Context *context)
  {
      return NoError();
  }
  
  template <class ObjectType>
  class BindingPointer;
  
  class RefCountObject : RefCountObjectNoID
  {
    public:
      explicit RefCountObject(GLuint id) : mId(id) {}
  
      GLuint id() const { return mId; }
  
      using RefCountObjectNoID::release;
      using RefCountObjectNoID::addRef;
      using RefCountObjectNoID::getRefCount;
  
    protected:
      ~RefCountObject() override {}
  
    private:
      GLuint mId;
  };
  
  template <class ObjectType>
  class BindingPointer
  {
    public:
      BindingPointer()
          : mObject(nullptr)
      {
      }
  
      BindingPointer(ObjectType *object) : mObject(object) { mObject->addRef(); }
  
      BindingPointer(const BindingPointer<ObjectType> &other) : mObject(other.mObject)
      {
          mObject->addRef();
      }
  
      BindingPointer &operator=(BindingPointer<ObjectType> &&other)
      {
          std::swap(mObject, other.mObject);
          return *this;
      }
  
      virtual ~BindingPointer()
      {
          // Objects have to be released before the resource manager is destroyed, so they must be explicitly cleaned up.
          ASSERT(mObject == nullptr);
      }
  
      virtual void set(const Context *context, ObjectType *newObject)
      {
          // addRef first in case newObject == mObject and this is the last reference to it.
          if (newObject != nullptr) reinterpret_cast<const RefCountObjectNoID*>(newObject)->addRef();
          // Store the old pointer in a temporary so we can set the pointer before calling release.
          // Otherwise the object could still be referenced when its destructor is called.
          ObjectType *oldObject = mObject;
          mObject = newObject;
          if (oldObject != nullptr)
              reinterpret_cast<RefCountObjectNoID *>(oldObject)->release(context);
      }
  
      ObjectType *get() const { return mObject; }
      ObjectType *operator->() const { return mObject; }
  
      GLuint id() const { return (mObject != nullptr) ? mObject->id() : 0; }
  
      bool operator==(const BindingPointer<ObjectType> &other) const
      {
          return mObject == other.mObject;
      }
  
      bool operator!=(const BindingPointer<ObjectType> &other) const { return !(*this == other); }
  
    private:
      ObjectType *mObject;
  };
  
  template <class ObjectType>
  class OffsetBindingPointer : public BindingPointer<ObjectType>
  {
    public:
      OffsetBindingPointer() : mOffset(0), mSize(0) { }
  
      void set(const Context *context, ObjectType *newObject) override
      {
          BindingPointer<ObjectType>::set(context, newObject);
          mOffset = 0;
          mSize = 0;
      }
  
      void set(const Context *context, ObjectType *newObject, GLintptr offset, GLsizeiptr size)
      {
          BindingPointer<ObjectType>::set(context, newObject);
          mOffset = offset;
          mSize = size;
      }
  
      GLintptr getOffset() const { return mOffset; }
      GLsizeiptr getSize() const { return mSize; }
  
      bool operator==(const OffsetBindingPointer<ObjectType> &other) const
      {
          return this->get() == other.get() && mOffset == other.mOffset && mSize == other.mSize;
      }
  
      bool operator!=(const OffsetBindingPointer<ObjectType> &other) const
      {
          return !(*this == other);
      }
  
    private:
      GLintptr mOffset;
      GLsizeiptr mSize;
  };
  }  // namespace gl
  
  #endif   // LIBANGLE_REFCOUNTOBJECT_H_