Hash :
aec5e65c
Author :
Date :
2021-07-28T00:36:12
Get direct-to-Metal backend to run angle_end2end_tests. Cherry-pick nameless struct fix from Apple in https://bugs.webkit.org/show_bug.cgi?id=227482 . Fix SeparateCompoundStructDeclarations pass to stop generating multiple declarations; thanks syoussefi@ for advice. Incorporate additional passes from TranslatorVulkan (MonomorphizeUnsupportedFunctionsInVulkanGLSL, RewriteArrayOfArrayOfOpaqueUniforms, SeparateStructFromUniformDeclarations) needed by RewriteStructSamplers pass in TranslatorMetalDirect. Fixes many assertion failures in GLSL tests. Moved these passes out of tree_ops/vulkan. Thanks again to syoussefi@ for advice and help. Disable a validation check related to the RewritePipelines pass. Skip two tests that were failing for other reasons. With these changes, angle_end2end_tests runs to completion when the direct-to-Metal backend is turned on. There are still ~1300 failures of the ~4000 tests which will be investigated next. Bug: angleproject:5505 Change-Id: Ibca77822543e8e8e8d2a8c862e92cdf74bfa3545 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3058524 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103
//
// Copyright 2020 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#include <cctype>
#include <cstring>
#include <limits>
#include <unordered_map>
#include <unordered_set>
#include "compiler/translator/TranslatorMetalDirect/RewriteKeywords.h"
using namespace sh;
////////////////////////////////////////////////////////////////////////////////
IdGen::IdGen() {}
template <typename String, typename StringToImmutable>
Name IdGen::createNewName(size_t count,
const String *baseNames,
const StringToImmutable &toImmutable)
{
const unsigned id = mNext++;
char idBuffer[std::numeric_limits<unsigned>::digits10 + 1];
sprintf(idBuffer, "%u", id);
mNewNameBuffer.clear();
mNewNameBuffer += '_';
mNewNameBuffer += idBuffer;
// Note:
// Double underscores are only allowed in C++ (and thus Metal) vendor identifiers, so here we
// take care not to introduce any.
for (size_t i = 0; i < count; ++i)
{
const ImmutableString baseName = toImmutable(baseNames[i]);
if (!baseName.empty())
{
const char *base = baseName.data();
if (baseName.beginsWith(kAngleInternalPrefix))
{
base += sizeof(kAngleInternalPrefix) - 1;
}
if (*base == '_')
{
++base;
}
ASSERT(*base != '_');
if (mNewNameBuffer.back() != '_')
{
mNewNameBuffer += '_';
}
mNewNameBuffer += base;
}
}
return Name(ImmutableString(mNewNameBuffer), SymbolType::AngleInternal);
}
Name IdGen::createNewName(const ImmutableString &baseName)
{
return createNewName({baseName});
}
Name IdGen::createNewName(const Name &baseName)
{
return createNewName(baseName.rawName());
}
Name IdGen::createNewName(const char *baseName)
{
return createNewName(ImmutableString(baseName));
}
Name IdGen::createNewName(std::initializer_list<ImmutableString> baseNames)
{
return createNewName(baseNames.size(), baseNames.begin(),
[](const ImmutableString &s) { return s; });
}
Name IdGen::createNewName(std::initializer_list<Name> baseNames)
{
return createNewName(baseNames.size(), baseNames.begin(),
[](const Name &s) { return s.rawName(); });
}
Name IdGen::createNewName(std::initializer_list<const char *> baseNames)
{
return createNewName(baseNames.size(), baseNames.begin(),
[](const char *s) { return ImmutableString(s); });
}
Name IdGen::createNewName()
{
// TODO(anglebug.com/5505): refactor this later.
return createNewName<int>(0, nullptr, [](int) { return kEmptyImmutableString; });
}