kc3-lang/angle/src/compiler/translator/tree_util/DriverUniform.h

• Show log

  Commit

• Hash : b3cbfd55
  Author :
  Date : 2021-07-07T12:31:57
  

  Fix multiple end2end crashes in direct-to-MSL compiler.
  
  This set of changes:
  
   - Adds a single place (CompilerMtl::useDirectToMSLCompiler) where the
     direct-to-MSL compiler can be enabled, still at compile time rather
     than run time. It is still disabled by default.
   - Initializes MTLWaitableCompileEventImpl::mShader, without which all
     shader compiles crash.
   - Fixes a mismatch of the ANGLERasterizerDisabled variable name in
     the generated MSL.
   - Removes the transform feedback bindings as an argument to the
     vertex shader's main0(). Transform feedback support needs to be
     reimplemented in this compiler backend.
   - Added an option to the DriverUniform class to emit as either an
     interface block or a struct. The direct-to-MSL backend assumes it
     is a struct.
   - Disable variable reference validation when referencing either
     sample mask or rasterizer discard functionality in the shader.
   - Disable struct usage validation when inserting references to
     ANGLE_TextureEnv. This occurs during pipeline rewriting and it's
     infeasible to disable it at that point, so disable it during
     pipeline rewriting - which means it's disabled for all shaders.
   - For angle_end2end_tests, disable the file API hooking which
     disables the Metal shader cache. This speeds up the tests
     significantly - by roughly a factor of 5.
  
  With these changes, several hundred angle_end2end_tests run without
  any assertion failures, though still with many test failures. The next
  crash is in:
   GLSLTest.NamelessScopedStructs/ES2_Metal
  and will likely require a larger bug fix, or more changes to be
  upstreamed from WebKit's repository.
  
  Bug: angleproject:5505
  Change-Id: Ia1ea9a13867f00035d4aeccf907fd032255588e3
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3010486
  Commit-Queue: Kenneth Russell <kbr@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
  

Download

• src/compiler/translator/tree_util/DriverUniform.h

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // DriverUniform.h: Add code to support driver uniforms
  //
  
  #ifndef COMPILER_TRANSLATOR_TREEUTIL_DRIVERUNIFORM_H_
  #define COMPILER_TRANSLATOR_TREEUTIL_DRIVERUNIFORM_H_
  
  #include "common/angleutils.h"
  #include "compiler/translator/Types.h"
  
  namespace sh
  {
  
  class TCompiler;
  class TIntermBlock;
  class TIntermNode;
  class TSymbolTable;
  class TIntermTyped;
  class TIntermSwizzle;
  class TIntermBinary;
  
  enum class DriverUniformMode
  {
      // Define the driver uniforms as an interface block. Used by the
      // Vulkan and Metal/SPIR-V backends.
      InterfaceBlock,
  
      // Define the driver uniforms as a structure. Used by the
      // direct-to-MSL Metal backend.
      Structure
  };
  
  class DriverUniform
  {
    public:
      DriverUniform(DriverUniformMode mode)
          : mMode(mode), mDriverUniforms(nullptr), mEmulatedDepthRangeType(nullptr)
      {}
      virtual ~DriverUniform() = default;
  
      bool addComputeDriverUniformsToShader(TIntermBlock *root, TSymbolTable *symbolTable);
      bool addGraphicsDriverUniformsToShader(TIntermBlock *root, TSymbolTable *symbolTable);
  
      TIntermBinary *getViewportRef() const;
      TIntermBinary *getAbcBufferOffsets() const;
      TIntermBinary *getXfbActiveUnpaused() const;
      TIntermBinary *getXfbVerticesPerInstance() const;
      TIntermBinary *getXfbBufferOffsets() const;
      TIntermBinary *getClipDistancesEnabled() const;
      TIntermBinary *getDepthRangeRef() const;
      TIntermBinary *getDepthRangeReservedFieldRef() const;
      TIntermBinary *getNumSamplesRef() const;
  
      virtual TIntermBinary *getFlipXYRef() const { return nullptr; }
      virtual TIntermBinary *getNegFlipXYRef() const { return nullptr; }
      virtual TIntermBinary *getPreRotationMatrixRef() const { return nullptr; }
      virtual TIntermBinary *getFragRotationMatrixRef() const { return nullptr; }
      virtual TIntermBinary *getHalfRenderAreaRef() const { return nullptr; }
      virtual TIntermSwizzle *getNegFlipYRef() const { return nullptr; }
      virtual TIntermBinary *getEmulatedInstanceId() const { return nullptr; }
      virtual TIntermBinary *getCoverageMask() const { return nullptr; }
  
      const TVariable *getDriverUniformsVariable() const { return mDriverUniforms; }
  
    protected:
      TIntermBinary *createDriverUniformRef(const char *fieldName) const;
      virtual TFieldList *createUniformFields(TSymbolTable *symbolTable);
      TType *createEmulatedDepthRangeType(TSymbolTable *symbolTable);
  
      const DriverUniformMode mMode;
      const TVariable *mDriverUniforms;
      TType *mEmulatedDepthRangeType;
  };
  
  class DriverUniformExtended : public DriverUniform
  {
    public:
      DriverUniformExtended(DriverUniformMode mode) : DriverUniform(mode) {}
      virtual ~DriverUniformExtended() override {}
  
      TIntermBinary *getFlipXYRef() const override;
      TIntermBinary *getNegFlipXYRef() const override;
      TIntermBinary *getPreRotationMatrixRef() const override;
      TIntermBinary *getFragRotationMatrixRef() const override;
      TIntermBinary *getHalfRenderAreaRef() const override;
      TIntermSwizzle *getNegFlipYRef() const override;
      TIntermBinary *getEmulatedInstanceId() const override;
      TIntermBinary *getCoverageMask() const override;
  
    protected:
      virtual TFieldList *createUniformFields(TSymbolTable *symbolTable) override;
  };
  
  }  // namespace sh
  
  #endif  // COMPILER_TRANSLATOR_TREEUTIL_DRIVERUNIFORM_H_
  

Download