Hash :
47c66901
Author :
Date :
2024-10-21T12:47:22
Vulkan: Set gl_Layer to 0 if the framebuffer is not layered Bug: angleproject:372390039 Change-Id: I29067c9488e06f6dd2e90f207fecb843267fb77c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5949263 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115
//
// Copyright 2024 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// ClampGLLayer: Clamp gl_Layer to 0 if framebuffer is not layered.
//
#include "compiler/translator/tree_ops/spirv/ClampGLLayer.h"
#include "compiler/translator/StaticType.h"
#include "compiler/translator/SymbolTable.h"
#include "compiler/translator/tree_util/DriverUniform.h"
#include "compiler/translator/tree_util/IntermNode_util.h"
#include "compiler/translator/tree_util/IntermTraverse.h"
namespace sh
{
namespace
{
// A traverser to check if gl_Layer is used at all.
class HasGLLayerTraverser : public TIntermTraverser
{
public:
HasGLLayerTraverser(TSymbolTable *symbolTable)
: TIntermTraverser(true, false, false, symbolTable)
{}
bool referencesGLLayer() const { return mReferencesGLLayer; }
void visitSymbol(TIntermSymbol *symbol) override
{
if (symbol->getQualifier() == EvqLayerOut)
{
mReferencesGLLayer = true;
}
}
private:
bool mReferencesGLLayer = false;
};
// A traverser that adds `if (!layeredFramebuffer) gl_Layer = 0;` before emitVertex() in geometry
// shaders.
class ClampGLLayerTraverser : public TIntermTraverser
{
public:
ClampGLLayerTraverser(TSymbolTable *symbolTable,
const DriverUniform *driverUniforms,
int shaderVersion)
: TIntermTraverser(true, false, false, symbolTable),
mDriverUniforms(driverUniforms),
mShaderVersion(shaderVersion)
{}
bool visitAggregate(Visit visit, TIntermAggregate *node) override;
private:
const DriverUniform *mDriverUniforms;
int mShaderVersion;
};
bool ClampGLLayerTraverser::visitAggregate(Visit visit, TIntermAggregate *node)
{
ASSERT(visit == Visit::PreVisit);
if (node->getOp() != EOpEmitVertex)
{
return false;
}
// if (!layeredFramebuffer)
TIntermTyped *layeredFramebuffer =
new TIntermUnary(EOpLogicalNot, mDriverUniforms->getLayeredFramebuffer(), nullptr);
// gl_Layer = 0;
const TVariable *gl_Layer = static_cast<const TVariable *>(
mSymbolTable->findBuiltIn(ImmutableString("gl_Layer"), mShaderVersion));
TIntermBinary *setToZero =
new TIntermBinary(EOpAssign, new TIntermSymbol(gl_Layer), CreateIndexNode(0));
TIntermBlock *block = new TIntermBlock;
block->appendStatement(setToZero);
TIntermIfElse *ifNotLayered = new TIntermIfElse(layeredFramebuffer, block, nullptr);
TIntermSequence replacement;
replacement.push_back(ifNotLayered);
replacement.push_back(node);
mMultiReplacements.emplace_back(getParentNode()->getAsBlock(), node, std::move(replacement));
return false;
}
} // anonymous namespace
bool ClampGLLayer(TCompiler *compiler,
TIntermBlock *root,
TSymbolTable *symbolTable,
const DriverUniform *driverUniforms)
{
// First, check if there is a reference to gl_Layer. If there isn't, there's nothing to do.
// Note that if gl_Layer isn't otherwise set, this transformation adds static usage of it
// without initializaing it in every path, leading to multiple drivers crashing / failing tests.
HasGLLayerTraverser hasGLLayer(symbolTable);
root->traverse(&hasGLLayer);
if (!hasGLLayer.referencesGLLayer())
{
return true;
}
ClampGLLayerTraverser traverser(symbolTable, driverUniforms, compiler->getShaderVersion());
root->traverse(&traverser);
return traverser.updateTree(compiler, root);
}
} // namespace sh