kc3-lang/angle/src/libANGLE/renderer/FramebufferAttachmentObjectImpl.h

• Show log

  Commit

• Hash : acf2f3ad
  Author :
  Date : 2017-11-21T19:22:44
  

  Apply Chromium style fixes.
  
  This addresses several minor code quality issues that are validated
  in Chromium, but not yet applied to ANGLE:
  
  * constructors and destructors must be defined out-of-line
  * auto is not allowed for simple pointer types
  * use override everywhere instead of virtual
  * virtual functions must also be defined out-of-line
  
  Slightly reduces binary size for me (~2k on Win, 150k on Linux).
  
  Bug: angleproject:1569
  Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6
  Reviewed-on: https://chromium-review.googlesource.com/779959
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/renderer/FramebufferAttachmentObjectImpl.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // FramebufferAttachmentObjectImpl.h:
  //   Common ancenstor for all implementations of FBO attachable-objects.
  //   This means Surfaces, Textures and Renderbuffers.
  //
  
  #ifndef LIBANGLE_RENDERER_FRAMEBUFFER_ATTACHMENT_OBJECT_IMPL_H_
  #define LIBANGLE_RENDERER_FRAMEBUFFER_ATTACHMENT_OBJECT_IMPL_H_
  
  #include "libANGLE/FramebufferAttachment.h"
  
  namespace rx
  {
  
  class FramebufferAttachmentObjectImpl : angle::NonCopyable
  {
    public:
      FramebufferAttachmentObjectImpl() {}
      virtual ~FramebufferAttachmentObjectImpl() {}
  
      virtual gl::Error getAttachmentRenderTarget(const gl::Context *context,
                                                  GLenum binding,
                                                  const gl::ImageIndex &imageIndex,
                                                  FramebufferAttachmentRenderTarget **rtOut);
  
      virtual gl::Error initializeContents(const gl::Context *context,
                                           const gl::ImageIndex &imageIndex);
  };
  
  inline gl::Error FramebufferAttachmentObjectImpl::getAttachmentRenderTarget(
      const gl::Context *context,
      GLenum binding,
      const gl::ImageIndex &imageIndex,
      FramebufferAttachmentRenderTarget **rtOut)
  {
      UNIMPLEMENTED();
      return gl::OutOfMemory() << "getAttachmentRenderTarget not supported.";
  }
  
  inline gl::Error FramebufferAttachmentObjectImpl::initializeContents(
      const gl::Context *context,
      const gl::ImageIndex &imageIndex)
  {
      UNIMPLEMENTED();
      return gl::OutOfMemory() << "initialize not supported.";
  }
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_FRAMEBUFFER_ATTACHMENT_OBJECT_IMPL_H_
  

Download