kc3-lang/angle/src/libANGLE/renderer/RenderbufferImpl.h

• Show log

  Commit

• Hash : acf2f3ad
  Author :
  Date : 2017-11-21T19:22:44
  

  Apply Chromium style fixes.
  
  This addresses several minor code quality issues that are validated
  in Chromium, but not yet applied to ANGLE:
  
  * constructors and destructors must be defined out-of-line
  * auto is not allowed for simple pointer types
  * use override everywhere instead of virtual
  * virtual functions must also be defined out-of-line
  
  Slightly reduces binary size for me (~2k on Win, 150k on Linux).
  
  Bug: angleproject:1569
  Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6
  Reviewed-on: https://chromium-review.googlesource.com/779959
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/renderer/RenderbufferImpl.h

• //
  // Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // RenderbufferImpl.h: Defines the abstract class gl::RenderbufferImpl
  
  #ifndef LIBANGLE_RENDERER_RENDERBUFFERIMPL_H_
  #define LIBANGLE_RENDERER_RENDERBUFFERIMPL_H_
  
  #include "angle_gl.h"
  #include "common/angleutils.h"
  #include "libANGLE/Error.h"
  #include "libANGLE/renderer/FramebufferAttachmentObjectImpl.h"
  
  namespace egl
  {
  class Image;
  }
  
  namespace rx
  {
  
  class RenderbufferImpl : public FramebufferAttachmentObjectImpl
  {
    public:
      RenderbufferImpl() {}
      ~RenderbufferImpl() override {}
      virtual gl::Error onDestroy(const gl::Context *context);
  
      virtual gl::Error setStorage(const gl::Context *context,
                                   GLenum internalformat,
                                   size_t width,
                                   size_t height) = 0;
      virtual gl::Error setStorageMultisample(const gl::Context *context,
                                              size_t samples,
                                              GLenum internalformat,
                                              size_t width,
                                              size_t height) = 0;
      virtual gl::Error setStorageEGLImageTarget(const gl::Context *context, egl::Image *image) = 0;
  };
  
  inline gl::Error RenderbufferImpl::onDestroy(const gl::Context *context)
  {
      return gl::NoError();
  }
  }
  
  #endif   // LIBANGLE_RENDERER_RENDERBUFFERIMPL_H_
  

Download