Hash :
acf2f3ad
Author :
Date :
2017-11-21T19:22:44
Apply Chromium style fixes. This addresses several minor code quality issues that are validated in Chromium, but not yet applied to ANGLE: * constructors and destructors must be defined out-of-line * auto is not allowed for simple pointer types * use override everywhere instead of virtual * virtual functions must also be defined out-of-line Slightly reduces binary size for me (~2k on Win, 150k on Linux). Bug: angleproject:1569 Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6 Reviewed-on: https://chromium-review.googlesource.com/779959 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
//
// Copyright (c) 2002-2012 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// VertexBuffer.h: Defines the abstract VertexBuffer class and VertexBufferInterface
// class with derivations, classes that perform graphics API agnostic vertex buffer operations.
#ifndef LIBANGLE_RENDERER_D3D_VERTEXBUFFER_H_
#define LIBANGLE_RENDERER_D3D_VERTEXBUFFER_H_
#include "common/angleutils.h"
#include "libANGLE/Error.h"
#include <GLES2/gl2.h>
#include <cstddef>
#include <cstdint>
#include <vector>
namespace gl
{
struct VertexAttribute;
class VertexBinding;
struct VertexAttribCurrentValueData;
}
namespace rx
{
class BufferFactoryD3D;
// Use a ref-counting scheme with self-deletion on release. We do this so that we can more
// easily manage the static buffer cache, without deleting currently bound buffers.
class VertexBuffer : angle::NonCopyable
{
public:
VertexBuffer();
virtual gl::Error initialize(unsigned int size, bool dynamicUsage) = 0;
// Warning: you should ensure binding really matches attrib.bindingIndex before using this
// function.
virtual gl::Error storeVertexAttributes(const gl::VertexAttribute &attrib,
const gl::VertexBinding &binding,
GLenum currentValueType,
GLint start,
GLsizei count,
GLsizei instances,
unsigned int offset,
const uint8_t *sourceData) = 0;
virtual unsigned int getBufferSize() const = 0;
virtual gl::Error setBufferSize(unsigned int size) = 0;
virtual gl::Error discard() = 0;
unsigned int getSerial() const;
// This may be overridden (e.g. by VertexBuffer11) if necessary.
virtual void hintUnmapResource() { };
// Reference counting.
void addRef();
void release();
protected:
void updateSerial();
virtual ~VertexBuffer();
private:
unsigned int mSerial;
static unsigned int mNextSerial;
unsigned int mRefCount;
};
class VertexBufferInterface : angle::NonCopyable
{
public:
VertexBufferInterface(BufferFactoryD3D *factory, bool dynamic);
virtual ~VertexBufferInterface();
unsigned int getBufferSize() const;
bool empty() const { return getBufferSize() == 0; }
unsigned int getSerial() const;
VertexBuffer *getVertexBuffer() const;
protected:
gl::Error discard();
gl::Error setBufferSize(unsigned int size);
gl::ErrorOrResult<unsigned int> getSpaceRequired(const gl::VertexAttribute &attrib,
const gl::VertexBinding &binding,
GLsizei count,
GLsizei instances) const;
BufferFactoryD3D *const mFactory;
VertexBuffer *mVertexBuffer;
bool mDynamic;
};
class StreamingVertexBufferInterface : public VertexBufferInterface
{
public:
StreamingVertexBufferInterface(BufferFactoryD3D *factory, std::size_t initialSize);
~StreamingVertexBufferInterface() override;
gl::Error storeDynamicAttribute(const gl::VertexAttribute &attrib,
const gl::VertexBinding &binding,
GLenum currentValueType,
GLint start,
GLsizei count,
GLsizei instances,
unsigned int *outStreamOffset,
const uint8_t *sourceData);
gl::Error reserveVertexSpace(const gl::VertexAttribute &attribute,
const gl::VertexBinding &binding,
GLsizei count,
GLsizei instances);
private:
gl::Error reserveSpace(unsigned int size);
unsigned int mWritePosition;
unsigned int mReservedSpace;
};
class StaticVertexBufferInterface : public VertexBufferInterface
{
public:
explicit StaticVertexBufferInterface(BufferFactoryD3D *factory);
~StaticVertexBufferInterface() override;
// Warning: you should ensure binding really matches attrib.bindingIndex before using these
// functions.
gl::Error storeStaticAttribute(const gl::VertexAttribute &attrib,
const gl::VertexBinding &binding,
GLint start,
GLsizei count,
GLsizei instances,
const uint8_t *sourceData);
bool matchesAttribute(const gl::VertexAttribute &attribute,
const gl::VertexBinding &binding) const;
void setAttribute(const gl::VertexAttribute &attribute, const gl::VertexBinding &binding);
private:
class AttributeSignature final : angle::NonCopyable
{
public:
AttributeSignature();
bool matchesAttribute(const gl::VertexAttribute &attrib,
const gl::VertexBinding &binding) const;
void set(const gl::VertexAttribute &attrib, const gl::VertexBinding &binding);
private:
GLenum type;
GLuint size;
GLuint stride;
bool normalized;
bool pureInteger;
size_t offset;
};
AttributeSignature mSignature;
};
} // namespace rx
#endif // LIBANGLE_RENDERER_D3D_VERTEXBUFFER_H_