Hash :
acf2f3ad
Author :
Date :
2017-11-21T19:22:44
Apply Chromium style fixes. This addresses several minor code quality issues that are validated in Chromium, but not yet applied to ANGLE: * constructors and destructors must be defined out-of-line * auto is not allowed for simple pointer types * use override everywhere instead of virtual * virtual functions must also be defined out-of-line Slightly reduces binary size for me (~2k on Win, 150k on Linux). Bug: angleproject:1569 Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6 Reviewed-on: https://chromium-review.googlesource.com/779959 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44
//
// Copyright (c) 2016 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// PathGL.h: Class definition for CHROMIUM_path_rendering path object for the
// GL backend.
#ifndef LIBANGLE_RENDERER_GL_PATHIMPL_H_
#define LIBANGLE_RENDERER_GL_PATHIMPL_H_
#include "libANGLE/renderer/PathImpl.h"
namespace rx
{
class FunctionsGL;
class PathGL : public PathImpl
{
public:
PathGL(const FunctionsGL *functions, GLuint path);
~PathGL() override;
gl::Error setCommands(GLsizei numCommands,
const GLubyte *commands,
GLsizei numCoords,
GLenum coordType,
const void *coords) override;
void setPathParameter(GLenum pname, GLfloat value) override;
GLuint getPathID() const { return mPathID; }
private:
const FunctionsGL *mFunctions;
GLuint mPathID;
};
} // namespace rx
#endif // LIBANGLE_RENDERER_GL_PATHIMPL_H_