Hash :
92019431
Author :
Date :
2017-11-20T13:09:34
Make conversion from GL types to native bools consistant. Some places would compare with "== GL_TRUE" and others with "!= GL_FALSE". This behaviour is not in the OpenGL spec but "!= GL_FALSE" is the most standard and follows the same rules as C and C++. Remove un-necessary validation that params are either GL_TRUE or GL_FALSE. Update some internal storage from GLboolean to bool. BUG=angleproject:2258 Change-Id: I12adbe2d24318a206521ca6ad1099ee7e2bf677e Reviewed-on: https://chromium-review.googlesource.com/779799 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160
//
// Copyright 2016 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// TextureNULL.cpp:
// Implements the class methods for TextureNULL.
//
#include "libANGLE/renderer/null/TextureNULL.h"
#include "common/debug.h"
namespace rx
{
TextureNULL::TextureNULL(const gl::TextureState &state) : TextureImpl(state)
{
}
TextureNULL::~TextureNULL()
{
}
gl::Error TextureNULL::setImage(const gl::Context *context,
GLenum target,
size_t level,
GLenum internalFormat,
const gl::Extents &size,
GLenum format,
GLenum type,
const gl::PixelUnpackState &unpack,
const uint8_t *pixels)
{
// TODO(geofflang): Read all incoming pixel data (maybe hash it?) to make sure we don't read out
// of bounds due to validation bugs.
return gl::NoError();
}
gl::Error TextureNULL::setSubImage(const gl::Context *context,
GLenum target,
size_t level,
const gl::Box &area,
GLenum format,
GLenum type,
const gl::PixelUnpackState &unpack,
const uint8_t *pixels)
{
return gl::NoError();
}
gl::Error TextureNULL::setCompressedImage(const gl::Context *context,
GLenum target,
size_t level,
GLenum internalFormat,
const gl::Extents &size,
const gl::PixelUnpackState &unpack,
size_t imageSize,
const uint8_t *pixels)
{
return gl::NoError();
}
gl::Error TextureNULL::setCompressedSubImage(const gl::Context *context,
GLenum target,
size_t level,
const gl::Box &area,
GLenum format,
const gl::PixelUnpackState &unpack,
size_t imageSize,
const uint8_t *pixels)
{
return gl::NoError();
}
gl::Error TextureNULL::copyImage(const gl::Context *context,
GLenum target,
size_t level,
const gl::Rectangle &sourceArea,
GLenum internalFormat,
const gl::Framebuffer *source)
{
return gl::NoError();
}
gl::Error TextureNULL::copySubImage(const gl::Context *context,
GLenum target,
size_t level,
const gl::Offset &destOffset,
const gl::Rectangle &sourceArea,
const gl::Framebuffer *source)
{
return gl::NoError();
}
gl::Error TextureNULL::setStorage(const gl::Context *context,
GLenum target,
size_t levels,
GLenum internalFormat,
const gl::Extents &size)
{
return gl::NoError();
}
gl::Error TextureNULL::setEGLImageTarget(const gl::Context *context,
GLenum target,
egl::Image *image)
{
return gl::NoError();
}
gl::Error TextureNULL::setImageExternal(const gl::Context *context,
GLenum target,
egl::Stream *stream,
const egl::Stream::GLTextureDescription &desc)
{
return gl::NoError();
}
gl::Error TextureNULL::generateMipmap(const gl::Context *context)
{
return gl::NoError();
}
gl::Error TextureNULL::setBaseLevel(const gl::Context *context, GLuint baseLevel)
{
return gl::NoError();
}
gl::Error TextureNULL::bindTexImage(const gl::Context *context, egl::Surface *surface)
{
return gl::NoError();
}
gl::Error TextureNULL::releaseTexImage(const gl::Context *context)
{
return gl::NoError();
}
void TextureNULL::syncState(const gl::Texture::DirtyBits &dirtyBits)
{
}
gl::Error TextureNULL::setStorageMultisample(const gl::Context *context,
GLenum target,
GLsizei samples,
GLint internalformat,
const gl::Extents &size,
bool fixedSampleLocations)
{
return gl::NoError();
}
gl::Error TextureNULL::initializeContents(const gl::Context *context,
const gl::ImageIndex &imageIndex)
{
return gl::NoError();
}
} // namespace rx