kc3-lang/angle/src/common/angleutils.cpp

• Show log

  Commit

• Hash : 8e7d7a30
  Author :
  Date : 2014-09-02T17:09:08
  

  Fix use of references with va_start
  
  BUG=angle:736
  
  va_start behavior is undefined if the second parameter is a
  function, array, or reference type. clang produces a warning
  for this, while MSVC does not.
  
  Change-Id: I0bc2805e312e3542aac816f10a257e2f1cfad128
  Reviewed-on: https://chromium-review.googlesource.com/216010
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Nico Weber <thakis@chromium.org>
  Tested-by: Nico Weber <thakis@chromium.org>
  

Download

• src/common/angleutils.cpp

• //
  // Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "common/angleutils.h"
  
  #include <vector>
  
  std::string FormatString(const char *fmt, va_list vararg)
  {
      static std::vector<char> buffer(512);
  
      // Attempt to just print to the current buffer
      int len = vsnprintf(&buffer[0], buffer.size(), fmt, vararg);
      if (len < 0 || static_cast<size_t>(len) >= buffer.size())
      {
          // Buffer was not large enough, calculate the required size and resize the buffer
          len = vsnprintf(NULL, 0, fmt, vararg);
          buffer.resize(len + 1);
  
          // Print again
          vsnprintf(&buffer[0], buffer.size(), fmt, vararg);
      }
  
      return std::string(buffer.data(), len);
  }
  
  std::string FormatString(const char *fmt, ...)
  {
      va_list vararg;
      va_start(vararg, fmt);
      std::string result = FormatString(fmt, vararg);
      va_end(vararg);
      return result;
  }
  

Download