kc3-lang/angle/src/gpu_info_util

Diff

• Show log

  Commit

• Hash : 02fb04a8
  Author :
  Date : 2025-04-09T18:36:35
  

  Revert "Reland "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD""
  
  This reverts commit 16c852917d0e384fdba780ee6239ab40c3652a7a.
  
  Reason for revert: causes Chromium Android FYI Release (Nexus 5X) tests failures: https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Nexus%205X)/77632/overview
  
  Original change's description:
  > Reland "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD"
  >
  > This is a reland of 3f028fc158fac948723e8d535463eb80d0a85fed.
  >
  > On Fuchsia, it is possible that there is no vulkan driver and
  > vkCreateInstance() triggered VVLDebugUtilsMessenger.
  > "vkCreateInstance: Found no drivers" is a
  > VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT message. We should only
  > care about VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT message
  > type. Remove VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT and
  > VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT from the
  > VkDebugUtilsMessengerCreateInfoEXT.
  >
  > Add code to print the VVL message in the log so we know what's wrong.
  >
  > Add a condition to only assert when the VVL message severity is
  > VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT.
  >
  > Original change's description:
  > > Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD
  > >
  > > This helps catching bugs for vulkan calls issued
  > > during GetSystemInfoVulkanWithICD().
  > >
  > > Also changed getProc() function to get vulkan function pointers by
  > > calling vkGetInstanceProcAddr(), instead of calling dlsym(). Only use
  > > dlsym() to get vkGetInstanceProcAddr() function pointer.
  >
  > > Bug: angleproject:407116232
  > > Change-Id: I14dce3453c76a084db63fdb45a3db07b7b4d5294
  > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6374305
  > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  > > Reviewed-by: Charlie Lao <cclao@google.com>
  > > Commit-Queue: Yuxin Hu <yuxinhu@google.com>
  >
  > Bug: angleproject:407116232
  > Change-Id: I1ffc4041368782641fc605366ff7cf03e43eb53f
  > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6435033
  > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  
  Bug: angleproject:407116232
  Bug: chromium:409350833
  Change-Id: I29aa9e450180857a993459da8f210df7aad9afaf
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6444658
  Auto-Submit: Yuxin Hu <yuxinhu@google.com>
  Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
  Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
  

• Files

• SystemInfo.cpp
• SystemInfo.h
• SystemInfo_android.cpp
• SystemInfo_apple.mm
• SystemInfo_fuchsia.cpp
• SystemInfo_internal.h
• SystemInfo_ios.cpp
• SystemInfo_libpci.cpp
• SystemInfo_linux.cpp
• SystemInfo_macos.mm
• SystemInfo_unittest.cpp
• SystemInfo_vulkan.cpp
• SystemInfo_vulkan.h
• SystemInfo_win.cpp
• SystemInfo_x11.cpp

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags