• Show log

    Commit

  • Hash : 4b33633a
    Author : Roman Lavrov
    Date : 2022-08-26T16:16:50

    Capture/Replay: Delete binary data in FinishReplay via callback
    
    Delete callback fixes b/179188489 as delete[] will get called from the
    same module where allocation happens. When decompress/delete callbacks
    not provided, new[] and delete[] are called from the fixture.
    
    AFAICT, gBinaryData == nullptr every time, even with a single test and
    --gtest_repeat=N, so we never delete the uncompressed data. When
    running multiple tests locally, I see RES usage grow significantly
    on Linux which this CL fixes. I don't think this matters for bot runs as
    we run tests one by one there.
    
    Bug: b/179188489
    Change-Id: Iee3bccb9d6d72c315c4358b70ec9c3c0ac963258
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3858185
    Reviewed-by: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: Cody Northrop <cnorthrop@google.com>
    Commit-Queue: Roman Lavrov <romanl@google.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags