kc3-lang/angle/src/compiler/translator/InfoSink.cpp

• Show log

  Commit

• Hash : 0f00fbae
  Author :
  Date : 2022-01-21T00:28:48
  

  Translator: Make vec/matrix size getters unsigned
  
  TType stored type's primary and secondary sizes as `unsigned char`, but
  the getters returned `int`.  This caused unnecessary casts when the size
  was passed from one TType to another, as well as comparisons with other
  unsigned numbers.
  
  This change specifies the type of these members as `uint8_t` and makes
  the getters return the same type.  The call sites are accordingly
  adjusted to remove unnecessary casts, use the correct type in local
  variables, and add casts when passed to ostream::operator<<.
  
  Bug: angleproject:6755
  Change-Id: Ia4d86bd4ccb5c1a2ae1e10a0085a5166c3a6bcf7
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3402850
  Reviewed-by: Tim Van Patten <timvp@google.com>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/compiler/translator/InfoSink.cpp

• //
  // Copyright 2002 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "compiler/translator/InfoSink.h"
  
  #include "compiler/translator/ImmutableString.h"
  #include "compiler/translator/Symbol.h"
  #include "compiler/translator/Types.h"
  
  namespace sh
  {
  
  void TInfoSinkBase::prefix(Severity severity)
  {
      switch (severity)
      {
          case SH_WARNING:
              sink.append("WARNING: ");
              break;
          case SH_ERROR:
              sink.append("ERROR: ");
              break;
          default:
              sink.append("UNKOWN ERROR: ");
              break;
      }
  }
  
  TInfoSinkBase &TInfoSinkBase::operator<<(const ImmutableString &str)
  {
      sink.append(str.data());
      return *this;
  }
  
  TInfoSinkBase &TInfoSinkBase::operator<<(const TType &type)
  {
      if (type.isInvariant())
          sink.append("invariant ");
      if (type.getQualifier() != EvqTemporary && type.getQualifier() != EvqGlobal)
      {
          sink.append(type.getQualifierString());
          sink.append(" ");
      }
      if (type.getPrecision() != EbpUndefined)
      {
          sink.append(type.getPrecisionString());
          sink.append(" ");
      }
  
      const TMemoryQualifier &memoryQualifier = type.getMemoryQualifier();
      if (memoryQualifier.readonly)
      {
          sink.append("readonly ");
      }
      if (memoryQualifier.writeonly)
      {
          sink.append("writeonly ");
      }
      if (memoryQualifier.coherent)
      {
          sink.append("coherent ");
      }
      if (memoryQualifier.restrictQualifier)
      {
          sink.append("restrict ");
      }
      if (memoryQualifier.volatileQualifier)
      {
          sink.append("volatile ");
      }
  
      if (type.isArray())
      {
          for (auto arraySizeIter = type.getArraySizes().rbegin();
               arraySizeIter != type.getArraySizes().rend(); ++arraySizeIter)
          {
              *this << "array[" << (*arraySizeIter) << "] of ";
          }
      }
      if (type.isMatrix())
      {
          *this << static_cast<uint32_t>(type.getCols()) << "X"
                << static_cast<uint32_t>(type.getRows()) << " matrix of ";
      }
      else if (type.isVector())
          *this << static_cast<uint32_t>(type.getNominalSize()) << "-component vector of ";
  
      sink.append(type.getBasicString());
  
      if (type.getStruct() != nullptr)
      {
          if (type.getStruct()->symbolType() == SymbolType::Empty)
          {
              *this << " <anonymous>";
          }
          else
          {
              *this << " '" << type.getStruct()->name() << "'";
          }
          if (type.isStructSpecifier())
          {
              *this << " (specifier)";
          }
      }
  
      return *this;
  }
  
  void TInfoSinkBase::location(int file, int line)
  {
      TPersistStringStream stream = sh::InitializeStream<TPersistStringStream>();
      if (line)
          stream << file << ":" << line;
      else
          stream << file << ":? ";
      stream << ": ";
  
      sink.append(stream.str());
  }
  
  }  // namespace sh
  

Download