Hash :
665ddccd
Author :
Date :
2021-12-09T23:06:39
Vulkan: Emulate dithering Dithering in OpenGL is vaguely defined, to the extent that no dithering is also a valid dithering algorithm. Dithering is enabled by default, but emulating it has a non-negligible cost. Similarly to some other GLES drivers, ANGLE enables dithering only on low-bit formats where visual banding is particularly common; namely RGBA4444, RGBA5551 and RGB565. Dithering is emulated in the fragment shader and is controlled by a spec constant. Every 2 bits of the spec constant correspond to one attachment, with the value indicating: - 00: No dithering - 01: Dither for RGBA4444 - 10: Dither for RGBA5551 - 11: Dither for RGB565 The translator appends code to the shader that, based on the format specified by the specialization constant, adds dithering to each color attachment output. A 2x2 Bayer matrix is used for dithering, indexed by gl_FragCoord.xy % 2. Bug: angleproject:6755 Change-Id: Ib45da5938e299b6626bff921119d63e7357dd353 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3374261 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135
//
// Copyright 2017 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// RunAtTheEndOfShader.cpp: Add code to be run at the end of the shader. In case main() contains a
// return statement, this is done by replacing the main() function with another function that calls
// the old main, like this:
//
// void main() { body }
// =>
// void main0() { body }
// void main()
// {
// main0();
// codeToRun
// }
//
// This way the code will get run even if the return statement inside main is executed. This is
// done if main ends in an unconditional |discard| as well, to help with SPIR-V generation that
// expects no dead-code to be present after branches in a block.
//
#include "compiler/translator/tree_util/RunAtTheEndOfShader.h"
#include "compiler/translator/Compiler.h"
#include "compiler/translator/IntermNode.h"
#include "compiler/translator/StaticType.h"
#include "compiler/translator/SymbolTable.h"
#include "compiler/translator/tree_util/FindMain.h"
#include "compiler/translator/tree_util/IntermNode_util.h"
#include "compiler/translator/tree_util/IntermTraverse.h"
namespace sh
{
namespace
{
constexpr const ImmutableString kMainString("main");
class ContainsReturnTraverser : public TIntermTraverser
{
public:
ContainsReturnTraverser() : TIntermTraverser(true, false, false), mContainsReturn(false) {}
bool visitBranch(Visit visit, TIntermBranch *node) override
{
if (node->getFlowOp() == EOpReturn)
{
mContainsReturn = true;
}
return false;
}
bool containsReturn() { return mContainsReturn; }
private:
bool mContainsReturn;
};
bool ContainsReturn(TIntermNode *node)
{
ContainsReturnTraverser traverser;
node->traverse(&traverser);
return traverser.containsReturn();
}
bool EndsInDiscard(TIntermBlock *block)
{
TIntermSequence *statements = block->getSequence();
TIntermBranch *lastStatementAsBranch =
statements->empty() ? nullptr : statements->back()->getAsBranchNode();
// The body can end in discard or return. There is no need to specifically check for discard as
// return is already detected in |ContainsReturn|.
return lastStatementAsBranch != nullptr;
}
void WrapMainAndAppend(TIntermBlock *root,
TIntermFunctionDefinition *main,
TIntermNode *codeToRun,
TSymbolTable *symbolTable)
{
// Replace main() with main0() with the same body.
TFunction *oldMain =
new TFunction(symbolTable, kEmptyImmutableString, SymbolType::AngleInternal,
StaticType::GetBasic<EbtVoid, EbpUndefined>(), false);
TIntermFunctionDefinition *oldMainDefinition =
CreateInternalFunctionDefinitionNode(*oldMain, main->getBody());
bool replaced = root->replaceChildNode(main, oldMainDefinition);
ASSERT(replaced);
// void main()
TFunction *newMain = new TFunction(symbolTable, kMainString, SymbolType::UserDefined,
StaticType::GetBasic<EbtVoid, EbpUndefined>(), false);
TIntermFunctionPrototype *newMainProto = new TIntermFunctionPrototype(newMain);
// {
// main0();
// codeToRun
// }
TIntermBlock *newMainBody = new TIntermBlock();
TIntermSequence emptySequence;
TIntermAggregate *oldMainCall = TIntermAggregate::CreateFunctionCall(*oldMain, &emptySequence);
newMainBody->appendStatement(oldMainCall);
newMainBody->appendStatement(codeToRun);
// Add the new main() to the root node.
TIntermFunctionDefinition *newMainDefinition =
new TIntermFunctionDefinition(newMainProto, newMainBody);
root->appendStatement(newMainDefinition);
}
} // anonymous namespace
bool RunAtTheEndOfShader(TCompiler *compiler,
TIntermBlock *root,
TIntermNode *codeToRun,
TSymbolTable *symbolTable)
{
TIntermFunctionDefinition *main = FindMain(root);
if (ContainsReturn(main) || EndsInDiscard(main->getBody()))
{
WrapMainAndAppend(root, main, codeToRun, symbolTable);
}
else
{
main->getBody()->appendStatement(codeToRun);
}
return compiler->validateAST(root);
}
} // namespace sh