Hash :
25390156
Author :
Date :
2025-08-21T00:13:19
Suppress unsafe buffers on a file-by-file basis in src/ [1 of N] In this CL, we suppress many files but stop short of actually enabling the warning by not removing the line from the unsafe_buffers_paths.txt file. That will happen in a follow-on CL, along with resolving any stragglers missed here. This is mostly a manual change so as to familiarize myself with the kinds of issues faced by the Angle codebase when applying buffer safety warnings. -- Re-generate affected hashes. -- Clang-format applied to all changed files. -- Add a few missing .reserve() calls to vectors as noticed. -- Fix some mismatches between file names and header comments. -- Be more consistent with header comment format (blank lines and trailing //-only lines when a filename comment adjoins license boilerplate). Bug: b/436880895 Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
//
// Copyright 2013 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#ifdef UNSAFE_BUFFERS_BUILD
# pragma allow_unsafe_buffers
#endif
// copyimage.cpp: Defines image copying functions
#include "image_util/copyimage.h"
namespace angle
{
namespace
{
inline uint32_t SwizzleBGRAToRGBA(uint32_t argb)
{
return ((argb & 0x000000FF) << 16) | // Move BGRA blue to RGBA blue
((argb & 0x00FF0000) >> 16) | // Move BGRA red to RGBA red
((argb & 0xFF00FF00)); // Keep alpha and green
}
void CopyBGRA8ToRGBA8Fast(const uint8_t *source,
int srcYAxisPitch,
uint8_t *dest,
int destYAxisPitch,
int destWidth,
int destHeight)
{
for (int y = 0; y < destHeight; ++y)
{
const uint32_t *src32 = reinterpret_cast<const uint32_t *>(source + y * srcYAxisPitch);
uint32_t *dest32 = reinterpret_cast<uint32_t *>(dest + y * destYAxisPitch);
const uint32_t *end32 = src32 + destWidth;
while (src32 != end32)
{
*dest32++ = SwizzleBGRAToRGBA(*src32++);
}
}
}
} // namespace
void CopyBGRA8ToRGBA8(const uint8_t *source,
int srcXAxisPitch,
int srcYAxisPitch,
uint8_t *dest,
int destXAxisPitch,
int destYAxisPitch,
int destWidth,
int destHeight)
{
if (srcXAxisPitch == 4 && destXAxisPitch == 4)
{
CopyBGRA8ToRGBA8Fast(source, srcYAxisPitch, dest, destYAxisPitch, destWidth, destHeight);
return;
}
for (int y = 0; y < destHeight; ++y)
{
uint8_t *dst = dest + y * destYAxisPitch;
const uint8_t *src = source + y * srcYAxisPitch;
const uint8_t *end = src + destWidth * srcXAxisPitch;
while (src != end)
{
*reinterpret_cast<uint32_t *>(dst) =
SwizzleBGRAToRGBA(*reinterpret_cast<const uint32_t *>(src));
src += srcXAxisPitch;
dst += destXAxisPitch;
}
}
}
} // namespace angle