-
Show log
Commit
-
Hash : 4d478713
Author :
Date : 2025-04-03T08:10:40
Revert "Metal: Make StateCache descriptors hash consistent" This reverts commit 4334125be506e0c2c5dde4cfc29b31a7ff2bdec6. Reason for revert: Pipeline creation failures. Bug: chromium:407310859 Original change's description: > Metal: Make StateCache descriptors hash consistent > > Various descriptors would compare equality and do hashing based on the > underlying storage. The storage contains alignment padding and > bitfields. The contents of these are not defined, even when the > constructors tried to memset and memcpy. > > The various hash and compare functions also seemed to be missing some > elements, like rasterSampleCount. > > Missing == on fields and hashing unused memory may lead to inconsistency > where a==b is true but hash(a) != hash(b). > > Fix by: > Remove the memset/memcpy and write out the operator== and > hash() consistently. > > Initialize the members to their default values. > > Use uint32_t : 1 instead of bool if the struct tries to optimize for > size, since mixing types stops the packing. > > Use uint32_t to get the alignment to uint32_t, which is mostly what > is expected. > > Use uint32 someVar : N where N is payload bits + padding bits for > the last member. This way the assignment clears the padding bits. > The goal os to get the operator== to compare the padding bits, which > lets the compiler elide the memberwise compares and use word-wise > compares where it makes sense. > > This is an attempt to fix rare crashes related to map inserts > and lookups. std::unordered_map will crash if operator== is not > consistent with hash. > > Bug: angleproject:403372465 > Change-Id: I0a3a2ff327ac9f65e7d41bc9585cda54ce93ab86 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6355828 > Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> > Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> > Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:403372465 Change-Id: Id111c0728b603776fd8085fd395819bb5aa14722 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6428466 Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
-
Files
- BUILD.gn
- BufferMtl.h
- BufferMtl.mm
- CompilerMtl.h
- CompilerMtl.mm
- ContextMtl.h
- ContextMtl.mm
- DeviceMtl.h
- DeviceMtl.mm
- DisplayMtl.h
- DisplayMtl.mm
- DisplayMtl_api.h
- FrameBufferMtl.h
- FrameBufferMtl.mm
- IOSurfaceSurfaceMtl.h
- IOSurfaceSurfaceMtl.mm
- ImageMtl.h
- ImageMtl.mm
- OWNERS
- ProgramExecutableMtl.h
- ProgramExecutableMtl.mm
- ProgramMtl.h
- ProgramMtl.mm
- ProvokingVertexHelper.h
- ProvokingVertexHelper.mm
- QueryMtl.h
- QueryMtl.mm
- RenderBufferMtl.h
- RenderBufferMtl.mm
- RenderTargetMtl.h
- RenderTargetMtl.mm
- SamplerMtl.h
- SamplerMtl.mm
- ShaderMtl.h
- ShaderMtl.mm
- SurfaceMtl.h
- SurfaceMtl.mm
- SyncMtl.h
- SyncMtl.mm
- TextureMtl.h
- TextureMtl.mm
- TransformFeedbackMtl.h
- TransformFeedbackMtl.mm
- VertexArrayMtl.h
- VertexArrayMtl.mm
- blocklayoutMetal.cpp
- blocklayoutMetal.h
- doc/
- file_hooking/
- gen_mtl_format_table.py
- metal_backend.gni
- mtl_buffer_manager.h
- mtl_buffer_manager.mm
- mtl_buffer_pool.h
- mtl_buffer_pool.mm
- mtl_command_buffer.h
- mtl_command_buffer.mm
- mtl_common.h
- mtl_common.mm
- mtl_context_device.h
- mtl_context_device.mm
- mtl_format_map.json
- mtl_format_table_autogen.mm
- mtl_format_utils.h
- mtl_format_utils.mm
- mtl_library_cache.h
- mtl_library_cache.mm
- mtl_msl_utils.h
- mtl_msl_utils.mm
- mtl_occlusion_query_pool.h
- mtl_occlusion_query_pool.mm
- mtl_pipeline_cache.h
- mtl_pipeline_cache.mm
- mtl_render_utils.h
- mtl_render_utils.mm
- mtl_resource_spi.h
- mtl_resources.h
- mtl_resources.mm
- mtl_state_cache.h
- mtl_state_cache.mm
- mtl_utils.h
- mtl_utils.mm
- renderermtl_utils.cpp
- renderermtl_utils.h
- shaders/
