kc3-lang/angle/src/compiler/preprocessor/Input.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/compiler/preprocessor/Input.cpp

• //
  // Copyright 2011 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "compiler/preprocessor/Input.h"
  
  #include <algorithm>
  #include <cstring>
  
  #include "common/debug.h"
  
  namespace angle
  {
  
  namespace pp
  {
  
  Input::Input() : mCount(0), mString(0) {}
  
  Input::~Input() {}
  
  Input::Input(size_t count, const char *const string[], const int length[])
      : mCount(count), mString(string)
  {
      mLength.reserve(mCount);
      for (size_t i = 0; i < mCount; ++i)
      {
          int len = length ? length[i] : -1;
          mLength.push_back(len < 0 ? std::strlen(mString[i]) : len);
      }
  }
  
  const char *Input::skipChar()
  {
      // This function should only be called when there is a character to skip.
      ASSERT(mReadLoc.cIndex < mLength[mReadLoc.sIndex]);
      ++mReadLoc.cIndex;
      if (mReadLoc.cIndex == mLength[mReadLoc.sIndex])
      {
          ++mReadLoc.sIndex;
          mReadLoc.cIndex = 0;
      }
      if (mReadLoc.sIndex >= mCount)
      {
          return nullptr;
      }
      return mString[mReadLoc.sIndex] + mReadLoc.cIndex;
  }
  
  size_t Input::read(char *buf, size_t maxSize, int *lineNo)
  {
      size_t nRead = 0;
      // The previous call to read might have stopped copying the string when encountering a line
      // continuation. Check for this possibility first.
      if (mReadLoc.sIndex < mCount && maxSize > 0)
      {
          const char *c = mString[mReadLoc.sIndex] + mReadLoc.cIndex;
          if ((*c) == '\\')
          {
              c = skipChar();
              if (c != nullptr && (*c) == '\n')
              {
                  // Line continuation of backslash + newline.
                  skipChar();
                  // Fake an EOF if the line number would overflow.
                  if (*lineNo == INT_MAX)
                  {
                      return 0;
                  }
                  ++(*lineNo);
              }
              else if (c != nullptr && (*c) == '\r')
              {
                  // Line continuation. Could be backslash + '\r\n' or just backslash + '\r'.
                  c = skipChar();
                  if (c != nullptr && (*c) == '\n')
                  {
                      skipChar();
                  }
                  // Fake an EOF if the line number would overflow.
                  if (*lineNo == INT_MAX)
                  {
                      return 0;
                  }
                  ++(*lineNo);
              }
              else
              {
                  // Not line continuation, so write the skipped backslash to buf.
                  *buf = '\\';
                  ++nRead;
              }
          }
      }
  
      size_t maxRead = maxSize;
      while ((nRead < maxRead) && (mReadLoc.sIndex < mCount))
      {
          size_t size = mLength[mReadLoc.sIndex] - mReadLoc.cIndex;
          size        = std::min(size, maxSize);
          for (size_t i = 0; i < size; ++i)
          {
              // Stop if a possible line continuation is encountered.
              // It will be processed on the next call on input, which skips it
              // and increments line number if necessary.
              if (*(mString[mReadLoc.sIndex] + mReadLoc.cIndex + i) == '\\')
              {
                  size    = i;
                  maxRead = nRead + size;  // Stop reading right before the backslash.
              }
          }
          std::memcpy(buf + nRead, mString[mReadLoc.sIndex] + mReadLoc.cIndex, size);
          nRead += size;
          mReadLoc.cIndex += size;
  
          // Advance string if we reached the end of current string.
          if (mReadLoc.cIndex == mLength[mReadLoc.sIndex])
          {
              ++mReadLoc.sIndex;
              mReadLoc.cIndex = 0;
          }
      }
      return nRead;
  }
  
  }  // namespace pp
  
  }  // namespace angle
  

Download