kc3-lang/angle/src/common/utilities_unittest.cpp

• Show log

  Commit

• Hash : d255123c
  Author :
  Date : 2017-10-26T20:03:33
  

  Store shader interface variables as per query spec
  
  GLES 3.1 section 7.3.1.1 specifies how active variable entries should
  be generated and how active variables are named. The specs for program
  interface variable queries are built on top of this section.
  
  ANGLE has already followed this spec for the most part for generating
  variable lists in ProgramState, but now we also follow the naming spec
  for arrays and include [0] at the end of the stored name.
  
  This will make implementing arrays of arrays more straightforward.
  Most logic for variable queries will just keep working as is when
  arrays of arrays are added instead of needing more complex logic for
  handling array indexing.
  
  BUG=angleproject:2125
  TEST=angle_end2end_tests
  
  Change-Id: I3acd14253153e10bc312114b0303065da2efb506
  Reviewed-on: https://chromium-review.googlesource.com/739826
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
  

Download

• src/common/utilities_unittest.cpp

• //
  // Copyright (c) 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  
  // utilities_unittest.cpp: Unit tests for ANGLE's GL utility functions
  
  #include "gmock/gmock.h"
  #include "gtest/gtest.h"
  
  #include "common/utilities.h"
  
  namespace
  {
  
  // Test parsing valid single array indices
  TEST(ParseResourceName, ArrayIndex)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo", gl::ParseResourceName("foo[123]", &indices));
      ASSERT_EQ(1u, indices.size());
      EXPECT_EQ(123u, indices[0]);
  
      EXPECT_EQ("bar", gl::ParseResourceName("bar[0]", &indices));
      ASSERT_EQ(1u, indices.size());
      EXPECT_EQ(0u, indices[0]);
  }
  
  // Parsing a negative array index should result in INVALID_INDEX.
  TEST(ParseResourceName, NegativeArrayIndex)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo", gl::ParseResourceName("foo[-1]", &indices));
      ASSERT_EQ(1u, indices.size());
      EXPECT_EQ(GL_INVALID_INDEX, indices.back());
  }
  
  // Parsing no array indices should result in an empty array.
  TEST(ParseResourceName, NoArrayIndex)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo", gl::ParseResourceName("foo", &indices));
      EXPECT_TRUE(indices.empty());
  }
  
  // The ParseResourceName function should work when a nullptr is passed as the indices output vector.
  TEST(ParseResourceName, NULLArrayIndices)
  {
      EXPECT_EQ("foo", gl::ParseResourceName("foo[10]", nullptr));
  }
  
  // Parsing multiple array indices should result in outermost array indices being last in the vector.
  TEST(ParseResourceName, MultipleArrayIndices)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo", gl::ParseResourceName("foo[12][34][56]", &indices));
      ASSERT_EQ(3u, indices.size());
      // Indices are sorted with outermost array index last.
      EXPECT_EQ(56u, indices[0]);
      EXPECT_EQ(34u, indices[1]);
      EXPECT_EQ(12u, indices[2]);
  }
  
  // Trailing whitespace should not be accepted by ParseResourceName.
  TEST(ParseResourceName, TrailingWhitespace)
  {
      std::vector<unsigned int> indices;
      EXPECT_EQ("foo ", gl::ParseResourceName("foo ", &indices));
      EXPECT_TRUE(indices.empty());
  
      EXPECT_EQ("foo[10] ", gl::ParseResourceName("foo[10] ", &indices));
      EXPECT_TRUE(indices.empty());
  
      EXPECT_EQ("foo[10][20] ", gl::ParseResourceName("foo[10][20] ", &indices));
      EXPECT_TRUE(indices.empty());
  }
  
  // Parse a string without any index.
  TEST(ParseArrayIndex, NoArrayIndex)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(3u, nameLengthWithoutArrayIndex);
  }
  
  // Parse an empty string for an array index.
  TEST(ParseArrayIndex, EmptyString)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(0u, nameLengthWithoutArrayIndex);
  }
  
  // A valid array index is parsed correctly from the end of the string.
  TEST(ParseArrayIndex, ArrayIndex)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(123u, gl::ParseArrayIndex("foo[123]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(3u, nameLengthWithoutArrayIndex);
  }
  
  // An array index from the middle of the string is not parsed.
  TEST(ParseArrayIndex, ArrayIndexInMiddle)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[123].bar", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(12u, nameLengthWithoutArrayIndex);
  }
  
  // Trailing whitespace in the parsed string is taken into account.
  TEST(ParseArrayIndex, TrailingWhitespace)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[123] ", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(9u, nameLengthWithoutArrayIndex);
  }
  
  // Only the last index is parsed.
  TEST(ParseArrayIndex, MultipleArrayIndices)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(34u, gl::ParseArrayIndex("foo[12][34]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(7u, nameLengthWithoutArrayIndex);
  }
  
  // GetProgramResourceLocation spec in GLES 3.1 November 2016 page 87 mentions "decimal" integer.
  // So an integer in hexadecimal format should not parse as an array index.
  TEST(ParseArrayIndex, HexArrayIndex)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[0xff]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(9u, nameLengthWithoutArrayIndex);
  }
  
  // GetProgramResourceLocation spec in GLES 3.1 November 2016 page 87 mentions that the array
  // index should not contain a leading plus sign.
  TEST(ParseArrayIndex, ArrayIndexLeadingPlus)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[+1]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(7u, nameLengthWithoutArrayIndex);
  }
  
  // GetProgramResourceLocation spec in GLES 3.1 November 2016 page 87 says that index should not
  // contain whitespace. Test leading whitespace.
  TEST(ParseArrayIndex, ArrayIndexLeadingWhiteSpace)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[ 0]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(7u, nameLengthWithoutArrayIndex);
  }
  
  // GetProgramResourceLocation spec in GLES 3.1 November 2016 page 87 says that index should not
  // contain whitespace. Test trailing whitespace.
  TEST(ParseArrayIndex, ArrayIndexTrailingWhiteSpace)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[0 ]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(7u, nameLengthWithoutArrayIndex);
  }
  
  // GetProgramResourceLocation spec in GLES 3.1 November 2016 page 87 says that index should only
  // contain an integer.
  TEST(ParseArrayIndex, ArrayIndexBogus)
  {
      size_t nameLengthWithoutArrayIndex;
      EXPECT_EQ(GL_INVALID_INDEX, gl::ParseArrayIndex("foo[0bogus]", &nameLengthWithoutArrayIndex));
      EXPECT_EQ(11u, nameLengthWithoutArrayIndex);
  }
  
  }  // anonymous namespace
  

Download