Hash :
a36f8bd4
Author :
Date :
2020-01-29T12:10:17
Mark MemoryBuffer allocation functions as NO_DISCARD Not all call sites were checking the return value of MemoryBuffer::resize, mark the return value as NO_DISCARD and fix all the warnings. BUG=chromium:1030835 Change-Id: I762796e3d11efc131a814069d78a195b0d4c9f8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2028151 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130
//
// Copyright 2018 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// BlobCache_unittest.h: Unit tests for the blob cache.
#include <gtest/gtest.h>
#include "libANGLE/BlobCache.h"
namespace egl
{
// Note: this is fairly similar to SizedMRUCache_unittest, and makes sure the
// BlobCache usage of SizedMRUCache is not broken.
using BlobPut = angle::MemoryBuffer;
using Blob = BlobCache::Value;
using Key = BlobCache::Key;
template <typename T>
void MakeSequence(T &seq, uint8_t start)
{
for (uint8_t i = 0; i < seq.size(); ++i)
{
seq[i] = i + start;
}
}
BlobPut MakeBlob(size_t size, uint8_t start = 0)
{
BlobPut blob;
EXPECT_TRUE(blob.resize(size));
MakeSequence(blob, start);
return blob;
}
Key MakeKey(uint8_t start = 0)
{
Key key;
MakeSequence(key, start);
return key;
}
// Test a cache with a value that takes up maximum size.
TEST(BlobCacheTest, MaxSizedValue)
{
constexpr size_t kSize = 32;
BlobCache blobCache(kSize);
blobCache.populate(MakeKey(0), MakeBlob(kSize));
EXPECT_EQ(32u, blobCache.size());
EXPECT_FALSE(blobCache.empty());
blobCache.populate(MakeKey(1), MakeBlob(kSize));
EXPECT_EQ(32u, blobCache.size());
EXPECT_FALSE(blobCache.empty());
Blob blob;
EXPECT_FALSE(blobCache.get(nullptr, MakeKey(0), &blob));
blobCache.clear();
EXPECT_TRUE(blobCache.empty());
}
// Test a cache with many small values, that it can handle unlimited inserts.
TEST(BlobCacheTest, ManySmallValues)
{
constexpr size_t kSize = 32;
BlobCache blobCache(kSize);
for (size_t value = 0; value < kSize; ++value)
{
blobCache.populate(MakeKey(value), MakeBlob(1, value));
Blob qvalue;
EXPECT_TRUE(blobCache.get(nullptr, MakeKey(value), &qvalue));
if (qvalue.size() > 0)
{
EXPECT_EQ(value, qvalue[0]);
}
}
EXPECT_EQ(32u, blobCache.size());
EXPECT_FALSE(blobCache.empty());
// Putting one element evicts the first element.
blobCache.populate(MakeKey(kSize), MakeBlob(1, kSize));
Blob qvalue;
EXPECT_FALSE(blobCache.get(nullptr, MakeKey(0), &qvalue));
// Putting one large element cleans out the whole stack.
blobCache.populate(MakeKey(kSize + 1), MakeBlob(kSize, kSize + 1));
EXPECT_EQ(32u, blobCache.size());
EXPECT_FALSE(blobCache.empty());
for (size_t value = 0; value <= kSize; ++value)
{
EXPECT_FALSE(blobCache.get(nullptr, MakeKey(value), &qvalue));
}
EXPECT_TRUE(blobCache.get(nullptr, MakeKey(kSize + 1), &qvalue));
if (qvalue.size() > 0)
{
EXPECT_EQ(kSize + 1, qvalue[0]);
}
// Put a bunch of items in the cache sequentially.
for (size_t value = 0; value < kSize * 10; ++value)
{
blobCache.populate(MakeKey(value), MakeBlob(1, value));
}
EXPECT_EQ(32u, blobCache.size());
}
// Tests putting an oversize element.
TEST(BlobCacheTest, OversizeValue)
{
constexpr size_t kSize = 32;
BlobCache blobCache(kSize);
blobCache.populate(MakeKey(5), MakeBlob(100));
Blob qvalue;
EXPECT_FALSE(blobCache.get(nullptr, MakeKey(5), &qvalue));
}
} // namespace egl