-
Show log
Commit
-
Hash : 2ce6d8df
Author :
Date : 2023-04-20T17:16:00
TextureVk calls onStateChange when releasing buffer views TextureVk::setBuffer releases buffer views and they don't get initialized unless a dirty bit is set. That works on the first draw call because Texture::Texture() sets DIRTY_BIT_IMPLEMENTATION in constructor, but when called twice mBufferViews remains unitialized causing mBufferViews.getView() misbehavior. Fix this by calling onStateChange when buffer views are released. As mBufferViews is only initialized conditionally for texture buffers, add a bool for tracking whether it is in the initialized state to avoid marking texture as dirty unnecessarily. Note that this isn't handled by signalDirtyStorage() inside Texture::setBufferRange because (in this test case?) there are no observers on Texture so onStateChange called from Texture is a no-op. Texture however observes its TextureVk implementation so onStateChange calls from TextureVk end up setting the dirty bit in Texture::onSubjectStateChange. Bug: b/278585075 Change-Id: I2b83160cdd89a086ed81e8412cd64d0aad930911 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4457147 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
-
Files
- BUILD.gn
- OWNERS
- angle_deqp_tests_main.cpp
- angle_end2end_tests.gni
- angle_end2end_tests_expectations.txt
- angle_end2end_tests_main.cpp
- angle_generic_tests_main.cpp
- angle_perftests.gni
- angle_perftests_main.cpp
- angle_system_info_tests_main.cpp
- angle_trace_tests_main.cpp
- angle_unittest_main.cpp
- angle_unittests.gni
- angle_unittests_utils.h
- angle_white_box_tests.gni
- angle_white_box_tests_main.cpp
- capture_replay_tests.py
- capture_replay_tests/
- compiler_tests/
- deqp_support/
- egl_tests/
- gl_tests/
- gles1_conformance_tests/
- gles_conformance_tests/
- perf_tests/
- preprocessor_tests/
- py_utils/
- restricted_traces/
- run_angle_android_test.py
- run_perf_tests.py
- test_expectations/
- test_utils/
- util_tests/
