kc3-lang/angle/src/compiler/translator/ImmutableStringBuilder.cpp

• Show log

  Commit

• Hash : 3fa8d578
  Author :
  Date : 2024-03-04T10:06:57
  

  Make appendDecimal use the last char of the buffer
  
  ImmutableStringBuilder(1) means 1 char usable payload and \0.
  
  This this should fit appendDecimal(1) but did not. Fix the off by one
  error calling snprintf.
  
  Also:
   * removes const & from uint32_t argument
   * removes const & from operator<<, to stay consistent
   * Removes a redundant static_cast
   * Implements operator<< const char* with potentially better
     operator<<(const ImmutableString&) (may get compile time strlen)
  
  Fixed: angleproject:8567
  Change-Id: Ibfff59f6846add0498d06e963266e50ec19baf80
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5332381
  Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Kenneth Russell <kbr@chromium.org>
  Commit-Queue: Kenneth Russell <kbr@chromium.org>
  

Download

• src/compiler/translator/ImmutableStringBuilder.cpp

• //
  // Copyright 2018 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // ImmutableStringBuilder.cpp: Stringstream-like utility for building pool allocated strings where
  // the maximum length is known in advance.
  //
  
  #include "compiler/translator/ImmutableStringBuilder.h"
  
  #include <stdio.h>
  
  namespace sh
  {
  
  ImmutableStringBuilder &ImmutableStringBuilder::operator<<(const ImmutableString &str)
  {
      ASSERT(mData != nullptr);
      ASSERT(mPos + str.length() <= mMaxLength);
      memcpy(mData + mPos, str.data(), str.length());
      mPos += str.length();
      return *this;
  }
  
  ImmutableStringBuilder &ImmutableStringBuilder::operator<<(char c)
  {
      ASSERT(mData != nullptr);
      ASSERT(mPos + 1 <= mMaxLength);
      mData[mPos++] = c;
      return *this;
  }
  
  void ImmutableStringBuilder::appendDecimal(uint32_t u)
  {
      // + 1 is because snprintf writes at most bufsz - 1 and then \0.
      // Our bufsz is mMaxLength + 1.
      int numChars = snprintf(mData + mPos, mMaxLength - mPos + 1, "%d", u);
      ASSERT(numChars >= 0);
      ASSERT(mPos + numChars <= mMaxLength);
      mPos += numChars;
  }
  
  ImmutableStringBuilder::operator ImmutableString()
  {
      mData[mPos] = '\0';
      ImmutableString str(mData, mPos);
  #if defined(ANGLE_ENABLE_ASSERTS)
      // Make sure that nothing is added to the string after it is finalized.
      mData = nullptr;
  #endif
      return str;
  }
  
  }  // namespace sh
  

Download