Hash :
472c74c6
Author :
Date :
2019-08-19T16:32:13
Translator: Allow tree validation in children of TCompiler This is to be able to perform validation inside TranslatorVulkan, even if it's through ASSERTs. Additionally, every transformation is changed such that they do their validation themselves. TIntermTraverser::updateTree() performs the validation, which indirectly validates many of three tree transformations. Some of the more ancient transformations that don't use this function directly call TCompiler::validateAST. Bug: angleproject:2733 Change-Id: Ie4af029d34e053c5ad1dc8c2c2568eecd625d344 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1761149 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97
//
// Copyright 2018 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// RewriteRepeatedAssignToSwizzled.cpp: Rewrite expressions that assign an assignment to a swizzled
// vector, like:
// v.x = z = expression;
// to:
// z = expression;
// v.x = z;
//
// Note that this doesn't handle some corner cases: expressions nested inside other expressions,
// inside loop headers, or inside if conditions.
#include "compiler/translator/tree_ops/RewriteRepeatedAssignToSwizzled.h"
#include "compiler/translator/tree_util/IntermNode_util.h"
#include "compiler/translator/tree_util/IntermTraverse.h"
namespace sh
{
namespace
{
class RewriteAssignToSwizzledTraverser : public TIntermTraverser
{
public:
ANGLE_NO_DISCARD static bool rewrite(TCompiler *compiler, TIntermBlock *root);
private:
RewriteAssignToSwizzledTraverser();
bool visitBinary(Visit, TIntermBinary *node) override;
void nextIteration();
bool didRewrite() { return mDidRewrite; }
bool mDidRewrite;
};
// static
bool RewriteAssignToSwizzledTraverser::rewrite(TCompiler *compiler, TIntermBlock *root)
{
RewriteAssignToSwizzledTraverser rewrite;
do
{
rewrite.nextIteration();
root->traverse(&rewrite);
if (!rewrite.updateTree(compiler, root))
{
return false;
}
} while (rewrite.didRewrite());
return true;
}
RewriteAssignToSwizzledTraverser::RewriteAssignToSwizzledTraverser()
: TIntermTraverser(true, false, false), mDidRewrite(false)
{}
void RewriteAssignToSwizzledTraverser::nextIteration()
{
mDidRewrite = false;
}
bool RewriteAssignToSwizzledTraverser::visitBinary(Visit, TIntermBinary *node)
{
TIntermBinary *rightBinary = node->getRight()->getAsBinaryNode();
TIntermBlock *parentBlock = getParentNode()->getAsBlock();
if (parentBlock && node->isAssignment() && node->getLeft()->getAsSwizzleNode() && rightBinary &&
rightBinary->isAssignment())
{
TIntermSequence replacements;
replacements.push_back(rightBinary);
TIntermTyped *rightAssignmentTargetCopy = rightBinary->getLeft()->deepCopy();
TIntermBinary *lastAssign =
new TIntermBinary(EOpAssign, node->getLeft(), rightAssignmentTargetCopy);
replacements.push_back(lastAssign);
mMultiReplacements.push_back(NodeReplaceWithMultipleEntry(parentBlock, node, replacements));
mDidRewrite = true;
return false;
}
return true;
}
} // anonymous namespace
bool RewriteRepeatedAssignToSwizzled(TCompiler *compiler, TIntermBlock *root)
{
return RewriteAssignToSwizzledTraverser::rewrite(compiler, root);
}
} // namespace sh