Hash :
472c74c6
Author :
Date :
2019-08-19T16:32:13
Translator: Allow tree validation in children of TCompiler This is to be able to perform validation inside TranslatorVulkan, even if it's through ASSERTs. Additionally, every transformation is changed such that they do their validation themselves. TIntermTraverser::updateTree() performs the validation, which indirectly validates many of three tree transformations. Some of the more ancient transformations that don't use this function directly call TCompiler::validateAST. Bug: angleproject:2733 Change-Id: Ie4af029d34e053c5ad1dc8c2c2568eecd625d344 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1761149 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115
//
// Copyright 2016 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Implementation of evaluating unary integer variable bug workaround.
// See header for more info.
#include "compiler/translator/tree_ops/RewriteUnaryMinusOperatorInt.h"
#include "compiler/translator/tree_util/IntermTraverse.h"
namespace sh
{
namespace
{
class Traverser : public TIntermTraverser
{
public:
ANGLE_NO_DISCARD static bool Apply(TCompiler *compiler, TIntermNode *root);
private:
Traverser();
bool visitUnary(Visit visit, TIntermUnary *node) override;
void nextIteration();
bool mFound = false;
};
// static
bool Traverser::Apply(TCompiler *compiler, TIntermNode *root)
{
Traverser traverser;
do
{
traverser.nextIteration();
root->traverse(&traverser);
if (traverser.mFound)
{
if (!traverser.updateTree(compiler, root))
{
return false;
}
}
} while (traverser.mFound);
return true;
}
Traverser::Traverser() : TIntermTraverser(true, false, false) {}
void Traverser::nextIteration()
{
mFound = false;
}
bool Traverser::visitUnary(Visit visit, TIntermUnary *node)
{
if (mFound)
{
return false;
}
// Decide if the current unary operator is unary minus.
if (node->getOp() != EOpNegative)
{
return true;
}
// Decide if the current operand is an integer variable.
TIntermTyped *opr = node->getOperand();
if (!opr->getType().isScalarInt())
{
return true;
}
// Potential problem case detected, apply workaround: -(int) -> ~(int) + 1.
// ~(int)
TIntermUnary *bitwiseNot = new TIntermUnary(EOpBitwiseNot, opr, nullptr);
bitwiseNot->setLine(opr->getLine());
// Constant 1 (or 1u)
TConstantUnion *one = new TConstantUnion();
if (opr->getType().getBasicType() == EbtInt)
{
one->setIConst(1);
}
else
{
one->setUConst(1u);
}
TIntermConstantUnion *oneNode =
new TIntermConstantUnion(one, TType(opr->getBasicType(), opr->getPrecision(), EvqConst));
oneNode->setLine(opr->getLine());
// ~(int) + 1
TIntermBinary *add = new TIntermBinary(EOpAdd, bitwiseNot, oneNode);
add->setLine(opr->getLine());
queueReplacement(add, OriginalNode::IS_DROPPED);
mFound = true;
return false;
}
} // anonymous namespace
bool RewriteUnaryMinusOperatorInt(TCompiler *compiler, TIntermNode *root)
{
return Traverser::Apply(compiler, root);
}
} // namespace sh