Hash :
da572160
Author :
Date :
2024-07-23T16:36:10
Reland: GL: Forward client-side arrays to the driver when possible The OpenGL driver can handle client-side arrays when the context is OpenGL ES or a desktop GL compatibility profile. When in these situations, use the driver default VAO for all frontend context VAOs and forward client-side data directly to the driver. Fix synchronizing the default VAO state for external contexts. There is no valid VertexArrayStateGL for external VAOs so make sure it's nulled and the VAO dirty bits are set so the correct VAO state is reapplied. Disable syncing to the default VAO for external contexts. The only VAO that they can share with ANGLE's internal state is the default VAO so avoid having to save and restore its state. Bug: angleproject:355034686 Change-Id: I015bbbc854938fe4bc1e92d0ca8fe04628d0db16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5743284 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907
//
// Copyright 2013 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Implementation of the state class for mananging GLES 3 Vertex Array Objects.
//
#include "libANGLE/VertexArray.h"
#include "common/utilities.h"
#include "libANGLE/Buffer.h"
#include "libANGLE/Context.h"
#include "libANGLE/renderer/BufferImpl.h"
#include "libANGLE/renderer/GLImplFactory.h"
#include "libANGLE/renderer/VertexArrayImpl.h"
namespace gl
{
namespace
{
bool IsElementArrayBufferSubjectIndex(angle::SubjectIndex subjectIndex)
{
return (subjectIndex == kElementArrayBufferIndex);
}
} // namespace
// VertexArrayState implementation.
VertexArrayState::VertexArrayState(VertexArray *vertexArray,
size_t maxAttribs,
size_t maxAttribBindings)
: mId(vertexArray->id()), mElementArrayBuffer(vertexArray, kElementArrayBufferIndex)
{
ASSERT(maxAttribs <= maxAttribBindings);
for (size_t i = 0; i < maxAttribs; i++)
{
mVertexAttributes.emplace_back(static_cast<GLuint>(i));
mVertexBindings.emplace_back(static_cast<GLuint>(i));
}
// Initially all attributes start as "client" with no buffer bound.
mClientMemoryAttribsMask.set();
}
VertexArrayState::~VertexArrayState() {}
bool VertexArrayState::hasEnabledNullPointerClientArray() const
{
return (mNullPointerClientMemoryAttribsMask & mEnabledAttributesMask).any();
}
AttributesMask VertexArrayState::getBindingToAttributesMask(GLuint bindingIndex) const
{
ASSERT(bindingIndex < mVertexBindings.size());
return mVertexBindings[bindingIndex].getBoundAttributesMask();
}
// Set an attribute using a new binding.
void VertexArrayState::setAttribBinding(const Context *context,
size_t attribIndex,
GLuint newBindingIndex)
{
ASSERT(attribIndex < mVertexAttributes.size() && newBindingIndex < mVertexBindings.size());
VertexAttribute &attrib = mVertexAttributes[attribIndex];
// Update the binding-attribute map.
const GLuint oldBindingIndex = attrib.bindingIndex;
ASSERT(oldBindingIndex != newBindingIndex);
VertexBinding &oldBinding = mVertexBindings[oldBindingIndex];
VertexBinding &newBinding = mVertexBindings[newBindingIndex];
ASSERT(oldBinding.getBoundAttributesMask().test(attribIndex) &&
!newBinding.getBoundAttributesMask().test(attribIndex));
oldBinding.resetBoundAttribute(attribIndex);
newBinding.setBoundAttribute(attribIndex);
// Set the attribute using the new binding.
attrib.bindingIndex = newBindingIndex;
if (context->isBufferAccessValidationEnabled())
{
attrib.updateCachedElementLimit(newBinding);
}
bool isMapped = newBinding.getBuffer().get() && newBinding.getBuffer()->isMapped();
mCachedMappedArrayBuffers.set(attribIndex, isMapped);
mEnabledAttributesMask.set(attribIndex, attrib.enabled);
updateCachedMutableOrNonPersistentArrayBuffers(attribIndex);
mCachedInvalidMappedArrayBuffer = mCachedMappedArrayBuffers & mEnabledAttributesMask &
mCachedMutableOrImpersistentArrayBuffers;
}
void VertexArrayState::updateCachedMutableOrNonPersistentArrayBuffers(size_t index)
{
const VertexBinding &vertexBinding = mVertexBindings[index];
const BindingPointer<Buffer> &buffer = vertexBinding.getBuffer();
bool isMutableOrImpersistentArrayBuffer =
buffer.get() &&
(!buffer->isImmutable() || (buffer->getAccessFlags() & GL_MAP_PERSISTENT_BIT_EXT) == 0);
mCachedMutableOrImpersistentArrayBuffers.set(index, isMutableOrImpersistentArrayBuffer);
}
bool VertexArrayState::isDefault() const
{
return mId.value == 0;
}
// VertexArray implementation.
VertexArray::VertexArray(rx::GLImplFactory *factory,
VertexArrayID id,
size_t maxAttribs,
size_t maxAttribBindings)
: mId(id),
mState(this, maxAttribs, maxAttribBindings),
mVertexArray(factory->createVertexArray(mState)),
mBufferAccessValidationEnabled(false),
mContentsObservers(this)
{
for (size_t attribIndex = 0; attribIndex < maxAttribBindings; ++attribIndex)
{
mArrayBufferObserverBindings.emplace_back(this, attribIndex);
}
mVertexArray->setContentsObservers(&mContentsObservers);
}
void VertexArray::onDestroy(const Context *context)
{
bool isBound = context->isCurrentVertexArray(this);
for (size_t bindingIndex : mState.mBufferBindingMask)
{
VertexBinding &binding = mState.mVertexBindings[bindingIndex];
Buffer *buffer = binding.getBuffer().get();
ASSERT(buffer != nullptr);
if (isBound)
{
buffer->onNonTFBindingChanged(-1);
}
else
{
// un-assigning to avoid assertion, since it was already removed from buffer's observer
// list.
mArrayBufferObserverBindings[bindingIndex].assignSubject(nullptr);
}
// Note: the non-contents observer is unbound in the ObserverBinding destructor.
buffer->removeContentsObserver(this, static_cast<uint32_t>(bindingIndex));
binding.setBuffer(context, nullptr);
}
mState.mBufferBindingMask.reset();
if (mState.mElementArrayBuffer.get())
{
if (isBound)
{
mState.mElementArrayBuffer->onNonTFBindingChanged(-1);
}
mState.mElementArrayBuffer->removeContentsObserver(this, kElementArrayBufferIndex);
}
mState.mElementArrayBuffer.bind(context, nullptr);
mVertexArray->destroy(context);
SafeDelete(mVertexArray);
delete this;
}
VertexArray::~VertexArray()
{
ASSERT(!mVertexArray);
}
angle::Result VertexArray::setLabel(const Context *context, const std::string &label)
{
mState.mLabel = label;
if (mVertexArray)
{
return mVertexArray->onLabelUpdate(context);
}
return angle::Result::Continue;
}
const std::string &VertexArray::getLabel() const
{
return mState.mLabel;
}
bool VertexArray::detachBuffer(const Context *context, BufferID bufferID)
{
bool isBound = context->isCurrentVertexArray(this);
bool anyBufferDetached = false;
for (size_t bindingIndex : mState.mBufferBindingMask)
{
VertexBinding &binding = mState.mVertexBindings[bindingIndex];
const BindingPointer<Buffer> &bufferBinding = binding.getBuffer();
if (bufferBinding.id() == bufferID)
{
if (isBound)
{
if (bufferBinding.get())
bufferBinding->onNonTFBindingChanged(-1);
}
bufferBinding->removeContentsObserver(this, static_cast<uint32_t>(bindingIndex));
binding.setBuffer(context, nullptr);
mArrayBufferObserverBindings[bindingIndex].reset();
mState.mBufferBindingMask.reset(bindingIndex);
if (context->getClientVersion() >= ES_3_1 && !mState.isDefault())
{
setDirtyBindingBit(bindingIndex, DIRTY_BINDING_BUFFER);
}
else
{
static_assert(MAX_VERTEX_ATTRIB_BINDINGS < 8 * sizeof(uint32_t),
"Not enough bits in bindingIndex");
// The redundant uint32_t cast here is required to avoid a warning on MSVC.
ASSERT(binding.getBoundAttributesMask() ==
AttributesMask(static_cast<uint32_t>(1 << bindingIndex)));
setDirtyAttribBit(bindingIndex, DIRTY_ATTRIB_POINTER);
}
anyBufferDetached = true;
mState.mClientMemoryAttribsMask |= binding.getBoundAttributesMask();
}
}
if (mState.mElementArrayBuffer.get() && mState.mElementArrayBuffer->id() == bufferID)
{
if (isBound && mState.mElementArrayBuffer.get())
mState.mElementArrayBuffer->onNonTFBindingChanged(-1);
mState.mElementArrayBuffer->removeContentsObserver(this, kElementArrayBufferIndex);
mState.mElementArrayBuffer.bind(context, nullptr);
mDirtyBits.set(DIRTY_BIT_ELEMENT_ARRAY_BUFFER);
anyBufferDetached = true;
}
return anyBufferDetached;
}
const VertexAttribute &VertexArray::getVertexAttribute(size_t attribIndex) const
{
ASSERT(attribIndex < getMaxAttribs());
return mState.mVertexAttributes[attribIndex];
}
const VertexBinding &VertexArray::getVertexBinding(size_t bindingIndex) const
{
ASSERT(bindingIndex < getMaxBindings());
return mState.mVertexBindings[bindingIndex];
}
size_t VertexArray::GetVertexIndexFromDirtyBit(size_t dirtyBit)
{
static_assert(MAX_VERTEX_ATTRIBS == MAX_VERTEX_ATTRIB_BINDINGS,
"The stride of vertex attributes should equal to that of vertex bindings.");
ASSERT(dirtyBit > DIRTY_BIT_ELEMENT_ARRAY_BUFFER);
return (dirtyBit - DIRTY_BIT_ATTRIB_0) % MAX_VERTEX_ATTRIBS;
}
ANGLE_INLINE void VertexArray::setDirtyAttribBit(size_t attribIndex,
DirtyAttribBitType dirtyAttribBit)
{
mDirtyBits.set(DIRTY_BIT_ATTRIB_0 + attribIndex);
mDirtyAttribBits[attribIndex].set(dirtyAttribBit);
}
ANGLE_INLINE void VertexArray::clearDirtyAttribBit(size_t attribIndex,
DirtyAttribBitType dirtyAttribBit)
{
mDirtyAttribBits[attribIndex].set(dirtyAttribBit, false);
if (mDirtyAttribBits[attribIndex].any())
{
return;
}
mDirtyBits.set(DIRTY_BIT_ATTRIB_0 + attribIndex, false);
}
ANGLE_INLINE void VertexArray::setDirtyBindingBit(size_t bindingIndex,
DirtyBindingBitType dirtyBindingBit)
{
mDirtyBits.set(DIRTY_BIT_BINDING_0 + bindingIndex);
mDirtyBindingBits[bindingIndex].set(dirtyBindingBit);
}
ANGLE_INLINE void VertexArray::updateCachedBufferBindingSize(VertexBinding *binding)
{
if (!mBufferAccessValidationEnabled)
return;
for (size_t boundAttribute : binding->getBoundAttributesMask())
{
mState.mVertexAttributes[boundAttribute].updateCachedElementLimit(*binding);
}
}
ANGLE_INLINE void VertexArray::updateCachedArrayBuffersMasks(
bool isMapped,
bool isImmutable,
bool isPersistent,
const AttributesMask &boundAttributesMask)
{
if (isMapped)
{
mState.mCachedMappedArrayBuffers |= boundAttributesMask;
}
else
{
mState.mCachedMappedArrayBuffers &= ~boundAttributesMask;
}
if (!isImmutable || !isPersistent)
{
mState.mCachedMutableOrImpersistentArrayBuffers |= boundAttributesMask;
}
else
{
mState.mCachedMutableOrImpersistentArrayBuffers &= ~boundAttributesMask;
}
mState.mCachedInvalidMappedArrayBuffer = mState.mCachedMappedArrayBuffers &
mState.mEnabledAttributesMask &
mState.mCachedMutableOrImpersistentArrayBuffers;
}
ANGLE_INLINE void VertexArray::updateCachedMappedArrayBuffersBinding(const VertexBinding &binding)
{
const Buffer *buffer = binding.getBuffer().get();
bool isMapped = buffer && buffer->isMapped();
bool isImmutable = buffer && buffer->isImmutable();
bool isPersistent = buffer && (buffer->getAccessFlags() & GL_MAP_PERSISTENT_BIT_EXT) != 0;
return updateCachedArrayBuffersMasks(isMapped, isImmutable, isPersistent,
binding.getBoundAttributesMask());
}
ANGLE_INLINE void VertexArray::updateCachedTransformFeedbackBindingValidation(size_t bindingIndex,
const Buffer *buffer)
{
const bool hasConflict = buffer && buffer->hasWebGLXFBBindingConflict(true);
mCachedTransformFeedbackConflictedBindingsMask.set(bindingIndex, hasConflict);
}
VertexArray::DirtyBindingBits VertexArray::bindVertexBufferImpl(const Context *context,
size_t bindingIndex,
Buffer *boundBuffer,
GLintptr offset,
GLsizei stride)
{
ASSERT(bindingIndex < getMaxBindings());
ASSERT(context->isCurrentVertexArray(this));
VertexBinding *binding = &mState.mVertexBindings[bindingIndex];
Buffer *oldBuffer = binding->getBuffer().get();
DirtyBindingBits dirtyBindingBits;
dirtyBindingBits.set(DIRTY_BINDING_BUFFER, oldBuffer != boundBuffer);
dirtyBindingBits.set(DIRTY_BINDING_STRIDE, static_cast<GLuint>(stride) != binding->getStride());
dirtyBindingBits.set(DIRTY_BINDING_OFFSET, offset != binding->getOffset());
if (dirtyBindingBits.none())
{
return dirtyBindingBits;
}
if (boundBuffer != oldBuffer)
{
angle::ObserverBinding *observer = &mArrayBufferObserverBindings[bindingIndex];
observer->assignSubject(boundBuffer);
// Several nullptr checks are combined here for optimization purposes.
if (oldBuffer)
{
oldBuffer->onNonTFBindingChanged(-1);
oldBuffer->removeObserver(observer);
oldBuffer->removeContentsObserver(this, static_cast<uint32_t>(bindingIndex));
oldBuffer->release(context);
mState.mBufferBindingMask.reset(bindingIndex);
}
binding->assignBuffer(boundBuffer);
// Update client memory attribute pointers. Affects all bound attributes.
if (boundBuffer)
{
boundBuffer->addRef();
boundBuffer->onNonTFBindingChanged(1);
boundBuffer->addObserver(observer);
if (context->isWebGL())
{
mCachedTransformFeedbackConflictedBindingsMask.set(
bindingIndex, boundBuffer->hasWebGLXFBBindingConflict(true));
}
mState.mBufferBindingMask.set(bindingIndex);
mState.mClientMemoryAttribsMask &= ~binding->getBoundAttributesMask();
bool isMapped = boundBuffer->isMapped() == GL_TRUE;
bool isImmutable = boundBuffer->isImmutable() == GL_TRUE;
bool isPersistent = (boundBuffer->getAccessFlags() & GL_MAP_PERSISTENT_BIT_EXT) != 0;
updateCachedArrayBuffersMasks(isMapped, isImmutable, isPersistent,
binding->getBoundAttributesMask());
}
else
{
if (context->isWebGL())
{
mCachedTransformFeedbackConflictedBindingsMask.set(bindingIndex, false);
}
mState.mClientMemoryAttribsMask |= binding->getBoundAttributesMask();
updateCachedArrayBuffersMasks(false, false, false, binding->getBoundAttributesMask());
}
}
binding->setOffset(offset);
binding->setStride(stride);
updateCachedBufferBindingSize(binding);
return dirtyBindingBits;
}
void VertexArray::bindVertexBuffer(const Context *context,
size_t bindingIndex,
Buffer *boundBuffer,
GLintptr offset,
GLsizei stride)
{
const VertexArray::DirtyBindingBits dirtyBindingBits =
bindVertexBufferImpl(context, bindingIndex, boundBuffer, offset, stride);
if (dirtyBindingBits.any())
{
mDirtyBits.set(DIRTY_BIT_BINDING_0 + bindingIndex);
mDirtyBindingBits[bindingIndex] |= dirtyBindingBits;
}
}
void VertexArray::setVertexAttribBinding(const Context *context,
size_t attribIndex,
GLuint bindingIndex)
{
ASSERT(attribIndex < getMaxAttribs() && bindingIndex < getMaxBindings());
if (mState.mVertexAttributes[attribIndex].bindingIndex == bindingIndex)
{
return;
}
// In ES 3.0 contexts, the binding cannot change, hence the code below is unreachable.
ASSERT(context->getClientVersion() >= ES_3_1 && !mState.isDefault());
mState.setAttribBinding(context, attribIndex, bindingIndex);
setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_BINDING);
// Update client attribs mask.
bool hasBuffer = mState.mVertexBindings[bindingIndex].getBuffer().get() != nullptr;
mState.mClientMemoryAttribsMask.set(attribIndex, !hasBuffer);
}
void VertexArray::setVertexBindingDivisor(const Context *context,
size_t bindingIndex,
GLuint divisor)
{
ASSERT(bindingIndex < getMaxBindings());
VertexBinding &binding = mState.mVertexBindings[bindingIndex];
if (binding.getDivisor() == divisor)
{
return;
}
binding.setDivisor(divisor);
setDirtyBindingBit(bindingIndex, DIRTY_BINDING_DIVISOR);
}
ANGLE_INLINE bool VertexArray::setVertexAttribFormatImpl(VertexAttribute *attrib,
GLint size,
VertexAttribType type,
bool normalized,
bool pureInteger,
GLuint relativeOffset)
{
angle::FormatID formatID = GetVertexFormatID(type, normalized, size, pureInteger);
if (formatID != attrib->format->id || attrib->relativeOffset != relativeOffset)
{
attrib->relativeOffset = relativeOffset;
attrib->format = &angle::Format::Get(formatID);
return true;
}
return false;
}
void VertexArray::setVertexAttribFormat(size_t attribIndex,
GLint size,
VertexAttribType type,
bool normalized,
bool pureInteger,
GLuint relativeOffset)
{
VertexAttribute &attrib = mState.mVertexAttributes[attribIndex];
ComponentType componentType = GetVertexAttributeComponentType(pureInteger, type);
SetComponentTypeMask(componentType, attribIndex, &mState.mVertexAttributesTypeMask);
if (setVertexAttribFormatImpl(&attrib, size, type, normalized, pureInteger, relativeOffset))
{
setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_FORMAT);
}
attrib.updateCachedElementLimit(mState.mVertexBindings[attrib.bindingIndex]);
}
void VertexArray::setVertexAttribDivisor(const Context *context, size_t attribIndex, GLuint divisor)
{
ASSERT(attribIndex < getMaxAttribs());
setVertexAttribBinding(context, attribIndex, static_cast<GLuint>(attribIndex));
setVertexBindingDivisor(context, attribIndex, divisor);
}
void VertexArray::enableAttribute(size_t attribIndex, bool enabledState)
{
ASSERT(attribIndex < getMaxAttribs());
VertexAttribute &attrib = mState.mVertexAttributes[attribIndex];
if (mState.mEnabledAttributesMask.test(attribIndex) == enabledState)
{
return;
}
attrib.enabled = enabledState;
// Update state cache
mState.mEnabledAttributesMask.set(attribIndex, enabledState);
bool enableChanged = (mState.mEnabledAttributesMask.test(attribIndex) !=
mState.mLastSyncedEnabledAttributesMask.test(attribIndex));
if (enableChanged)
{
setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_ENABLED);
}
else
{
clearDirtyAttribBit(attribIndex, DIRTY_ATTRIB_ENABLED);
}
mState.updateCachedMutableOrNonPersistentArrayBuffers(attribIndex);
mState.mCachedInvalidMappedArrayBuffer = mState.mCachedMappedArrayBuffers &
mState.mEnabledAttributesMask &
mState.mCachedMutableOrImpersistentArrayBuffers;
}
ANGLE_INLINE void VertexArray::setVertexAttribPointerImpl(const Context *context,
ComponentType componentType,
bool pureInteger,
size_t attribIndex,
Buffer *boundBuffer,
GLint size,
VertexAttribType type,
bool normalized,
GLsizei stride,
const void *pointer)
{
ASSERT(attribIndex < getMaxAttribs());
VertexAttribute &attrib = mState.mVertexAttributes[attribIndex];
SetComponentTypeMask(componentType, attribIndex, &mState.mVertexAttributesTypeMask);
bool attribDirty = setVertexAttribFormatImpl(&attrib, size, type, normalized, pureInteger, 0);
if (attrib.bindingIndex != attribIndex)
{
setVertexAttribBinding(context, attribIndex, static_cast<GLuint>(attribIndex));
}
GLsizei effectiveStride =
stride == 0 ? static_cast<GLsizei>(ComputeVertexAttributeTypeSize(attrib)) : stride;
if (attrib.vertexAttribArrayStride != static_cast<GLuint>(stride))
{
attribDirty = true;
}
attrib.vertexAttribArrayStride = stride;
// If we switch from an array buffer to a client pointer(or vice-versa), we set the whole
// attribute dirty. This notifies the Vulkan back-end to update all its caches.
const VertexBinding &binding = mState.mVertexBindings[attribIndex];
if ((boundBuffer == nullptr) != (binding.getBuffer().get() == nullptr))
{
attribDirty = true;
}
// If using client arrays and the pointer changes, set the attribute as dirty
if (boundBuffer == nullptr && attrib.pointer != pointer)
{
attribDirty = true;
}
// Change of attrib.pointer is not part of attribDirty. Pointer is actually the buffer offset
// which is handled within bindVertexBufferImpl and reflected in bufferDirty.
attrib.pointer = pointer;
GLintptr offset = boundBuffer ? reinterpret_cast<GLintptr>(pointer) : 0;
const VertexArray::DirtyBindingBits dirtyBindingBits =
bindVertexBufferImpl(context, attribIndex, boundBuffer, offset, effectiveStride);
if (attribDirty)
{
setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER);
}
else if (dirtyBindingBits.any())
{
setDirtyAttribBit(attribIndex, DIRTY_ATTRIB_POINTER_BUFFER);
}
mState.mNullPointerClientMemoryAttribsMask.set(attribIndex,
boundBuffer == nullptr && pointer == nullptr);
}
void VertexArray::setVertexAttribPointer(const Context *context,
size_t attribIndex,
Buffer *boundBuffer,
GLint size,
VertexAttribType type,
bool normalized,
GLsizei stride,
const void *pointer)
{
setVertexAttribPointerImpl(context, ComponentType::Float, false, attribIndex, boundBuffer, size,
type, normalized, stride, pointer);
}
void VertexArray::setVertexAttribIPointer(const Context *context,
size_t attribIndex,
Buffer *boundBuffer,
GLint size,
VertexAttribType type,
GLsizei stride,
const void *pointer)
{
ComponentType componentType = GetVertexAttributeComponentType(true, type);
setVertexAttribPointerImpl(context, componentType, true, attribIndex, boundBuffer, size, type,
false, stride, pointer);
}
angle::Result VertexArray::syncState(const Context *context)
{
if (mDirtyBits.any())
{
mDirtyBitsGuard = mDirtyBits;
ANGLE_TRY(
mVertexArray->syncState(context, mDirtyBits, &mDirtyAttribBits, &mDirtyBindingBits));
mDirtyBits.reset();
mDirtyBitsGuard.reset();
// The dirty bits should be reset in the back-end. To simplify ASSERTs only check attrib 0.
ASSERT(mDirtyAttribBits[0].none());
ASSERT(mDirtyBindingBits[0].none());
mState.mLastSyncedEnabledAttributesMask = mState.mEnabledAttributesMask;
}
return angle::Result::Continue;
}
// This becomes current vertex array on the context
void VertexArray::onBind(const Context *context)
{
// This vertex array becoming current. Some of the bindings we may have removed from buffer's
// observer list. We need to add it back to the buffer's observer list and update dirty bits
// that we may have missed while we were not observing.
for (size_t bindingIndex : mState.getBufferBindingMask())
{
const VertexBinding &binding = mState.getVertexBindings()[bindingIndex];
Buffer *bufferGL = binding.getBuffer().get();
ASSERT(bufferGL != nullptr);
bufferGL->addObserver(&mArrayBufferObserverBindings[bindingIndex]);
updateCachedMappedArrayBuffersBinding(mState.mVertexBindings[bindingIndex]);
if (mBufferAccessValidationEnabled)
{
for (size_t boundAttribute :
mState.mVertexBindings[bindingIndex].getBoundAttributesMask())
{
mState.mVertexAttributes[boundAttribute].updateCachedElementLimit(
mState.mVertexBindings[bindingIndex]);
}
}
if (context->isWebGL())
{
updateCachedTransformFeedbackBindingValidation(bindingIndex, bufferGL);
}
}
mDirtyBits.set(DIRTY_BIT_LOST_OBSERVATION);
onStateChange(angle::SubjectMessage::ContentsChanged);
}
// This becomes non-current vertex array on the context
void VertexArray::onUnbind(const Context *context)
{
// This vertex array becoming non-current. For performance reason, we remove it from the
// buffers' observer list so that the cost of buffer sending signal to observers will not be too
// expensive.
for (size_t bindingIndex : mState.mBufferBindingMask)
{
const VertexBinding &binding = mState.getVertexBindings()[bindingIndex];
Buffer *bufferGL = binding.getBuffer().get();
ASSERT(bufferGL != nullptr);
bufferGL->removeObserver(&mArrayBufferObserverBindings[bindingIndex]);
}
}
void VertexArray::onBindingChanged(const Context *context, int incr)
{
// When vertex array gets unbound, we remove it from bound buffers' observer list so that when
// buffer changes, it wont has to loop over all these non-current vertex arrays and set dirty
// bit on them. To compensate for that, when we bind a vertex array, we have to check against
// each bound buffers and see if they have changed and needs to update vertex array's dirty bits
// accordingly
ASSERT(incr == 1 || incr == -1);
if (incr < 0)
{
onUnbind(context);
}
else
{
onBind(context);
}
if (context->isWebGL())
{
if (mState.mElementArrayBuffer.get())
{
mState.mElementArrayBuffer->onNonTFBindingChanged(incr);
}
for (size_t bindingIndex : mState.mBufferBindingMask)
{
mState.mVertexBindings[bindingIndex].onContainerBindingChanged(context, incr);
}
}
}
VertexArray::DirtyBitType VertexArray::getDirtyBitFromIndex(bool contentsChanged,
angle::SubjectIndex index) const
{
if (IsElementArrayBufferSubjectIndex(index))
{
mIndexRangeCache.invalidate();
return contentsChanged ? DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA
: DIRTY_BIT_ELEMENT_ARRAY_BUFFER;
}
else
{
// Note: this currently just gets the top-level dirty bit.
ASSERT(index < mArrayBufferObserverBindings.size());
return static_cast<DirtyBitType>(
(contentsChanged ? DIRTY_BIT_BUFFER_DATA_0 : DIRTY_BIT_BINDING_0) + index);
}
}
void VertexArray::onSubjectStateChange(angle::SubjectIndex index, angle::SubjectMessage message)
{
switch (message)
{
case angle::SubjectMessage::SubjectChanged:
if (!IsElementArrayBufferSubjectIndex(index))
{
updateCachedBufferBindingSize(&mState.mVertexBindings[index]);
}
setDependentDirtyBit(false, index);
break;
case angle::SubjectMessage::BindingChanged:
if (!IsElementArrayBufferSubjectIndex(index))
{
const Buffer *buffer = mState.mVertexBindings[index].getBuffer().get();
updateCachedTransformFeedbackBindingValidation(index, buffer);
}
break;
case angle::SubjectMessage::SubjectMapped:
if (!IsElementArrayBufferSubjectIndex(index))
{
updateCachedMappedArrayBuffersBinding(mState.mVertexBindings[index]);
}
onStateChange(angle::SubjectMessage::SubjectMapped);
break;
case angle::SubjectMessage::SubjectUnmapped:
setDependentDirtyBit(true, index);
if (!IsElementArrayBufferSubjectIndex(index))
{
updateCachedMappedArrayBuffersBinding(mState.mVertexBindings[index]);
}
onStateChange(angle::SubjectMessage::SubjectUnmapped);
break;
case angle::SubjectMessage::InternalMemoryAllocationChanged:
setDependentDirtyBit(false, index);
break;
default:
UNREACHABLE();
break;
}
}
void VertexArray::setDependentDirtyBit(bool contentsChanged, angle::SubjectIndex index)
{
DirtyBitType dirtyBit = getDirtyBitFromIndex(contentsChanged, index);
ASSERT(!mDirtyBitsGuard.valid() || mDirtyBitsGuard.value().test(dirtyBit));
mDirtyBits.set(dirtyBit);
onStateChange(angle::SubjectMessage::ContentsChanged);
}
bool VertexArray::hasTransformFeedbackBindingConflict(const Context *context) const
{
// Fast check first.
if (!mCachedTransformFeedbackConflictedBindingsMask.any())
{
return false;
}
const AttributesMask &activeAttribues = context->getStateCache().getActiveBufferedAttribsMask();
// Slow check. We must ensure that the conflicting attributes are enabled/active.
for (size_t attribIndex : activeAttribues)
{
const VertexAttribute &attrib = mState.mVertexAttributes[attribIndex];
if (mCachedTransformFeedbackConflictedBindingsMask[attrib.bindingIndex])
{
return true;
}
}
return false;
}
angle::Result VertexArray::getIndexRangeImpl(const Context *context,
DrawElementsType type,
GLsizei indexCount,
const void *indices,
IndexRange *indexRangeOut) const
{
Buffer *elementArrayBuffer = mState.mElementArrayBuffer.get();
if (!elementArrayBuffer)
{
*indexRangeOut = ComputeIndexRange(type, indices, indexCount,
context->getState().isPrimitiveRestartEnabled());
return angle::Result::Continue;
}
size_t offset = reinterpret_cast<uintptr_t>(indices);
ANGLE_TRY(elementArrayBuffer->getIndexRange(context, type, offset, indexCount,
context->getState().isPrimitiveRestartEnabled(),
indexRangeOut));
mIndexRangeCache.put(type, indexCount, offset, *indexRangeOut);
return angle::Result::Continue;
}
VertexArray::IndexRangeCache::IndexRangeCache() = default;
void VertexArray::IndexRangeCache::put(DrawElementsType type,
GLsizei indexCount,
size_t offset,
const IndexRange &indexRange)
{
ASSERT(type != DrawElementsType::InvalidEnum);
mTypeKey = type;
mIndexCountKey = indexCount;
mOffsetKey = offset;
mPayload = indexRange;
}
void VertexArray::onBufferContentsChange(uint32_t bufferIndex)
{
setDependentDirtyBit(true, bufferIndex);
}
VertexArrayBufferContentsObservers::VertexArrayBufferContentsObservers(VertexArray *vertexArray)
: mVertexArray(vertexArray)
{}
void VertexArrayBufferContentsObservers::enableForBuffer(Buffer *buffer, uint32_t attribIndex)
{
buffer->addContentsObserver(mVertexArray, attribIndex);
mBufferObserversBitMask.set(attribIndex);
}
void VertexArrayBufferContentsObservers::disableForBuffer(Buffer *buffer, uint32_t attribIndex)
{
if (mBufferObserversBitMask.test(attribIndex))
{
buffer->removeContentsObserver(mVertexArray, attribIndex);
mBufferObserversBitMask.reset(attribIndex);
}
}
} // namespace gl