kc3-lang/angle/src/libGLESv2/entry_points_cl_utils.cpp

• Show log

  Commit

• Hash : baca10b7
  Author :
  Date : 2021-05-29T16:26:57
  

  CL: Remove object cache and fix multi-threading
  
  All CL front end objects used to be cached to be able to determine
  if an object has been created by the front end to check its validity.
  The validity is now checked with the existence of an intrinsic value
  (the dispatch table pointer), which is consistent with the patterns
  found in Mesa and clvk (though clvk uses a magic value).
  This allows the removal of all cached objects.
  
  The cached objects were stored with std::unique_ptr. These are now
  gone and all remaining pointers are now custom intrinsic reference
  count pointers.
  
  Also remove global lock which causes deadlocks, e.g. when CL API
  is called from a separate thread to unlock a blocking call with
  a user event. Most of the front end is constant and already
  thread-safe. The ref count is also thread-safe now (atomic).
  A few remaining locks will follow.
  Without the global lock it was now possible to make the API
  reentrant, and to remove the workaround with the Khronos ICD
  loader to skip ANGLE's OpenCL library.
  
  Bug: angleproject:6001
  Change-Id: I7d3b52db9011a02cb7ea9ebdeb6e22c4c702ef5b
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2927395
  Commit-Queue: John Plate <jplate@google.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Cody Northrop <cnorthrop@google.com>
  

Download

• src/libGLESv2/entry_points_cl_utils.cpp

• //
  // Copyright 2021 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // entry_points_cl_utils.cpp: These helpers are used in CL entry point routines.
  
  #include "libGLESv2/entry_points_cl_utils.h"
  
  #include "libGLESv2/cl_dispatch_table.h"
  
  #include "libANGLE/CLPlatform.h"
  #ifdef ANGLE_ENABLE_CL_PASSTHROUGH
  #    include "libANGLE/renderer/cl/CLPlatformCL.h"
  #endif
  #ifdef ANGLE_ENABLE_VULKAN
  #    include "libANGLE/renderer/vulkan/CLPlatformVk.h"
  #endif
  
  #include "anglebase/no_destructor.h"
  
  #include <mutex>
  
  namespace cl
  {
  
  void InitBackEnds(bool isIcd)
  {
      enum struct State
      {
          Uninitialized,
          Initializing,
          Initialized
      };
      static State sState = State::Uninitialized;
  
      // Fast thread-unsafe check first
      if (sState == State::Initialized)
      {
          return;
      }
  
      static angle::base::NoDestructor<std::recursive_mutex> sMutex;
      std::lock_guard<std::recursive_mutex> lock(*sMutex);
  
      // Thread-safe check, return if initialized
      // or if already initializing (re-entry from CL pass-through back end)
      if (sState != State::Uninitialized)
      {
          return;
      }
  
      sState = State::Initializing;
  
      rx::CLPlatformImpl::CreateFuncs createFuncs;
  #ifdef ANGLE_ENABLE_CL_PASSTHROUGH
      rx::CLPlatformCL::Initialize(createFuncs, isIcd);
  #endif
  #ifdef ANGLE_ENABLE_VULKAN
      rx::CLPlatformVk::Initialize(createFuncs);
  #endif
      Platform::Initialize(gCLIcdDispatchTable, std::move(createFuncs));
  
      sState = State::Initialized;
  }
  
  }  // namespace cl
  

Download