Edit

kc3-lang/angle/src/compiler/ConstantUnion.h

Branch :

  • Show log

    Commit

  • Author : daniel@transgaming.com
    Date : 2011-03-15 18:23:46
    Hash : cd3a1b94
    Message : Fix clang warning: ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch Issue=124 Part 1 of 5: <http://webkit.org/b/56337> Enable -Werror on ANGLE Signed-off-by: Nicolas Capens Signed-off-by: Daniel Koch Upstream bug: <http://code.google.com/p/angleproject/issues/detail?id=124> Fixes the following static analyzer warning: In file included from src/compiler/debug.cpp:14: In file included from src/compiler/ParseHelper.h:10: In file included from src/compiler/localintermediate.h:11: In file included from src/compiler/intermediate.h:21: src/compiler/ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch: 'EbtVoid', 'EbtGuardSamplerBegin', 'EbtSampler2D'... [-Wswitch-enum,2] switch (type) { ^ * src/compiler/ConstantUnion.h: (ConstantUnion::operator==): Added a default case. Author: David Kilzer <ddkilzer@apple.com> git-svn-id: https://angleproject.googlecode.com/svn/trunk@572 736b8ea6-26fd-11df-bfd4-992fa37f6226

  • src/compiler/ConstantUnion.h
  • //
    // Copyright (c) 2002-2010 The ANGLE Project Authors. All rights reserved.
    // Use of this source code is governed by a BSD-style license that can be
    // found in the LICENSE file.
    //
    
    #ifndef _CONSTANT_UNION_INCLUDED_
    #define _CONSTANT_UNION_INCLUDED_
    
    #include <assert.h>
    
    class ConstantUnion {
    public:
    
        POOL_ALLOCATOR_NEW_DELETE(GlobalPoolAllocator)        
        void setIConst(int i) {iConst = i; type = EbtInt; }
        void setFConst(float f) {fConst = f; type = EbtFloat; }
        void setBConst(bool b) {bConst = b; type = EbtBool; }
    
        int getIConst() { return iConst; }
        float getFConst() { return fConst; }
        bool getBConst() { return bConst; }
        int getIConst() const { return iConst; }
        float getFConst() const { return fConst; }
        bool getBConst() const { return bConst; }
    
        bool operator==(const int i) const
        {
            return i == iConst;
        }
    
        bool operator==(const float f) const
        {
            return f == fConst;
        }
    
        bool operator==(const bool b) const
        {
            return b == bConst;
        }
    
        bool operator==(const ConstantUnion& constant) const
        {
            if (constant.type != type)
                return false;
    
            switch (type) {
            case EbtInt:
                return constant.iConst == iConst;
            case EbtFloat:
                return constant.fConst == fConst;
            case EbtBool:
                return constant.bConst == bConst;
            default:
                return false;
            }
    
            return false;
        }
    
        bool operator!=(const int i) const
        {
            return !operator==(i);
        }
    
        bool operator!=(const float f) const
        {
            return !operator==(f);
        }
    
        bool operator!=(const bool b) const
        {
            return !operator==(b);
        }
    
        bool operator!=(const ConstantUnion& constant) const
        {
            return !operator==(constant);
        }
    
        bool operator>(const ConstantUnion& constant) const
        { 
            assert(type == constant.type);
            switch (type) {
            case EbtInt:
                return iConst > constant.iConst;
            case EbtFloat:
                return fConst > constant.fConst;
            default:
                return false;   // Invalid operation, handled at semantic analysis
            }
    
            return false;
        }
    
        bool operator<(const ConstantUnion& constant) const
        { 
            assert(type == constant.type);
            switch (type) {
            case EbtInt:
                return iConst < constant.iConst;
            case EbtFloat:
                return fConst < constant.fConst;
            default:
                return false;   // Invalid operation, handled at semantic analysis
            }
    
            return false;
        }
    
        ConstantUnion operator+(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtInt: returnValue.setIConst(iConst + constant.iConst); break;
            case EbtFloat: returnValue.setFConst(fConst + constant.fConst); break;
            default: assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        ConstantUnion operator-(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtInt: returnValue.setIConst(iConst - constant.iConst); break;
            case EbtFloat: returnValue.setFConst(fConst - constant.fConst); break;
            default: assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        ConstantUnion operator*(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtInt: returnValue.setIConst(iConst * constant.iConst); break;
            case EbtFloat: returnValue.setFConst(fConst * constant.fConst); break; 
            default: assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        ConstantUnion operator%(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtInt: returnValue.setIConst(iConst % constant.iConst); break;
            default:     assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        ConstantUnion operator>>(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtInt: returnValue.setIConst(iConst >> constant.iConst); break;
            default:     assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        ConstantUnion operator<<(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtInt: returnValue.setIConst(iConst << constant.iConst); break;
            default:     assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        ConstantUnion operator&(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtInt:  returnValue.setIConst(iConst & constant.iConst); break;
            default:     assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        ConstantUnion operator|(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtInt:  returnValue.setIConst(iConst | constant.iConst); break;
            default:     assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        ConstantUnion operator^(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtInt:  returnValue.setIConst(iConst ^ constant.iConst); break;
            default:     assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        ConstantUnion operator&&(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtBool: returnValue.setBConst(bConst && constant.bConst); break;
            default:     assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        ConstantUnion operator||(const ConstantUnion& constant) const
        { 
            ConstantUnion returnValue;
            assert(type == constant.type);
            switch (type) {
            case EbtBool: returnValue.setBConst(bConst || constant.bConst); break;
            default:     assert(false && "Default missing");
            }
    
            return returnValue;
        }
    
        TBasicType getType() const { return type; }
    private:
    
        union  {
            int iConst;  // used for ivec, scalar ints
            bool bConst; // used for bvec, scalar bools
            float fConst;   // used for vec, mat, scalar floats
        } ;
    
        TBasicType type;
    };
    
    #endif // _CONSTANT_UNION_INCLUDED_