• Show log

    Commit

  • Hash : 16c85291
    Author : Yuxin Hu
    Date : 2025-03-19T18:15:43

    Reland "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD"
    
    This is a reland of 3f028fc158fac948723e8d535463eb80d0a85fed.
    
    On Fuchsia, it is possible that there is no vulkan driver and
    vkCreateInstance() triggered VVLDebugUtilsMessenger.
    "vkCreateInstance: Found no drivers" is a
    VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT message. We should only
    care about VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT message
    type. Remove VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT and
    VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT from the
    VkDebugUtilsMessengerCreateInfoEXT.
    
    Add code to print the VVL message in the log so we know what's wrong.
    
    Add a condition to only assert when the VVL message severity is
    VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT.
    
    Original change's description:
    > Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD
    >
    > This helps catching bugs for vulkan calls issued
    > during GetSystemInfoVulkanWithICD().
    >
    > Also changed getProc() function to get vulkan function pointers by
    > calling vkGetInstanceProcAddr(), instead of calling dlsym(). Only use
    > dlsym() to get vkGetInstanceProcAddr() function pointer.
    
    > Bug: angleproject:407116232
    > Change-Id: I14dce3453c76a084db63fdb45a3db07b7b4d5294
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6374305
    > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    > Reviewed-by: Charlie Lao <cclao@google.com>
    > Commit-Queue: Yuxin Hu <yuxinhu@google.com>
    
    Bug: angleproject:407116232
    Change-Id: I1ffc4041368782641fc605366ff7cf03e43eb53f
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6435033
    Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags