kc3-lang/angle/src/libANGLE/renderer

• Show log

  Commit

• Hash : 4334125b
  Author :
  Date : 2025-03-14T16:12:32
  

  Metal: Make StateCache descriptors hash consistent
  
  Various descriptors would compare equality and do hashing based on the
  underlying storage. The storage contains alignment padding and
  bitfields. The contents of these are not defined, even when the
  constructors tried to memset and memcpy.
  
  The various hash and compare functions also seemed to be missing some
  elements, like rasterSampleCount.
  
  Missing == on fields and hashing unused memory may lead to inconsistency
  where a==b is true but hash(a) != hash(b).
  
  Fix by:
  Remove the memset/memcpy and write out the operator== and
  hash() consistently.
  
  Initialize the members to their default values.
  
  Use uint32_t : 1 instead of bool if the struct tries to optimize for
  size, since mixing types stops the packing.
  
  Use uint32_t to get the alignment to uint32_t, which is mostly what
  is expected.
  
  Use uint32 someVar : N where N is payload bits + padding bits for
  the last member. This way the assignment clears the padding bits.
  The goal os to get the operator== to compare the padding bits, which
  lets the compiler elide the memberwise compares and use word-wise
  compares where it makes sense.
  
  This is an attempt to fix rare crashes related to map inserts
  and lookups. std::unordered_map will crash if operator== is not
  consistent with hash.
  
  Bug: angleproject:403372465
  Change-Id: I0a3a2ff327ac9f65e7d41bc9585cda54ce93ab86
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6355828
  Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
  Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
  Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  

• Files

• BufferImpl.cpp
• BufferImpl.h
• BufferImpl_mock.h
• CLCommandQueueImpl.cpp
• CLCommandQueueImpl.h
• CLContextImpl.cpp
• CLContextImpl.h
• CLDeviceImpl.cpp
• CLDeviceImpl.h
• CLEventImpl.cpp
• CLEventImpl.h
• CLExtensions.cpp
• CLExtensions.h
• CLKernelImpl.cpp
• CLKernelImpl.h
• CLMemoryImpl.cpp
• CLMemoryImpl.h
• CLPlatformImpl.cpp
• CLPlatformImpl.h
• CLProgramImpl.cpp
• CLProgramImpl.h
• CLSamplerImpl.cpp
• CLSamplerImpl.h
• CompilerImpl.h
• ContextImpl.cpp
• ContextImpl.h
• DeviceImpl.cpp
• DeviceImpl.h
• DisplayImpl.cpp
• DisplayImpl.h
• EGLImplFactory.h
• EGLReusableSync.cpp
• EGLReusableSync.h
• EGLSyncImpl.cpp
• EGLSyncImpl.h
• FenceNVImpl.h
• Format.h
• FormatID_autogen.h
• Format_table_autogen.cpp
• FramebufferAttachmentObjectImpl.h
• FramebufferImpl.cpp
• FramebufferImpl.h
• FramebufferImpl_mock.h
• GLImplFactory.h
• ImageImpl.cpp
• ImageImpl.h
• ImageImpl_mock.h
• MemoryObjectImpl.h
• OverlayImpl.h
• ProgramExecutableImpl.h
• ProgramImpl.cpp
• ProgramImpl.h
• ProgramImpl_mock.h
• ProgramPipelineImpl.cpp
• ProgramPipelineImpl.h
• QueryImpl.cpp
• QueryImpl.h
• README.md
• RenderTargetCache.h
• RenderbufferImpl.cpp
• RenderbufferImpl.h
• RenderbufferImpl_mock.h
• SamplerImpl.h
• SemaphoreImpl.h
• ShaderImpl.cpp
• ShaderImpl.h
• ShareGroupImpl.h
• StreamProducerImpl.h
• SurfaceImpl.cpp
• SurfaceImpl.h
• SyncImpl.h
• TextureImpl.cpp
• TextureImpl.h
• TextureImpl_mock.h
• TransformFeedbackImpl.cpp
• TransformFeedbackImpl.h
• TransformFeedbackImpl_mock.h
• VertexArrayImpl.cpp
• VertexArrayImpl.h
• angle_cl_format_map.json
• angle_format.py
• angle_format_data.json
• angle_format_map.json
• cl/
• cl_types.h
• copyvertex.h
• copyvertex.inc.h
• d3d/
• d3d_format.cpp
• d3d_format.h
• driver_utils.cpp
• driver_utils.h
• driver_utils_ios.mm
• driver_utils_mac.mm
• dxgi_format_data.json
• dxgi_format_map.h
• dxgi_format_map_autogen.cpp
• dxgi_support_data.json
• dxgi_support_table.h
• dxgi_support_table_autogen.cpp
• gen_angle_format_table.py
• gen_dxgi_format_table.py
• gen_dxgi_support_tables.py
• gen_load_functions_table.py
• gl/
• load_functions_data.json
• load_functions_table.h
• load_functions_table_autogen.cpp
• metal/
• null/
• renderer_utils.cpp
• renderer_utils.h
• serial_utils.h
• serial_utils_unittest.cpp
• vulkan/
• wgpu/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags