kc3-lang/angle/src/libANGLE/renderer/vulkan

Diff

  • Show log

    Commit

  • Hash : 37c40014
    Author : Tim Van Patten
    Date : 2020-10-16T22:19:20 

    Revert "Vulkan: Fold deferred clears into current clears"

This reverts commit e416c92a81c9ef01d633ec5c05e81c2551b6c5d6.

Reason for revert: Reverted parent:
https://chromium-review.googlesource.com/c/angle/angle/+/2481612

Original change's description:
> Vulkan: Fold deferred clears into current clears
>
> If there are clears prior to a glClear() call, those clears were
> flushed (starting a new render pass) and then the clear call's clears
> would be applied (essentially modifying the loadOps of said render
> pass).
>
> The main downside of the above is that the current glClear() clears
> don't get a chance to be deferred.  This was observed in Chrome which
> clears an attachment with an emulated format, then switches
> framebuffers.
>
> Additionally, if the render pass had already been started, the deferred
> clears could have become inlined instead of breaking the render pass.
> Although, it's unlikely for there to be deferred clears when the render
> pass is already open.
>
> This change first identifies which clears need to go through the draw
> path (scissored, masked or as workaround for driver bug).  It merges the
> rest of the clears (that don't need the draw path) with the deferred
> clears.  It then checks deferred clears and applies them by either:
>
> - vkCmdClearAttachments if mid RP
> - Start a new render pass and use loadOps, if any draw-based clear needs
>   to follow.
> - Modify current RP loadOps / defer the clear
>
> Afterwards, the draw-based clears are applied.
>
> Bug: angleproject:4836
> Change-Id: Id4992c78983b199734508c9d4bb18ed3195c91ec
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455167
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Charlie Lao <cclao@google.com>

TBR=syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com

Change-Id: I85733b3594409df9b96e3d5b34933522c97c42cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4836
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2481613
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github
    Users
    		 kc3_lang_org www_kmx_io thodg_w thodg_l thodg thodg_m
    Tags

  • README.md

  • ANGLE: Vulkan Back-end

    ANGLE’s Vulkan back-end implementation lives in this folder.

    Vulkan is an explicit graphics API. It has a lot in common with other explicit APIs such as Microsoft’s D3D12 and Apple’s Metal. Compared to APIs like OpenGL or D3D11 explicit APIs can offer a number of significant benefits:

    • Lower API call CPU overhead.
    • A smaller API surface with more direct hardware control.
    • Better support for multi-core programming.
    • Vulkan in particular has open-source tooling and tests.

    Back-end Design

    The RendererVk class represents an EGLDisplay. RendererVk owns shared global resources like the VkDevice, VkQueue, the Vulkan format tables and internal Vulkan shaders. The ContextVk class implements the back-end of a front-end OpenGL Context. ContextVk processes state changes and handles action commands like glDrawArrays and glDrawElements.

    Command recording

    The back-end records commands into command buffers via the the following ContextVk APIs:

    • getOutsideRenderPassCommandBuffer: returns a secondary command buffer outside a RenderPass instance.
    • flushAndBeginRenderPass: returns a secondary command buffer inside a RenderPass instance.

    Note: All of these commands may write out (aka flush) prior pending commands into a primary command buffer. When a RenderPass is open getOutsideRenderPassCommandBuffer will flush the pending RenderPass commands. flushAndBeginRenderPass will flush out pending commands outside a RenderPass to a primary buffer. On submit ANGLE submits the primary command buffer to a VkQueue.

    If you need to record inside a RenderPass, use flushAndBeginRenderPass. Otherwise, use getOutsideRenderPassCommandBuffer.

    The back-end (mostly) records Image and Buffer barriers through additional ContextVk APIs:

    • onBufferTransferRead and onBufferComputeShaderRead accumulate VkBuffer read barriers.
    • onBufferTransferWrite and onBufferComputeShaderWrite accumulate VkBuffer write barriers.
    • onBuffferSelfCopy is a special case for VkBuffer self copies. It behaves the same as write.
    • onImageTransferRead and onImageComputerShadeRead accumulate VkImage read barriers.
    • onImageTransferWrite and onImageComputerShadeWrite accumulate VkImage write barriers.
    • onImageRenderPassRead and onImageRenderPassWrite accumulate VkImage barriers inside a started RenderPass.

    After the back-end records commands to the primary buffer we flush (e.g. on swap) or when we call ContextVk::finishToSerial.

    See the code for more details.

    Simple command recording example

    In this example we’ll be recording a buffer copy command:

        # Ensure that ANGLE sets proper read and write barriers for the Buffers.
    ANGLE_TRY(contextVk->onBufferTransferWrite(destBuffer));
    ANGLE_TRY(contextVk->onBufferTransferRead(srcBuffer));

    # Get a pointer to a secondary command buffer for command recording. May "flush" the RP.
    vk::CommandBuffer *commandBuffer;
    ANGLE_TRY(contextVk->getOutsideRenderPassCommandBuffer(&commandBuffer));

    # Record the copy command into the secondary buffer. We're done!
    commandBuffer->copyBuffer(srcBuffer->getBuffer(), destBuffer->getBuffer(), copyCount, copies);

    Additional Reading

    More implementation details can be found in the doc directory:

kmx.io     mail     discord kmxgit v0.4.0