kc3-lang/angle/src/tests/test_utils/gl_raii.h

Branch : - branch - main - tag -

• Show log

  Commit

• Author : Jamie Madill
  Date : 2016-12-13 15:08:19
  Hash : a7d12dc7
  Message : Store uniform block bindings in program binaries. This affects all back-ends - we weren't saving this. Note that bindings can only be set after program linking. The spec is fairly clear in that any programs saved must be loadable and runnable under the same set of state, which would include block bindings. Also add validation for zero binary formats in GetProgramBinary. Also add a workaround for AMD where the block bindings were not applied properly after link, similarly to our original bug. This CL also includes a few fixups for GLProgram (raii). BUG=angleproject:1637 Change-Id: Iae068eb4e1e4c763aa9f9332c033e38708026c8f Reviewed-on: https://chromium-review.googlesource.com/418393 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>

• src/tests/test_utils/gl_raii.h

• //
  // Copyright (c) 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // gl_raii:
  //   Helper methods for containing GL objects like buffers and textures.
  
  #ifndef ANGLE_TESTS_GL_RAII_H_
  #define ANGLE_TESTS_GL_RAII_H_
  
  #include <functional>
  
  #include "angle_gl.h"
  
  namespace angle
  {
  
  // This is a bit of hack to work around a bug in MSVS intellisense, and make it very easy to
  // use the correct function pointer type without worrying about the various definitions of
  // GL_APICALL.
  using GLGen    = decltype(glGenBuffers);
  using GLDelete = decltype(glDeleteBuffers);
  
  template <GLGen GenF, GLDelete DeleteF>
  class GLWrapper
  {
    public:
      GLWrapper() {}
      ~GLWrapper() { DeleteF(1, &mHandle); }
  
      GLuint get()
      {
          if (!mHandle)
          {
              GenF(1, &mHandle);
          }
          return mHandle;
      }
  
    private:
      GLuint mHandle = 0;
  };
  
  using GLBuffer       = GLWrapper<glGenBuffers, glDeleteBuffers>;
  using GLTexture      = GLWrapper<glGenTextures, glDeleteTextures>;
  using GLFramebuffer  = GLWrapper<glGenFramebuffers, glDeleteFramebuffers>;
  using GLRenderbuffer = GLWrapper<glGenRenderbuffers, glDeleteRenderbuffers>;
  using GLSampler      = GLWrapper<glGenSamplers, glDeleteSamplers>;
  
  // Don't use GLProgram directly, use ANGLE_GL_PROGRAM.
  namespace priv
  {
  class GLProgram
  {
    public:
      GLProgram() : mHandle(0) {}
  
      ~GLProgram() { glDeleteProgram(mHandle); }
  
      void makeCompute(const std::string &computeShader)
      {
          mHandle = CompileComputeProgram(computeShader);
      }
  
      void makeRaster(const std::string &vertexShader, const std::string &fragmentShader)
      {
          mHandle = CompileProgram(vertexShader, fragmentShader);
      }
  
      void makeBinaryOES(const std::vector<uint8_t> &binary, GLenum binaryFormat)
      {
          mHandle = LoadBinaryProgramOES(binary, binaryFormat);
      }
  
      void makeBinaryES3(const std::vector<uint8_t> &binary, GLenum binaryFormat)
      {
          mHandle = LoadBinaryProgramES3(binary, binaryFormat);
      }
  
      GLuint get()
      {
          ASSERT(mHandle != 0);
          return mHandle;
      }
  
    private:
      GLuint mHandle;
  };
  }  // namespace priv
  
  #define ANGLE_GL_PROGRAM(name, vertex, fragment) \
      priv::GLProgram name;                        \
      name.makeRaster(vertex, fragment);           \
      ASSERT_NE(0u, name.get());
  
  #define ANGLE_GL_COMPUTE_PROGRAM(name, compute) \
      priv::GLProgram name;                       \
      name.makeCompute(compute);                  \
      ASSERT_NE(0u, name.get());
  
  #define ANGLE_GL_BINARY_OES_PROGRAM(name, binary, binaryFormat) \
      priv::GLProgram name;                                       \
      name.makeBinaryOES(binary, binaryFormat);                   \
      ASSERT_NE(0u, name.get());
  
  #define ANGLE_GL_BINARY_ES3_PROGRAM(name, binary, binaryFormat) \
      priv::GLProgram name;                                       \
      name.makeBinaryES3(binary, binaryFormat);                   \
      ASSERT_NE(0u, name.get());
  
  }  // namespace angle
  
  #endif  // ANGLE_TESTS_GL_RAII_H_