kc3-lang/angle/src/compiler/translator/msl/ProgramPrelude.h

• Show log

  Commit

• Hash : 898a1c12
  Author :
  Date : 2024-10-24T13:09:36
  

  Metal: Fix ToposortStructs validation == failures
  
  ToposortStructs would convert mat, vec, struct == to ANGLE_equals()
  calls. However, the functions called were not in AST. This would cause
  "Found node calling previously undeclared function
  <validateFunctionCall>" validation error and ASSERT.
  
  Mat, vec equality calls would use prelude ANGLE_equals implementations.
  The MSL emit already does the conversion from == to ANGLE_equals for
  these builtins.
  
  For user-defined structs the logic would be:
   - collect struct decls, structs, create equality functions
   - toposort
   - for each sorted struct:
     - insert struct decl
     - insert equality function
  
  Move the equality function creation after the toposort:
   - collect struct decls, structs
   - toposort
     - for each sorted struct:
       - insert struct decl
       - create equality function
       - insert equality function
  
  This way the sort ensures that nested struct equality functions can
  refer to previously introduced equality functions.
  
  Bug: angleproject:375352601
  Change-Id: I59efed98bca6d99b198abc2b5c7577cf5d1d5d83
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5961281
  Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
  

Download

• src/compiler/translator/msl/ProgramPrelude.h

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #ifndef COMPILER_TRANSLATOR_MSL_PROGRAMPRELUDE_H_
  #define COMPILER_TRANSLATOR_MSL_PROGRAMPRELUDE_H_
  
  #include <unordered_set>
  
  #include "common/angleutils.h"
  
  namespace sh
  {
  
  class TInfoSinkBase;
  class TIntermBlock;
  
  enum class MetalShaderType
  {
      None,
      Vertex,
      Fragment,
      Compute,  // Unused currently
      Count,
  };
  
  struct ProgramPreludeConfig
  {
    public:
      ProgramPreludeConfig() {}
      explicit ProgramPreludeConfig(MetalShaderType shaderType) : shaderType(shaderType) {}
      bool usesDerivatives       = false;
      MetalShaderType shaderType = MetalShaderType::None;
  };
  
  // This emits fixed helper Metal code directly without adding code to the AST. This walks the AST to
  // figure out the required what prelude MSL code is needed for various things in the AST. You can
  // think of this as effectively inlining various portions of a helper library into the emitted
  // Metal program.
  [[nodiscard]] bool EmitProgramPrelude(TIntermBlock &root,
                                        TInfoSinkBase &out,
                                        const ProgramPreludeConfig &ppc);
  
  }  // namespace sh
  
  #endif  // COMPILER_TRANSLATOR_MSL_PROGRAMPRELUDE_H_
  

Download